Re: [PATCH] backlight: led_bl: fix initial power state

2023-07-06 Thread Måns Rullgård
Daniel Thompson writes: > On Wed, Jul 05, 2023 at 03:36:46PM +0100, Måns Rullgård wrote: >> Daniel Thompson writes: >> >> > On Wed, Jul 05, 2023 at 03:24:14PM +0100, Mans Rullgard wrote: >> >> The condition for the initial power state based on the default >> >> brightness value is reversed. Fix

[PATCH] backlight: led_bl: fix initial power state

2023-07-06 Thread Mans Rullgard
The condition for the initial power state based on the default brightness value is reversed. Fix it. Furthermore, use the actual state of the LEDs rather than the default brightness specified in the devicetree as the latter should not cause the backlight to be automatically turned on. If the bac

Re: [PATCH] backlight: led_bl: fix initial power state

2023-07-06 Thread Måns Rullgård
Daniel Thompson writes: > On Wed, Jul 05, 2023 at 03:24:14PM +0100, Mans Rullgard wrote: >> The condition for the initial power state based on the default >> brightness value is reversed. Fix it. >> >> Furthermore, use the actual state of the LEDs rather than the default >> brightness specified

Re: [PATCH] backlight: led_bl: fix initial power state

2023-07-05 Thread Sam Ravnborg
Hi Daniel, On Wed, Jul 05, 2023 at 03:07:31PM +0100, Daniel Thompson wrote: > On Tue, Jul 04, 2023 at 07:07:31PM +0200, Sam Ravnborg wrote: > > Hi Daniel, > > > > > > @@ -200,8 +200,8 @@ static int led_bl_probe(struct platform_device > > > > *pdev) > > > > props.type = BACKLIGHT_RAW; > >

Re: [PATCH] backlight: led_bl: fix initial power state

2023-07-05 Thread Daniel Thompson
On Wed, Jul 05, 2023 at 03:36:46PM +0100, Måns Rullgård wrote: > Daniel Thompson writes: > > > On Wed, Jul 05, 2023 at 03:24:14PM +0100, Mans Rullgard wrote: > >> The condition for the initial power state based on the default > >> brightness value is reversed. Fix it. > >> > >> Furthermore, use t

Re: [PATCH] backlight: led_bl: fix initial power state

2023-07-05 Thread Daniel Thompson
On Wed, Jul 05, 2023 at 03:24:14PM +0100, Mans Rullgard wrote: > The condition for the initial power state based on the default > brightness value is reversed. Fix it. > > Furthermore, use the actual state of the LEDs rather than the default > brightness specified in the devicetree as the latter s

Re: [PATCH] backlight: led_bl: fix initial power state

2023-07-05 Thread Daniel Thompson
On Tue, Jul 04, 2023 at 07:07:31PM +0200, Sam Ravnborg wrote: > Hi Daniel, > > > > @@ -200,8 +200,8 @@ static int led_bl_probe(struct platform_device *pdev) > > > props.type = BACKLIGHT_RAW; > > > props.max_brightness = priv->max_brightness; > > > props.brightness = priv->default_brightness;

[PATCH] backlight: led_bl: fix initial power state

2023-07-04 Thread Mans Rullgard
The condition for the initial power state based on the default brightness value is reversed. Fix it. Fixes: ae232e45acf9 ("backlight: add led-backlight driver") Signed-off-by: Mans Rullgard --- drivers/video/backlight/led_bl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --gi

Re: [PATCH] backlight: led_bl: fix initial power state

2023-07-04 Thread Måns Rullgård
Daniel Thompson writes: > On Tue, Jul 04, 2023 at 03:07:50PM +0100, Mans Rullgard wrote: >> The condition for the initial power state based on the default >> brightness value is reversed. Fix it. >> >> Fixes: ae232e45acf9 ("backlight: add led-backlight driver") >> Signed-off-by: Mans Rullgard >

Re: [PATCH] backlight: led_bl: fix initial power state

2023-07-04 Thread Sam Ravnborg
Hi Daniel, > > @@ -200,8 +200,8 @@ static int led_bl_probe(struct platform_device *pdev) > > props.type = BACKLIGHT_RAW; > > props.max_brightness = priv->max_brightness; > > props.brightness = priv->default_brightness; > > - props.power = (priv->default_brightness > 0) ? FB_BLANK_POW

Re: [PATCH] backlight: led_bl: fix initial power state

2023-07-04 Thread Daniel Thompson
On Tue, Jul 04, 2023 at 04:31:51PM +0100, Måns Rullgård wrote: > Daniel Thompson writes: > > > On Tue, Jul 04, 2023 at 03:07:50PM +0100, Mans Rullgard wrote: > >> The condition for the initial power state based on the default > >> brightness value is reversed. Fix it. > >> > >> Fixes: ae232e45acf

Re: [PATCH] backlight: led_bl: fix initial power state

2023-07-04 Thread Daniel Thompson
On Tue, Jul 04, 2023 at 03:07:50PM +0100, Mans Rullgard wrote: > The condition for the initial power state based on the default > brightness value is reversed. Fix it. > > Fixes: ae232e45acf9 ("backlight: add led-backlight driver") > Signed-off-by: Mans Rullgard > --- > drivers/video/backlight/l