Re: [PATCH] backlight: ktz8866: Convert to i2c's .probe_new()

2023-02-22 Thread Lee Jones
On Sun, 12 Feb 2023, Uwe Kleine-König wrote: > Hello Lee, > > On Mon, Jan 30, 2023 at 09:42:01AM +, Lee Jones wrote: > > On Fri, 27 Jan 2023, Uwe Kleine-König wrote: > > > > > The probe function doesn't make use of the i2c_device_id * parameter so > > > it can be trivially converted. > > >

Re: [PATCH] backlight: ktz8866: Convert to i2c's .probe_new()

2023-02-11 Thread Uwe Kleine-König
Hello Lee, On Mon, Jan 30, 2023 at 09:42:01AM +, Lee Jones wrote: > On Fri, 27 Jan 2023, Uwe Kleine-König wrote: > > > The probe function doesn't make use of the i2c_device_id * parameter so > > it can be trivially converted. > > > > Signed-off-by: Uwe Kleine-König > > --- > > Hello, > > >

Re: [PATCH] backlight: ktz8866: Convert to i2c's .probe_new()

2023-01-30 Thread Lee Jones
On Fri, 27 Jan 2023, Uwe Kleine-König wrote: > The probe function doesn't make use of the i2c_device_id * parameter so > it can be trivially converted. > > Signed-off-by: Uwe Kleine-König > --- > Hello, > > there is an ongoing effort to convert all drivers to .probe_new to > eventually drop .pr

Re: [PATCH] backlight: ktz8866: Convert to i2c's .probe_new()

2023-01-28 Thread Jianhua Lu
On Sat, Jan 28, 2023 at 06:07:08PM +0100, Uwe Kleine-König wrote: > Hello, > > On Sun, Jan 29, 2023 at 12:44:30AM +0800, Jianhua Lu wrote: > > On Sat, Jan 28, 2023 at 05:16:13PM +0100, Uwe Kleine-König wrote: > > > I don't want to squash the changes to the ktz8866 driver into the patch > > > that

Re: [PATCH] backlight: ktz8866: Convert to i2c's .probe_new()

2023-01-28 Thread Uwe Kleine-König
Hello, On Sun, Jan 29, 2023 at 12:44:30AM +0800, Jianhua Lu wrote: > On Sat, Jan 28, 2023 at 05:16:13PM +0100, Uwe Kleine-König wrote: > > I don't want to squash the changes to the ktz8866 driver into the patch > > that modifies struct i2c_driver, as this needlessly clutters the commit, > > if it'

Re: [PATCH] backlight: ktz8866: Convert to i2c's .probe_new()

2023-01-28 Thread Jianhua Lu
On Sat, Jan 28, 2023 at 05:16:13PM +0100, Uwe Kleine-König wrote: > Hello, > > On Sat, Jan 28, 2023 at 10:14:09PM +0800, Jianhua Lu wrote: > > On Sat, Jan 28, 2023 at 02:32:39PM +0100, Uwe Kleine-König wrote: > > > On Sat, Jan 28, 2023 at 08:36:28AM +0800, Jianhua Lu wrote: > > > > I prefer that y

Re: [PATCH] backlight: ktz8866: Convert to i2c's .probe_new()

2023-01-28 Thread Uwe Kleine-König
Hello, On Sat, Jan 28, 2023 at 10:14:09PM +0800, Jianhua Lu wrote: > On Sat, Jan 28, 2023 at 02:32:39PM +0100, Uwe Kleine-König wrote: > > On Sat, Jan 28, 2023 at 08:36:28AM +0800, Jianhua Lu wrote: > > > I prefer that you pack this commit to the i2c-tree commit that drops > > > old .probe(). > >

Re: [PATCH] backlight: ktz8866: Convert to i2c's .probe_new()

2023-01-28 Thread Jianhua Lu
On Sat, Jan 28, 2023 at 02:32:39PM +0100, Uwe Kleine-König wrote: > Hello, > > On Sat, Jan 28, 2023 at 08:36:28AM +0800, Jianhua Lu wrote: > > On Fri, Jan 27, 2023 at 04:26:39PM +0100, Uwe Kleine-König wrote: > > > The probe function doesn't make use of the i2c_device_id * parameter so > > > it ca

Re: [PATCH] backlight: ktz8866: Convert to i2c's .probe_new()

2023-01-28 Thread Uwe Kleine-König
Hello, On Sat, Jan 28, 2023 at 08:36:28AM +0800, Jianhua Lu wrote: > On Fri, Jan 27, 2023 at 04:26:39PM +0100, Uwe Kleine-König wrote: > > The probe function doesn't make use of the i2c_device_id * parameter so > > it can be trivially converted. > > > > Signed-off-by: Uwe Kleine-König > > --- >

Re: [PATCH] backlight: ktz8866: Convert to i2c's .probe_new()

2023-01-28 Thread Jianhua Lu
On Fri, Jan 27, 2023 at 04:26:39PM +0100, Uwe Kleine-König wrote: > The probe function doesn't make use of the i2c_device_id * parameter so > it can be trivially converted. > > Signed-off-by: Uwe Kleine-König > --- > Hello, > > there is an ongoing effort to convert all drivers to .probe_new to >

[PATCH] backlight: ktz8866: Convert to i2c's .probe_new()

2023-01-27 Thread Uwe Kleine-König
The probe function doesn't make use of the i2c_device_id * parameter so it can be trivially converted. Signed-off-by: Uwe Kleine-König --- Hello, there is an ongoing effort to convert all drivers to .probe_new to eventually drop .probe with the i2c_device_id parameter. This driver currently sits