Re: [PATCH] backlight: corgi: Convert to use GPIO descriptors

2019-12-17 Thread Linus Walleij
On Mon, Dec 16, 2019 at 5:27 PM Lee Jones wrote: > On Tue, 03 Dec 2019, Linus Walleij wrote: > > > The code in the Corgi backlight driver can be considerably > > simplified by moving to GPIO descriptors and lookup tables > > from the board files instead of passing GPIO numbers using > > the old AP

Re: [PATCH] backlight: corgi: Convert to use GPIO descriptors

2019-12-16 Thread Lee Jones
On Tue, 03 Dec 2019, Linus Walleij wrote: > The code in the Corgi backlight driver can be considerably > simplified by moving to GPIO descriptors and lookup tables > from the board files instead of passing GPIO numbers using > the old API. > > Make sure to encode inversion semantics for the Akita

Re: [PATCH] backlight: corgi: Convert to use GPIO descriptors

2019-12-16 Thread Lee Jones
On Sat, 14 Dec 2019, Linus Walleij wrote: > On Fri, Dec 13, 2019 at 6:24 PM Robert Jarzmik wrote: > > Linus Walleij writes: > > > On Sun, Dec 8, 2019 at 9:06 PM Robert Jarzmik > > > wrote: > > >> Linus Walleij writes: > > > > So it will theoretically "spi0.1" > > > > > > Beware about bugs in

Re: [PATCH] backlight: corgi: Convert to use GPIO descriptors

2019-12-14 Thread Robert Jarzmik
Linus Walleij writes: > On Sun, Dec 8, 2019 at 9:06 PM Robert Jarzmik wrote: > >> Linus Walleij writes: >> > @@ -525,13 +525,33 @@ static void spitz_bl_kick_battery(void) >> > } >> > } >> > >> > +static struct gpiod_lookup_table spitz_lcdcon_gpio_table = { >> > + .dev_id = "spi0.1",

Re: [PATCH] backlight: corgi: Convert to use GPIO descriptors

2019-12-13 Thread Linus Walleij
On Fri, Dec 13, 2019 at 6:24 PM Robert Jarzmik wrote: > Linus Walleij writes: > > On Sun, Dec 8, 2019 at 9:06 PM Robert Jarzmik > > wrote: > >> Linus Walleij writes: > > So it will theoretically "spi0.1" > > > > Beware about bugs in the above interpreter because it is > > just my brain. > > W

Re: [PATCH] backlight: corgi: Convert to use GPIO descriptors

2019-12-10 Thread Linus Walleij
On Sun, Dec 8, 2019 at 9:06 PM Robert Jarzmik wrote: > Linus Walleij writes: > > @@ -525,13 +525,33 @@ static void spitz_bl_kick_battery(void) > > } > > } > > > > +static struct gpiod_lookup_table spitz_lcdcon_gpio_table = { > > + .dev_id = "spi0.1", > How do you know the correct devi

Re: [PATCH] backlight: corgi: Convert to use GPIO descriptors

2019-12-09 Thread Robert Jarzmik
Linus Walleij writes: Hi Linus, > @@ -525,13 +525,33 @@ static void spitz_bl_kick_battery(void) > } > } > > +static struct gpiod_lookup_table spitz_lcdcon_gpio_table = { > + .dev_id = "spi0.1", How do you know the correct device name is "spi0.1" ? Cheers. -- Robert ___

Re: [PATCH] backlight: corgi: Convert to use GPIO descriptors

2019-12-05 Thread Daniel Thompson
On Tue, Dec 03, 2019 at 01:31:43PM +0100, Linus Walleij wrote: > The code in the Corgi backlight driver can be considerably > simplified by moving to GPIO descriptors and lookup tables > from the board files instead of passing GPIO numbers using > the old API. > > Make sure to encode inversion sem

[PATCH] backlight: corgi: Convert to use GPIO descriptors

2019-12-03 Thread Linus Walleij
The code in the Corgi backlight driver can be considerably simplified by moving to GPIO descriptors and lookup tables from the board files instead of passing GPIO numbers using the old API. Make sure to encode inversion semantics for the Akita and Spitz platforms inside the GPIO lookup table and d