[PATCH] agp: Enable all supported rates for graphic cards

2011-11-07 Thread Tormod Volden
On Mon, Nov 7, 2011 at 5:08 PM, Alex Deucher wrote: > On Mon, Nov 7, 2011 at 11:05 AM, Tormod Volden > wrote: >> On Mon, Nov 7, 2011 at 2:50 PM, Konrad Rzeszutek Wilk >> wrote: >>> On Sun, Nov 06, 2011 at 04:03:21PM +0100, Tormod Volden wrote: From: Tormod Volden Some cards repo

[PATCH] agp: Enable all supported rates for graphic cards

2011-11-07 Thread Tormod Volden
On Mon, Nov 7, 2011 at 2:50 PM, Konrad Rzeszutek Wilk wrote: > On Sun, Nov 06, 2011 at 04:03:21PM +0100, Tormod Volden wrote: >> From: Tormod Volden >> >> Some cards report that they support only 4x, in which case they >> should support 2x and 1x as well, according to the AGP spec. > > Have you t

[PATCH] agp: Enable all supported rates for graphic cards

2011-11-07 Thread Alex Deucher
On Mon, Nov 7, 2011 at 11:05 AM, Tormod Volden wrote: > On Mon, Nov 7, 2011 at 2:50 PM, Konrad Rzeszutek Wilk > wrote: >> On Sun, Nov 06, 2011 at 04:03:21PM +0100, Tormod Volden wrote: >>> From: Tormod Volden >>> >>> Some cards report that they support only 4x, in which case they >>> should sup

[PATCH] agp: Enable all supported rates for graphic cards

2011-11-07 Thread Konrad Rzeszutek Wilk
On Sun, Nov 06, 2011 at 04:03:21PM +0100, Tormod Volden wrote: > From: Tormod Volden > > Some cards report that they support only 4x, in which case they > should support 2x and 1x as well, according to the AGP spec. Have you tested it on other hardware besides your KN133? > > Otherwise a reque

Re: [PATCH] agp: Enable all supported rates for graphic cards

2011-11-07 Thread Tormod Volden
On Mon, Nov 7, 2011 at 5:08 PM, Alex Deucher wrote: > On Mon, Nov 7, 2011 at 11:05 AM, Tormod Volden wrote: >> On Mon, Nov 7, 2011 at 2:50 PM, Konrad Rzeszutek Wilk >> wrote: >>> On Sun, Nov 06, 2011 at 04:03:21PM +0100, Tormod Volden wrote: From: Tormod Volden Some cards report

Re: [PATCH] agp: Enable all supported rates for graphic cards

2011-11-07 Thread Alex Deucher
On Mon, Nov 7, 2011 at 11:05 AM, Tormod Volden wrote: > On Mon, Nov 7, 2011 at 2:50 PM, Konrad Rzeszutek Wilk > wrote: >> On Sun, Nov 06, 2011 at 04:03:21PM +0100, Tormod Volden wrote: >>> From: Tormod Volden >>> >>> Some cards report that they support only 4x, in which case they >>> should supp

Re: [PATCH] agp: Enable all supported rates for graphic cards

2011-11-07 Thread Tormod Volden
On Mon, Nov 7, 2011 at 2:50 PM, Konrad Rzeszutek Wilk wrote: > On Sun, Nov 06, 2011 at 04:03:21PM +0100, Tormod Volden wrote: >> From: Tormod Volden >> >> Some cards report that they support only 4x, in which case they >> should support 2x and 1x as well, according to the AGP spec. > > Have you t

Re: [PATCH] agp: Enable all supported rates for graphic cards

2011-11-07 Thread Konrad Rzeszutek Wilk
On Sun, Nov 06, 2011 at 04:03:21PM +0100, Tormod Volden wrote: > From: Tormod Volden > > Some cards report that they support only 4x, in which case they > should support 2x and 1x as well, according to the AGP spec. Have you tested it on other hardware besides your KN133? > > Otherwise a reque

[PATCH] agp: Enable all supported rates for graphic cards

2011-11-06 Thread Tormod Volden
On Sun, Nov 6, 2011 at 4:37 PM, Corbin Simpson wrote: > Trusting the spec worries me; could this break anybody? It will allow the user to override possibly safer default settings. If a user has specified, say, 2x in his xorg.conf and this was not honored because the card only reported 4x, this pa

[PATCH] agp: Enable all supported rates for graphic cards

2011-11-06 Thread Tormod Volden
From: Tormod Volden Some cards report that they support only 4x, in which case they should support 2x and 1x as well, according to the AGP spec. Otherwise a requested 1x or 2x rate will result in 0 being set: agpgart-via :00:00.0: putting AGP V2 device into 0x mode For instance ProSavage K

Re: [PATCH] agp: Enable all supported rates for graphic cards

2011-11-06 Thread Corbin Simpson
Thanks for writing it! Reviewed-by: Corbin Simpson Sending from a mobile, pardon my terseness. ~ C. On Nov 6, 2011 10:39 AM, "Tormod Volden" wrote: > On Sun, Nov 6, 2011 at 4:37 PM, Corbin Simpson > wrote: > > Trusting the spec worries me; could this break anybody? > > It will allow the user

[PATCH] agp: Enable all supported rates for graphic cards

2011-11-06 Thread Corbin Simpson
Thanks for writing it! Reviewed-by: Corbin Simpson Sending from a mobile, pardon my terseness. ~ C. On Nov 6, 2011 10:39 AM, "Tormod Volden" wrote: > On Sun, Nov 6, 2011 at 4:37 PM, Corbin Simpson > wrote: > > Trusting the spec worries me; could this break anybody? > > It will allow the user

Re: [PATCH] agp: Enable all supported rates for graphic cards

2011-11-06 Thread Tormod Volden
On Sun, Nov 6, 2011 at 4:37 PM, Corbin Simpson wrote: > Trusting the spec worries me; could this break anybody? It will allow the user to override possibly safer default settings. If a user has specified, say, 2x in his xorg.conf and this was not honored because the card only reported 4x, this pa

Re: [PATCH] agp: Enable all supported rates for graphic cards

2011-11-06 Thread Corbin Simpson
Trusting the spec worries me; could this break anybody? Is there any reason to use the not-so-magic numbers instead of the named constants? Sending from a mobile, pardon my terseness. ~ C. On Nov 6, 2011 7:03 AM, "Tormod Volden" wrote: > From: Tormod Volden > > Some cards report that they supp

[PATCH] agp: Enable all supported rates for graphic cards

2011-11-06 Thread Corbin Simpson
Trusting the spec worries me; could this break anybody? Is there any reason to use the not-so-magic numbers instead of the named constants? Sending from a mobile, pardon my terseness. ~ C. On Nov 6, 2011 7:03 AM, "Tormod Volden" wrote: > From: Tormod Volden > > Some cards report that they supp

[PATCH] agp: Enable all supported rates for graphic cards

2011-11-06 Thread Tormod Volden
From: Tormod Volden Some cards report that they support only 4x, in which case they should support 2x and 1x as well, according to the AGP spec. Otherwise a requested 1x or 2x rate will result in 0 being set: agpgart-via :00:00.0: putting AGP V2 device into 0x mode For instance ProSavage K