Re: [PATCH] accel/qaic: silence some uninitialized variable warnings

2023-05-16 Thread Jeffrey Hugo
On 5/10/2023 10:48 AM, Dan Carpenter wrote: On Wed, May 10, 2023 at 08:57:03AM -0600, Jeffrey Hugo wrote: On 5/3/2023 4:41 AM, Dan Carpenter wrote: Smatch complains that these are not initialized if get_cntl_version() fails but we still print them in the debug message. Not the end of the world

Re: [PATCH] accel/qaic: silence some uninitialized variable warnings

2023-05-12 Thread Pranjal Ramajor Asha Kanojiya
On 5/3/2023 4:11 PM, Dan Carpenter wrote: Smatch complains that these are not initialized if get_cntl_version() fails but we still print them in the debug message. Not the end of the world, but true enough. Let's just initialize them to a dummy value to make the checker happy. Signed-off-by

Re: [PATCH] accel/qaic: silence some uninitialized variable warnings

2023-05-12 Thread Carl Vanderlip
On 5/3/2023 3:41 AM, Dan Carpenter wrote: Smatch complains that these are not initialized if get_cntl_version() fails but we still print them in the debug message. Not the end of the world, but true enough. Let's just initialize them to a dummy value to make the checker happy. Signed-off-by: D

Re: [PATCH] accel/qaic: silence some uninitialized variable warnings

2023-05-10 Thread Dan Carpenter
On Wed, May 10, 2023 at 08:57:03AM -0600, Jeffrey Hugo wrote: > On 5/3/2023 4:41 AM, Dan Carpenter wrote: > > Smatch complains that these are not initialized if get_cntl_version() > > fails but we still print them in the debug message. Not the end of > > the world, but true enough. Let's just ini

Re: [PATCH] accel/qaic: silence some uninitialized variable warnings

2023-05-10 Thread Jeffrey Hugo
On 5/3/2023 4:41 AM, Dan Carpenter wrote: Smatch complains that these are not initialized if get_cntl_version() fails but we still print them in the debug message. Not the end of the world, but true enough. Let's just initialize them to a dummy value to make the checker happy. Signed-off-by: D

[PATCH] accel/qaic: silence some uninitialized variable warnings

2023-05-03 Thread Dan Carpenter
Smatch complains that these are not initialized if get_cntl_version() fails but we still print them in the debug message. Not the end of the world, but true enough. Let's just initialize them to a dummy value to make the checker happy. Signed-off-by: Dan Carpenter --- drivers/accel/qaic/qaic_d