Re: [PATCH] SPI: meson-spifc add missed calls to remove function

2021-04-30 Thread Mark Brown
On Fri, Apr 30, 2021 at 04:49:35PM +0800, Art Nikpal wrote: > Yep! but Please don't top post, reply in line with needed context. This allows readers to readily follow the flow of conversation and understand what you are talking about and also helps ensure that everything in the discussion is bei

Re: [PATCH] SPI: meson-spifc add missed calls to remove function

2021-04-30 Thread Art Nikpal
Yep! but if i try call spi_master_put(master) or spi_unregister_controller(master); it's made Segmentation fault for me what's wrong - may be somebody can help me On Mon, Apr 26, 2021 at 7:57 PM Mark Brown wrote: > > On Sat, Apr 24, 2021 at 07:57:19AM +0800, Art Nikpal wrote: > > > > I would e

Re: [PATCH] SPI: meson-spifc add missed calls to remove function

2021-04-26 Thread Mark Brown
On Sat, Apr 24, 2021 at 07:57:19AM +0800, Art Nikpal wrote: > > I would expect the driver to unregister the controller at the start of > > the remove function, suspend doesn't really make sense here > It's strange - But without spi_master_suspend i have randomly stucks when i > try unload this mo

Re: [PATCH] SPI: meson-spifc add missed calls to remove function

2021-04-23 Thread Art Nikpal
> I would expect the driver to unregister the controller at the start of > the remove function, suspend doesn't really make sense here It's strange - But without spi_master_suspend i have randomly stucks when i try unload this module - as was written before i was test it (load/unload module in loo

Re: [PATCH] SPI: meson-spifc add missed calls to remove function

2021-04-23 Thread Art Nikpal
> I would expect the driver to unregister the controller at the start of > the remove function, suspend doesn't really make sense here It's strange - But without spi_master_suspend i have randomly stucks when i try unload this module - as was written before i was test it (load/unload module in loo

Re: [PATCH] SPI: meson-spifc add missed calls to remove function

2021-04-23 Thread Mark Brown
On Fri, Apr 23, 2021 at 11:42:47AM +0800, Artem Lapkin wrote: > Problem: rmmod meson_gx_mmc - not stable without spi_master_suspend call > and we can get stuck when try unload this module > +++ b/drivers/spi/spi-meson-spifc.c > @@ -359,6 +359,7 @@ static int meson_spifc_remove(struct platform_devi

[PATCH] SPI: meson-spifc add missed calls to remove function

2021-04-22 Thread Artem Lapkin
Problem: rmmod meson_gx_mmc - not stable without spi_master_suspend call and we can get stuck when try unload this module rmmod meson_gx_mmc ... [ 421.108614] Deleting MTD partitions on "spi0.0": [ 424.219862] spi_master spi0: Failed to power device: -13 ... lsmod | grep spi spi_meson_spifc