[PATCH] Prevent zero sized wl_egl_window

2014-02-18 Thread Kristian Høgsberg
On Fri, Feb 14, 2014 at 09:31:45AM +0200, Pekka Paalanen wrote: > On Thu, 13 Feb 2014 18:18:23 + > "Yeh, Sinclair" wrote: > > > > The below seems fine, but I wonder if we could make this one cause an > > > error to be returned later where we can, rather than silently ignoring. > > > I'm not s

[PATCH] Prevent zero sized wl_egl_window

2014-02-14 Thread Pekka Paalanen
On Thu, 13 Feb 2014 18:18:23 + "Yeh, Sinclair" wrote: > > The below seems fine, but I wonder if we could make this one cause an > > error to be returned later where we can, rather than silently ignoring. > > I'm not sure where or how, though. > > Would it make sense to change wl_egl_window_r

[PATCH] Prevent zero sized wl_egl_window

2014-02-13 Thread Yeh, Sinclair
> The below seems fine, but I wonder if we could make this one cause an > error to be returned later where we can, rather than silently ignoring. > I'm not sure where or how, though. Would it make sense to change wl_egl_window_resize() so that it return a value? Either that, or it should be docum

[PATCH] Prevent zero sized wl_egl_window

2014-02-13 Thread Pekka Paalanen
On Wed, 12 Feb 2014 16:21:11 -0800 Sinclair Yeh wrote: > It is illegal to create or resize a window to zero (or negative) width > and/or height. This patch prevents such a request from happening. > --- > src/egl/wayland/wayland-egl/wayland-egl.c | 6 ++ > 1 file changed, 6 insertions(+) >

[PATCH] Prevent zero sized wl_egl_window

2014-02-12 Thread Sinclair Yeh
It is illegal to create or resize a window to zero (or negative) width and/or height. This patch prevents such a request from happening. --- src/egl/wayland/wayland-egl/wayland-egl.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/egl/wayland/wayland-egl/wayland-egl.c b/src/egl/way