[PATCH] [rfc] drm: close race in connector registration

2014-07-24 Thread Dave Airlie
> > This is the same we do for minor-objects, so fine with me. I'd prefer > if the registration is done last in drm_connector_register(), not > first, but I'm not sure the debugfs hooks work without the connector > available in the lookup tables. Maybe worth a try. I was worried sysfs registration

[PATCH] [rfc] drm: close race in connector registration

2014-07-24 Thread Dave Airlie
From: Dave Airlie Daniel pointed out with hotplug that userspace could be trying to oops us as root for lols, and that to be correct we shouldn't register the object with the idr before we have fully set the connector object up. His proposed solution was a lot more life changing, this seemed lik

[PATCH] [rfc] drm: close race in connector registration

2014-07-24 Thread David Herrmann
Hi On Thu, Jul 24, 2014 at 10:49 AM, Dave Airlie wrote: >> >> This is the same we do for minor-objects, so fine with me. I'd prefer >> if the registration is done last in drm_connector_register(), not >> first, but I'm not sure the debugfs hooks work without the connector >> available in the look

[PATCH] [rfc] drm: close race in connector registration

2014-07-24 Thread David Herrmann
Hi On Thu, Jul 24, 2014 at 3:53 AM, Dave Airlie wrote: > From: Dave Airlie > > Daniel pointed out with hotplug that userspace could be trying to oops us > as root for lols, and that to be correct we shouldn't register the object > with the idr before we have fully set the connector object up. >

[PATCH] [rfc] drm: close race in connector registration

2014-07-24 Thread Daniel Vetter
On Thu, Jul 24, 2014 at 11:53:45AM +1000, Dave Airlie wrote: > From: Dave Airlie > > Daniel pointed out with hotplug that userspace could be trying to oops us > as root for lols, and that to be correct we shouldn't register the object > with the idr before we have fully set the connector object u