On Thu, Oct 28, 2021 at 5:24 PM Daniel Vetter wrote:
>
> On Wed, Oct 27, 2021 at 03:19:34PM +0200, Javier Martinez Canillas wrote:
> > On 10/27/21 14:18, Arnd Bergmann wrote:
> >
> > [snip]
> >
> > > Right, how about this change on top?
> > >
> > > --- a/drivers/gpu/drm/Kconfig
> > > +++ b/drivers
On Wed, Oct 27, 2021 at 03:19:34PM +0200, Javier Martinez Canillas wrote:
> On 10/27/21 14:18, Arnd Bergmann wrote:
>
> [snip]
>
> > Right, how about this change on top?
> >
> > --- a/drivers/gpu/drm/Kconfig
> > +++ b/drivers/gpu/drm/Kconfig
> > @@ -117,9 +117,8 @@ config DRM_DEBUG_MODESET_LOCK
On 10/27/21 15:25, Arnd Bergmann wrote:
[snip]
> That's not going to help in this case, the way the helper functions work is
> that
> you select them as needed, and you avoid the other dependencies. This part
> works fine.
>
> We could probably get rid of this symbol by just making it an uncond
On Wed, Oct 27, 2021 at 3:06 PM Jani Nikula wrote:
> On Wed, 27 Oct 2021, Arnd Bergmann wrote:
> > This fails because of all the other drivers that try to 'select
> > DRM_KMS_HELPER'.
> > Kconfig will now complain about a symbol that gets selected while its
> > dependencies
> > are not met.
> >
On 10/27/21 14:18, Arnd Bergmann wrote:
[snip]
> Right, how about this change on top?
>
> --- a/drivers/gpu/drm/Kconfig
> +++ b/drivers/gpu/drm/Kconfig
> @@ -117,9 +117,8 @@ config DRM_DEBUG_MODESET_LOCK
>
> config DRM_FBDEV_EMULATION
> bool "Enable legacy fbdev support for your modese
On 10/27/21 14:55, Jani Nikula wrote:
[snip]
>> Why the dependency has to be in a user-visible symbol? What could be the
>> problem with having something like:
>>
>> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
>> index cea777ae7fb9..f80b404946ca 100644
>> --- a/drivers/gpu/drm/
On Wed, 27 Oct 2021, Arnd Bergmann wrote:
> On Wed, Oct 27, 2021 at 2:38 PM Javier Martinez Canillas
> wrote:
>> >
>> > This is something we can't easily express in Kconfig, as we can't add the
>> > dependency to a symbol that only gets selected by other drivers, which
>> > is why the dependency
On Wed, 27 Oct 2021, Arnd Bergmann wrote:
> On a related note, I did manage to sort out the backlight dependency issue
> (intel_panel.c:(.text+0x2f58): undefined reference to
> `backlight_device_register'),
> but haven't sent that one again yet, but I can if you like. This one changes
> DRM_I915 a
On 10/27/21 14:52, Arnd Bergmann wrote:
[snip]
>>
>> @@ -104,7 +105,6 @@ config DRM_FBDEV_EMULATION
>> bool "Enable legacy fbdev support for your modesetting driver"
>> depends on DRM
>> depends on FB
>> - select DRM_KMS_HELPER
>> select FB_CFB_FILLRECT
>>
On Wed, 27 Oct 2021, Javier Martinez Canillas wrote:
> On 10/27/21 14:18, Arnd Bergmann wrote:
>> On Wed, Oct 27, 2021 at 1:47 PM Jani Nikula
>> wrote:
>
> [snip]
>
>>> drm_fb_helper.o is not part of drm.ko, it's part of
>>> drm_kms_helper.ko. This adds some sort of indirect dependency via DRM
>
On Wed, Oct 27, 2021 at 2:38 PM Javier Martinez Canillas
wrote:
> >
> > This is something we can't easily express in Kconfig, as we can't add the
> > dependency to a symbol that only gets selected by other drivers, which
> > is why the dependency has to be in the user-visible symbol,
> > in this c
On 10/27/21 14:18, Arnd Bergmann wrote:
> On Wed, Oct 27, 2021 at 1:47 PM Jani Nikula
> wrote:
[snip]
>> drm_fb_helper.o is not part of drm.ko, it's part of
>> drm_kms_helper.ko. This adds some sort of indirect dependency via DRM
>> which might work, maybe by coincidence, maybe not - but it's c
On Wed, Oct 27, 2021 at 1:47 PM Jani Nikula wrote:
> On Thu, 30 Sep 2021, Daniel Vetter wrote:
> > On Mon, Sep 27, 2021 at 09:23:45AM -0700, Kees Cook wrote:
> >> On Mon, Sep 27, 2021 at 04:28:02PM +0200, Arnd Bergmann wrote:
> >> > From: Arnd Bergmann
> >> >
> >> > With CONFIG_FB=m and CONFIG_D
On Wed, 27 Oct 2021, Jani Nikula wrote:
> On Thu, 30 Sep 2021, Daniel Vetter wrote:
>> On Mon, Sep 27, 2021 at 09:23:45AM -0700, Kees Cook wrote:
>>> On Mon, Sep 27, 2021 at 04:28:02PM +0200, Arnd Bergmann wrote:
>>> > From: Arnd Bergmann
>>> >
>>> > With CONFIG_FB=m and CONFIG_DRM=y, we get a
On Thu, 30 Sep 2021, Daniel Vetter wrote:
> On Mon, Sep 27, 2021 at 09:23:45AM -0700, Kees Cook wrote:
>> On Mon, Sep 27, 2021 at 04:28:02PM +0200, Arnd Bergmann wrote:
>> > From: Arnd Bergmann
>> >
>> > With CONFIG_FB=m and CONFIG_DRM=y, we get a link error in the fb helper:
>> >
>> > aarch64-
On Mon, Sep 27, 2021 at 09:23:45AM -0700, Kees Cook wrote:
> On Mon, Sep 27, 2021 at 04:28:02PM +0200, Arnd Bergmann wrote:
> > From: Arnd Bergmann
> >
> > With CONFIG_FB=m and CONFIG_DRM=y, we get a link error in the fb helper:
> >
> > aarch64-linux-ld: drivers/gpu/drm/drm_fb_helper.o: in funct
On Mon, Sep 27, 2021 at 04:28:02PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> With CONFIG_FB=m and CONFIG_DRM=y, we get a link error in the fb helper:
>
> aarch64-linux-ld: drivers/gpu/drm/drm_fb_helper.o: in function
> `drm_fb_helper_alloc_fbi':
> (.text+0x10cc): undefined reference
From: Arnd Bergmann
With CONFIG_FB=m and CONFIG_DRM=y, we get a link error in the fb helper:
aarch64-linux-ld: drivers/gpu/drm/drm_fb_helper.o: in function
`drm_fb_helper_alloc_fbi':
(.text+0x10cc): undefined reference to `framebuffer_alloc'
Tighten the dependency so it is only allowed in the
18 matches
Mail list logo
