Re: [PATCH][next] drm/v3d: fix double free of bin

2019-10-25 Thread Dan Carpenter
On Thu, Oct 24, 2019 at 02:38:53PM +0200, Daniel Vetter wrote: > On Thu, Oct 24, 2019 at 11:48:01AM +0100, Colin King wrote: > > From: Colin Ian King > > > > Two different fixes have addressed the same memory leak of bin and > > this now causes a double free of bin. While the individual memory >

Re: [PATCH][next] drm/v3d: fix double free of bin

2019-10-24 Thread Stephen Rothwell
Hi all, On Thu, 24 Oct 2019 14:49:36 +0200 Daniel Vetter wrote: > > Ok adding Stephen. There's a merge conflict between drm-misc-fixes and > drm-next (I think) and the merge double-added the kfree(bin). See > above for the relevant sha1. Dave is already on here as a heads-up, > but also adding dr

Re: [PATCH][next] drm/v3d: fix double free of bin

2019-10-24 Thread Daniel Vetter
On Thu, Oct 24, 2019 at 2:43 PM Colin Ian King wrote: > > On 24/10/2019 13:38, Daniel Vetter wrote: > > On Thu, Oct 24, 2019 at 11:48:01AM +0100, Colin King wrote: > >> From: Colin Ian King > >> > >> Two different fixes have addressed the same memory leak of bin and > >> this now causes a double

Re: [PATCH][next] drm/v3d: fix double free of bin

2019-10-24 Thread Colin Ian King
On 24/10/2019 13:38, Daniel Vetter wrote: > On Thu, Oct 24, 2019 at 11:48:01AM +0100, Colin King wrote: >> From: Colin Ian King >> >> Two different fixes have addressed the same memory leak of bin and >> this now causes a double free of bin. While the individual memory >> leak fixes are fine, bot

Re: [PATCH][next] drm/v3d: fix double free of bin

2019-10-24 Thread Daniel Vetter
On Thu, Oct 24, 2019 at 11:48:01AM +0100, Colin King wrote: > From: Colin Ian King > > Two different fixes have addressed the same memory leak of bin and > this now causes a double free of bin. While the individual memory > leak fixes are fine, both fixes together are problematic. > > Addresses

[PATCH][next] drm/v3d: fix double free of bin

2019-10-24 Thread Colin King
From: Colin Ian King Two different fixes have addressed the same memory leak of bin and this now causes a double free of bin. While the individual memory leak fixes are fine, both fixes together are problematic. Addresses-Coverity: ("Double free") Fixes: 29cd13cfd762 ("drm/v3d: Fix memory leak