Re: [PATCH][next] drm/komeda: remove redundant assignment to pointer disable_done

2019-10-08 Thread james qian wang (Arm Technology China)
On Mon, Oct 07, 2019 at 04:25:05PM +0300, Dan Carpenter wrote: > On Fri, Oct 04, 2019 at 10:53:44PM +0100, Colin Ian King wrote: > > On 04/10/2019 20:27, Liviu Dudau wrote: > > > On Fri, Oct 04, 2019 at 05:21:56PM +0100, Colin King wrote: > > >> From: Colin Ian King > > >> > > >> The pointer disab

Re: [PATCH][next] drm/komeda: remove redundant assignment to pointer disable_done

2019-10-07 Thread Dan Carpenter
On Fri, Oct 04, 2019 at 10:53:44PM +0100, Colin Ian King wrote: > On 04/10/2019 20:27, Liviu Dudau wrote: > > On Fri, Oct 04, 2019 at 05:21:56PM +0100, Colin King wrote: > >> From: Colin Ian King > >> > >> The pointer disable_done is being initialized with a value that > >> is never read and is be

Re: [PATCH][next] drm/komeda: remove redundant assignment to pointer disable_done

2019-10-04 Thread Colin Ian King
On 04/10/2019 20:27, Liviu Dudau wrote: > On Fri, Oct 04, 2019 at 05:21:56PM +0100, Colin King wrote: >> From: Colin Ian King >> >> The pointer disable_done is being initialized with a value that >> is never read and is being re-assigned a little later on. The >> assignment is redundant and hence

Re: [PATCH][next] drm/komeda: remove redundant assignment to pointer disable_done

2019-10-04 Thread Liviu Dudau
On Fri, Oct 04, 2019 at 05:21:56PM +0100, Colin King wrote: > From: Colin Ian King > > The pointer disable_done is being initialized with a value that > is never read and is being re-assigned a little later on. The > assignment is redundant and hence can be removed. Not really true, isn't it? Th

[PATCH][next] drm/komeda: remove redundant assignment to pointer disable_done

2019-10-04 Thread Colin King
From: Colin Ian King The pointer disable_done is being initialized with a value that is never read and is being re-assigned a little later on. The assignment is redundant and hence can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/gpu/drm/arm/displa