Re: [PATCH][next] dma-buf: heaps: remove redundant assignment to variable ret

2019-10-31 Thread Colin Ian King
On 30/10/2019 17:21, John Stultz wrote: > On Wed, Oct 30, 2019 at 8:45 AM Andrew F. Davis wrote: >> >> On 10/30/19 11:02 AM, Colin King wrote: >>> From: Colin Ian King >>> >>> The variable ret is being assigned with a value that is never >>> read, it is being re-assigned the same value on the err

Re: [PATCH][next] dma-buf: heaps: remove redundant assignment to variable ret

2019-10-30 Thread John Stultz
On Wed, Oct 30, 2019 at 8:45 AM Andrew F. Davis wrote: > > On 10/30/19 11:02 AM, Colin King wrote: > > From: Colin Ian King > > > > The variable ret is being assigned with a value that is never > > read, it is being re-assigned the same value on the err0 exit > > path. The assignment is redundant

Re: [PATCH][next] dma-buf: heaps: remove redundant assignment to variable ret

2019-10-30 Thread Andrew F. Davis
On 10/30/19 11:02 AM, Colin King wrote: > From: Colin Ian King > > The variable ret is being assigned with a value that is never > read, it is being re-assigned the same value on the err0 exit > path. The assignment is redundant and hence can be removed. > > Addresses-Coverity: ("Unused value")

[PATCH][next] dma-buf: heaps: remove redundant assignment to variable ret

2019-10-30 Thread Colin King
From: Colin Ian King The variable ret is being assigned with a value that is never read, it is being re-assigned the same value on the err0 exit path. The assignment is redundant and hence can be removed. Addresses-Coverity: ("Unused value") Fixes: 47a32f9c1226 ("dma-buf: heaps: Add system heap