On 8 July 2015 at 18:41, Alan Coopersmith
wrote:
> Linux seems to pick these up via another header, but Solaris needs them
> explictly included, or we get undefined symbol errors for major & minor.
>
> v2: use headers documented in makedev(3C) man page instead of sysmacros.h
>
> Signed-off-by: Al
Hi Alan
On 7 July 2015 at 01:45, Alan Coopersmith
wrote:
> Linux seems to pick this up via another header, but Solaris needs it
> explictly included, or we get undefined symbol errors for major & minor.
>
A slightly pedandic suggestion:
Can we use sys/types.h + sys/mkdev.h as the manpage suggest
On 07/ 8/15 10:59 AM, Emil Velikov wrote:
> On 8 July 2015 at 18:41, Alan Coopersmith
> wrote:
>> Linux seems to pick these up via another header, but Solaris needs them
>> explictly included, or we get undefined symbol errors for major & minor.
>>
>> v2: use headers documented in makedev(3C) man
Linux seems to pick these up via another header, but Solaris needs them
explictly included, or we get undefined symbol errors for major & minor.
v2: use headers documented in makedev(3C) man page instead of sysmacros.h
Signed-off-by: Alan Coopersmith
---
libkms/linux.c |2 ++
1 file changed
On 07/ 8/15 09:19 AM, Emil Velikov wrote:
> Hi Alan
>
> On 7 July 2015 at 01:45, Alan Coopersmith
> wrote:
>> Linux seems to pick this up via another header, but Solaris needs it
>> explictly included, or we get undefined symbol errors for major & minor.
>>
> A slightly pedandic suggestion:
> Can
Linux seems to pick this up via another header, but Solaris needs it
explictly included, or we get undefined symbol errors for major & minor.
Signed-off-by: Alan Coopersmith
---
libkms/linux.c |1 +
1 file changed, 1 insertion(+)
diff --git a/libkms/linux.c b/libkms/linux.c
index 4d47148..f