Re: [PATCH, RESEND] drm/vmwgfx: Don't double-free the mode stored in par->set_mode

2019-03-19 Thread Thomas Hellstrom
Hi, Deepak, On Mon, 2019-03-18 at 09:59 -0700, Deepak Singh Rawat wrote: > Hi Thomas, > > Thanks for doing this and somehow I missed the last patch, sorry > about > that. Have some questions below otherwise the patch looks good to me. > > Reviewed-by: Deepak Rawat > > I will include your chang

Re: [PATCH, RESEND] drm/vmwgfx: Don't double-free the mode stored in par->set_mode

2019-03-19 Thread Thomas Zimmermann
Hi Deepak Am 18.03.19 um 17:59 schrieb Deepak Singh Rawat: > Hi Thomas, > > Thanks for doing this and somehow I missed the last patch, sorry about > that. Have some questions below otherwise the patch looks good to me. > > Reviewed-by: Deepak Rawat > > I will include your changes in vmwgfx-nex

Re: [PATCH, RESEND] drm/vmwgfx: Don't double-free the mode stored in par->set_mode

2019-03-18 Thread Deepak Singh Rawat
Hi Thomas, Thanks for doing this and somehow I missed the last patch, sorry about that. Have some questions below otherwise the patch looks good to me. Reviewed-by: Deepak Rawat I will include your changes in vmwgfx-next and run tests. On Mon, 2019-03-18 at 15:47 +0100, Thomas Zimmermann wrote

[PATCH, RESEND] drm/vmwgfx: Don't double-free the mode stored in par->set_mode

2019-03-18 Thread Thomas Zimmermann
When calling vmw_fb_set_par(), the mode stored in par->set_mode gets free'd twice. The first free is in vmw_fb_kms_detach(), the second is near the end of vmw_fb_set_par() under the name of 'old_mode'. The mode-setting code only works correctly if the mode doesn't actually change. Removing 'old_mod