Re: [Intel-xe] [PATCH 02/14] drm/xe: Introduce the dev_coredump infrastructure.

2023-05-02 Thread Matthew Brost
On Tue, May 02, 2023 at 02:06:55PM -0400, Rodrigo Vivi wrote: > On Tue, May 02, 2023 at 07:57:02AM +, Matthew Brost wrote: > > On Thu, Apr 27, 2023 at 10:28:13AM +0200, Thomas Hellström wrote: > > > > > > On 4/26/23 22:57, Rodrigo Vivi wrote: > > > > The goal is to use devcoredump infrastructu

Re: [Intel-xe] [PATCH 02/14] drm/xe: Introduce the dev_coredump infrastructure.

2023-05-02 Thread Rodrigo Vivi
On Tue, May 02, 2023 at 07:57:02AM +, Matthew Brost wrote: > On Thu, Apr 27, 2023 at 10:28:13AM +0200, Thomas Hellström wrote: > > > > On 4/26/23 22:57, Rodrigo Vivi wrote: > > > The goal is to use devcoredump infrastructure to report error states > > > captured at the crash time. > > > > > >

Re: [Intel-xe] [PATCH 02/14] drm/xe: Introduce the dev_coredump infrastructure.

2023-05-02 Thread Rodrigo Vivi
On Tue, May 02, 2023 at 10:55:14AM +0300, Jani Nikula wrote: > On Wed, 26 Apr 2023, Rodrigo Vivi wrote: > > + drm_info(&xe->drm, "Check your > > /sys/class/drm/card/device/devcoredump/data\n"); > > Drive-by comment, could use %d and xe->drm.primary->index instead of yeap, I wondered about tha

Re: [Intel-xe] [PATCH 02/14] drm/xe: Introduce the dev_coredump infrastructure.

2023-05-02 Thread Matthew Brost
On Thu, Apr 27, 2023 at 10:28:13AM +0200, Thomas Hellström wrote: > > On 4/26/23 22:57, Rodrigo Vivi wrote: > > The goal is to use devcoredump infrastructure to report error states > > captured at the crash time. > > > > The error state will contain useful information for GPU hang debug, such > >

Re: [Intel-xe] [PATCH 02/14] drm/xe: Introduce the dev_coredump infrastructure.

2023-05-02 Thread Jani Nikula
On Wed, 26 Apr 2023, Rodrigo Vivi wrote: > + drm_info(&xe->drm, "Check your > /sys/class/drm/card/device/devcoredump/data\n"); Drive-by comment, could use %d and xe->drm.primary->index instead of . BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center

Re: [Intel-xe] [PATCH 02/14] drm/xe: Introduce the dev_coredump infrastructure.

2023-04-27 Thread Thomas Hellström
On 4/26/23 22:57, Rodrigo Vivi wrote: The goal is to use devcoredump infrastructure to report error states captured at the crash time. The error state will contain useful information for GPU hang debug, such as INSTDONE registers and the current buffers getting executed, as well as any other i