Re: [Intel-gfx] [PATCH v6 01/11] drm/i915: Store backpointer to GT in uncore

2021-12-09 Thread Andi Shyti
Hi Jani, thanks for looking at it. > > - intel_gt_init_early(&dev_priv->gt, dev_priv); > > + __intel_gt_init_early(&dev_priv->gt, dev_priv); > > Why double underscores here? It looks like it's supposed to be internal > to intel_gt, not to be called by anyone else. I forgot to write two line

Re: [Intel-gfx] [PATCH v6 01/11] drm/i915: Store backpointer to GT in uncore

2021-12-09 Thread Jani Nikula
On Thu, 09 Dec 2021, Andi Shyti wrote: > From: Michał Winiarski > > We now support a per-gt uncore, yet we're not able to infer which GT > we're operating upon. Let's store a backpointer for now. > > Signed-off-by: Michał Winiarski > Signed-off-by: Matt Roper > Reviewed-by: Andi Shyti > Signe