Re: [Intel-gfx] [PATCH 2/3] drm: Create a format/modifier blob

2017-05-17 Thread Rob Clark
On Wed, May 17, 2017 at 8:38 PM, Rob Clark wrote: > On Wed, May 17, 2017 at 8:00 PM, Ben Widawsky wrote: >> On 17-05-17 13:31:44, Daniel Vetter wrote: >>> >>> On Tue, May 16, 2017 at 02:19:12PM -0700, Ben Widawsky wrote: On 17-05-03 17:08:27, Daniel Vetter wrote: > On Tue, May 02,

Re: [Intel-gfx] [PATCH 2/3] drm: Create a format/modifier blob

2017-05-17 Thread Rob Clark
On Wed, May 17, 2017 at 8:00 PM, Ben Widawsky wrote: > On 17-05-17 13:31:44, Daniel Vetter wrote: >> >> On Tue, May 16, 2017 at 02:19:12PM -0700, Ben Widawsky wrote: >>> >>> On 17-05-03 17:08:27, Daniel Vetter wrote: >>> > On Tue, May 02, 2017 at 10:14:27PM -0700, Ben Widawsky wrote: >>> > > +stru

Re: [Intel-gfx] [PATCH 2/3] drm: Create a format/modifier blob

2017-05-17 Thread Ben Widawsky
On 17-05-17 13:31:44, Daniel Vetter wrote: On Tue, May 16, 2017 at 02:19:12PM -0700, Ben Widawsky wrote: On 17-05-03 17:08:27, Daniel Vetter wrote: > On Tue, May 02, 2017 at 10:14:27PM -0700, Ben Widawsky wrote: > > +struct drm_format_modifier_blob { > > +#define FORMAT_BLOB_CURRENT 1 > > +

Re: [Intel-gfx] [PATCH 2/3] drm: Create a format/modifier blob

2017-05-17 Thread Daniel Vetter
On Wed, May 17, 2017 at 1:31 PM, Daniel Vetter wrote: > On Tue, May 16, 2017 at 02:19:12PM -0700, Ben Widawsky wrote: >> On 17-05-03 17:08:27, Daniel Vetter wrote: >> > On Tue, May 02, 2017 at 10:14:27PM -0700, Ben Widawsky wrote: >> > > +struct drm_format_modifier_blob { >> > > +#define FORMAT_BL

Re: [Intel-gfx] [PATCH 2/3] drm: Create a format/modifier blob

2017-05-17 Thread Daniel Vetter
On Tue, May 16, 2017 at 02:19:12PM -0700, Ben Widawsky wrote: > On 17-05-03 17:08:27, Daniel Vetter wrote: > > On Tue, May 02, 2017 at 10:14:27PM -0700, Ben Widawsky wrote: > > > +struct drm_format_modifier_blob { > > > +#define FORMAT_BLOB_CURRENT 1 > > > + /* Version of this blob format */ > > >

Re: [Intel-gfx] [PATCH 2/3] drm: Create a format/modifier blob

2017-05-16 Thread Ben Widawsky
On 17-05-03 17:08:27, Daniel Vetter wrote: On Tue, May 02, 2017 at 10:14:27PM -0700, Ben Widawsky wrote: Updated blob layout (Rob, Daniel, Kristian, xerpi) Cc: Rob Clark Cc: Daniel Stone Cc: Kristian H. Kristensen Signed-off-by: Ben Widawsky --- drivers/gpu/drm/drm_mode_config.c | 7 +++

Re: [Intel-gfx] [PATCH 2/3] drm: Create a format/modifier blob

2017-05-03 Thread Daniel Vetter
On Tue, May 02, 2017 at 10:14:27PM -0700, Ben Widawsky wrote: > Updated blob layout (Rob, Daniel, Kristian, xerpi) > > Cc: Rob Clark > Cc: Daniel Stone > Cc: Kristian H. Kristensen > Signed-off-by: Ben Widawsky > --- > drivers/gpu/drm/drm_mode_config.c | 7 +++ > drivers/gpu/drm/drm_plane.c

Re: [Intel-gfx] [PATCH 2/3] drm: Create a format/modifier blob

2017-05-03 Thread Brian Starkey
Hi Daniel, On Wed, May 03, 2017 at 03:07:40PM +0100, Daniel Stone wrote: Hi Brian, On 3 May 2017 at 15:03, Brian Starkey wrote: On Wed, May 03, 2017 at 02:51:18PM +0100, Daniel Stone wrote: formats_offset is the end of the fixed-size element, which is currently aligned to 32 bytes, and pract

Re: [Intel-gfx] [PATCH 2/3] drm: Create a format/modifier blob

2017-05-03 Thread Daniel Stone
Hi Brian, On 3 May 2017 at 15:03, Brian Starkey wrote: > On Wed, May 03, 2017 at 02:51:18PM +0100, Daniel Stone wrote: >> formats_offset is the end of the fixed-size element, which is >> currently aligned to 32 bytes, and practically speaking would always >> have to be anyway. As it is an array o

Re: [Intel-gfx] [PATCH 2/3] drm: Create a format/modifier blob

2017-05-03 Thread Brian Starkey
On Wed, May 03, 2017 at 02:51:18PM +0100, Daniel Stone wrote: Hi Brian, On 3 May 2017 at 13:51, Brian Starkey wrote: On Tue, May 02, 2017 at 10:14:27PM -0700, Ben Widawsky wrote: + modifiers_size = + sizeof(struct drm_format_modifier) * format_modifier_count; + + blo

Re: [Intel-gfx] [PATCH 2/3] drm: Create a format/modifier blob

2017-05-03 Thread Daniel Stone
Hi Brian, On 3 May 2017 at 13:51, Brian Starkey wrote: > On Tue, May 02, 2017 at 10:14:27PM -0700, Ben Widawsky wrote: >> + modifiers_size = >> + sizeof(struct drm_format_modifier) * >> format_modifier_count; >> + >> + blob_size = ALIGN(sizeof(struct drm_format_modifier_