Re: [Intel-gfx] [PATCH 16/21] drm/i915/gem: Delay context creation

2021-04-30 Thread Daniel Vetter
On Fri, Apr 30, 2021 at 6:57 PM Jason Ekstrand wrote: > > On Fri, Apr 30, 2021 at 11:33 AM Daniel Vetter wrote: > > > > On Fri, Apr 30, 2021 at 6:27 PM Jason Ekstrand wrote: > > > > > > On Fri, Apr 30, 2021 at 1:53 AM Daniel Vetter wrote: > > > > > > > > On Thu, Apr 29, 2021 at 11:35 PM Jason E

Re: [Intel-gfx] [PATCH 16/21] drm/i915/gem: Delay context creation

2021-04-30 Thread Jason Ekstrand
On Fri, Apr 30, 2021 at 11:33 AM Daniel Vetter wrote: > > On Fri, Apr 30, 2021 at 6:27 PM Jason Ekstrand wrote: > > > > On Fri, Apr 30, 2021 at 1:53 AM Daniel Vetter wrote: > > > > > > On Thu, Apr 29, 2021 at 11:35 PM Jason Ekstrand > > > wrote: > > > > > > > > On Thu, Apr 29, 2021 at 2:07 PM

Re: [Intel-gfx] [PATCH 16/21] drm/i915/gem: Delay context creation

2021-04-30 Thread Daniel Vetter
On Fri, Apr 30, 2021 at 6:27 PM Jason Ekstrand wrote: > > On Fri, Apr 30, 2021 at 1:53 AM Daniel Vetter wrote: > > > > On Thu, Apr 29, 2021 at 11:35 PM Jason Ekstrand > > wrote: > > > > > > On Thu, Apr 29, 2021 at 2:07 PM Daniel Vetter wrote: > > > > > > > > On Thu, Apr 29, 2021 at 02:01:16PM

Re: [Intel-gfx] [PATCH 16/21] drm/i915/gem: Delay context creation

2021-04-30 Thread Jason Ekstrand
On Fri, Apr 30, 2021 at 1:53 AM Daniel Vetter wrote: > > On Thu, Apr 29, 2021 at 11:35 PM Jason Ekstrand wrote: > > > > On Thu, Apr 29, 2021 at 2:07 PM Daniel Vetter wrote: > > > > > > On Thu, Apr 29, 2021 at 02:01:16PM -0500, Jason Ekstrand wrote: > > > > On Thu, Apr 29, 2021 at 1:56 PM Daniel

Re: [Intel-gfx] [PATCH 16/21] drm/i915/gem: Delay context creation

2021-04-30 Thread Tvrtko Ursulin
On 30/04/2021 14:07, Daniel Vetter wrote: On Fri, Apr 30, 2021 at 2:44 PM Tvrtko Ursulin wrote: On 30/04/2021 13:30, Daniel Vetter wrote: On Fri, Apr 30, 2021 at 1:58 PM Tvrtko Ursulin wrote: On 30/04/2021 07:53, Daniel Vetter wrote: On Thu, Apr 29, 2021 at 11:35 PM Jason Ekstrand wrote:

Re: [Intel-gfx] [PATCH 16/21] drm/i915/gem: Delay context creation

2021-04-30 Thread Daniel Vetter
On Fri, Apr 30, 2021 at 2:44 PM Tvrtko Ursulin wrote: > > > > On 30/04/2021 13:30, Daniel Vetter wrote: > > On Fri, Apr 30, 2021 at 1:58 PM Tvrtko Ursulin > > wrote: > >> On 30/04/2021 07:53, Daniel Vetter wrote: > >>> On Thu, Apr 29, 2021 at 11:35 PM Jason Ekstrand > >>> wrote: > > O

Re: [Intel-gfx] [PATCH 16/21] drm/i915/gem: Delay context creation

2021-04-30 Thread Tvrtko Ursulin
On 30/04/2021 13:30, Daniel Vetter wrote: On Fri, Apr 30, 2021 at 1:58 PM Tvrtko Ursulin wrote: On 30/04/2021 07:53, Daniel Vetter wrote: On Thu, Apr 29, 2021 at 11:35 PM Jason Ekstrand wrote: On Thu, Apr 29, 2021 at 2:07 PM Daniel Vetter wrote: On Thu, Apr 29, 2021 at 02:01:16PM -050

Re: [Intel-gfx] [PATCH 16/21] drm/i915/gem: Delay context creation

2021-04-30 Thread Daniel Vetter
On Fri, Apr 30, 2021 at 1:58 PM Tvrtko Ursulin wrote: > > > On 30/04/2021 07:53, Daniel Vetter wrote: > > On Thu, Apr 29, 2021 at 11:35 PM Jason Ekstrand > > wrote: > >> > >> On Thu, Apr 29, 2021 at 2:07 PM Daniel Vetter wrote: > >>> > >>> On Thu, Apr 29, 2021 at 02:01:16PM -0500, Jason Ekstran

Re: [Intel-gfx] [PATCH 16/21] drm/i915/gem: Delay context creation

2021-04-30 Thread Tvrtko Ursulin
On 30/04/2021 07:53, Daniel Vetter wrote: On Thu, Apr 29, 2021 at 11:35 PM Jason Ekstrand wrote: On Thu, Apr 29, 2021 at 2:07 PM Daniel Vetter wrote: On Thu, Apr 29, 2021 at 02:01:16PM -0500, Jason Ekstrand wrote: On Thu, Apr 29, 2021 at 1:56 PM Daniel Vetter wrote: On Thu, Apr 29, 202

Re: [Intel-gfx] [PATCH 16/21] drm/i915/gem: Delay context creation

2021-04-29 Thread Daniel Vetter
On Thu, Apr 29, 2021 at 11:35 PM Jason Ekstrand wrote: > > On Thu, Apr 29, 2021 at 2:07 PM Daniel Vetter wrote: > > > > On Thu, Apr 29, 2021 at 02:01:16PM -0500, Jason Ekstrand wrote: > > > On Thu, Apr 29, 2021 at 1:56 PM Daniel Vetter wrote: > > > > On Thu, Apr 29, 2021 at 01:16:04PM -0500, Jas

Re: [Intel-gfx] [PATCH 16/21] drm/i915/gem: Delay context creation

2021-04-29 Thread Jason Ekstrand
On Thu, Apr 29, 2021 at 2:07 PM Daniel Vetter wrote: > > On Thu, Apr 29, 2021 at 02:01:16PM -0500, Jason Ekstrand wrote: > > On Thu, Apr 29, 2021 at 1:56 PM Daniel Vetter wrote: > > > On Thu, Apr 29, 2021 at 01:16:04PM -0500, Jason Ekstrand wrote: > > > > On Thu, Apr 29, 2021 at 10:51 AM Daniel V

Re: [Intel-gfx] [PATCH 16/21] drm/i915/gem: Delay context creation

2021-04-29 Thread Daniel Vetter
On Thu, Apr 29, 2021 at 02:01:16PM -0500, Jason Ekstrand wrote: > On Thu, Apr 29, 2021 at 1:56 PM Daniel Vetter wrote: > > On Thu, Apr 29, 2021 at 01:16:04PM -0500, Jason Ekstrand wrote: > > > On Thu, Apr 29, 2021 at 10:51 AM Daniel Vetter wrote: > > > > > + ret = set_proto_ctx_param(file_pri

Re: [Intel-gfx] [PATCH 16/21] drm/i915/gem: Delay context creation

2021-04-29 Thread Jason Ekstrand
On Thu, Apr 29, 2021 at 1:56 PM Daniel Vetter wrote: > > On Thu, Apr 29, 2021 at 01:16:04PM -0500, Jason Ekstrand wrote: > > On Thu, Apr 29, 2021 at 10:51 AM Daniel Vetter wrote: > > > > + ret = set_proto_ctx_param(file_priv, pc, args); > > > > > > I think we should have a FIXME here of not a

Re: [Intel-gfx] [PATCH 16/21] drm/i915/gem: Delay context creation

2021-04-29 Thread Daniel Vetter
On Thu, Apr 29, 2021 at 01:16:04PM -0500, Jason Ekstrand wrote: > On Thu, Apr 29, 2021 at 10:51 AM Daniel Vetter wrote: > > > + ret = set_proto_ctx_param(file_priv, pc, args); > > > > I think we should have a FIXME here of not allowing this on some future > > platforms because just use CTX_CRE

Re: [Intel-gfx] [PATCH 16/21] drm/i915/gem: Delay context creation

2021-04-29 Thread Jason Ekstrand
On Thu, Apr 29, 2021 at 10:51 AM Daniel Vetter wrote: > > Yeah this needs some text to explain what/why you're doing this, and maybe > some rough sketch of the locking design. Yup. Will add. > > On Fri, Apr 23, 2021 at 05:31:26PM -0500, Jason Ekstrand wrote: > > Signed-off-by: Jason Ekstrand >

Re: [Intel-gfx] [PATCH 16/21] drm/i915/gem: Delay context creation

2021-04-29 Thread Daniel Vetter
Yeah this needs some text to explain what/why you're doing this, and maybe some rough sketch of the locking design. On Fri, Apr 23, 2021 at 05:31:26PM -0500, Jason Ekstrand wrote: > Signed-off-by: Jason Ekstrand > --- > drivers/gpu/drm/i915/gem/i915_gem_context.c | 657 -- > dr

Re: [Intel-gfx] [PATCH 16/21] drm/i915/gem: Delay context creation

2021-04-23 Thread kernel test robot
Hi Jason, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-tip/drm-tip drm-exynos/exynos-drm-next next-20210423] [cannot apply to tegra-drm/drm/tegra/for-next drm/drm-next v5.12-rc8] [If your patch is app

Re: [Intel-gfx] [PATCH 16/21] drm/i915/gem: Delay context creation

2021-04-23 Thread kernel test robot
Hi Jason, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-tip/drm-tip drm-exynos/exynos-drm-next next-20210423] [cannot apply to tegra-drm/drm/tegra/for-next drm/drm-next v5.12-rc8] [If your patch is applied to