[Intel-gfx] [PATCH 06/21] drm/i915: Unlock PCH_PP_CONTROL always

2011-10-01 Thread Daniel Vetter
On Fri, Sep 30, 2011 at 04:14:40PM -0700, Keith Packard wrote: > On Fri, 30 Sep 2011 19:09:46 +0200, Daniel Vetter wrote: > > > grep shows that we also write to PCH_PP_CONTROL in intel_lvds.c in the > > dpms functions - any reasons these two writes are left out? > > Upon a bit of review: > >

Re: [Intel-gfx] [PATCH 06/21] drm/i915: Unlock PCH_PP_CONTROL always

2011-10-01 Thread Daniel Vetter
On Fri, Sep 30, 2011 at 04:14:40PM -0700, Keith Packard wrote: > On Fri, 30 Sep 2011 19:09:46 +0200, Daniel Vetter wrote: > > > grep shows that we also write to PCH_PP_CONTROL in intel_lvds.c in the > > dpms functions - any reasons these two writes are left out? > > Upon a bit of review: > >

[Intel-gfx] [PATCH 06/21] drm/i915: Unlock PCH_PP_CONTROL always

2011-09-30 Thread Daniel Vetter
On Thu, Sep 29, 2011 at 06:09:38PM -0700, Keith Packard wrote: > Avoid any question about locked registers by just writing the unlock > pattern with every write to the register. > > Signed-off-by: Keith Packard grep shows that we also write to PCH_PP_CONTROL in intel_lvds.c in the dpms functions

Re: [Intel-gfx] [PATCH 06/21] drm/i915: Unlock PCH_PP_CONTROL always

2011-09-30 Thread Keith Packard
On Fri, 30 Sep 2011 19:09:46 +0200, Daniel Vetter wrote: > grep shows that we also write to PCH_PP_CONTROL in intel_lvds.c in the > dpms functions - any reasons these two writes are left out? Upon a bit of review: The bspec makes it clear that this write protect key only needs to be written

[Intel-gfx] [PATCH 06/21] drm/i915: Unlock PCH_PP_CONTROL always

2011-09-30 Thread Keith Packard
On Fri, 30 Sep 2011 19:09:46 +0200, Daniel Vetter wrote: > grep shows that we also write to PCH_PP_CONTROL in intel_lvds.c in the > dpms functions - any reasons these two writes are left out? Upon a bit of review: The bspec makes it clear that this write protect key only needs to be written

Re: [Intel-gfx] [PATCH 06/21] drm/i915: Unlock PCH_PP_CONTROL always

2011-09-30 Thread Keith Packard
On Fri, 30 Sep 2011 19:09:46 +0200, Daniel Vetter wrote: > grep shows that we also write to PCH_PP_CONTROL in intel_lvds.c in the > dpms functions - any reasons these two writes are left out? Nope, I just didn't look there. I'll fix that. Locking registers with magic patterns is just crazy these

[Intel-gfx] [PATCH 06/21] drm/i915: Unlock PCH_PP_CONTROL always

2011-09-30 Thread Keith Packard
On Fri, 30 Sep 2011 19:09:46 +0200, Daniel Vetter wrote: > grep shows that we also write to PCH_PP_CONTROL in intel_lvds.c in the > dpms functions - any reasons these two writes are left out? Nope, I just didn't look there. I'll fix that. Locking registers with magic patterns is just crazy these

Re: [Intel-gfx] [PATCH 06/21] drm/i915: Unlock PCH_PP_CONTROL always

2011-09-30 Thread Daniel Vetter
On Thu, Sep 29, 2011 at 06:09:38PM -0700, Keith Packard wrote: > Avoid any question about locked registers by just writing the unlock > pattern with every write to the register. > > Signed-off-by: Keith Packard grep shows that we also write to PCH_PP_CONTROL in intel_lvds.c in the dpms functions