Re: [Intel-gfx] [PATCH 05/27] drm/i915: Add GT PM unpark worker

2021-09-13 Thread Matthew Brost
On Mon, Sep 13, 2021 at 11:33:46AM +0100, Tvrtko Ursulin wrote: > > On 10/09/2021 21:09, Matthew Brost wrote: > > On Fri, Sep 10, 2021 at 09:36:17AM +0100, Tvrtko Ursulin wrote: > > > > > > On 20/08/2021 23:44, Matthew Brost wrote: > > > > Sometimes it is desirable to queue work up for later if t

Re: [Intel-gfx] [PATCH 05/27] drm/i915: Add GT PM unpark worker

2021-09-13 Thread Tvrtko Ursulin
On 10/09/2021 21:09, Matthew Brost wrote: On Fri, Sep 10, 2021 at 09:36:17AM +0100, Tvrtko Ursulin wrote: On 20/08/2021 23:44, Matthew Brost wrote: Sometimes it is desirable to queue work up for later if the GT PM isn't held and run that work on next GT PM unpark. Sounds maybe plausible, b

Re: [Intel-gfx] [PATCH 05/27] drm/i915: Add GT PM unpark worker

2021-09-10 Thread Matthew Brost
On Fri, Sep 10, 2021 at 09:36:17AM +0100, Tvrtko Ursulin wrote: > > On 20/08/2021 23:44, Matthew Brost wrote: > > Sometimes it is desirable to queue work up for later if the GT PM isn't > > held and run that work on next GT PM unpark. > > Sounds maybe plausible, but it depends how much work can h

Re: [Intel-gfx] [PATCH 05/27] drm/i915: Add GT PM unpark worker

2021-09-10 Thread Tvrtko Ursulin
On 20/08/2021 23:44, Matthew Brost wrote: Sometimes it is desirable to queue work up for later if the GT PM isn't held and run that work on next GT PM unpark. Sounds maybe plausible, but it depends how much work can happen on unpark and whether it can have too much of a negative impact on la

Re: [Intel-gfx] [PATCH 05/27] drm/i915: Add GT PM unpark worker

2021-09-09 Thread Matthew Brost
On Thu, Sep 09, 2021 at 03:36:44PM -0700, John Harrison wrote: > On 8/20/2021 15:44, Matthew Brost wrote: > > Sometimes it is desirable to queue work up for later if the GT PM isn't > > held and run that work on next GT PM unpark. > What is the reason for doing this? Why is it important? Why not ju

Re: [Intel-gfx] [PATCH 05/27] drm/i915: Add GT PM unpark worker

2021-09-09 Thread John Harrison
On 8/20/2021 15:44, Matthew Brost wrote: Sometimes it is desirable to queue work up for later if the GT PM isn't held and run that work on next GT PM unpark. What is the reason for doing this? Why is it important? Why not just take the GT PM at the time the work is requested? Implemented wit