Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Provide sysfs for efficient freq

2023-04-18 Thread Andi Shyti
Hi Vinay, On Mon, Apr 17, 2023 at 11:04:31PM -0700, Belgaumkar, Vinay wrote: > > On 4/17/2023 6:39 PM, Andi Shyti wrote: > > Hi Vinay, > > > > Looks good, just few minor comments below, > > > > [...] > > > > > @@ -267,13 +267,11 @@ static int run_test(struct intel_gt *gt, int > > > test_type)

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Provide sysfs for efficient freq

2023-04-17 Thread Belgaumkar, Vinay
On 4/17/2023 6:39 PM, Andi Shyti wrote: Hi Vinay, Looks good, just few minor comments below, [...] @@ -267,13 +267,11 @@ static int run_test(struct intel_gt *gt, int test_type) } /* -* Set min frequency to RPn so that we can test the whole -* range of RPn-RP0.

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Provide sysfs for efficient freq

2023-04-17 Thread Andi Shyti
Hi Vinay, Looks good, just few minor comments below, [...] > @@ -267,13 +267,11 @@ static int run_test(struct intel_gt *gt, int test_type) > } > > /* > - * Set min frequency to RPn so that we can test the whole > - * range of RPn-RP0. This also turns off efficient freq >