[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 GitLab Migration User changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 --- Comment #20 from Alex Deucher --- yes: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f732036f12d67a96f546c11236fa635b3eda6e9c -- You are receiving this mail because: You are the assignee for the bug. -- next part

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 --- Comment #20 from Alex Deucher --- yes: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f732036f12d67a96f546c11236fa635b3eda6e9c -- You are receiving this mail because: You are the assignee for the bug. _

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 --- Comment #19 from romulasry at gmail.com --- Is this patch upsteam in git? -- You are receiving this mail because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL:

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 --- Comment #19 from romula...@gmail.com --- Is this patch upsteam in git? -- You are receiving this mail because: You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedeskt

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 --- Comment #18 from Ian Romanick --- (In reply to comment #17) > (In reply to comment #16) > > Making the support general (instead of just for preprocessor directives) > > simplified the code greatly. Since I'm responsible for maintaining this

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 --- Comment #17 from Erik Faye-Lund --- (In reply to comment #16) > (In reply to comment #15) > > Thanks for the clarification, but I'm still not entirely convinced. > > > > I've just tested the latter. So apparently, Mesa is the only major > >

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 --- Comment #16 from Ian Romanick --- (In reply to comment #15) > Thanks for the clarification, but I'm still not entirely convinced. > > I agree that this per-spec for OpenGL ES 3.0 (although I'm a bit > disappointed that the ES3-group missed t

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 --- Comment #15 from Erik Faye-Lund --- Thanks for the clarification, but I'm still not entirely convinced. I agree that this per-spec for OpenGL ES 3.0 (although I'm a bit disappointed that the ES3-group missed that we in the ES2-group had made

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 --- Comment #14 from Ian Romanick --- (In reply to comment #12) > Well, Khronos meetings don't define the spec, the specification does. And > the specification is pretty clear here. The discussion was at the time of the vote, and I stand by that

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 --- Comment #13 from Ian Romanick --- Comment on attachment 78052 --> https://bugs.freedesktop.org/attachment.cgi?id=78052 [PATCH] gallium: handle drirc disable_glsl_line_continuations option You'll probably want review from someone that actua

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 --- Comment #12 from Erik Faye-Lund --- Well, Khronos meetings don't define the spec, the specification does. And the specification is pretty clear here. -- You are receiving this mail because: You are the assignee for the bug. -- n

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 --- Comment #11 from Ian Romanick --- (In reply to comment #9) > I don't know where you have the retroactive-story from, but the > specification does not mention it being retroactive, and even goes as far as > to say: I have the story from being

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 --- Comment #18 from Ian Romanick --- (In reply to comment #17) > (In reply to comment #16) > > Making the support general (instead of just for preprocessor directives) > > simplified the code greatly. Since I'm responsible for maintaining this

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 --- Comment #17 from Erik Faye-Lund --- (In reply to comment #16) > (In reply to comment #15) > > Thanks for the clarification, but I'm still not entirely convinced. > > > > I've just tested the latter. So apparently, Mesa is the only major > >

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 --- Comment #16 from Ian Romanick --- (In reply to comment #15) > Thanks for the clarification, but I'm still not entirely convinced. > > I agree that this per-spec for OpenGL ES 3.0 (although I'm a bit > disappointed that the ES3-group missed t

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 --- Comment #15 from Erik Faye-Lund --- Thanks for the clarification, but I'm still not entirely convinced. I agree that this per-spec for OpenGL ES 3.0 (although I'm a bit disappointed that the ES3-group missed that we in the ES2-group had made

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 --- Comment #14 from Ian Romanick --- (In reply to comment #12) > Well, Khronos meetings don't define the spec, the specification does. And > the specification is pretty clear here. The discussion was at the time of the vote, and I stand by that

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 --- Comment #13 from Ian Romanick --- Comment on attachment 78052 --> https://bugs.freedesktop.org/attachment.cgi?id=78052 [PATCH] gallium: handle drirc disable_glsl_line_continuations option You'll probably want review from someone that actua

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 --- Comment #12 from Erik Faye-Lund --- Well, Khronos meetings don't define the spec, the specification does. And the specification is pretty clear here. -- You are receiving this mail because: You are the assignee for the bug.

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 --- Comment #11 from Ian Romanick --- (In reply to comment #9) > I don't know where you have the retroactive-story from, but the > specification does not mention it being retroactive, and even goes as far as > to say: I have the story from being

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 --- Comment #10 from Erik Faye-Lund --- Another data-point: My AMD driver also does not support line continuation characters by default, although they do *after* a "#version 420" line. So in conclusion, I think blindly supporting line-continuati

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 --- Comment #10 from Erik Faye-Lund --- Another data-point: My AMD driver also does not support line continuation characters by default, although they do *after* a "#version 420" line. So in conclusion, I think blindly supporting line-continuati

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 --- Comment #9 from Erik Faye-Lund --- I don't know where you have the retroactive-story from, but the specification does not mention it being retroactive, and even goes as far as to say: "This document specifies only version 4.20 of the OpenGL

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 --- Comment #8 from Ian Romanick --- The problem is that you can have comments *before* the #version line. Because of that (and every other vendor has implemented line continuation in some form since forever), Khronos decided to make the change

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 --- Comment #9 from Erik Faye-Lund --- I don't know where you have the retroactive-story from, but the specification does not mention it being retroactive, and even goes as far as to say: "This document specifies only version 4.20 of the OpenGL

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 --- Comment #8 from Ian Romanick --- The problem is that you can have comments *before* the #version line. Because of that (and every other vendor has implemented line continuation in some form since forever), Khronos decided to make the change

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 --- Comment #7 from Erik Faye-Lund --- Is the shader really incorrect? I notice that it declares "#version 120" in the first line, and the GLSL 1.2 spec explicitly states that there is no line-continuation character (http://www.opengl.org/registr

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 --- Comment #6 from Vadim Girlin --- Created attachment 78052 --> https://bugs.freedesktop.org/attachment.cgi?id=78052&action=edit [PATCH] gallium: handle drirc disable_glsl_line_continuations option This patch will allow to use the workaround

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 --- Comment #5 from Matt Turner --- (In reply to comment #4) > Looks like some shaders related to sky rendering are not compiled > successfully. The problem is that there is a '\' (line-continuation) > character in the comment, followed by the li

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 --- Comment #4 from Vadim Girlin --- Looks like some shaders related to sky rendering are not compiled successfully. The problem is that there is a '\' (line-continuation) character in the comment, followed by the line that is not expected to be

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 --- Comment #3 from romulasry at gmail.com --- I believe the git before is incorrect, I did another: The merge base 2d2f1fd164218eacf2b142bc808be1f25f66e72c is bad. This means the bug has been fixed between 2d2f1fd164218eacf2b142bc808be1f25f66e72c

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 romulasry at gmail.com changed: What|Removed |Added Attachment #78046|text/plain |image/png mime type|

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 romulasry at gmail.com changed: What|Removed |Added CC||romulasry at gmail.com

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 --- Comment #2 from romulasry at gmail.com --- I did a git bisect for this and got: 02b808b08acc73b9b3d31832a7f137a9aae4bdd9 is the first bad commit commit 02b808b08acc73b9b3d31832a7f137a9aae4bdd9 Author: Francisco Jerez Date: Sun Apr 7 18:31:

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 --- Comment #1 from romulasry at gmail.com --- Created attachment 78047 --> https://bugs.freedesktop.org/attachment.cgi?id=78047&action=edit Top of screen *sky* renders white -- You are receiving this mail because: You are the assignee for the

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 --- Comment #7 from Erik Faye-Lund --- Is the shader really incorrect? I notice that it declares "#version 120" in the first line, and the GLSL 1.2 spec explicitly states that there is no line-continuation character (http://www.opengl.org/registr

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 --- Comment #6 from Vadim Girlin --- Created attachment 78052 --> https://bugs.freedesktop.org/attachment.cgi?id=78052&action=edit [PATCH] gallium: handle drirc disable_glsl_line_continuations option This patch will allow to use the workaround

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 --- Comment #5 from Matt Turner --- (In reply to comment #4) > Looks like some shaders related to sky rendering are not compiled > successfully. The problem is that there is a '\' (line-continuation) > character in the comment, followed by the li

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 --- Comment #4 from Vadim Girlin --- Looks like some shaders related to sky rendering are not compiled successfully. The problem is that there is a '\' (line-continuation) character in the comment, followed by the line that is not expected to be

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 --- Comment #3 from romula...@gmail.com --- I believe the git before is incorrect, I did another: The merge base 2d2f1fd164218eacf2b142bc808be1f25f66e72c is bad. This means the bug has been fixed between 2d2f1fd164218eacf2b142bc808be1f25f66e72c an

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 romula...@gmail.com changed: What|Removed |Added Attachment #78046|text/plain |image/png mime type|

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 romula...@gmail.com changed: What|Removed |Added CC||romula...@gmail.com

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 --- Comment #2 from romula...@gmail.com --- I did a git bisect for this and got: 02b808b08acc73b9b3d31832a7f137a9aae4bdd9 is the first bad commit commit 02b808b08acc73b9b3d31832a7f137a9aae4bdd9 Author: Francisco Jerez Date: Sun Apr 7 18:31:06

[Bug 63579] Savage 2 Edges render white [r600g]

https://bugs.freedesktop.org/show_bug.cgi?id=63579 --- Comment #1 from romula...@gmail.com --- Created attachment 78047 --> https://bugs.freedesktop.org/attachment.cgi?id=78047&action=edit Top of screen *sky* renders white -- You are receiving this mail because: You are the assignee for the bu