https://bugzilla.kernel.org/show_bug.cgi?id=29572
Alan changed:
What|Removed |Added
Status|NEW |RESOLVED
CC|
https://bugzilla.kernel.org/show_bug.cgi?id=29572
Alan changed:
What|Removed |Added
Status|NEW |RESOLVED
CC|
https://bugzilla.kernel.org/show_bug.cgi?id=29572
--- Comment #12 from Old?ich Jedli?ka 2011-02-25
06:17:11 ---
If you use the value 0?C as "OFF" while it is really a valid value, then you
pass the decision whether the card is off outside of the kernel to the software
reading the temperatur
https://bugzilla.kernel.org/show_bug.cgi?id=29572
--- Comment #12 from Oldřich Jedlička 2011-02-25
06:17:11 ---
If you use the value 0°C as "OFF" while it is really a valid value, then you
pass the decision whether the card is off outside of the kernel to the software
reading the temperatur
https://bugzilla.kernel.org/show_bug.cgi?id=29572
--- Comment #11 from Andrew Morton 2011-02-24
18:59:33 ---
(In reply to comment #10)
> is 0 really a reasonable value?
Well no, not really. I assume that a machine will work OK in -30C ambient, in
which case the chip might actually be runn
https://bugzilla.kernel.org/show_bug.cgi?id=29572
--- Comment #10 from Alex Deucher 2011-02-24
17:36:13 ---
(In reply to comment #8)
> I bet everyone's machine was previously reading zero. Now it's reading random
> crap.
It was always reading back random random crap, that's my point! The
https://bugzilla.kernel.org/show_bug.cgi?id=29572
--- Comment #11 from Andrew Morton 2011-02-24
18:59:33 ---
(In reply to comment #10)
> is 0 really a reasonable value?
Well no, not really. I assume that a machine will work OK in -30C ambient, in
which case the chip might actually be runn
https://bugzilla.kernel.org/show_bug.cgi?id=29572
Old?ich Jedli?ka changed:
What|Removed |Added
CC||oldium.pro at seznam.cz
--- Commen
https://bugzilla.kernel.org/show_bug.cgi?id=29572
--- Comment #10 from Alex Deucher 2011-02-24 17:36:13
---
(In reply to comment #8)
> I bet everyone's machine was previously reading zero. Now it's reading random
> crap.
It was always reading back random random crap, that's my point! The
https://bugzilla.kernel.org/show_bug.cgi?id=29572
--- Comment #8 from Andrew Morton 2011-02-24
08:14:46 ---
The interface changed. Why is this so hard to understand? Change it back!
It's two lines of code, I expect.
I bet everyone's machine was previously reading zero. Now it's reading
https://bugzilla.kernel.org/show_bug.cgi?id=29572
--- Comment #7 from Alex Deucher 2011-02-24
06:21:01 ---
None of the temperatures potentially returned are accurate when the device is
disabled.
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
--- You are rece
https://bugzilla.kernel.org/show_bug.cgi?id=29572
--- Comment #6 from Alex Deucher 2011-02-24
06:19:12 ---
The previous behavior was undefined; it just happened to be 0 for one user.
It's reading back a register from an MMIO aperture on a disabled PCI device.
It might read back as 50 for
https://bugzilla.kernel.org/show_bug.cgi?id=29572
--- Comment #5 from Andrew Morton 2011-02-24
05:14:11 ---
(In reply to comment #4)
> The old behavior was wrong.
Don't care really. We shouldn't change interfaces.
> The temperature value in the register was
> interpreted incorrectly prio
https://bugzilla.kernel.org/show_bug.cgi?id=29572
--- Comment #4 from Alex Deucher 2011-02-24
04:36:28 ---
The old behavior was wrong. The temperature value in the register was
interpreted incorrectly prior to my recent patch (improper handling of signed
values). Also, if the card is disa
https://bugzilla.kernel.org/show_bug.cgi?id=29572
Oldřich Jedlička changed:
What|Removed |Added
CC||oldium@seznam.cz
--- Comment #
https://bugzilla.kernel.org/show_bug.cgi?id=29572
--- Comment #8 from Andrew Morton 2011-02-24
08:14:46 ---
The interface changed. Why is this so hard to understand? Change it back!
It's two lines of code, I expect.
I bet everyone's machine was previously reading zero. Now it's reading
https://bugzilla.kernel.org/show_bug.cgi?id=29572
Andrew Morton changed:
What|Removed |Added
CC||akpm at linux-foundation.org
--- Comm
https://bugzilla.kernel.org/show_bug.cgi?id=29572
--- Comment #7 from Alex Deucher 2011-02-24 06:21:01
---
None of the temperatures potentially returned are accurate when the device is
disabled.
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
--- You are rece
https://bugzilla.kernel.org/show_bug.cgi?id=29572
--- Comment #6 from Alex Deucher 2011-02-24 06:19:12
---
The previous behavior was undefined; it just happened to be 0 for one user.
It's reading back a register from an MMIO aperture on a disabled PCI device.
It might read back as 50 for
https://bugzilla.kernel.org/show_bug.cgi?id=29572
--- Comment #5 from Andrew Morton 2011-02-24
05:14:11 ---
(In reply to comment #4)
> The old behavior was wrong.
Don't care really. We shouldn't change interfaces.
> The temperature value in the register was
> interpreted incorrectly prio
https://bugzilla.kernel.org/show_bug.cgi?id=29572
--- Comment #4 from Alex Deucher 2011-02-24 04:36:28
---
The old behavior was wrong. The temperature value in the register was
interpreted incorrectly prior to my recent patch (improper handling of signed
values). Also, if the card is disa
https://bugzilla.kernel.org/show_bug.cgi?id=29572
Andrew Morton changed:
What|Removed |Added
CC||a...@linux-foundation.org
--- Comment
https://bugzilla.kernel.org/show_bug.cgi?id=29572
--- Comment #2 from Marco Trevisan (Trevi?o) 2011-02-21
16:24:51 ---
Ok, both are wrong... But I'd prefer that 0? would be shown (also as a
confirmation that the card is OFF) instead of an invalid value...
--
Configure bugmail: https://bug
https://bugzilla.kernel.org/show_bug.cgi?id=29572
Alex Deucher changed:
What|Removed |Added
CC||alexdeucher at gmail.com
--- Comment #
https://bugzilla.kernel.org/show_bug.cgi?id=29572
--- Comment #2 from Marco Trevisan (Treviño) 2011-02-21
16:24:51 ---
Ok, both are wrong... But I'd prefer that 0° would be shown (also as a
confirmation that the card is OFF) instead of an invalid value...
--
Configure bugmail: https://bug
https://bugzilla.kernel.org/show_bug.cgi?id=29572
Alex Deucher changed:
What|Removed |Added
CC||alexdeuc...@gmail.com
--- Comment #1 f
26 matches
Mail list logo
