Re: [BUG] fbdev: i740fb: Divide error when ‘var->pixclock’ is zero

2022-04-07 Thread Helge Deller
On 4/6/22 03:24, Zheyu Ma wrote: > On Wed, Apr 6, 2022 at 2:23 AM Helge Deller wrote: >> >> On 4/5/22 19:46, Ondrej Zary wrote: >>> On Tuesday 05 April 2022 08:33:57 Helge Deller wrote: Hello Geert, On 4/4/22 13:46, Geert Uytterhoeven wrote: > Hi Helge, > > On Sun, Apr 3

Re: [BUG] fbdev: i740fb: Divide error when ‘var->pixclock’ is zero

2022-04-05 Thread Zheyu Ma
On Wed, Apr 6, 2022 at 2:23 AM Helge Deller wrote: > > On 4/5/22 19:46, Ondrej Zary wrote: > > On Tuesday 05 April 2022 08:33:57 Helge Deller wrote: > >> Hello Geert, > >> > >> On 4/4/22 13:46, Geert Uytterhoeven wrote: > >>> Hi Helge, > >>> > >>> On Sun, Apr 3, 2022 at 5:41 PM Helge Deller wrote

Re: [BUG] fbdev: i740fb: Divide error when ‘var->pixclock’ is zero

2022-04-05 Thread Helge Deller
On 4/5/22 19:46, Ondrej Zary wrote: > On Tuesday 05 April 2022 08:33:57 Helge Deller wrote: >> Hello Geert, >> >> On 4/4/22 13:46, Geert Uytterhoeven wrote: >>> Hi Helge, >>> >>> On Sun, Apr 3, 2022 at 5:41 PM Helge Deller wrote: On 4/3/22 13:26, Zheyu Ma wrote: > I found a bug in the fun

Re: [BUG] fbdev: i740fb: Divide error when ‘var->pixclock’ is zero

2022-04-05 Thread Ondrej Zary
On Tuesday 05 April 2022 08:33:57 Helge Deller wrote: > Hello Geert, > > On 4/4/22 13:46, Geert Uytterhoeven wrote: > > Hi Helge, > > > > On Sun, Apr 3, 2022 at 5:41 PM Helge Deller wrote: > >> On 4/3/22 13:26, Zheyu Ma wrote: > >>> I found a bug in the function i740fb_set_par(). > >> > >> Nic

Re: [BUG] fbdev: i740fb: Divide error when ‘var->pixclock’ is zero

2022-04-04 Thread Geert Uytterhoeven
Hi Helge, On Tue, Apr 5, 2022 at 8:34 AM Helge Deller wrote: > On 4/4/22 13:46, Geert Uytterhoeven wrote: > > On Sun, Apr 3, 2022 at 5:41 PM Helge Deller wrote: > >> On 4/3/22 13:26, Zheyu Ma wrote: > >>> I found a bug in the function i740fb_set_par(). > >> > >> Nice catch! > >> > >>> When the u

Re: [BUG] fbdev: i740fb: Divide error when ‘var->pixclock’ is zero

2022-04-04 Thread Helge Deller
Hello Geert, On 4/4/22 13:46, Geert Uytterhoeven wrote: > Hi Helge, > > On Sun, Apr 3, 2022 at 5:41 PM Helge Deller wrote: >> On 4/3/22 13:26, Zheyu Ma wrote: >>> I found a bug in the function i740fb_set_par(). >> >> Nice catch! >> >>> When the user calls the ioctl system call without setting the

Re: [BUG] fbdev: i740fb: Divide error when ‘var->pixclock’ is zero

2022-04-04 Thread Geert Uytterhoeven
Hi Helge, On Sun, Apr 3, 2022 at 5:41 PM Helge Deller wrote: > On 4/3/22 13:26, Zheyu Ma wrote: > > I found a bug in the function i740fb_set_par(). > > Nice catch! > > > When the user calls the ioctl system call without setting the value to > > 'var->pixclock', the driver will throw a divide erro

Re: [BUG] fbdev: i740fb: Divide error when ‘var->pixclock’ is zero

2022-04-03 Thread Zheyu Ma
On Sun, Apr 3, 2022, 23:02 Helge Deller wrote: > On 4/3/22 13:26, Zheyu Ma wrote: > > Hi, > > > > I found a bug in the function i740fb_set_par(). > > Nice catch! > > > When the user calls the ioctl system call without setting the value to > > 'var->pixclock', the driver will throw a divide error.

Re: [BUG] fbdev: i740fb: Divide error when ‘var->pixclock’ is zero

2022-04-03 Thread Helge Deller
On 4/3/22 13:26, Zheyu Ma wrote: > Hi, > > I found a bug in the function i740fb_set_par(). Nice catch! > When the user calls the ioctl system call without setting the value to > 'var->pixclock', the driver will throw a divide error. > > This bug occurs because the driver uses the value of 'var->p

[BUG] fbdev: i740fb: Divide error when ‘var->pixclock’ is zero

2022-04-03 Thread Zheyu Ma
Hi, I found a bug in the function i740fb_set_par(). When the user calls the ioctl system call without setting the value to 'var->pixclock', the driver will throw a divide error. This bug occurs because the driver uses the value of 'var->pixclock' without checking it, as the following code snippe