Re: [BUG] BUG: kernel NULL pointer dereference at ttm_device_init+0xb4

2024-01-23 Thread Steven Rostedt
On Tue, 23 Jan 2024 10:43:04 +0100 Christian König wrote: > While applying the fix a week ago I was under the impression that QXL > doesn't use a device structure because it doesn't have one and so can't > give anything meaningful for this parameter. > > If QXL does have a device structure and

Re: [BUG] BUG: kernel NULL pointer dereference at ttm_device_init+0xb4

2024-01-23 Thread Christian König
Am 23.01.24 um 03:52 schrieb Steven Rostedt: On Tue, 23 Jan 2024 12:32:39 +1000 Dave Airlie wrote: On Tue, 23 Jan 2024 at 12:21, Dave Airlie wrote: On Tue, 23 Jan 2024 at 12:15, Steven Rostedt wrote: On Mon, 22 Jan 2024 19:56:08 -0500 "Bhardwaj, Rajneesh" wrote: On 1/22/2024 7:43 PM,

Re: [BUG] BUG: kernel NULL pointer dereference at ttm_device_init+0xb4

2024-01-22 Thread Steven Rostedt
On Tue, 23 Jan 2024 12:32:39 +1000 Dave Airlie wrote: > On Tue, 23 Jan 2024 at 12:21, Dave Airlie wrote: > > > > On Tue, 23 Jan 2024 at 12:15, Steven Rostedt wrote: > > > > > > On Mon, 22 Jan 2024 19:56:08 -0500 > > > "Bhardwaj, Rajneesh" wrote: > > > > > > > > > > > On 1/22/2024 7:43 PM,

Re: [BUG] BUG: kernel NULL pointer dereference at ttm_device_init+0xb4

2024-01-22 Thread Dave Airlie
On Tue, 23 Jan 2024 at 12:21, Dave Airlie wrote: > > On Tue, 23 Jan 2024 at 12:15, Steven Rostedt wrote: > > > > On Mon, 22 Jan 2024 19:56:08 -0500 > > "Bhardwaj, Rajneesh" wrote: > > > > > > > > On 1/22/2024 7:43 PM, Linus Torvalds wrote: > > > > On Mon, 22 Jan 2024 at 15:17, Steven Rostedt >

Re: [BUG] BUG: kernel NULL pointer dereference at ttm_device_init+0xb4

2024-01-22 Thread Dave Airlie
On Tue, 23 Jan 2024 at 12:15, Steven Rostedt wrote: > > On Mon, 22 Jan 2024 19:56:08 -0500 > "Bhardwaj, Rajneesh" wrote: > > > > > On 1/22/2024 7:43 PM, Linus Torvalds wrote: > > > On Mon, 22 Jan 2024 at 15:17, Steven Rostedt wrote: > > >> Perhaps this is the real fix? > > > If you send a signed

Re: [BUG] BUG: kernel NULL pointer dereference at ttm_device_init+0xb4

2024-01-22 Thread Steven Rostedt
On Mon, 22 Jan 2024 19:56:08 -0500 "Bhardwaj, Rajneesh" wrote: > > On 1/22/2024 7:43 PM, Linus Torvalds wrote: > > On Mon, 22 Jan 2024 at 15:17, Steven Rostedt wrote: > >> Perhaps this is the real fix? > > If you send a signed-off version, I'll apply it asap. > > > I think a fix might already

Re: [BUG] BUG: kernel NULL pointer dereference at ttm_device_init+0xb4

2024-01-22 Thread Linus Torvalds
On Mon, 22 Jan 2024 at 16:56, Bhardwaj, Rajneesh wrote: > > I think a fix might already be in flight. Please see Linux-Kernel Archive: > Re: [PATCH] drm/ttm: fix ttm pool initialization for no-dma-device drivers > (iu.edu) Please use lore.kernel.org that doesn't corrupt whitespace in patches o

RE: [BUG] BUG: kernel NULL pointer dereference at ttm_device_init+0xb4

2024-01-22 Thread Bhardwaj, Rajneesh
[AMD Official Use Only - General] -Original Message- From: Steven Rostedt Sent: Monday, January 22, 2024 6:19 PM To: LKML Cc: Linus Torvalds ; Bhardwaj, Rajneesh ; Kuehling, Felix ; Koenig, Christian ; dri-devel@lists.freedesktop.org Subject: Re: [BUG] BUG: kernel NULL pointer

Re: [BUG] BUG: kernel NULL pointer dereference at ttm_device_init+0xb4

2024-01-22 Thread Bhardwaj, Rajneesh
On 1/22/2024 7:43 PM, Linus Torvalds wrote: On Mon, 22 Jan 2024 at 15:17, Steven Rostedt wrote: Perhaps this is the real fix? If you send a signed-off version, I'll apply it asap. I think a fix might already be in flight. Please see Linux-Kernel Archive: Re: [PATCH] drm/ttm: fix ttm pool

Re: [BUG] BUG: kernel NULL pointer dereference at ttm_device_init+0xb4

2024-01-22 Thread Linus Torvalds
On Mon, 22 Jan 2024 at 15:17, Steven Rostedt wrote: > > Perhaps this is the real fix? If you send a signed-off version, I'll apply it asap. Thanks, Linus

Re: [BUG] BUG: kernel NULL pointer dereference at ttm_device_init+0xb4

2024-01-22 Thread Bhardwaj, Rajneesh
On 1/22/2024 7:34 PM, Steven Rostedt wrote: On Mon, 22 Jan 2024 19:29:41 -0500 "Bhardwaj, Rajneesh" wrote: In one of my previous revisions of this patch when I was experimenting, I used something like below. Wonder if that could work in your case and/or in general. diff --git a/drivers/gpu

Re: [BUG] BUG: kernel NULL pointer dereference at ttm_device_init+0xb4

2024-01-22 Thread Steven Rostedt
On Mon, 22 Jan 2024 19:29:41 -0500 "Bhardwaj, Rajneesh" wrote: > > In one of my previous revisions of this patch when I was experimenting, > I used something like below. Wonder if that could work in your case > and/or in general. > > > diff --git a/drivers/gpu/drm/ttm/ttm_device.c > b/drive

Re: [BUG] BUG: kernel NULL pointer dereference at ttm_device_init+0xb4

2024-01-22 Thread Bhardwaj, Rajneesh
On 1/22/2024 6:06 PM, Steven Rostedt wrote: I just kicked off testing some patches on top of 6.8-rc1 and triggered this immediately: [ note this happened on both my 32 bit an 64 bit test machines, this is just the 32 bit output ] BUG: kernel NULL pointer dereference, address: 0238 #

Re: [BUG] BUG: kernel NULL pointer dereference at ttm_device_init+0xb4

2024-01-22 Thread Steven Rostedt
On Mon, 22 Jan 2024 18:15:47 -0500 Steven Rostedt wrote: > > ttm_pool_init(&bdev->pool, dev, dev_to_node(dev), use_dma_alloc, > > use_dma32); <<<--- BUG! > > > > Specifically, it appears that dev is NULL and dev_to_node() doesn't like > > having a NULL pointer passed to it. > > > >

Re: [BUG] BUG: kernel NULL pointer dereference at ttm_device_init+0xb4

2024-01-22 Thread Steven Rostedt
On Mon, 22 Jan 2024 18:06:05 -0500 Steven Rostedt wrote: > qxl_ttm_init+0x34/0x130 > > int ttm_device_init(struct ttm_device *bdev, const struct ttm_device_funcs > *funcs, > struct device *dev, struct address_space *mapping, > struct drm_vma_offset_manag

[BUG] BUG: kernel NULL pointer dereference at ttm_device_init+0xb4

2024-01-22 Thread Steven Rostedt
I just kicked off testing some patches on top of 6.8-rc1 and triggered this immediately: [ note this happened on both my 32 bit an 64 bit test machines, this is just the 32 bit output ] BUG: kernel NULL pointer dereference, address: 0238 #PF: supervisor read access in kernel mode #PF: er