[PATCH v2 13/14] drm/ast: Move widescreen and tx-chip detection into separate helpers

2023-06-21 Thread Thomas Zimmermann
Split ast_detect_chip() into three functions and call them one by one. The new functions detect the transmitter chip and widescreen support. This will allow for further refactoring. Signed-off-by: Thomas Zimmermann Reviewed-by: Sui Jingfeng Reviewed-by: Jocelyn Falempe Tested-by: Jocelyn Falemp

Re: [13/14] drm/ast: Move widescreen- and tx-chip detection into separate helpers

2023-06-18 Thread Sui Jingfeng
Hi, Split ast_detect_chip() into three functions made it more clear. As tx-chip is typicality  suffer from changed, and it is a choice of the PCB board designer. tx-chip belong to the output, which chip identify and wide screen support is a capability of the chip itself, once the chip is

Re: [13/14] drm/ast: Move widescreen- and tx-chip detection into separate helpers

2023-06-18 Thread Sui Jingfeng
Hi, "widescreen-" -> "widescreen" On 2023/6/16 21:52, Thomas Zimmermann wrote: Split ast_detect_chip() into three functions and call them one by one. The new functions detect the transmitter chip and widescreen support. This will allow for further refactoring. Signed-off-by: Thomas Zimmerman

[PATCH 13/14] drm/ast: Move widescreen- and tx-chip detection into separate helpers

2023-06-16 Thread Thomas Zimmermann
Split ast_detect_chip() into three functions and call them one by one. The new functions detect the transmitter chip and widescreen support. This will allow for further refactoring. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_main.c | 18 +++--- 1 file changed, 15 in