Re: [[PATCH v2]] drm/ast: fixed reading monitor EDID not stable issue

2018-11-22 Thread 陳雅正
Hi Dave, Thanks for your feedback. No issue found actually if I remove "volatile" on my platform. In my experience, if the value is volatile, adding "volatile" will be safer and no harm, that is why I add it by default. If you think it is not necessary, it's ok for me to remove it. Regards, Y.C.

Re: [[PATCH v2]] drm/ast: fixed reading monitor EDID not stable issue

2018-11-21 Thread Dave Airlie
On Thu, 22 Nov 2018 at 11:42, 陳雅正 wrote: > > Hi Dave, > Thanks for your feedback. No issue found actually if I remove "volatile" on > my platform. In my experience, if the value is volatile, adding "volatile" > will be safer and no harm, that is why I add it by default. If you think it > is not

Re: [[PATCH v2]] drm/ast: fixed reading monitor EDID not stable issue

2018-11-21 Thread Dave Airlie
On Wed, 31 Oct 2018 at 18:12, Y.C. Chen wrote: > > From: "Y.C. Chen" > > v1: over-sample data to increase the stability with some specific monitors > v2: refine to avoid infinite loop This contains at least 4 whitespace breakages (val =) in a few places, also why the volatiles, I don't think th

[[PATCH v2]] drm/ast: fixed reading monitor EDID not stable issue

2018-10-31 Thread Y.C. Chen
From: "Y.C. Chen" v1: over-sample data to increase the stability with some specific monitors v2: refine to avoid infinite loop Signed-off-by: Y.C. Chen --- drivers/gpu/drm/ast/ast_mode.c | 34 -- 1 file changed, 28 insertions(+), 6 deletions(-) diff --git a/dri