[PATCH] drm/amd/display: remove redundant null pointer check before kfree

2019-10-30 Thread zhong jiang
kfree has taken null pointer into account. hence it is safe to remove the unnecessary check. Signed-off-by: zhong jiang --- drivers/gpu/drm/amd/display/dc/hdcp/hdcp_msg.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/hdcp/hdcp_msg.c b

[PATCH v2] drm/vkms: Fix an undefined reference error in vkms_composer_worker

2019-09-22 Thread zhong jiang
I hit the following error when compile the kernel. drivers/gpu/drm/vkms/vkms_composer.o: In function `vkms_composer_worker': vkms_composer.c:(.text+0x5e4): undefined reference to `crc32_le' make: *** [vmlinux] Error 1 Signed-off-by: zhong jiang --- drivers/gpu/drm/Kconfig | 1 + 1 fi

Re: [PATCH] drm/vkms: Fix an undefined reference error in vkms_composer_worker

2019-09-22 Thread zhong jiang
please ignore the patch, author is incorrect, will repost. Thanks Sincerely, zhong jiang On 2019/9/23 9:21, zhong jiang wrote: > From: YueHaibing > > I hit the following error when compile the kernel. > > drivers/gpu/drm/vkms/vkms_composer.o: In function `vkms_

[PATCH] drm/vkms: Fix an undefined reference error in vkms_composer_worker

2019-09-22 Thread zhong jiang
From: YueHaibing I hit the following error when compile the kernel. drivers/gpu/drm/vkms/vkms_composer.o: In function `vkms_composer_worker': vkms_composer.c:(.text+0x5e4): undefined reference to `crc32_le' make: *** [vmlinux] Error 1 Signed-off-by: YueHaibing Signed-off-by: z

Re: drm/amdgpu: remove the redundant null check

2019-09-06 Thread zhong jiang
gt; Was the script “ifnullfree.cocci” applied here? Yep > Will it be helpful to add attribution for such tools > to any more descriptions in your patches? Sometimes, I will add the description in my patches. Not always. Thanks, zhong jiang > Regards, > Markus > > . >

Re: [PATCH] drm: amd: Use kmemdup instead of duplicating its function

2018-09-23 Thread zhong jiang
+cc amd-...@lists.freedesktop.org Thanks, zhong jiang On 2018/9/18 23:35, zhong jiang wrote: > kmemdup has implemented the function that kmalloc() + memcpy(). > We prefer to kmemdup rather than code opened implementation. > > Signed-off-by: zhong jiang > --- > drivers/

[PATCH] drm: amd: Use kmemdup instead of duplicating its function

2018-09-18 Thread zhong jiang
kmemdup has implemented the function that kmalloc() + memcpy(). We prefer to kmemdup rather than code opened implementation. Signed-off-by: zhong jiang --- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd

Re: [PATCH] gpu: do not double put device node in zx_drm_probe

2018-09-18 Thread zhong jiang
Hi, Greg Can you pick up the patch? Thanks, zhong jiang On 2018/8/17 10:24, zhong jiang wrote: > for_each_available_child_of_node will get and put the node properly, > the following of_node_put will lead to the double put. So just > remove it. > > Signed-off-by: zhong jiang &

Re: [PATCH] gpu: do not double put device node in zx_drm_probe

2018-09-18 Thread zhong jiang
On 2018/9/18 23:02, Greg KH wrote: > On Tue, Sep 18, 2018 at 10:59:08PM +0800, zhong jiang wrote: >> Hi, Greg >> >> Can you pick up the patch? > Nope: > $ ./scripts/get_maintainer.pl --file drivers/gpu/drm/zte/zx_drm_drv.c > Shawn Guo (maintainer:DRM DRIV

[PATCH] drm/omap: Use ERR_CAST directly instead of RR_PTR(PTR_ERR())

2018-09-12 Thread zhong jiang
We prefer to use ERR_CAST to do so. The issue is detected with the help of Coccinelle. Signed-off-by: zhong jiang --- drivers/gpu/drm/omapdrm/dss/dss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/omapdrm/dss/dss.c b/drivers/gpu/drm/omapdrm/dss/dss.c

Re: [PATCH] gpu: do not double put device node in zx_drm_probe

2018-09-07 Thread zhong jiang
+to maintainer. On 2018/8/17 10:24, zhong jiang wrote: > for_each_available_child_of_node will get and put the node properly, > the following of_node_put will lead to the double put. So just > remove it. > > Signed-off-by: zhong jiang gg > --- > drivers/gpu/drm/zte/zx_drm_drv

Re: [PATCH] drm/pl111: add in missing sentinel to a of_device_id array

2018-08-23 Thread zhong jiang
Hi, Colin I has posted the same patch about a month ago. but it seems to be ignored.:-( https://lore.kernel.org/patchwork/patch/971652/ Thanks, zhong jiang On 2018/8/21 18:54, Colin King wrote: > From: Colin Ian King > > Array vexpress_muxfpga_match is missing an end of array sentin

Re: [PATCH] gpu: do not double put device node in zx_drm_probe

2018-08-23 Thread zhong jiang
Ping, Anyone has any objections a about the patch? Best wishes, zhong jiang On 2018/8/17 10:24, zhong jiang wrote: > for_each_available_child_of_node will get and put the node properly, > the following of_node_put will lead to the double put. So just > remove it. > > Signed-off-

[PATCH] gpu: do not double put device node in zx_drm_probe

2018-08-17 Thread zhong jiang
for_each_available_child_of_node will get and put the node properly, the following of_node_put will lead to the double put. So just remove it. Signed-off-by: zhong jiang --- drivers/gpu/drm/zte/zx_drm_drv.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm

[PATCH] gpu:p1111: Make sure of_device_id tables are NULL terminated

2018-08-06 Thread zhong jiang
We prefer to of_device_id tables are NULL terminated. So make vexpress_muxfpga_match is NULL terminated. Signed-off-by: zhong jiang --- drivers/gpu/drm/pl111/pl111_vexpress.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/pl111/pl111_vexpress.c b/drivers

[PATCH linux-next] gnu: fix mismatch in function argument.

2018-07-25 Thread zhong jiang
Fix the sparse error. the dpu_rm_init declaration is not consistent with the implement. Signed-off-by: zhong jiang --- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h b/drivers/gpu/drm/msm/disp

[PATCH linux-next] gnu: fix mismatch in function argument.

2018-07-25 Thread zhong jiang
Fix the sparse error. the dpu_rm_init declaration is not consistent with the implement. Signed-off-by: zhong jiang --- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h b/drivers/gpu/drm/msm/disp