Re: [PATCH v1, 7/8] media: uapi: Init VP9 stateless decode params

Hi AngeloGioacchino, Thanks for your suggestion, Separate this patch with mt8195 support, and sent it again. On Thu, 2022-01-27 at 11:35 +0100, AngeloGioacchino Del Regno wrote: > Il 27/01/22 03:55, Yunfei Dong ha scritto: > > Init some of VP9 frame decode params to default value. > > > > Signed

Re: [PATCH v1, 7/8] media: uapi: Init VP9 stateless decode params

Hi Chen-Yu, Thanks for your suggestion. Send this patch again. On Thu, 2022-01-27 at 17:23 +0800, Chen-Yu Tsai wrote: > Hi, > > On Thu, Jan 27, 2022 at 10:56 AM Yunfei Dong < > yunfei.d...@mediatek.com> wrote: > > > > Init some of VP9 frame decode params to default

Re: [PATCH v2, 03/12] media: mtk-vcodec: get capture queue buffer size from scp

Hi Tzung-Bi, Thanks for your suggestion. On Wed, 2021-12-29 at 13:36 +0800, Tzung-Bi Shih wrote: > On Tue, Dec 28, 2021 at 05:41:37PM +0800, Yunfei Dong wrote: > > From: Yunfei Dong > > [...] > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c > > b/drivers/media/platform/mtk-vco

Re: [PATCH v1, 12/12] media: mtk-vcodec: Add h264 slice api driver for mt8192

Hi Nicolas, Thanks for your suggestion. On Wed, 2021-12-15 at 10:27 -0500, Nicolas Dufresne wrote: > Hi Yunfei, > > Le mercredi 15 décembre 2021 à 14:59 +0800, Yunfei Dong a écrit : > > From: Yunfei Dong > > > > Adds h264 lat and core driver for mt8192. > > This is purely a nit, but I have fir

Re: [PATCH v12, 13/19] media: mtk-vcodec: Add work queue for core hardware decode

Hi steve, Thanks for your suggestion. On Thu, 2021-12-09 at 15:44 -0800, Steve Cho wrote: > On Wed, Dec 1, 2021 at 7:46 PM Yunfei Dong > wrote: > > > > Add work queue to process core hardware information. > > First, get lat_buf from message queue, then call core > > hardware of each codec(H264/

Re: [PATCH v12, 06/19] media: mtk-vcodec: Add to support multi hardware decode

Hi Steve, Thanks for your suggestion, On Thu, 2021-12-09 at 15:29 -0800, Steve Cho wrote: > Few comments and questions. > > On Wed, Dec 1, 2021 at 7:46 PM Yunfei Dong > wrote: > > > > There are more than two hardwares for decoder: LAT0, LAT1 and CORE. > > In order to > > manage these hardwares,

Re: [PATCH v12, 15/19] dt-bindings: media: mtk-vcodec: Adds decoder dt-bindings for mt8192

Hi Rob, Thanks for your suggestion. On Fri, 2021-12-10 at 10:49 -0600, Rob Herring wrote: > On Thu, Dec 02, 2021 at 11:45:40AM +0800, Yunfei Dong wrote: > > Adds decoder dt-bindings for mt8192. > > > > Signed-off-by: Yunfei Dong > > --- > > .../media/mediatek,vcodec-subdev-decoder.yaml | 266 >

Re: [PATCH v11, 10/19] media: mtk-vcodec: Add msg queue feature for lat and core architecture

Hi AngeloGioacchino, Thanks for your suggestion. On Wed, 2021-12-01 at 13:09 +0100, AngeloGioacchino Del Regno wrote: > Il 29/11/21 04:41, Yunfei Dong ha scritto: > > For lat and core architecture, lat thread will send message to core > > thread when lat decode done. Core hardware will use the mes

Re: [PATCH v11, 04/19] media: mtk-vcodec: export decoder pm functions

Hi Benjamin, Thanks for your suggestion. On Tue, 2021-11-30 at 14:34 +0100, Benjamin Gaignard wrote: > Le 29/11/2021 à 04:41, Yunfei Dong a écrit : > > Register each hardware as platform device, need to call pm > > functions > > to open/close power and clock from module mtk-vcodec-dec, export > >

Re: [PATCH v11, 01/19] media: mtk-vcodec: Get numbers of register bases from DT

Hi Steve, Thanks for your suggestion.On Wed, 2021-12-01 at 15:36 -0800, Steve Cho wrote: > LGTM with few nits. > > Thanks,Steve > > On Sun, Nov 28, 2021 at 7:44 PM Yunfei Dong > wrote: > > Different platform may has different numbers of register bases. > > Gets the > > > > numbers of register

Re: [PATCH v11, 01/19] media: mtk-vcodec: Get numbers of register bases from DT

Hi Benjamin, Thanks for your suggestion. On Tue, 2021-11-30 at 14:20 +0100, Benjamin Gaignard wrote: > Le 29/11/2021 à 04:41, Yunfei Dong a écrit : > > Different platform may has different numbers of register bases. > > Gets the > > numbers of register bases from DT (sizeof(u32) * 4 bytes for each

Re: [PATCH v10, 00/19] Support multi hardware decode using of_platform_populate

Hi Ezequiel, On Tue, 2021-11-16 at 09:06 -0300, Ezequiel Garcia wrote: > Hi Yunfei, > > On Tue, 16 Nov 2021 at 08:42, yunfei.d...@mediatek.com > wrote: > > > > Hi Ezequiel, > > > > Thanks for you suggestion. > > On Sun, 2021-11-14 at 19:04 -03

Re: [PATCH v10, 15/19] dt-bindings: media: mtk-vcodec: Adds decoder dt-bindings for mt8192

Hi Ezequiel, Thanks for your suggestion. On Sun, 2021-11-14 at 18:56 -0300, Ezequiel Garcia wrote: > Yunfei, > > On Thu, 11 Nov 2021 at 01:15, Yunfei Dong > wrote: > > > > Adds decoder dt-bindings for mt8192. > > > > Signed-off-by: Yunfei Dong > > --- > > .../media/mediatek,vcodec-subdev-dec

Re: [PATCH v10, 00/19] Support multi hardware decode using of_platform_populate

Hi Ezequiel, Thanks for you suggestion. On Sun, 2021-11-14 at 19:04 -0300, Ezequiel Garcia wrote: > Hi Yunfei, > > On Thu, 11 Nov 2021 at 01:15, Yunfei Dong > wrote: > > > > This series adds support for multi hardware decode into mtk-vcodec, > > by first adding use > > of_platform_populate to

Re: [PATCH v9, 06/19] media: mtk-vcodec: Manage multi hardware information

Hi Tzung-Bi, Thanks for your suggestion. On Wed, 2021-11-10 at 18:30 +0800, Tzung-Bi Shih wrote: > On Tue, Nov 09, 2021 at 08:50:17PM +0800, Yunfei Dong wrote: > > Manage each hardware information which includes irq/power/clk. > > The hardware includes LAT0, LAT1 and CORE. > > The commit message

Re: [PATCH v8, 03/17] media: mtk-vcodec: Refactor vcodec pm interface

Hi dafna, Thanks for your suggestion. On Fri, 2021-10-29 at 13:35 +0200, Dafna Hirschfeld wrote: > > On 29.10.21 05:55, Yunfei Dong wrote: > > Using the needed param for pm init/release function and remove > > unused > > param mtkdev in 'struct mtk_vcodec_pm'. > > > > Reviewed-by: Tzung-Bi Shih

Re: [PATCH v8, 04/17] media: mtk-vcodec: Build decoder pm file as module

Hi dafna, Thanks for your suggestion. On Fri, 2021-10-29 at 13:42 +0200, Dafna Hirschfeld wrote: > > On 29.10.21 05:55, Yunfei Dong wrote: > > Need to build decoder pm file as module for master and comp > > use the same pm interface. > > Do you still use the component framework in this patchset?

Re: [PATCH v8, 07/17] dt-bindings: media: mtk-vcodec: Separate video encoder and decoder dt-bindings

Hi Dafna, Thanks for your suggestion, On Fri, 2021-10-29 at 13:49 +0200, Dafna Hirschfeld wrote: > > On 29.10.21 05:55, Yunfei Dong wrote: > > Decoder will use component framework to manage hardware, it is big > > difference with encoder. > > > > Reviewed-by: Rob Herring > > Signed-off-by: Yunfe

Re: [PATCH v1] media: mtk-vcodec: Align width and height to 64

Hi steve, Thanks for your suggestion.On Tue, 2021-11-02 at 09:43 -0700, Steve Cho wrote: > Thank you Yunfei for following up with this change. > This change is the last missing piece to enable VD on Kukui with > Chromium. > This patch fixed the corruption we were seeing on Kukui with certain > te

Re: [PATCH v8, 03/17] media: mtk-vcodec: Refactor vcodec pm interface

Hi Dafna, Thanks for your suggestion. On Fri, 2021-10-29 at 13:35 +0200, Dafna Hirschfeld wrote: > > On 29.10.21 05:55, Yunfei Dong wrote: > > Using the needed param for pm init/release function and remove > > unused > > param mtkdev in 'struct mtk_vcodec_pm'. > > > > Reviewed-by: Tzung-Bi Shih

Re: [PATCH v8, 04/17] media: mtk-vcodec: Build decoder pm file as module

Hi Danfa, Thanks for your feedback. On Fri, 2021-10-29 at 13:42 +0200, Dafna Hirschfeld wrote: > > On 29.10.21 05:55, Yunfei Dong wrote: > > Need to build decoder pm file as module for master and comp > > use the same pm interface. > > Do you still use the component framework in this patchset? >

Re: [PATCH v8, 07/17] dt-bindings: media: mtk-vcodec: Separate video encoder and decoder dt-bindings

Hi Dafna, Thanks for your suggestion. On Fri, 2021-10-29 at 13:49 +0200, Dafna Hirschfeld wrote: > > On 29.10.21 05:55, Yunfei Dong wrote: > > Decoder will use component framework to manage hardware, it is big > > difference with encoder. > > > > Reviewed-by: Rob Herring > > Signed-off-by: Yunfe

Re: [PATCH v7, 03/15] media: mtk-vcodec: Refactor vcodec pm interface

Hi Dafna, Thanks for your suggestion. On Thu, 2021-10-14 at 15:44 +0200, Dafna Hirschfeld wrote: > > On 11.10.21 09:02, Yunfei Dong wrote: > > Using the needed param for pm init/release function and remove > > unused > > param mtkdev in 'struct mtk_vcodec_pm'. > > > > I see that there is a lot

Re: [PATCH v7, 11/15] media: mtk-vcodec: Add core thread

Hi Ezequiel, 1. Thanks for your suggestion. On Thu, 2021-10-14 at 09:29 -0300, Ezequiel Garcia wrote: > Hi Yunfei, > > On Mon, Oct 11, 2021 at 03:02:43PM +0800, Yunfei Dong wrote: > > Core thread: > > 1. Gets lat_buf from core msg queue. > > 2. Proceeds core decode. > > 3. Puts the lat_buf bac

Re: [PATCH v6, 00/15] Using component framework to support multi hardware decode

Hi Ezequiel, Thanks for your suggestion. On Thu, 2021-10-14 at 09:38 -0300, Ezequiel Garcia wrote: > Hi Yunfei, > > On Tue, 12 Oct 2021 at 22:17, yunfei.d...@mediatek.com > wrote: > > Hi Ezequiel, > > > > Thanks for your feedback, > > > > The driver

Re: [PATCH v7, 04/15] media: mtk-vcodec: Manage multi hardware information

Hi AngeloGioacchino, Thanks for your suggestion. On Thu, 2021-10-14 at 11:20 +0200, AngeloGioacchino Del Regno wrote: > > Manage each hardware information which includes irq/power/clk. > > The hardware includes LAT0, LAT1 and CORE. > > > > Signed-off-by: Yunfei Dong > > --- > > v7: Using of_pla

Re: [PATCH v7, 07/15] media: mtk-vcodec: Add irq interface for multi hardware

Hi AngeloGioacchino, Thanks for your suggestion. On Thu, 2021-10-14 at 12:04 +0200, AngeloGioacchino Del Regno wrote: > > Adds irq interface for multi hardware. > > > > Signed-off-by: Yunfei Dong > > --- > > .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 33 > > +-- > > .../

Re: [PATCH v7, 08/15] media: mtk-vcodec: Add msg queue feature for lat and core architecture

Hi AngeloGioacchino, Thanks for your suggestion. On Thu, 2021-10-14 at 12:35 +0200, AngeloGioacchino Del Regno wrote: > > For lat and core architecture, lat thread will send message to core > > thread when lat decode done. Core hardware will use the message > > from lat to decode, then free messa

Re: [PATCH v7, 09/15] media: mtk-vcodec: Generalize power and clock on/off interfaces

Hi AngeloGioacchino, Thanks for your suggestion. On Thu, 2021-10-14 at 12:44 +0200, AngeloGioacchino Del Regno wrote: > > Generalizes power and clock on/off interfaces to support different > > hardware. > > > > Signed-off-by: Yunfei Dong > > --- > > .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c

Re: [PATCH v7, 11/15] media: mtk-vcodec: Add core thread

Hi AngeloGioacchino, Thanks for your suggestion. On Thu, 2021-10-14 at 12:56 +0200, AngeloGioacchino Del Regno wrote: > > Core thread: > > 1. Gets lat_buf from core msg queue. > > 2. Proceeds core decode. > > 3. Puts the lat_buf back to lat msg queue. > > > > Both H264 and VP9 rely on the core th

Re: [PATCH v7, 12/15] media: mtk-vcodec: Support 34bits dma address for vdec

Hi AngeloGioacchino, Thanks for your suggestion. On Thu, 2021-10-14 at 13:02 +0200, AngeloGioacchino Del Regno wrote: > > Use the dma_set_mask_and_coherent helper to set vdec > > DMA bit mask to support 34bits iova space(16GB) that > > the mt8192 iommu HW support. > > > > Whole the iova range sep

Re: [PATCH v6, 00/15] Using component framework to support multi hardware decode

platform device. Could you please help to review the patch again when you are free: https://patchwork.linuxtv.org/project/linux-media/cover/20211011070247.792-1-yunfei.d...@mediatek.com/ Best Regards, Yunfei Dong On Sun, 2021-09-26 at 11:51 -0300, Ezequiel Garcia wrote: > On Sun, 26 Sept 2021 at

Re: [PATCH v7, 00/15] Support multi hardware decode using of_platform_populate

interface. > > > > Patch 4 add to support multi hardware. > > > > Patch 5 separate video encoder and decoder document > > > > Patches 6-15 add interfaces to support core hardware. > > Which tree does the series apply to? I don't understand

Re: [PATCH v6, 12/15] media: mtk-vcodec: Support 34bits dma address for vdec

Hi Benjiamin, On Thu, 2021-10-07 at 13:37 +0200, Benjamin Gaignard wrote: > Le 01/09/2021 à 10:32, Yunfei Dong a écrit : > > Use the dma_set_mask_and_coherent helper to set vdec > > DMA bit mask to support 34bits iova space(16GB) that > > the mt8192 iommu HW support. > > > > Whole the iova range

Re: [PATCH v6, 00/15] Using component framework to support multi hardware decode

, 2021-09-14 at 20:16 +0800, yunfei.d...@mediatek.com wrote: > Hi Ezequiel, > > On Fri, 2021-09-03 at 11:08 +0800, yunfei.d...@mediatek.com wrote: > > Hi Ezequiel, > > > > Thanks for your suggestion. > > On Thu, 2021-09-02 at 13:30 -0300, Ezequiel Garcia wrote:

Re: [PATCH v6, 00/15] Using component framework to support multi hardware decode

Hi Ezequiel, On Fri, 2021-09-03 at 11:08 +0800, yunfei.d...@mediatek.com wrote: > Hi Ezequiel, > > Thanks for your suggestion. > On Thu, 2021-09-02 at 13:30 -0300, Ezequiel Garcia wrote: > > On Wed, 1 Sept 2021 at 05:32, Yunfei Dong > > > > wrote: > > > &

Re: [PATCH v6, 15/15] media: mtk-vcodec: Use codec type to separate different hardware

Hi Danfa, Thanks for your suggestion. On Fri, 2021-09-03 at 14:42 +0200, Dafna Hirschfeld wrote: > > On 02.09.21 08:05, yunfei.d...@mediatek.com wrote: > > On Wed, 2021-09-01 at 14:17 +0200, Dafna Hirschfeld wrote: > > Hi Dafna, > > > > Thanks for your sugges

Re: [PATCH v6, 00/15] Using component framework to support multi hardware decode

Hi Ezequiel, Thanks for your suggestion. On Thu, 2021-09-02 at 13:30 -0300, Ezequiel Garcia wrote: > On Wed, 1 Sept 2021 at 05:32, Yunfei Dong > wrote: > > > > This series adds support for multi hardware decode into mtk-vcodec, > > by first > > adding component framework to manage each hardware

Re: [PATCH v6, 15/15] media: mtk-vcodec: Use codec type to separate different hardware

On Wed, 2021-09-01 at 14:17 +0200, Dafna Hirschfeld wrote: Hi Dafna, Thanks for your suggestion. > Hi > > On 01.09.21 10:32, Yunfei Dong wrote: > > There are just one core thread, in order to separeate different > > hardware, using codec type to separeate it in scp driver. > > this code seems to

Re: [PATCH v5, 00/15] Using component framework to support multi hardware decode

Hi Ezequiel, You can get the dtsi information from patch 13, it is decoder yaml file about component architecture: [PATCH v4, 13/15] dt-bindings: media: mtk-vcodec: Adds decoder dt- bindings for mt8192 Thanks Yunfei Dong On Tue, 2021-08-24 at 18:21 +0800, yunfei.d...@mediatek.com wrote: >

Re: [PATCH v5, 00/15] Using component framework to support multi hardware decode

Hi Ezequiel, Thanks for your suggestion. On Sun, 2021-08-22 at 11:32 -0300, Ezequiel Garcia wrote: > On Fri, 20 Aug 2021 at 04:59, yunfei.d...@mediatek.com > wrote: > > > > Hi Ezequiel, > > > > Thanks for your detail feedback. > > > > On Thu, 2021-0

Re: [PATCH v5, 00/15] Using component framework to support multi hardware decode

Hi Ezequiel, Thanks for your detail feedback. On Thu, 2021-08-19 at 11:10 -0300, Ezequiel Garcia wrote: > On Thu, 19 Aug 2021 at 04:13, yunfei.d...@mediatek.com > wrote: > > > > Hi Ezequiel, > > > > Thanks for your suggestion. > > > > On Wed, 2021-0

Re: [PATCH v5, 00/15] Using component framework to support multi hardware decode

Hi Ezequiel, Thanks for your suggestion. On Wed, 2021-08-18 at 11:11 -0300, Ezequiel Garcia wrote: > +danvet > > Hi, > > On Tue, 10 Aug 2021 at 23:58, Yunfei Dong > wrote: > > > > This series adds support for multi hardware decode into mtk-vcodec, > > by first > > adding component framework