Dear Shuah:
> > @@ -357,7 +357,7 @@ static int test_alloc_errors(char *heap_name)
> > if (heap_fd >= 0)
> > close(heap_fd);
> >
> > - return ret;
> > + return !ret;
>
> This change doesn't make sense. Initializing ret to 0 is a better
> way to go.
>
I don't agree with
>
> On 3/3/20 10:34 PM, Leon He wrote:
> > If the 'name' array in check_vgem() was not initialized to null, the
> > value of name[4] may be random. Which will cause strcmp(name, "vgem")
> > failed.
>
> Nit: "to fail" instead of "failed"
OK, thanks!
>
>
> >
> > Signed-off-by: Leon He
> > ---
> >
