Re: [PATCH] drm: assure aux_dev is nonzero before using it

2019-09-23 Thread Tony Camuso
On 7/12/19 1:06 PM, Ville Syrjälä wrote: On Fri, Jul 12, 2019 at 12:07:46PM -0400, Tony Camuso wrote: On 7/10/19 9:56 AM, Ville Syrjälä wrote: On Wed, Jul 10, 2019 at 09:47:11AM -0400, Tony Camuso wrote: On 5/24/19 4:36 AM, Jani Nikula wrote: On Thu, 23 May 2019, tcamuso wrote: From

Re: [PATCH] drm: assure aux_dev is nonzero before using it

2019-07-12 Thread Tony Camuso
On 7/12/19 1:06 PM, Ville Syrjälä wrote: On Fri, Jul 12, 2019 at 12:07:46PM -0400, Tony Camuso wrote: On 7/10/19 9:56 AM, Ville Syrjälä wrote: On Wed, Jul 10, 2019 at 09:47:11AM -0400, Tony Camuso wrote: On 5/24/19 4:36 AM, Jani Nikula wrote: On Thu, 23 May 2019, tcamuso wrote: From

Re: [PATCH] drm: assure aux_dev is nonzero before using it

2019-07-12 Thread Tony Camuso
On 7/10/19 9:56 AM, Ville Syrjälä wrote: On Wed, Jul 10, 2019 at 09:47:11AM -0400, Tony Camuso wrote: On 5/24/19 4:36 AM, Jani Nikula wrote: On Thu, 23 May 2019, tcamuso wrote: From Daniel Kwon The system was crashed due to invalid memory access while trying to access auxiliary device

Re: [PATCH] drm: assure aux_dev is nonzero before using it

2019-07-10 Thread Tony Camuso
aux_dev = NULL; 64 mutex_unlock(&aux_idr_mutex); 65 66 return aux_dev; 67 } To avoid this kinds of situation, we should make a safeguard for the returned value. Changing the line 62 with the below would do. 62 if (aux_dev && !kref

Re: [PATCH] drm: assure aux_dev is nonzero before using it

2019-05-24 Thread tony camuso
On 5/24/19 4:36 AM, Jani Nikula wrote: On Thu, 23 May 2019, tcamuso wrote: From Daniel Kwon The system was crashed due to invalid memory access while trying to access auxiliary device. crash> bt PID: 9863 TASK: 89d1bdf11040 CPU: 1 COMMAND: "ipmitool" #0 [89cedd7f3868] machine