Use string choice helpers for better readability.
Reported-by: kernel test robot
Reported-by: Julia Lawall
Closes: https://lore.kernel.org/r/202503222049.suxl3q6w-...@intel.com/
Signed-off-by: R Sundar
---
Reported in linux repository.
cocci warnings: (new ones prefixed by >>)
>>
Corrected a spelling mistake in the exynos_drm_fimd driver to improve code
readability. No functional changes were made.
Signed-off-by: Anindya Sundar Gayen
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos
On 29/10/24 19:11, Alex Deucher wrote:
On Sun, Oct 27, 2024 at 10:18 AM R Sundar wrote:
Use string choice helpers for better readability.
I personally find this less readable, but if this is the preferred
method going forward, I'm fine to take the patch.
Alex
Hi,
Thanks fo
Use string choice helpers for better readability.
Reported-by: kernel test robot
Reported-by: Julia Lawall
Closes: https://lore.kernel.org/r/202410161814.i6p2nnux-...@intel.com/
Signed-off-by: R Sundar
---
reported in linux repository.
tree: https://git.kernel.org/pub/scm/linux/kernel/git
Use str_on_off string helpers for better readability and to fix cocci
warning.
Reported-by: kernel test robot
Reported-by: Julia Lawall
Closes: https://lore.kernel.org/r/202410071252.cwiljzrh-...@intel.com/
Signed-off-by: R Sundar
---
Reported in linux repo:
tree: https://git.kernel.org/pub
Use str_enabled_disabled string helpers for better readability and to
fix cocci warning.
Reported-by: kernel test robot
Reported-by: Julia Lawall
Closes: https://lore.kernel.org/r/202410071601.tfpxoqgw-...@intel.com/
Signed-off-by: R Sundar
---
Reported in linux repo:
tree: https
Added colon in kernel-doc comment to fix the warning.
./include/drm/drm_drv.h:372: warning: Incorrect use of kernel-doc format:
* @fbdev_probe
./include/drm/drm_drv.h:435: warning: Function parameter or struct member
'fbdev_probe' not described in 'drm_driver'
Sig
On 27/04/24 10:20, R Sundar wrote:
use the new cleanup magic to replace of_node_put() with
__free(device_node) marking to auto release when they get out of scope.
Suggested-by: Julia Lawall
Signed-off-by: R Sundar
---
drivers/gpu/ipu-v3/ipu-pre.c | 7 ++-
1 file changed, 2 insertions
Use the new cleanup magic to replace of_node_put() with
__free(device_node) marking to auto release when they get out of scope.
Suggested-by: Julia Lawall
Signed-off-by: R Sundar
---
drivers/video/backlight/sky81452-backlight.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions
use the new cleanup magic to replace of_node_put() with
__free(device_node) marking to auto release when they get out of scope.
Suggested-by: Julia Lawall
Signed-off-by: R Sundar
---
drivers/gpu/ipu-v3/ipu-pre.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers
#x27;size_hints_propertty' description in 'drm_mode_config'
Signed-off-by: sundar
---
include/drm/drm_mode_config.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm/drm_mode_config.h b/include/drm/drm_mode_config.h
index 06da881f..8de3c9a5f61b 100644
-
ber
'operation_mode' description in 'drm_dp_as_sdp'
Signed-off-by: R SUNDAR
---
include/drm/display/drm_dp_helper.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm/display/drm_dp_helper.h
b/include/drm/display/drm_dp_helper.h
index baf9949ff96
For linux-next repo
./include/drm/display/drm_dp_mst_helper.h:156: warning: Excess struct member
'vcpi' description in 'drm_dp_mst_port'
Signed-off-by: R SUNDAR
---
include/drm/display/drm_dp_mst_helper.h | 1 -
1 file changed, 1 deletion(-)
diff --git a
nd_cfg'
Signed-off-by: R SUNDAR
---
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h
b/drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h
index ba9b942ce09f..34a398f23fc6 100644
--- a
./include/drm/drm_gem_vram_helper.h:185: warning: Excess struct member 'funcs'
description in 'drm_vram_mm'
Signed-off-by: R SUNDAR
---
include/drm/drm_gem_vram_helper.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/drm/drm_gem_vram_helper.h
b/include/drm/d
Hi Hans,
Apologies for the long delay.
On 10/19/2023 12:38 AM, Hans de Goede wrote:
> Hi,
>
> I was not following this at first, so my apologies for
> jumping in in the middle of the thread:
>
>
>
>
>> +static int amd_pmf_gpu_get_cur_state(struct thermal_cooling_device
>> *cooling_d
On 10/19/2023 2:31 PM, Christian König wrote:
> Am 18.10.23 um 19:05 schrieb Shyam Sundar S K:
>>
>> On 10/18/2023 9:37 PM, Christian König wrote:
>>> Am 18.10.23 um 17:47 schrieb Mario Limonciello:
>>>> On 10/18/2023 08:40, Christian König wrote:
>>&g
Hi Ilpo,
Apologies for the long delay.
On 10/18/2023 2:30 PM, Ilpo Järvinen wrote:
> On Wed, 18 Oct 2023, Shyam Sundar S K wrote:
>
>> PMF driver sends constant inputs to TA which its gets via the other
>> subsystems in the kernel. To debug certain TA issues knowing what input
On 10/18/2023 9:37 PM, Christian König wrote:
> Am 18.10.23 um 17:47 schrieb Mario Limonciello:
>> On 10/18/2023 08:40, Christian König wrote:
>>>
>>>
>>> Am 18.10.23 um 11:28 schrieb Shyam Sundar S K:
>>>>
>>>> On 10/18/2023 2:50 PM,
On 10/18/2023 2:50 PM, Ilpo Järvinen wrote:
> On Wed, 18 Oct 2023, Shyam Sundar S K wrote:
>
>> In order to provide GPU inputs to TA for the Smart PC solution to work, we
>> need to have interface between the PMF driver and the AMDGPU driver.
>>
>> Add the initi
From: Basavaraj Natikar
AMDSFH has information about the Ambient light via the Ambient
Light Sensor (ALS) which is part of the AMD sensor fusion hub.
Add PMF and AMDSFH interface to get this information.
Reviewed-by: Mario Limonciello
Co-developed-by: Shyam Sundar S K
Signed-off-by: Shyam
From: Basavaraj Natikar
AMDSFH has information about the User presence information via the Human
Presence Detection (HPD) sensor which is part of the AMD sensor fusion hub.
Add PMF and AMDSFH interface to get this information.
Co-developed-by: Shyam Sundar S K
Signed-off-by: Shyam Sundar S K
on will be called by multiple callers in the
next patch.
Co-developed-by: Shyam Sundar S K
Signed-off-by: Shyam Sundar S K
Signed-off-by: Basavaraj Natikar
---
drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_desc.c | 22 +--
.../amd-sfh-hid/sfh1_1/amd_sfh_interface.h| 1 +
2 files c
Limonciello
Signed-off-by: Mario Limonciello
Signed-off-by: Shyam Sundar S K
---
drivers/gpu/drm/amd/amdgpu/amdgpu_pmf.c | 18 ++
drivers/platform/x86/amd/pmf/pmf.h | 2 ++
drivers/platform/x86/amd/pmf/tee-if.c | 21 +++--
3 files changed, 39 insertions
Sundar S K
---
drivers/gpu/drm/amd/amdgpu/Makefile | 2 +
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 +
drivers/gpu/drm/amd/amdgpu/amdgpu_pmf.c | 138
drivers/platform/x86/amd/pmf/Kconfig| 1 +
drivers/platform/x86/amd/pmf/core.c | 1 +
drivers/platform
Limonciello
Signed-off-by: Shyam Sundar S K
---
drivers/platform/x86/amd/pmf/tee-if.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/platform/x86/amd/pmf/tee-if.c
b/drivers/platform/x86/amd/pmf/tee-if.c
index 6c4ce22ba518..2f5fb8623c20 100644
--- a/drivers/platform/x86/amd
: Mario Limonciello
Signed-off-by: Shyam Sundar S K
---
drivers/platform/x86/amd/pmf/pmf.h| 1 +
drivers/platform/x86/amd/pmf/tee-if.c | 67 +++
2 files changed, 68 insertions(+)
diff --git a/drivers/platform/x86/amd/pmf/pmf.h
b/drivers/platform/x86/amd/pmf/pmf.h
index
-static function as this helper is
required outside of sps.c file.
Reviewed-by: Mario Limonciello
Signed-off-by: Shyam Sundar S K
---
drivers/platform/x86/amd/pmf/pmf.h| 3 +++
drivers/platform/x86/amd/pmf/spc.c| 37 +++
drivers/platform/x86/amd/pmf/tee-if.c | 1 +
3
Add amd_pmf prefix to source_as_str() function, so that the function name
does not look generic. As this is a helper function make it as non-static
so that it can be reused across multiple PMF features.
Signed-off-by: Shyam Sundar S K
---
drivers/platform/x86/amd/pmf/pmf.h | 1 +
drivers
rules under Documentation/admin-guide/pmf.rst.
Reviewed-by: Mario Limonciello
Signed-off-by: Shyam Sundar S K
---
Documentation/admin-guide/index.rst | 1 +
Documentation/admin-guide/pmf.rst | 24 +++
drivers/platform/x86/amd/pmf/pmf.h| 9 +++
drivers/platform/x86
P3T (Peak Package Power Limit) is a metric within the SMU controller
that can influence the power limits. Add support from the driver
to update P3T limits accordingly.
Reviewed-by: Mario Limonciello
Signed-off-by: Shyam Sundar S K
---
drivers/platform/x86/amd/pmf/pmf.h| 3 +++
drivers
PMF driver sends changing inputs from each subystem to TA for evaluating
the conditions in the policy binary.
Add initial support of plumbing in the PMF driver for Smart PC to get
information from other subsystems in the kernel.
Signed-off-by: Shyam Sundar S K
---
drivers/platform/x86/amd/pmf
es() so that when the Smart PC init happens, it has the
parent debugfs directory to get itself hooked.
Reviewed-by: Mario Limonciello
Signed-off-by: Shyam Sundar S K
---
drivers/platform/x86/amd/pmf/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform
t in the kernel which can load the amdtee driver.
Without amdtee driver loading onto the system the "tee" calls shall fail
from the PMF driver. Hence an explicit MODULE_SOFTDEP has been added
to address this.
Signed-off-by: Shyam Sundar S K
---
drivers/platform/x86/amd/pmf/Kconfig | 2
function to set the DRAM
address.
Add a suspend handler that can free up the allocated memory for getting
the metrics table information.
Reviewed-by: Mario Limonciello
Signed-off-by: Shyam Sundar S K
---
drivers/platform/x86/amd/pmf/core.c | 42 ++---
drivers/platform/x86
getting the information from
the other kernel subsystems or from userland)
2) Enact: Enact the output actions from the TA. The action could be
applying a new thermal limit to boost/throttle the power limits or
change system behavior.
Reviewed-by: Mario Limonciello
Signed-off-by: Shyam Sundar S K
code path to build these pipes.
Reviewed-by: Mario Limonciello
Signed-off-by: Shyam Sundar S K
---
drivers/platform/x86/amd/pmf/Kconfig | 1 +
drivers/platform/x86/amd/pmf/Makefile | 3 +-
drivers/platform/x86/amd/pmf/core.c | 10 ++-
drivers/platform/x86/amd/pmf/pmf.h| 16
dr
or interaction with SFH
- other cosmetic remarks
Basavaraj Natikar (3):
HID: amd_sfh: rename float_to_int() to amd_sfh_float_to_int()
platform/x86/amd/pmf: Add PMF-AMDSFH interface for HPD
platform/x86/amd/pmf: Add PMF-AMDSFH interface for ALS
Shyam Sundar S K (14):
platform/x86/a
On 10/11/2023 8:47 AM, Shyam Sundar S K wrote:
>
>
> On 10/10/2023 9:56 PM, Mario Limonciello wrote:
>> On 10/10/2023 07:59, Shyam Sundar S K wrote:
>>> PMF Policy binary is a encrypted and signed binary that will be part
>>> of the BIOS. PMF driver via the AC
On 10/10/2023 9:56 PM, Mario Limonciello wrote:
> On 10/10/2023 07:59, Shyam Sundar S K wrote:
>> PMF Policy binary is a encrypted and signed binary that will be part
>> of the BIOS. PMF driver via the ACPI interface checks the existence
>> of Smart PC bit. If the adverti
On 10/10/2023 9:33 PM, Mario Limonciello wrote:
> On 10/10/2023 07:59, Shyam Sundar S K wrote:
>> PMF driver based on the output actions from the TA can request to
>> update
>> the system states like entering s0i3, lock screen etc. by generating
>> an uevent. Based o
On 10/10/2023 6:38 PM, Ilpo Järvinen wrote:
> On Tue, 10 Oct 2023, Shyam Sundar S K wrote:
>
>> Sometimes policy binary retrieved from the BIOS maybe incorrect that can
>> end up in failing to enable the Smart PC solution feature.
>>
>> Use print_hex_dump_debug(
the current file.
Co-developed-by: Shyam Sundar S K
Signed-off-by: Shyam Sundar S K
Signed-off-by: Basavaraj Natikar
---
drivers/hid/amd-sfh-hid/amd_sfh_common.h | 1 +
drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_desc.c | 2 +-
drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c | 6 ++
.../amd
From: Basavaraj Natikar
AMDSFH has information about the User presence information via the Human
Presence Detection (HPD) sensor which is part of the AMD sensor fusion hub.
Add PMF and AMDSFH interface to get this information.
Co-developed-by: Shyam Sundar S K
Signed-off-by: Shyam Sundar S K
on will be called by multiple callers in the
next patch.
Co-developed-by: Shyam Sundar S K
Signed-off-by: Shyam Sundar S K
Signed-off-by: Basavaraj Natikar
---
drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_desc.c | 22 +--
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/d
Limonciello
Signed-off-by: Mario Limonciello
Signed-off-by: Shyam Sundar S K
---
drivers/gpu/drm/amd/amdgpu/amdgpu_pmf.c | 18 ++
drivers/platform/x86/amd/pmf/pmf.h | 2 ++
drivers/platform/x86/amd/pmf/tee-if.c | 21 +++--
3 files changed, 39 insertions
Sundar S K
---
drivers/gpu/drm/amd/amdgpu/Makefile | 2 +
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 +
drivers/gpu/drm/amd/amdgpu/amdgpu_pmf.c | 136
drivers/platform/x86/amd/pmf/Kconfig| 1 +
drivers/platform/x86/amd/pmf/core.c | 1 +
drivers/platform
Sundar S K
---
drivers/platform/x86/amd/pmf/tee-if.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/platform/x86/amd/pmf/tee-if.c
b/drivers/platform/x86/amd/pmf/tee-if.c
index 994daf945795..e4386f503ad0 100644
--- a/drivers/platform/x86/amd/pmf/tee-if.c
+++ b/drivers
: Mario Limonciello
Signed-off-by: Shyam Sundar S K
---
drivers/platform/x86/amd/pmf/pmf.h| 1 +
drivers/platform/x86/amd/pmf/tee-if.c | 67 +++
2 files changed, 68 insertions(+)
diff --git a/drivers/platform/x86/amd/pmf/pmf.h
b/drivers/platform/x86/amd/pmf/pmf.h
index
-static function as this helper is
required outside of sps.c file.
Reviewed-by: Mario Limonciello
Signed-off-by: Shyam Sundar S K
---
drivers/platform/x86/amd/pmf/pmf.h| 3 +++
drivers/platform/x86/amd/pmf/spc.c| 37 +++
drivers/platform/x86/amd/pmf/sps.c| 2
rules under Documentation/admin-guide/pmf.rst.
Signed-off-by: Shyam Sundar S K
---
Documentation/admin-guide/index.rst | 1 +
Documentation/admin-guide/pmf.rst | 25 +++
drivers/platform/x86/amd/pmf/pmf.h| 9 +++
drivers/platform/x86/amd/pmf/tee-if.c | 36
P3T (Peak Package Power Limit) is a metric within the SMU controller
that can influence the power limits. Add support from the driver
to update P3T limits accordingly.
Reviewed-by: Mario Limonciello
Signed-off-by: Shyam Sundar S K
---
drivers/platform/x86/amd/pmf/pmf.h| 3 +++
drivers
PMF driver sends changing inputs from each subystem to TA for evaluating
the conditions in the policy binary.
Add initial support of plumbing in the PMF driver for Smart PC to get
information from other subsystems in the kernel.
Signed-off-by: Shyam Sundar S K
---
drivers/platform/x86/amd/pmf
es() so that when the Smart PC init happens, it has the
parent debugfs directory to get itself hooked.
Reviewed-by: Mario Limonciello
Signed-off-by: Shyam Sundar S K
---
drivers/platform/x86/amd/pmf/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform
t in the kernel which can load the amdtee driver.
Without amdtee driver loading onto the system the "tee" calls shall fail
from the PMF driver. Hence an explicit "request_module" has been added
to address this.
Signed-off-by: Shyam Sundar S K
---
drivers/platform/x86/amd/pmf/
function to set the DRAM
address.
Add a suspend handler that can free up the allocated memory for getting
the metrics table information.
Reviewed-by: Mario Limonciello
Signed-off-by: Shyam Sundar S K
---
drivers/platform/x86/amd/pmf/core.c | 42 ++---
drivers/platform/x86
getting the information from
the other kernel subsystems or from userland)
2) Enact: Enact the output actions from the TA. The action could be
applying a new thermal limit to boost/throttle the power limits or
change system behavior.
Reviewed-by: Mario Limonciello
Signed-off-by: Shyam Sundar S K
code path to build these pipes.
Reviewed-by: Mario Limonciello
Signed-off-by: Shyam Sundar S K
---
drivers/platform/x86/amd/pmf/Kconfig | 1 +
drivers/platform/x86/amd/pmf/Makefile | 3 +-
drivers/platform/x86/amd/pmf/core.c | 10 ++-
drivers/platform/x86/amd/pmf/pmf.h| 16
dr
raction with SFH
- other cosmetic remarks
Basavaraj Natikar (3):
HID: amd_sfh: rename float_to_int() to amd_sfh_float_to_int()
platform/x86/amd/pmf: Add PMF-AMDSFH interface for HPD
platform/x86/amd/pmf: Add PMF-AMDSFH interface for ALS
Shyam Sundar S K (13):
platform/x86/amd/pmf: Add P
On 10/4/2023 6:19 PM, Ilpo Järvinen wrote:
> On Sat, 30 Sep 2023, Shyam Sundar S K wrote:
>
>> In order to provide GPU inputs to TA for the Smart PC solution to work, we
>> need to have interface between the PMF driver and the AMDGPU driver.
>>
>> Add the initi
On 10/4/2023 5:53 PM, Ilpo Järvinen wrote:
> On Sat, 30 Sep 2023, Shyam Sundar S K wrote:
>
>> PMF driver based on the output actions from the TA can request to update
>> the system states like entering s0i3, lock screen etc. by generating
>> an uevent. Based on t
On 10/4/2023 5:44 PM, Ilpo Järvinen wrote:
> On Sat, 30 Sep 2023, Shyam Sundar S K wrote:
>
>> PMF driver sends changing inputs from each subystem to TA for evaluating
>> the conditions in the policy binary.
>>
>> Add initial support of plumbing in the
On 10/4/2023 5:30 PM, Ilpo Järvinen wrote:
> On Sat, 30 Sep 2023, Shyam Sundar S K wrote:
>
>> PMF Policy binary is a encrypted and signed binary that will be part
>> of the BIOS. PMF driver via the ACPI interface checks the existence
>> of Smart PC bit. If the adve
On 10/4/2023 4:20 PM, Ilpo Järvinen wrote:
> On Sat, 30 Sep 2023, Shyam Sundar S K wrote:
>
>> AMD PMF driver loads the PMF TA (Trusted Application) into the AMD
>> ASP's (AMD Security Processor) TEE (Trusted Execution Environment).
>>
>> PMF Trusted Appli
On 9/26/2023 10:38 PM, Ilpo Järvinen wrote:
> On Fri, 22 Sep 2023, Shyam Sundar S K wrote:
>
>> PMF driver sends changing inputs from each subystem to TA for evaluating
>> the conditions in the policy binary.
>>
>> Add initial support of plumbing in the
From: Basavaraj Natikar
AMDSFH has information about the User presence information via the Human
Presence Detection (HPD) sensor which is part of the AMD sensor fusion hub.
Add PMF and AMDSFH interface to get this information.
Co-developed-by: Shyam Sundar S K
Signed-off-by: Shyam Sundar S K
the current file.
Co-developed-by: Shyam Sundar S K
Signed-off-by: Shyam Sundar S K
Signed-off-by: Basavaraj Natikar
---
drivers/hid/amd-sfh-hid/amd_sfh_common.h | 1 +
drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_desc.c | 2 +-
drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c | 6 ++
.../amd
on will be called by multiple callers in the
next patch.
Co-developed-by: Shyam Sundar S K
Signed-off-by: Shyam Sundar S K
Signed-off-by: Basavaraj Natikar
---
drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_desc.c | 22 +--
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/d
Sundar S K
---
drivers/gpu/drm/amd/amdgpu/Makefile | 2 +
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 +
drivers/gpu/drm/amd/amdgpu/amdgpu_pmf.c | 136
drivers/platform/x86/amd/pmf/Kconfig| 1 +
drivers/platform/x86/amd/pmf/core.c | 1 +
drivers/platform
Limonciello
Signed-off-by: Mario Limonciello
Signed-off-by: Shyam Sundar S K
---
drivers/gpu/drm/amd/amdgpu/amdgpu_pmf.c | 18 ++
drivers/platform/x86/amd/pmf/pmf.h | 2 ++
drivers/platform/x86/amd/pmf/tee-if.c | 21 +++--
3 files changed, 39 insertions
: kernel test robot
Closes:
https://lore.kernel.org/oe-kbuild-all/202309251031.awddkrgs-...@intel.com/
Reviewed-by: Mario Limonciello
Signed-off-by: Shyam Sundar S K
---
drivers/platform/x86/amd/pmf/pmf.h| 1 +
drivers/platform/x86/amd/pmf/tee-if.c | 68 +++
2 files
Sundar S K
---
drivers/platform/x86/amd/pmf/tee-if.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/platform/x86/amd/pmf/tee-if.c
b/drivers/platform/x86/amd/pmf/tee-if.c
index 01f974b55a6a..d16bdecfd43a 100644
--- a/drivers/platform/x86/amd/pmf/tee-if.c
+++ b/drivers/platform
-static function as this helper is
required outside of sps.c file.
Reviewed-by: Mario Limonciello
Signed-off-by: Shyam Sundar S K
---
drivers/platform/x86/amd/pmf/pmf.h| 3 +++
drivers/platform/x86/amd/pmf/spc.c| 37 +++
drivers/platform/x86/amd/pmf/sps.c| 2
rules under Documentation/admin-guide/pmf.rst.
Reported-by: kernel test robot
Closes:
https://lore.kernel.org/oe-kbuild-all/202309260515.5xbr6n0g-...@intel.com/
Signed-off-by: Shyam Sundar S K
---
Documentation/admin-guide/index.rst | 1 +
Documentation/admin-guide/pmf.rst | 25
P3T (Peak Package Power Limit) is a metric within the SMU controller
that can influence the power limits. Add support from the driver
to update P3T limits accordingly.
Reviewed-by: Mario Limonciello
Signed-off-by: Shyam Sundar S K
---
drivers/platform/x86/amd/pmf/pmf.h| 3 +++
drivers
PMF driver sends changing inputs from each subystem to TA for evaluating
the conditions in the policy binary.
Add initial support of plumbing in the PMF driver for Smart PC to get
information from other subsystems in the kernel.
Signed-off-by: Shyam Sundar S K
---
drivers/platform/x86/amd/pmf
es() so that when the Smart PC init happens, it has the
parent debugfs directory to get itself hooked.
Reviewed-by: Mario Limonciello
Signed-off-by: Shyam Sundar S K
---
drivers/platform/x86/amd/pmf/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform
t in the kernel which can load the amdtee driver.
Without amdtee driver loading onto the system the "tee" calls shall fail
from the PMF driver. Hence an explicit "request_module" has been added
to address this.
Signed-off-by: Shyam Sundar S K
---
drivers/platform/x86/amd/pmf
function to set the DRAM
address.
Reviewed-by: Mario Limonciello
Signed-off-by: Shyam Sundar S K
---
drivers/platform/x86/amd/pmf/core.c | 26 ++
drivers/platform/x86/amd/pmf/pmf.h | 1 +
2 files changed, 19 insertions(+), 8 deletions(-)
diff --git a/drivers/platform
getting the information from
the other kernel subsystems or from userland)
2) Enact: Enact the output actions from the TA. The action could be
applying a new thermal limit to boost/throttle the power limits or
change system behavior.
Reviewed-by: Mario Limonciello
Signed-off-by: Shyam Sundar S K
code path to build these pipes.
Reviewed-by: Mario Limonciello
Signed-off-by: Shyam Sundar S K
---
drivers/platform/x86/amd/pmf/Makefile | 3 +-
drivers/platform/x86/amd/pmf/core.c | 11 ++-
drivers/platform/x86/amd/pmf/pmf.h| 16
drivers/platform/x86/amd/pmf/tee-if.c
float_to_int() to amd_sfh_float_to_int()
platform/x86/amd/pmf: Add PMF-AMDSFH interface for HPD
platform/x86/amd/pmf: Add PMF-AMDSFH interface for ALS
Shyam Sundar S K (13):
platform/x86/amd/pmf: Add PMF TEE interface
platform/x86/amd/pmf: Add support PMF-TA interaction
platform/x86/am
On 9/23/2023 12:31 AM, Mario Limonciello wrote:
> On 9/22/2023 12:50, Shyam Sundar S K wrote:
>> Sometimes policy binary retrieved from the BIOS maybe incorrect that
>> can
>> end up in failing to enable the Smart PC solution feature.
>>
>> Use print_hex_dump_
On 9/23/2023 12:21 AM, Mario Limonciello wrote:
> On 9/22/2023 12:50, Shyam Sundar S K wrote:
>> PMF Policy binary is a encrypted and signed binary that will be part
>> of the BIOS. PMF driver via the ACPI interface checks the existence
>> of Smart PC bit. If the adverti
Hi Ilpo,
On 9/27/2023 7:03 PM, Ilpo Järvinen wrote:
> On Fri, 22 Sep 2023, Shyam Sundar S K wrote:
>
>> From: Basavaraj Natikar
>>
>> AMDSFH has information about the Ambient light via the Ambient
>> Light Sensor (ALS) which is part of the AMD sensor fusion hub.
&
Hi Hans,
On 9/27/2023 6:34 PM, Hans de Goede wrote:
> HI,
>
> On 9/26/23 15:17, Christian König wrote:
>> Am 26.09.23 um 14:56 schrieb Hans de Goede:
>>> Hi,
>>>
>>> On 9/26/23 13:24, Shyam Sundar S K wrote:
>>>> Hi Hans,
>>
Hi Christian,
On 9/26/2023 6:47 PM, Christian König wrote:
> Am 26.09.23 um 14:56 schrieb Hans de Goede:
>> Hi,
>>
>> On 9/26/23 13:24, Shyam Sundar S K wrote:
>>> Hi Hans,
>>>
>>> On 9/26/2023 4:05 PM, Hans de Goede wrote:
>>>> Hi,
&
Hi Hans,
On 9/26/2023 4:05 PM, Hans de Goede wrote:
> Hi,
>
> On 9/22/23 19:50, Shyam Sundar S K wrote:
>> For the Smart PC Solution to fully work, it has to enact to the actions
>> coming from TA. Add the initial code path for set interface to AMDGPU.
>>
>> C
On 9/25/2023 10:00 PM, Mario Limonciello wrote:
> On 9/25/2023 11:27, Deucher, Alexander wrote:
>> [Public]
>>
>>> -Original Message-
>>> From: amd-gfx On Behalf Of
>>> Shyam Sundar S K
>>> Sent: Friday, September 22, 2023 1:51 P
On 9/25/2023 9:57 PM, Deucher, Alexander wrote:
> [Public]
>
>> -Original Message-
>> From: amd-gfx On Behalf Of
>> Shyam Sundar S K
>> Sent: Friday, September 22, 2023 1:51 PM
>> To: hdego...@redhat.com; markgr...@kernel.org; Nati
From: Basavaraj Natikar
AMDSFH has information about the User presence information via the Human
Presence Detection (HPD) sensor which is part of the AMD sensor fusion hub.
Add PMF and AMDSFH interface to get this information.
Co-developed-by: Shyam Sundar S K
Signed-off-by: Shyam Sundar S K
From: Basavaraj Natikar
AMDSFH has information about the Ambient light via the Ambient
Light Sensor (ALS) which is part of the AMD sensor fusion hub.
Add PMF and AMDSFH interface to get this information.
Co-developed-by: Shyam Sundar S K
Signed-off-by: Shyam Sundar S K
Signed-off-by
For the Smart PC Solution to fully work, it has to enact to the actions
coming from TA. Add the initial code path for set interface to AMDGPU.
Co-developed-by: Mario Limonciello
Signed-off-by: Mario Limonciello
Signed-off-by: Shyam Sundar S K
---
drivers/gpu/drm/amd/amdgpu/amdgpu_pmf.c | 21
Sundar S K
---
drivers/gpu/drm/amd/amdgpu/Makefile | 2 +
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 +
drivers/gpu/drm/amd/amdgpu/amdgpu_pmf.c | 70 +
drivers/platform/x86/amd/pmf/Kconfig| 1 +
drivers/platform/x86/amd/pmf/core.c | 1 +
drivers/platform/x86
Sundar S K
---
drivers/platform/x86/amd/pmf/tee-if.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/platform/x86/amd/pmf/tee-if.c
b/drivers/platform/x86/amd/pmf/tee-if.c
index fa37cfab2dc7..3daa122f35d5 100644
--- a/drivers/platform/x86/amd/pmf/tee-if.c
+++ b/drivers/platform
amd_pmf_dbgfs_register() needs to be called before amd_pmf_init_features().
Hence change the sequence.
Reviewed-by: Mario Limonciello
Signed-off-by: Shyam Sundar S K
---
drivers/platform/x86/amd/pmf/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86
: Mario Limonciello
Signed-off-by: Shyam Sundar S K
---
drivers/platform/x86/amd/pmf/pmf.h| 1 +
drivers/platform/x86/amd/pmf/tee-if.c | 60 +++
2 files changed, 61 insertions(+)
diff --git a/drivers/platform/x86/amd/pmf/pmf.h
b/drivers/platform/x86/amd/pmf/pmf.h
index
-off-by: Shyam Sundar S K
---
drivers/platform/x86/amd/pmf/pmf.h| 3 +++
drivers/platform/x86/amd/pmf/spc.c| 37 +++
drivers/platform/x86/amd/pmf/sps.c| 2 +-
drivers/platform/x86/amd/pmf/tee-if.c | 1 +
4 files changed, 42 insertions(+), 1 deletion(-)
diff
rules under Documentation/admin-guide/pmf.rst.
Signed-off-by: Shyam Sundar S K
---
Documentation/admin-guide/pmf.rst | 24
drivers/platform/x86/amd/pmf/pmf.h| 9 ++
drivers/platform/x86/amd/pmf/tee-if.c | 40 ++-
3 files changed, 72 insertions
P3T (Peak Package Power Limit) is a metric within the SMU controller
that can influence the power limits. Add support from the driver
to update P3T limits accordingly.
Reviewed-by: Mario Limonciello
Signed-off-by: Shyam Sundar S K
---
drivers/platform/x86/amd/pmf/pmf.h| 3 +++
drivers
1 - 100 of 107 matches
Mail list logo
