Re: [PATCH V2 5/13] hid: use time_is_after_jiffies() instead of jiffies judgment

2022-02-11 Thread srinivas pandruvada
On Thu, 2022-02-10 at 18:30 -0800, Qing Wang wrote: > From: Wang Qing > > It is better to use time_xxx() directly instead of jiffies judgment > for understanding. > > Signed-off-by: Wang Qing Acked-by: Srinivas Pandruvada > --- >  drivers/hid/intel-ish-hid/ipc/ipc.c

Re: [PATCH v2 12/63] thermal: intel: int340x_thermal: Use struct_group() for memcpy() region

2021-11-23 Thread Srinivas Pandruvada
t; line number induced differences). > > > > Cc: Zhang Rui > > Cc: Daniel Lezcano > > Cc: Amit Kucheria > > Cc: linux...@vger.kernel.org > > Signed-off-by: Kees Cook > > Rui, Srinivas, any comments here? Looks good. Reviewed-by: Srinivas Pandruvada

Re: [PATCH 00/25] Rid W=1 warnings from HID

2021-03-25 Thread Srinivas Pandruvada
On Wed, 2021-03-24 at 17:33 +, Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > For changes in drivers/hid/intel-ish-hid folder Acked-by: Sriniva