(10);
+ usleep_range(1, 10200);
}
// read rc result
thanks,
-- Shuah
l put them into mm.git, to advance things a bit.
I haven't heard from kunit maintainers yet. This thread got lost
in inbox due to travel.
David/Brendan/Rae, Okay to take this series?
Andrew, Okay to take this through your tree - this needs merging.
thanks,
-- Shuah
On 11/12/24 07:43, Mark Brown wrote:
On Mon, Nov 11, 2024 at 02:50:45PM -0700, Shuah Khan wrote:
On 11/11/24 13:07, Simona Vetter wrote:
Personal take, but I think a forced public apology as the primary or at
least initial coc enforcement approach is one of the worst.
...
This document
On 11/11/24 22:18, Laurent Pinchart wrote:
On Mon, Nov 11, 2024 at 05:35:11PM -0700, Shuah Khan wrote:
On 11/11/24 15:35, Laurent Pinchart wrote:
On Mon, Nov 11, 2024 at 02:50:45PM -0700, Shuah Khan wrote:
On 11/11/24 13:07, Simona Vetter wrote:
On Fri, Nov 08, 2024 at 09:18:53AM -0700
On 11/11/24 15:35, Laurent Pinchart wrote:
Hi Shuah,
On Mon, Nov 11, 2024 at 02:50:45PM -0700, Shuah Khan wrote:
On 11/11/24 13:07, Simona Vetter wrote:
On Fri, Nov 08, 2024 at 09:18:53AM -0700, Shuah Khan wrote:
The Code of Conduct committee's goal first and foremost is to bring
On 11/11/24 13:07, Simona Vetter wrote:
On Fri, Nov 08, 2024 at 09:18:53AM -0700, Shuah Khan wrote:
The Code of Conduct committee's goal first and foremost is to bring about
change to ensure our community continues to foster respectful discussions.
In the interest of transparency, th
for this value?
thanks,
-- Shuah
) +
j);
+ mask |= (u64)1 << ((i *
adev->jpeg.num_jpeg_rings) + j);
}
}
*val = mask;
thanks,
-- Shuah
__u16 width;
+ /** @height: Height of the plane in pixels. */
__u16 height;
};
Reviewed-by: Shuah Khan
thanks,
-- Shuah
On 8/12/24 13:37, Abhinav Jain wrote:
Hello,
Can this be kindly reviewed? Thanks.
You removed all the relevant information for people to be able to review the
patch :)
thanks,
-- Shuah
BT709_YCC:
*XVYCC_601:
@@ -2378,6 +2381,7 @@ EXPORT_SYMBOL(drm_mode_create_aspect_ratio_property);
*DCI-P3_RGB_Theater:
*RGB_WIDE_FIXED:
*RGB_WIDE_FLOAT:
+ *
*BT601_YCC:
*The behavior is undefined.
*
Reviewed-by: Shuah Khan
thanks,
-- Shuah
XVYCC_601:
@@ -2378,6 +2381,7 @@ EXPORT_SYMBOL(drm_mode_create_aspect_ratio_property);
*DCI-P3_RGB_Theater:
*RGB_WIDE_FIXED:
*RGB_WIDE_FLOAT:
+ *
*BT601_YCC:
*The behavior is undefined.
*
thanks,
-- Shuah
accel device exists
+QAIC creates an accel device per physical PCIe device. This accel device exists
for as long as the PCIe device is known to Linux.
The PCIe device may not be in the state to accept requests from userspace at
thanks,
-- Shuah
tests comes from a patch by Mike Kravetz.
Add Suggested-by for Mike Kravetz
Cc: Shuah Khan
Cc: David Hildenbrand
Cc: Daniel Vetter
Cc: Mike Kravetz
Cc: Hugh Dickins
Cc: Peter Xu
Cc: Jason Gunthorpe
Cc: Gerd Hoffmann
Cc: Dongwon Kim
Cc: Junxiao Chang
Signed-off-by: Vivek Kasireddy
Hi Stephen,
On 3/1/24 15:30, Shuah Khan wrote:
Hi Stephen,
On 3/1/24 13:46, Stephen Rothwell wrote:
Hi Shuah,
On Fri, 1 Mar 2024 09:05:57 -0700 Shuah Khan wrote:
On 3/1/24 03:43, Stephen Rothwell wrote:
Hi all,
On Fri, 1 Mar 2024 15:15:02 +0800 David Gow wrote:
On Thu, 29 Feb 2024 at
Hi Stephen,
On 3/1/24 13:46, Stephen Rothwell wrote:
Hi Shuah,
On Fri, 1 Mar 2024 09:05:57 -0700 Shuah Khan wrote:
On 3/1/24 03:43, Stephen Rothwell wrote:
Hi all,
On Fri, 1 Mar 2024 15:15:02 +0800 David Gow wrote:
On Thu, 29 Feb 2024 at 23:07, Shuah Khan wrote:
I can carry the fix
On 3/1/24 03:43, Stephen Rothwell wrote:
Hi all,
On Fri, 1 Mar 2024 15:15:02 +0800 David Gow wrote:
On Thu, 29 Feb 2024 at 23:07, Shuah Khan wrote:
I can carry the fix through kselftest kunit if it works
for all.
I'm happy for this to go in with the KUnit changes if that's th
"buddy_alloc failed with bias(%x-%x),
size=%u, ps=%u\n",
+ "buddy_alloc failed with bias(%x-%x),
size=%u\n",
bias_start, bias_end, size);
bias_rem -= size;
thanks,
-- Shuah
hanks,
-- Shuah
ne doesn't
apply as is due to conflict between this one and fca7526b7d89
I think if we can fix this here - we won't problems during pull
request merge.
thanks,
-- Shuah
a8b18 ("rtc: Improve performance of rtc_time64_to_tm(). Add
tests.")
Signed-off-by: David Gow
Who do you expect to take this patch?
I am going to be applying this series to linux-kselftest kunit next
in just a bit. Would you like to ack the pacth?
thanks,
-- Shuah
Thank you for a quick response David. I will apply the series to
kunit next for Linux 6.9 as soon as the reviews are complete.
thanks,
-- Shuah
FAIL_ON(mode.tv_margins.left != 24);
- FAIL_ON(mode.tv_margins.bottom != 36);
- FAIL_ON(mode.tv_margins.top != 42);
-
- FAIL_ON(mode.rb);
- FAIL_ON(mode.cvt);
- FAIL_ON(mode.interlace);
- FAIL_ON(mode.margins);
- FAIL_ON(mode.force != DRM_FORCE_ON);
+ drm_cmdline_test_properties(ignored, &mode, DRM_FORCE_ON);
return 0;
}
@@ -1107,20 +843,17 @@ static int drm_cmdline_test_panel_orientation(void
*ignored)
{
struct drm_cmdline_mode mode = { };
- FAIL_ON(!drm_mode_parse_command_line_for_connector("panel_orientation=upside_down",
- &no_connector,
- &mode));
+ FAIL_ON(!drm_mode_parse_command_line_for_connector(
+ "panel_orientation=upside_down", &no_connector,
&mode));
Same here about changing the format.
+
FAIL_ON(mode.specified);
FAIL_ON(mode.refresh_specified);
FAIL_ON(mode.bpp_specified);
+
FAIL_ON(mode.panel_orientation != DRM_MODE_PANEL_ORIENTATION_BOTTOM_UP);
- FAIL_ON(mode.rb);
- FAIL_ON(mode.cvt);
- FAIL_ON(mode.interlace);
- FAIL_ON(mode.margins);
- FAIL_ON(mode.force != DRM_FORCE_UNSPECIFIED);
+ drm_cmdline_test_properties(ignored, &mode, DRM_FORCE_UNSPECIFIED);
return 0;
}
thanks,
-- Shuah
goto err_child;
+ }
+ fbo = (struct flat_binder_object *)tr->data.ptr.buffer;
+ ASSERT_EQ(fbo->hdr.type, BINDER_TYPE_PTR) {
+ TH_LOG("Did not receive a buffer object from child");
+ goto err_child;
+ }
+ bbo = (struct binder_buffer_object *)fbo;
+ ASSERT_EQ(bbo->length, 0) {
+ TH_LOG("Did not receive an empty buffer object from child");
+ goto err_child;
+ }
+
+ TH_LOG("Received transaction from child");
+ send_dmabuf_reply(b_ctx.fd, tr, dmabuf_fd);
+
+ ASSERT_EQ(cg_read_key_long(cg_ctx.dest, GPUMEM_FILENAME, "system"),
ONE_MiB) {
+ TH_LOG("Destination cgroup does not have system charge!");
+ goto err_child;
+ }
+ ASSERT_EQ(cg_read_key_long(cg_ctx.source, GPUMEM_FILENAME, "system"),
0) {
+ TH_LOG("Source cgroup still has system charge!");
+ goto err_child;
+ }
+ TH_LOG("Charge transfer succeeded!");
+
+err_child:
+ waitpid(child_pid, &ret, 0);
+ if (WIFEXITED(ret))
+ TH_LOG("Child %d terminated with %d", child_pid,
WEXITSTATUS(ret));
+ else
+ TH_LOG("Child terminated abnormally");
What does this mean? What are the conditions that could cause this?
Pls include more info. in the message.
+err_binder:
+ close_binder(&b_ctx);
+err_dmabuf:
+ close(dmabuf_fd);
+err_cg:
+ destroy_cgroups(_metadata, &cg_ctx);
+ destroy_binderfs(&bfs_ctx);
+}
+
+TEST_HARNESS_MAIN
thanks,
-- Shuah
thing that is in the plan to address as
part of this work?
thanks,
-- Shuah
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
which then
causes the _IOCW macros to give the wrong ioctl numbers,
specifically for DMA_BUF_IOCTL_SYNC.
This patch simply removes the extra include from the Makefile
Cc: Shuah Khan
Cc: Brian Starkey
Cc: Sumit Semwal
Cc: Laura Abbott
Cc: Hridya Valsaraju
Cc: Suren Baghdasaryan
Cc: Sandeep
Laura Abbott
Cc: Martijn Coenen
Cc: Shuah Khan
Cc: Sumit Semwal
Cc: Suren Baghdasaryan
Cc: Todd Kjos
Cc: de...@driverdev.osuosl.org
Cc: dri-devel@lists.freedesktop.org
Cc: linaro-mm-...@lists.linaro.org
Signed-off-by: Greg Kroah-Hartman
---
MAINTAINERS
. Initializing ret to 0 is a better
way to go.
thanks,
-- Shuah
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
;
While you are at it, why not change strcmp() to strncmp()?
thanks,
-- Shuah
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
n't
already in the mainline. In any case, repeating myself
Let's work on top of - it is rebased to 5.4-rc1 and ready for use.
https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/log/?h=test
Let's use that for kunit work for 5.5. I won't add any kselftest
timing.
That is probably the initial thought. However, it makes perfect sense
to add a couple of tests in. We have a few weeks anyway and it gives
us more confidence on kunit.
I already have a branch that is in linux-next and it just has kunit in
it and I will rebase it to 5.4-rc1.
https://git.kerne
On 10/4/19 6:33 PM, Brendan Higgins wrote:
On Fri, Oct 4, 2019 at 4:57 PM shuah wrote:
On 10/4/19 5:52 PM, Brendan Higgins wrote:
On Fri, Oct 4, 2019 at 4:30 PM Theodore Y. Ts'o wrote:
On Fri, Oct 04, 2019 at 04:47:09PM -0600, shuah wrote:
However, if I encourage arbitrary
On 10/4/19 5:52 PM, Brendan Higgins wrote:
On Fri, Oct 4, 2019 at 4:30 PM Theodore Y. Ts'o wrote:
On Fri, Oct 04, 2019 at 04:47:09PM -0600, shuah wrote:
However, if I encourage arbitrary tests/improvements into my KUnit
branch, it further diverges away from torvalds/master, and is
On 10/4/19 5:10 PM, Brendan Higgins wrote:
On Fri, Oct 4, 2019 at 3:47 PM shuah wrote:
On 10/4/19 4:27 PM, Brendan Higgins wrote:
On Fri, Oct 04, 2019 at 03:59:10PM -0600, shuah wrote:
On 10/4/19 3:42 PM, Linus Torvalds wrote:
On Fri, Oct 4, 2019 at 2:39 PM Theodore Y. Ts'o wrote:
On 10/4/19 4:27 PM, Brendan Higgins wrote:
On Fri, Oct 04, 2019 at 03:59:10PM -0600, shuah wrote:
On 10/4/19 3:42 PM, Linus Torvalds wrote:
On Fri, Oct 4, 2019 at 2:39 PM Theodore Y. Ts'o wrote:
This question is primarily directed at Shuah and Linus
What's the current sta
On 10/4/19 3:42 PM, Linus Torvalds wrote:
On Fri, Oct 4, 2019 at 2:39 PM Theodore Y. Ts'o wrote:
This question is primarily directed at Shuah and Linus
What's the current status of the kunit series now that Brendan has
moved it out of the top-level kunit directory as Linus has
apply.
Hope you are okay with that Randy!
thanks,
-- Shuah
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
On 8/23/19 7:34 PM, Brendan Higgins wrote:
## TL;DR
This revision addresses comments from Shuah by fixing a couple
checkpatch warnings and fixing some comment readability issues. No API
or major structual changes have been made since v13.
## Background
This patch set proposes KUnit, a
On 8/23/19 1:20 PM, Brendan Higgins wrote:
On Fri, Aug 23, 2019 at 12:04 PM shuah wrote:
On 8/23/19 12:56 PM, Brendan Higgins wrote:
On Fri, Aug 23, 2019 at 11:32 AM shuah wrote:
On 8/23/19 11:54 AM, Brendan Higgins wrote:
On Fri, Aug 23, 2019 at 10:34 AM shuah wrote:
On 8/23/19 11:27
On 8/23/19 12:56 PM, Brendan Higgins wrote:
On Fri, Aug 23, 2019 at 11:32 AM shuah wrote:
On 8/23/19 11:54 AM, Brendan Higgins wrote:
On Fri, Aug 23, 2019 at 10:34 AM shuah wrote:
On 8/23/19 11:27 AM, Brendan Higgins wrote:
On Fri, Aug 23, 2019 at 10:05 AM shuah wrote:
On 8/23/19 10
On 8/23/19 11:54 AM, Brendan Higgins wrote:
On Fri, Aug 23, 2019 at 10:34 AM shuah wrote:
On 8/23/19 11:27 AM, Brendan Higgins wrote:
On Fri, Aug 23, 2019 at 10:05 AM shuah wrote:
On 8/23/19 10:48 AM, Brendan Higgins wrote:
On Fri, Aug 23, 2019 at 8:33 AM shuah wrote:
Hi Brendan,
On
On 8/23/19 11:27 AM, Brendan Higgins wrote:
On Fri, Aug 23, 2019 at 10:05 AM shuah wrote:
On 8/23/19 10:48 AM, Brendan Higgins wrote:
On Fri, Aug 23, 2019 at 8:33 AM shuah wrote:
Hi Brendan,
On 8/20/19 5:20 PM, Brendan Higgins wrote:
Add core facilities for defining unit tests; this
On 8/23/19 10:56 AM, Brendan Higgins wrote:
On Fri, Aug 23, 2019 at 8:36 AM shuah wrote:
Hi Brendan,
On 8/20/19 5:20 PM, Brendan Higgins wrote:
Add support for aborting/bailing out of test cases, which is needed for
implementing assertions.
An assertion is like an expectation, but bails
On 8/23/19 10:48 AM, Brendan Higgins wrote:
On Fri, Aug 23, 2019 at 8:33 AM shuah wrote:
Hi Brendan,
On 8/20/19 5:20 PM, Brendan Higgins wrote:
Add core facilities for defining unit tests; this provides a common way
to define test cases, functions that execute code which is under test
and
BUG();
I recall discussion on this. What's the point in keeping thie
BUG() around when it doesn't even reach? It can even be a
WARN_ON() in that case right?
thanks,
-- Shuah
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://l
h an
+ * empty test case.
+ *
+ * Example:
Can you fix these line continuations. It makes it very hard to read.
Sorry for this late comment. These comments lines are longer than 80
and wrap.
There are several comment lines in the file that are way too long.
th
On 8/20/19 5:23 PM, Brendan Higgins wrote:
On Tue, Aug 20, 2019 at 2:26 PM Brendan Higgins
wrote:
On Tue, Aug 20, 2019 at 12:08 PM shuah wrote:
On 8/20/19 12:24 PM, Brendan Higgins wrote:
On Tue, Aug 20, 2019 at 11:24:45AM -0600, shuah wrote:
On 8/13/19 11:50 PM, Brendan Higgins wrote
On 8/20/19 12:24 PM, Brendan Higgins wrote:
On Tue, Aug 20, 2019 at 11:24:45AM -0600, shuah wrote:
On 8/13/19 11:50 PM, Brendan Higgins wrote:
## TL;DR
This revision addresses comments from Stephen and Bjorn Helgaas. Most
changes are pretty minor stuff that doesn't affect the API in a
ignificant changes from here on
out.
Hi Brendan,
I found checkpatch errors in one or two patches. Can you fix those and
send v14.
thanks,
-- Shuah
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
R
M:Luis Chamberlain
L:linux-ker...@vger.kernel.org
Thanks Brendan.
I am good with this. I can take KUnit patches through kselftest
with your Ack.
thanks,
-- Shuah
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
;< 31)
+#define KFD_IOC_ALLOC_MEM_FLAGS_WRITABLE (1U << 31)
#define KFD_IOC_ALLOC_MEM_FLAGS_EXECUTABLE(1 << 30)
#define KFD_IOC_ALLOC_MEM_FLAGS_PUBLIC(1 << 29)
#define KFD_IOC_ALLOC_MEM_FLAGS_NO_SUBSTITUTE (1 << 28)
thanks,
-- Shuah
On 6/21/19 12:13 PM, Theodore Ts'o wrote:
On Fri, Jun 21, 2019 at 08:59:48AM -0600, shuah wrote:
### But wait! Doesn't kselftest support in kernel testing?!
I think I commented on this before. I agree with the statement that
there is no overlap between Kselftest and KUnit. I
st and development alone. I wouldn't hesitate loading a Kselftest
test module on my laptop and running tests, but I wouldn't use KUnit
the same way.
Again, this is not a competition between which is better. Kselftest
and KUnit serve different needs and problem spaces.
Please redo this documentation to reflect that.
thanks,
-- Shuah
adds a simple test, that calls the uname syscall with a
tagged user pointer as an argument. Without the kernel accepting tagged
user pointers the test fails with EFAULT.
Signed-off-by: Andrey Konovalov
I'm adding Shuah to CC in case she has some suggestions about the new
selftest.
Thanks
On 5/7/19 2:01 AM, Greg KH wrote:
On Mon, May 06, 2019 at 08:14:12PM -0700, Frank Rowand wrote:
On 5/1/19 4:01 PM, Brendan Higgins wrote:
## TLDR
I rebased the last patchset on 5.1-rc7 in hopes that we can get this in
5.2.
Shuah, I think you, Greg KH, and myself talked off thread, and we
ub.io/kunit-docs/third_party/kernel/docs/
+S: Maintained
+F: Documentation/kunit/
+F: include/kunit/
+F: kunit/
+F: tools/testing/kunit/
+
Please add kselftest mailing list to this entry, based on our
conversation on taking these patches through kselftest tree.
thanks,
--
.
thanks,
-- Shuah
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
tream, KERN_ERR);
+ kunit_stream_commit(stream);
+}
+
int kunit_init_test(struct kunit *test, const char *name)
{
spin_lock_init(&test->lock);
INIT_LIST_HEAD(&test->resources);
test->name = name;
test->vprintk = kunit_vprintk;
+ test->fail = kunit_fail;
return 0;
}
thanks,
-- Shuah
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
On 5/1/19 5:01 PM, Brendan Higgins wrote:
Add a test for string stream along with a simpler example.
Signed-off-by: Brendan Higgins
---
kunit/Kconfig | 12 ++
kunit/Makefile | 4 ++
kunit/example-test.c | 88 ++
kunit/
if (!stream)
+ return NULL;
+
+ INIT_LIST_HEAD(&stream->fragments);
+ spin_lock_init(&stream->lock);
+ kref_init(&stream->refcount);
+ return stream;
+}
+
+void string_stream_get(struct string_stream *stream)
+{
+ kref_get(&stream->refcount)
Sunday.
Shuah, I think you, Greg KH, and myself talked off thread, and we agreed
we would merge through your tree when the time came? Am I remembering
correctly?
No objection from me.
Yes. I can take these through kselftest tree when the time comes.
Agree with Greg that 5.2 might be rushing it
they evolve quicker as kernel developers contribute tests as
part of their kernel work-flow. Maintaining tests and framework
separately will make it harder to maintain them and keep them updated
for us the kernel community.
thanks,
-- Shuah
___
dr
On 11/06/2018 06:28 PM, Brendan Higgins wrote:
> On Fri, Nov 2, 2018 at 11:44 AM Shuah Khan wrote:
>>
>> On 10/23/2018 05:57 PM, Brendan Higgins wrote:
>
>>> + * Example:
>>> + *
>>> + * .. code-block:: c
>>&g
Q(test, -1, add(INT_MAX, INT_MIN));
> + * }
> + *
> + * static struct test_case example_test_cases[] = {
> + * TEST_CASE(add_test_basic),
> + * {},
> + * };
> + *
> + */
> +struct test_case {
> + void (*run_case)(st
and ran into
problems:
./tools/testing/kunit/kunit.py
usage: kunit.py [-h] {run,new} ...
Helps writing and running KUnit tests.
positional arguments:
{run,new}
run Runs KUnit tests.
new Prints out boilerplate for writing new tests.
optional arguments:
-h, --help sho
here: https://kunit-review.googlesource.com/c/linux/+/1132),
>as suggested by Rob.
> - Cleaned up some of the commit messages and tweaked commit order a
> bit based on suggestions.
>
I am a bit behind on reviewing this patch series.
Just a quick note that I will start looking at thes
On 02/26/2018 06:48 PM, Laura Abbott wrote:
> On 02/26/2018 09:07 AM, Shuah Khan wrote:
>> On 02/19/2018 11:33 AM, Daniel Vetter wrote:
>>> On Mon, Feb 19, 2018 at 10:18:21AM -0800, Laura Abbott wrote:
>>>> On 02/19/2018 07:31 AM, Daniel Vetter wrote:
>>>>
vgem_fd, info.buffd, &handle);
>>>> +
>>>> + if (ret < 0) {
>>>> + printf("Failed to import buffer\n");
>>>> + goto out_vgem;
>>>> + }
>>>> +
>>>> + sync.flags = DMA_BUF_SYNC_START | DMA_BUF_SYNC_RW;
>>>> + ret = ioctl(info.buffd, DMA_BUF_IOCTL_SYNC, &sync);
>>>> + if (ret)
>>>> + printf("sync start failed %d\n", errno);
>>>> +
>>>> + memset(info.buffer, 0xff, 4096);
>>>> +
>>>> + sync.flags = DMA_BUF_SYNC_END | DMA_BUF_SYNC_RW;
>>>> + ret = ioctl(info.buffd, DMA_BUF_IOCTL_SYNC, &sync);
>>>> + if (ret)
>>>> + printf("sync end failed %d\n", errno);
>>>
>>> At least in drm we require that userspace auto-restarts all ioctls when
>>> they get interrupt. See
>>>
>>> https://cgit.freedesktop.org/drm/libdrm/tree/xf86drm.c#n186
>>>
>>> not really an issue with vgem (which can't wait for hw or anything else).
>>> But good to make sure we don't spread bad copypastas.
>>>
>>> Actual use of the ioctls looks all good. With the drmIoctl wrapper added
>>> and used this is:
>>>
>>> Reviewed-by: Daniel Vetter
>>
>> Thanks for the review. The reason I didn't use the standard drmIoctl was
>> because I didn't want to introduce a dependency on libdrm. I don't see
>> an example of another selftest having a dependency on an external
>> library.
>>
>> Is adding a dependencies on fairly standard but still external userspace
>> libraries okay for kernel self tests?
We have cases where external libraries are used. fuse test probably is one
example.
>
> Yeah adding a dependency isn't good, I'd just copypaste a local static
> version into the test file. That's good enough, the point isn't to use the
> libdrm one, but a wrapper that automatically restarts (every other
> userspace for gfx has their own copy of it since it's so trivial).
Let's go ahead and use libdrm - It is important to keep them in sync. Maybe
we can check dependency in the ion Makefile and not compile the test. As long
as the rest of the tests run even when libdrm dependency isn't met, we should
be good.
thanks,
-- Shuah
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
if (ion_info->ionfd > 0)
> close(ion_info->ionfd);
> - printf("<%s>: buffer release successfully\n", __func__);
> }
> }
>
>
Thanks Laura. I will queue this up for 4.17-rc1.
thanks,
-- Shuah
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
On 07/31/2017 01:43 PM, Gustavo Padovan wrote:
> 2017-07-30 Chris Wilson :
>
>> Quoting Gustavo Padovan (2017-07-29 16:22:17)
>>> From: Gustavo Padovan
>>>
>>> We found this bug in the sw_sync so adding a test case to prevent it to
>>> happen in t
Fix to call of_node_put() right after of_drm_find_bridge() instead of
holding on to it until exynos_dsi_remove().
Suggested-by: Inki Dae
Signed-off-by: Shuah Khan
---
drivers/gpu/drm/exynos/exynos_drm_dsi.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm
Hi Inki,
On Sun, Jun 18, 2017 at 8:12 PM, Inki Dae wrote:
> Hi Shuah,
>
> 2017년 06월 17일 05:16에 Shuah Khan 이(가) 쓴 글:
>> On 06/16/2017 08:16 AM, Shuah Khan wrote:
>>> Hi Inki,
>>>
>>> On Fri, Jun 16, 2017 at 1:50 AM, Inki Dae wrote:
>>>>
return mipi_dsi_host_register(&dsi->dsi_host);
> }
> --
> 1.9.1
Looks good to me.
Reviewed-by: Shuah Khan
thanks,
-- Shuah
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Fix exynos_dsi_parse_dt() to return -ENODEV when of_graph_get_remote_node()
doesn't find DSI_PORT_OUT. -ENODEV is the correct error code to return and
this change makes exynos behavior consistent with rest of the drm drivers.
Signed-off-by: Shuah Khan
---
drivers/gpu/drm/exynos/exynos_drm_
On 06/16/2017 08:16 AM, Shuah Khan wrote:
> Hi Inki,
>
> On Fri, Jun 16, 2017 at 1:50 AM, Inki Dae wrote:
>> It doesn't need to try to find a bridge if bridge node doesn't exist.
>>
>> Signed-off-by: Inki Dae
>> ---
>> drivers/gpu/drm/exynos/ex
e_prepare_buf() all have
access to v4l2_buf - void *pb
Would it make it easeir and avoid adding a new parameter all these routines
if we add a vl42-common routine to return the true if
V4L2_BUF_FLAG_NO_CACHE_SYNC is set?
Something along the lines of v4l2_is_no_cache_sync_set()?
thanks,
-- Shuah
&
_REQUEUEING) {
> @@ -1571,6 +1566,10 @@ static void __vb2_dqbuf(struct vb2_buffer *vb)
>
> vb->state = VB2_BUF_STATE_DEQUEUED;
>
> + /* sync buffers */
> + for (i = 0; i < vb->num_planes; ++i)
> + call_void_memop(vb, finish, vb->plan
>vec)
> return;
With the unification dma_sgt is valid for MMAP buffers after vb2_dma_sg_alloc()
if dma_sgt is not null, sync happens - the patch description doesn't seem to be
in sync with the change.
I might be missing something. I think it would help if these two changes ar
On 02/03/2017 01:06 AM, Daniel Vetter wrote:
> On Thu, Feb 02, 2017 at 10:25:44AM -0700, Shuah Khan wrote:
>> On 02/02/2017 01:32 AM, Jani Nikula wrote:
>>> On Thu, 02 Feb 2017, Shuah Khan wrote:
>>>> Change drm_helper_probe_single_connector_modes() to print an
On 02/02/2017 01:32 AM, Jani Nikula wrote:
> On Thu, 02 Feb 2017, Shuah Khan wrote:
>> Change drm_helper_probe_single_connector_modes() to print an error to
>> report connector disconnected status instead of a debug message.
>>
>> When this condition occurs, applic
ke it easier to debug.
Signed-off-by: Shuah Khan
---
drivers/gpu/drm/drm_probe_helper.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_probe_helper.c
b/drivers/gpu/drm/drm_probe_helper.c
index ac953f0..6472b7f 100644
--- a/drivers/gpu/drm/drm_probe_hel
>
> fds.fd = fd;
>
> fds.events = POLLIN;
>
>
>
> do {
>
> ret = poll(&fds, 1, timeout);
>
> if (ret > 0) {
>
> if (fds.revents & (POLLERR | POLLNVAL)) {
>
>errno = EINVAL;
>
>return -1;
>
> }
>
> return 0;
>
> } else if (ret == 0) {
>
> errno = ETIME;
>
> return -1;
>
> }
>
> } while (ret == -1 && (errno == EINTR || errno == EAGAIN));
>
>
>
> return ret;
>
> }
>
>
> Gustavo
>
thanks,
-- Shuah
On 12/01/2016 06:17 PM, Shuah Khan wrote:
> On 10/19/2016 06:49 AM, Emilio López wrote:
>> Hello everyone,
>>
>> This is a series of tests to exercise the sync kernel infrastructure. It is
>> meant to be a test suite for the work Gustavo has been doing to destage
he last test will
> currently fail due to a regression[0].
Hi Emilio,
Thanks. I will apply these to linux-kselftest next for 4.10-rc1
-- Shuah
>
> As usual, all comments are welcome.
>
> Cheers!
> Emilio
>
> [0] https://patchwork.kernel.org/patch/9343347/
>
> E
On 10/25/2016 11:57 AM, Tobias Jakobi wrote:
> Hello Shuah,
>
>
> Shuah Khan wrote:
>> On 10/19/2016 04:27 PM, Shuah Khan wrote:
>>> On 10/19/2016 08:16 AM, Inki Dae wrote:
>>>> Hi Shuah,
>>>>
>>>> 2016-10-13 8:11 GMT+09:00 Shuah Kha
On 10/19/2016 04:27 PM, Shuah Khan wrote:
> On 10/19/2016 08:16 AM, Inki Dae wrote:
>> Hi Shuah,
>>
>> 2016-10-13 8:11 GMT+09:00 Shuah Khan :
>>> Hi Inki,
>>>
>>> On 08/15/2016 10:40 PM, Inki Dae wrote:
>>>
>>>>>
>>>
On 10/19/2016 10:23 AM, Tobias Jakobi wrote:
> Hello Shuah,
>
> just a short note that more misleading comments about default allocation
> flags can be found in libdrm.
>
> https://cgit.freedesktop.org/mesa/drm/tree/exynos/exynos_drm.c
>
> See e.g. the comment for exynos
On 10/19/2016 08:16 AM, Inki Dae wrote:
> Hi Shuah,
>
> 2016-10-13 8:11 GMT+09:00 Shuah Khan :
>> Hi Inki,
>>
>> On 08/15/2016 10:40 PM, Inki Dae wrote:
>>
>>>>
>>>> okay the very first commit that added IOMMU support
>>>> int
an avoid such breaks in the future by keeping kernel and
xf86-video-armsoc in sync.
thanks,
-- Shuah
On 10/12/2016 05:11 PM, Shuah Khan wrote:
+ Fixing Krzysztof Kozlowski address.
> Hi Inki,
>
> On 08/15/2016 10:40 PM, Inki Dae wrote:
>
>>>
>>> okay the very first commit that added IOMMU support
>>> introduced the code that rejects non-contig gem memory
lan?
I can submit a patch to xf86-video-armsoc. I am also looking ahead to
see if we can avoid such breaks in the future by keeping kernel and
xf86-video-armsoc in sync.
thanks,
-- Shuah
On 08/12/2016 11:28 AM, Shuah Khan wrote:
> On 08/10/2016 05:05 PM, Shuah Khan wrote:
>> On 08/10/2016 04:59 PM, Inki Dae wrote:
>>> Hi Shuah,
>>>
>>> 2016ë
08ì 11ì¼ 02:30ì Shuah Khan ì´(ê°) ì´ ê¸:
>>>> Fix exynos_drm_gem_create
On 08/10/2016 05:05 PM, Shuah Khan wrote:
> On 08/10/2016 04:59 PM, Inki Dae wrote:
>> Hi Shuah,
>>
>> 2016ë
08ì 11ì¼ 02:30ì Shuah Khan ì´(ê°) ì´ ê¸:
>>> Fix exynos_drm_gem_create_ioctl() attempts to allocate non-contiguous GEM
>>> memory without
On 08/10/2016 04:59 PM, Inki Dae wrote:
> Hi Shuah,
>
> 2016ë
08ì 11ì¼ 02:30ì Shuah Khan ì´(ê°) ì´ ê¸:
>> Fix exynos_drm_gem_create_ioctl() attempts to allocate non-contiguous GEM
>> memory without IOMMU. In this case, there is no point in attempting to
>
>
start.
Check if non-contiguous GEM memory is requested without IOMMU. If so,
allocate contiguous GEM memory to help display manager start.
Signed-off-by: Shuah Khan
---
drivers/gpu/drm/exynos/exynos_drm_gem.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/drivers/gpu/drm
Fix exynos_drm_gem_create() error messages to include flags and size when
flags and size are invalid.
Signed-off-by: Shuah Khan
---
drivers/gpu/drm/exynos/exynos_drm_gem.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.c
b/drivers
Fix unsupported GEM memory type error message to include the memory type
information.
Signed-off-by: Shuah Khan
---
Changes since v1:
-- Comment changed to read clearly
drivers/gpu/drm/exynos/exynos_drm_fb.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu
On 08/08/2016 10:56 AM, Krzysztof Kozlowski wrote:
> On Fri, Aug 05, 2016 at 07:50:06PM -0600, Shuah Khan wrote:
>> Fix unsupported GEM memory type error message to include the memory type
>> information.
>>
>> Signed-off-by: Shuah Khan
>> ---
>> dri
Fix unsupported GEM memory type error message to include the memory type
information.
Signed-off-by: Shuah Khan
---
drivers/gpu/drm/exynos/exynos_drm_fb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fb.c
b/drivers/gpu/drm/exynos
> err += RUN_TEST(test_fence_wait_on_destroyed_timeline);
> +#endif
It would be useful to have a real define here that can be
enabled later easily instead of if 0.
thanks,
-- Shuah
> err += RUN_TEST(test_stress_two_threads_shared_timeline);
> err
1 - 100 of 126 matches
Mail list logo
