Re: [PATCH] drm/fourcc: Add modifier definition for describing Verisilicon video framebuffer

2024-11-10 Thread Nicolas Dufresne
Hi, I have an update on top of what I've said ealier. Le mercredi 06 novembre 2024 à 14:49 -0500, Nicolas Dufresne a écrit : > Hi, > > Le mercredi 06 novembre 2024 à 16:53 +0100, Benjamin Gaignard a écrit : > > + nicolas > > Thanks for the CC, I'm obviously w

Re: [PATCH] drm/fourcc: Add modifier definition for describing Verisilicon video framebuffer

2024-11-06 Thread Nicolas Dufresne
Hi, Le mercredi 06 novembre 2024 à 16:53 +0100, Benjamin Gaignard a écrit : > + nicolas Thanks for the CC, I'm obviously watching ker...@collabora.com, I don't know why it didn't make it to my mailbox. I'm adding explicitly Lucas and Philipp, as I believe they can provide relevant information he

Re: Requirements to merge new heaps in the kernel

2024-10-22 Thread Nicolas Dufresne
Hi, Le mardi 22 octobre 2024 à 09:19 -0700, John Stultz a écrit : > On Tue, Oct 22, 2024 at 1:38 AM Maxime Ripard wrote: > > > > I wanted to follow-up on the discussion we had at Plumbers with John and > > T.J. about (among other things) adding new heaps to the kernel. > > > > I'm still interes

Re: [PATCH v1 00/10] Add MediaTek ISP7 camera system driver

2024-10-15 Thread Nicolas Dufresne
Hi, Le mercredi 09 octobre 2024 à 19:15 +0800, Shu-hsiang Yang a écrit : > Based on linux-next/master, tag: next-20241008 > > The patch set adds the MediaTek ISP7.x camera system hardware driver. > > This driver sets up ISP hardware, handles interrupts, and initializes > V4L2 device nodes and fu

Re: [PATCH v2 2/2] media: imx: vdic: Introduce mem2mem VDI deinterlacer driver

2024-10-15 Thread Nicolas Dufresne
Le jeudi 03 octobre 2024 à 16:57 +0200, Marek Vasut a écrit : > On 9/26/24 1:16 PM, Philipp Zabel wrote: > > On Mi, 2024-09-25 at 22:45 +0200, Marek Vasut wrote: > > [...] > > > > The driver is not taking ownership of prev_buf, only curr_buf is > > > > guaranteed to > > > > exist until v4l2_m2m_jo

Re: [PATCH v2 2/2] media: imx: vdic: Introduce mem2mem VDI deinterlacer driver

2024-10-15 Thread Nicolas Dufresne
Le mardi 24 septembre 2024 à 17:28 +0200, Marek Vasut a écrit : > On 9/6/24 11:01 AM, Philipp Zabel wrote: > > Hi, > > > > diff --git a/drivers/staging/media/imx/imx-media-dev.c > > > b/drivers/staging/media/imx/imx-media-dev.c > > > index be54dca11465d..a841fdb4c2394 100644 > > > --- a/drivers/

Re: [PATCH v2 2/2] media: imx: vdic: Introduce mem2mem VDI deinterlacer driver

2024-10-15 Thread Nicolas Dufresne
Le lundi 29 juillet 2024 à 04:16 +0200, Marek Vasut a écrit : > On 7/24/24 6:08 PM, Nicolas Dufresne wrote: > > Hi Marek, > > Hi, > > > Le mercredi 24 juillet 2024 à 02:19 +0200, Marek Vasut a écrit : > > > Introduce dedicated memory-to-memory IPUv3 VDI deinter

Re: [Linaro-mm-sig] Re: [RFC PATCH 0/4] Linaro restricted heap

2024-09-27 Thread Nicolas Dufresne
Le jeudi 26 septembre 2024 à 19:22 +0530, Sumit Garg a écrit : > [Resend in plain text format as my earlier message was rejected by > some mailing lists] > > On Thu, 26 Sept 2024 at 19:17, Sumit Garg wrote: > > > > On 9/25/24 19:31, Christian König wrote: > > > > Am 25.09.24 um 14:51 schrieb Dm

Re: [PATCH v2 2/2] media: imx: vdic: Introduce mem2mem VDI deinterlacer driver

2024-09-27 Thread Nicolas Dufresne
Le mercredi 25 septembre 2024 à 22:45 +0200, Marek Vasut a écrit : > On 9/25/24 7:58 PM, Nicolas Dufresne wrote: > > [...] > > > > +static irqreturn_t ipu_mem2mem_vdic_nfb4eof_interrupt(int irq, void > > > *dev_id) > > > +{ > > &g

Re: [PATCH v2 2/2] media: imx: vdic: Introduce mem2mem VDI deinterlacer driver

2024-09-25 Thread Nicolas Dufresne
Hi, Le mercredi 24 juillet 2024 à 02:19 +0200, Marek Vasut a écrit : > Introduce dedicated memory-to-memory IPUv3 VDI deinterlacer driver. > Currently the IPUv3 can operate VDI in DIRECT mode, from sensor to > memory. This only works for single stream, that is, one input from > one camera is deint

Re: [PATCH v2 2/2] media: imx: vdic: Introduce mem2mem VDI deinterlacer driver

2024-07-30 Thread Nicolas Dufresne
Le lundi 29 juillet 2024 à 04:16 +0200, Marek Vasut a écrit : > On 7/24/24 6:08 PM, Nicolas Dufresne wrote: > > Hi Marek, > > Hi, > > > Le mercredi 24 juillet 2024 à 02:19 +0200, Marek Vasut a écrit : > > > Introduce dedicated memory-to-memory IPUv3 VDI deinter

Re: [PATCH v2 2/2] media: imx: vdic: Introduce mem2mem VDI deinterlacer driver

2024-07-24 Thread Nicolas Dufresne
Hi Marek, Le mercredi 24 juillet 2024 à 02:19 +0200, Marek Vasut a écrit : > Introduce dedicated memory-to-memory IPUv3 VDI deinterlacer driver. > Currently the IPUv3 can operate VDI in DIRECT mode, from sensor to > memory. This only works for single stream, that is, one input from > one camera is

Re: [PATCH v5 2/9] scatterlist: Add a flag for the restricted memory

2024-06-28 Thread Nicolas Dufresne
Hi Thierry, Le vendredi 28 juin 2024 à 16:11 +0200, Thierry Reding a écrit : > On Fri, Jun 28, 2024 at 03:21:51PM GMT, mrip...@kernel.org wrote: > > On Fri, Jun 28, 2024 at 01:47:01PM GMT, Thierry Reding wrote: > > > On Thu, Jun 27, 2024 at 04:40:02PM GMT, mrip...@kernel.org wrote: > > > > On Thu,

Re: [PATCH v5 2/9] scatterlist: Add a flag for the restricted memory

2024-06-28 Thread Nicolas Dufresne
Hi, Le jeudi 27 juin 2024 à 16:40 +0200, mrip...@kernel.org a écrit : > > You can trivially say during use hey this buffer is encrypted. > > > > At least that's my 10 mile high view, maybe I'm missing some extensive key > > exchange or something like that. > > That doesn't work in all cases, unf

Re: [PATCH v5 2/9] scatterlist: Add a flag for the restricted memory

2024-06-28 Thread Nicolas Dufresne
Hi Christian, Le jeudi 27 juin 2024 à 08:57 +0200, Christian König a écrit : > Am 27.06.24 um 05:21 schrieb Jason-JH Lin (林睿祥): > > > > On Wed, 2024-06-26 at 19:56 +0200, Daniel Vetter wrote: > > > > > > External email : Please do not click links or open attachments until > > > you have verifi

Re: [PATCH] media: videobuf2: sync caches for dmabuf memory

2024-06-18 Thread Nicolas Dufresne
Le mardi 18 juin 2024 à 16:47 +0900, Tomasz Figa a écrit : > Hi TaoJiang, > > On Tue, Jun 18, 2024 at 4:30 PM TaoJiang wrote: > > > > From: Ming Qian > > > > When the memory type is VB2_MEMORY_DMABUF, the v4l2 device can't know > > whether the dma buffer is coherent or synchronized. > > > > T

Re: [PATCH v6,04/24] v4l: add documentation for restricted memory flag

2024-06-17 Thread Nicolas Dufresne
Le mercredi 12 juin 2024 à 23:25 +0300, Laurent Pinchart a écrit : > On Wed, Jun 12, 2024 at 03:43:58PM -0400, Nicolas Dufresne wrote: > > Le mercredi 12 juin 2024 à 13:37 +0900, Tomasz Figa a écrit : > > > > Why is this flag needed ? Given that the usage model requires the V

Re: [PATCH 6/9] accel/rocket: Add a new driver for Rockchip's NPU

2024-06-14 Thread Nicolas Dufresne
Hi, Le vendredi 14 juin 2024 à 10:16 -0600, Jeffrey Hugo a écrit : > > + version = rocket_read(core, REG_PC_VERSION) + (rocket_read(core, > > REG_PC_VERSION_NUM) & 0x); > > + dev_info(rdev->dev, "Rockchip NPU core %d version: %d\n", core->index, > > version); > > A properly working driv

Re: [PATCH v6,04/24] v4l: add documentation for restricted memory flag

2024-06-12 Thread Nicolas Dufresne
Hi, Le mercredi 12 juin 2024 à 23:25 +0300, Laurent Pinchart a écrit : > On Wed, Jun 12, 2024 at 03:43:58PM -0400, Nicolas Dufresne wrote: > > Le mercredi 12 juin 2024 à 13:37 +0900, Tomasz Figa a écrit : > > > > Why is this flag needed ? Given that the usage mo

Re: [PATCH v6,04/24] v4l: add documentation for restricted memory flag

2024-06-12 Thread Nicolas Dufresne
Hi, Le mercredi 12 juin 2024 à 13:37 +0900, Tomasz Figa a écrit : > > Why is this flag needed ? Given that the usage model requires the V4L2 > > device to be a dma buf importer, why would userspace set the > > V4L2_BUF_CAP_SUPPORTS_RESTRICTED_MEM flag and pass a non-restricted > > buffer to the de

Re: [PATCH v6,15/24] media: mediatek: vcodec: Add one plane format

2024-05-31 Thread Nicolas Dufresne
Le jeudi 16 mai 2024 à 20:20 +0800, Yunfei Dong a écrit : > Adding capture formats to support V4L2_PIX_FMT_MS21. This format has > one plane and only be used for secure video playback at current period. Please, replace "one plane" with "single allocation". This should disambiguate the message a li

Re: [PATCH v6,14/24] media: mediatek: vcodec: Add capture format to support one plane memory

2024-05-31 Thread Nicolas Dufresne
Hi, Le jeudi 23 mai 2024 à 18:36 +0800, Chen-Yu Tsai a écrit : > On Thu, May 23, 2024 at 6:14 PM Andrzej Pietrasiewicz > wrote: > > > > Hi, > > > > I'm having second thoughts, please see inline, > > > > W dniu 22.05.2024 o 14:26, Andrzej Pietrasiewicz pisze: > > > Hi Yunfei, > > > > > > W dni

Re: Safety of opening up /dev/dma_heap/* to physically present users (udev uaccess tag) ?

2024-05-22 Thread Nicolas Dufresne
Le jeudi 16 mai 2024 à 14:20 +0300, Laurent Pinchart a écrit : > On Thu, May 16, 2024 at 07:00:31AM +, Simon Ser wrote: > > On Tuesday, May 14th, 2024 at 22:42, Laurent Pinchart wrote: > > > > > My experience on Arm platforms is that the KMS drivers offer allocation > > > for scanout buffers,

Re: Safety of opening up /dev/dma_heap/* to physically present users (udev uaccess tag) ?

2024-05-21 Thread nicolas . dufresne
Le mardi 21 mai 2024 à 10:43 +0200, Maxime Ripard a écrit : > On Thu, May 16, 2024 at 01:11:51PM GMT, > nicolas.dufre...@collabora.corp-partner.google.com wrote: > > Le jeudi 16 mai 2024 à 14:27 +0300, Laurent Pinchart a écrit : > > > Hi Nicolas, > > > > > > On Wed, May 15, 2024 at 01:43:58PM -04

Re: Safety of opening up /dev/dma_heap/* to physically present users (udev uaccess tag) ?

2024-05-16 Thread nicolas . dufresne
Le jeudi 16 mai 2024 à 14:27 +0300, Laurent Pinchart a écrit : > Hi Nicolas, > > On Wed, May 15, 2024 at 01:43:58PM -0400, > nicolas.dufre...@collabora.corp-partner.google.com wrote: > > Le mardi 14 mai 2024 à 23:42 +0300, Laurent Pinchart a écrit : > > > > You'll hit the same limitation as we hi

Re: Safety of opening up /dev/dma_heap/* to physically present users (udev uaccess tag) ?

2024-05-15 Thread nicolas . dufresne
Le mardi 14 mai 2024 à 23:42 +0300, Laurent Pinchart a écrit : > > You'll hit the same limitation as we hit in GStreamer, which is that KMS > > driver > > only offer allocation for render buffers and most of them are missing > > allocators > > for YUV buffers, even though they can import in these

Re: Safety of opening up /dev/dma_heap/* to physically present users (udev uaccess tag) ?

2024-05-14 Thread Nicolas Dufresne
Hi, Le mardi 14 mai 2024 à 23:45 +0300, Laurent Pinchart a écrit : > > And finally, none of this fixes the issue that the heap allocation are not > > being > > accounted properly and allow of an easy memory DoS. So uaccess should be > > granted > > with care, meaning that defaulting a "desktop"

Re: [PATCH v7 7/8] media: imagination: Round to closest multiple for cropping region

2024-05-14 Thread Nicolas Dufresne
Le samedi 11 mai 2024 à 22:38 +0530, Devarsh Thakkar a écrit : > Hi Andy, > > Thanks for the quick review. > On 10/05/24 20:40, Andy Shevchenko wrote: > > On Fri, May 10, 2024 at 12:10:01AM +0530, Devarsh Thakkar wrote: > > > If neither of the flags to round down (V4L2_SEL_FLAG_LE) or round up > >

Re: Safety of opening up /dev/dma_heap/* to physically present users (udev uaccess tag) ?

2024-05-13 Thread Nicolas Dufresne
Le lundi 13 mai 2024 à 11:34 +0300, Laurent Pinchart a écrit : > On Mon, May 13, 2024 at 10:29:22AM +0200, Maxime Ripard wrote: > > On Wed, May 08, 2024 at 10:36:08AM +0200, Daniel Vetter wrote: > > > On Tue, May 07, 2024 at 04:07:39PM -0400, Nicolas Dufresne wrote: > > >

Re: Safety of opening up /dev/dma_heap/* to physically present users (udev uaccess tag) ?

2024-05-13 Thread Nicolas Dufresne
Le lundi 13 mai 2024 à 15:51 +0200, Maxime Ripard a écrit : > On Mon, May 13, 2024 at 09:42:00AM -0400, Nicolas Dufresne wrote: > > Le lundi 13 mai 2024 à 10:29 +0200, Maxime Ripard a écrit : > > > On Wed, May 08, 2024 at 10:36:08AM +0200, Daniel Vetter wrote: > > > >

Re: Safety of opening up /dev/dma_heap/* to physically present users (udev uaccess tag) ?

2024-05-13 Thread Nicolas Dufresne
Le lundi 13 mai 2024 à 10:29 +0200, Maxime Ripard a écrit : > On Wed, May 08, 2024 at 10:36:08AM +0200, Daniel Vetter wrote: > > On Tue, May 07, 2024 at 04:07:39PM -0400, Nicolas Dufresne wrote: > > > Hi, > > > > > > Le mardi 07 mai 2024 à 21:36 +0300, Lauren

Re: Safety of opening up /dev/dma_heap/* to physically present users (udev uaccess tag) ?

2024-05-07 Thread Nicolas Dufresne
Hi, Le mardi 07 mai 2024 à 21:36 +0300, Laurent Pinchart a écrit : > Shorter term, we have a problem to solve, and the best option we have > found so far is to rely on dma-buf heaps as a backend for the frame > buffer allocatro helper in libcamera for the use case described above. > This won't wor

Re: [PATCH v5 1/9] drm/mediatek/uapi: Add DRM_MTK_GEM_CREATE_ENCRYPTED flag

2024-04-16 Thread Nicolas Dufresne
Hi, Le mercredi 03 avril 2024 à 18:26 +0800, Shawn Sung a écrit : > From: "Jason-JH.Lin" > > Add DRM_MTK_GEM_CREATE_ENCRYPTED flag to allow user to allocate Is "ENCRYPTED" a proper naming ? My expectation is that this would hold data in a PROTECTED memory region but that no cryptographic algori

Re: [PATCH 1/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-03-07 Thread Nicolas Dufresne
Le jeudi 29 février 2024 à 10:02 +0100, Maxime Ripard a écrit : > Hi Helen, > > Thanks for working on this > > On Wed, Feb 28, 2024 at 07:55:25PM -0300, Helen Koike wrote: > > This patch introduces a `.gitlab-ci` file along with a `ci/` folder, > > defininga basic test pipeline triggered by code

Re: [PATCH 0/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-02-29 Thread Nicolas Dufresne
Hi, Le jeudi 29 février 2024 à 16:16 +0200, Nikolai Kondrashov a écrit : > On 2/29/24 2:20 PM, Guillaume Tucker wrote: > > Hello, > > > > On 28/02/2024 23:55, Helen Koike wrote: > > > Dear Kernel Community, > > > > > > This patch introduces a `.gitlab-ci` file along with a `ci/` folder, > > > d

Re: [PATCH 1/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-02-29 Thread Nicolas Dufresne
Hi Tim, just replying below to one of your comment which I happen to be involved in, but I'll let others reply for the more specific comments. Le jeudi 29 février 2024 à 02:44 +, Bird, Tim a écrit : > > -Original Message- > > From: Helen Koike > > > > > > Hey all, > > > > You

Re: [PATCH v3,04/21] v4l: add documentation for secure memory flag

2024-01-17 Thread Nicolas Dufresne
Hi, Le mercredi 06 décembre 2023 à 16:15 +0800, Yunfei Dong a écrit : > From: Jeffrey Kardatzke > > Adds documentation for V4L2_MEMORY_FLAG_SECURE. As I noticed from DMA Heap discussions, shall this also be renamed SECURE -> RESTRICTED ? regards, Nicolas > > Signed-off-by: Jeffrey Kardatzke

Re: [PATCH 3/9] dma-heap: Provide accessors so that in-kernel drivers can allocate dmabufs from specific heaps

2023-09-12 Thread Nicolas Dufresne
Le mardi 12 septembre 2023 à 08:47 +, Yong Wu (吴勇) a écrit : > On Mon, 2023-09-11 at 12:12 -0400, Nicolas Dufresne wrote: > > > > External email : Please do not click links or open attachments until > > you have verified the sender or the content. > > Hi, >

Re: [PATCH 3/9] dma-heap: Provide accessors so that in-kernel drivers can allocate dmabufs from specific heaps

2023-09-12 Thread Nicolas Dufresne
Le mardi 12 septembre 2023 à 16:46 +0200, Christian König a écrit : > Am 12.09.23 um 10:52 schrieb Yong Wu (吴勇): > > [SNIP] > > > But what we should try to avoid is that newly merged drivers provide > > > both a driver specific UAPI and DMA-heaps. The justification that > > > this > > > makes it ea

Re: [PATCH 3/9] dma-heap: Provide accessors so that in-kernel drivers can allocate dmabufs from specific heaps

2023-09-12 Thread Nicolas Dufresne
Le lundi 11 septembre 2023 à 12:13 +0200, Christian König a écrit : > Am 11.09.23 um 04:30 schrieb Yong Wu: > > From: John Stultz > > > > This allows drivers who don't want to create their own > > DMA-BUF exporter to be able to allocate DMA-BUFs directly > > from existing DMA-BUF Heaps. > > > >

Re: [PATCH 3/9] dma-heap: Provide accessors so that in-kernel drivers can allocate dmabufs from specific heaps

2023-09-11 Thread Nicolas Dufresne
Hi, Le lundi 11 septembre 2023 à 10:30 +0800, Yong Wu a écrit : > From: John Stultz > > This allows drivers who don't want to create their own > DMA-BUF exporter to be able to allocate DMA-BUFs directly > from existing DMA-BUF Heaps. > > There is some concern that the premise of DMA-BUF heaps i

Re: [RFC]: shmem fd for non-DMA buffer sharing cross drivers

2023-08-22 Thread Nicolas Dufresne
Hi, Le mardi 22 août 2023 à 19:14 +0800, Hsia-Jun Li a écrit : > Hello > > I would like to introduce a usage of SHMEM slimier to DMA-buf, the major > purpose of that is sharing metadata or just a pure container for cross > drivers. > > We need to exchange some sort of metadata between drivers,

Re: [v2] media: mediatek: vcodec: fix AV1 decode fail for 36bit iova

2023-08-02 Thread Nicolas Dufresne
. > > Fixes: 2f5d0aef37c6 ("media: mediatek: vcodec: support stateless AV1 decoder") > Signed-off-by: Xiaoyong Lu With some rework of the commit message, see my suggestions above: Reviewed-by: Nicolas Dufresne > --- > Changes from v1 > > - prefer '|' rather

Re: [PATCH 3/9] drm/verisilicon: Add basic drm driver

2023-07-13 Thread Nicolas Dufresne
Le samedi 08 juillet 2023 à 21:11 +0200, Thomas Zimmermann a écrit : > Hi > > Am 07.07.23 um 20:09 schrieb Nicolas Dufresne: > [...] > > > > +config DRM_VERISILICON > > > > + tristate "DRM Support for VeriSilicon" > > > > &g

Re: [PATCH 3/9] drm/verisilicon: Add basic drm driver

2023-07-07 Thread Nicolas Dufresne
Hi Thomas, Le lundi 19 juin 2023 à 14:59 +0200, Thomas Zimmermann a écrit : > Hi, > > I appreciate that you split the driver into small patches. Please find > some comments below. > > Am 02.06.23 um 09:40 schrieb Keith Zhao: > > Add a basic platform driver of the DRM driver for JH7110 SoC. > >

Re: media: mediatek: vcodec: fix AV1 decode fail for 36bit iova

2023-06-28 Thread Nicolas Dufresne
Hi, Le mercredi 28 juin 2023 à 13:41 +0800, Xiaoyong Lu a écrit : > Decoder hardware will access incorrect iova address when tile buffer is > 36bit, leading to iommu fault when hardware access dram data. > > Fixes: 2f5d0aef37c6 ("media: mediatek: vcodec: support stateless AV1 decoder") > Signed-o

Re: [RFC PATCH v8] media: mediatek: vcodec: support stateless AV1 decoder

2023-03-31 Thread Nicolas Dufresne
you still have to pull the uAPI of course). > > Signed-off-by: Xiaoyong Lu Tested-by: Nicolas Dufresne Reviewed-by: Nicolas Dufresne > --- > Changes from v7: Please, don't forget to include your fluster test result here too. Fluster has 3 test suites, you should provide the s

Re: [PATCH v3 2/7] media: Add Y210, Y212 and Y216 formats

2023-02-24 Thread Nicolas Dufresne
Le jeudi 23 février 2023 à 15:10 +0200, Tomi Valkeinen a écrit : > Hi, > > On 22/02/2023 17:28, Nicolas Dufresne wrote: > > Hi Tomi, > > > > Le mercredi 21 décembre 2022 à 11:24 +0200, Tomi Valkeinen a écrit : > > > Add Y210, Y212 and Y216 formats. > &

Re: [PATCH v3 2/7] media: Add Y210, Y212 and Y216 formats

2023-02-22 Thread Nicolas Dufresne
Hi Tomi, Le mercredi 21 décembre 2022 à 11:24 +0200, Tomi Valkeinen a écrit : > Add Y210, Y212 and Y216 formats. > > Signed-off-by: Tomi Valkeinen > --- > .../media/v4l/pixfmt-packed-yuv.rst | 49 ++- > drivers/media/v4l2-core/v4l2-ioctl.c | 3 ++ > include/u

Re: Try to address the DMA-buf coherency problem

2022-12-06 Thread Nicolas Dufresne
Le lundi 05 décembre 2022 à 09:28 +0100, Christian König a écrit : > Hi Tomasz, > > Am 05.12.22 um 07:41 schrieb Tomasz Figa: > > [SNIP] > > > In other words explicit ownership transfer is not something we would > > > want as requirement in the framework, cause otherwise we break tons of > > > use

Re: [PATCH 2/7] media: Add Y210, Y212 and Y216 formats

2022-12-06 Thread Nicolas Dufresne
Hi, Le mardi 06 décembre 2022 à 15:39 +0200, Tomi Valkeinen a écrit : > Add Y210, Y212 and Y216 formats. > > Signed-off-by: Tomi Valkeinen This patch is simply missing an update to: Documentation/userspace-api/media/v4l/yuv-formats.rst regards, Nicolas > --- > drivers/media/v4l2-core/v4l2-i

Re: [PATCH 1/7] media: Add 2-10-10-10 RGB formats

2022-12-06 Thread Nicolas Dufresne
Hi, Le mardi 06 décembre 2022 à 15:39 +0200, Tomi Valkeinen a écrit : > Add XBGR2101010, ABGR2101010 and BGRA1010102 formats. > > Signed-off-by: Tomi Valkeinen This patch is simply missing an update to Documentation/userspace-api/media/v4l/pixfmt-rgb.rst regards, Nicolas > --- > drivers/med

Re: Try to address the DMA-buf coherency problem

2022-11-25 Thread Nicolas Dufresne
Le mercredi 23 novembre 2022 à 17:33 +0100, Daniel Vetter a écrit : > On Wed, Nov 23, 2022 at 10:33:38AM +0200, Pekka Paalanen wrote: > > On Tue, 22 Nov 2022 18:33:59 +0100 > > Christian König wrote: > > > > > We should have come up with dma-heaps earlier and make it clear that > > > exporting a

Re: Try to address the DMA-buf coherency problem

2022-11-19 Thread Nicolas Dufresne
Le vendredi 18 novembre 2022 à 11:32 -0800, Rob Clark a écrit : > On Thu, Nov 17, 2022 at 7:38 AM Nicolas Dufresne wrote: > > > > Le jeudi 17 novembre 2022 à 13:10 +0100, Christian König a écrit : > > > > > DMA-Buf let's the exporter setup the DMA addres

Re: Try to address the DMA-buf coherency problem

2022-11-17 Thread Nicolas Dufresne
Le jeudi 17 novembre 2022 à 13:10 +0100, Christian König a écrit : > > > DMA-Buf let's the exporter setup the DMA addresses the importer uses to > > > be able to directly decided where a certain operation should go. E.g. we > > > have cases where for example a P2P write doesn't even go to memory, b

Re: Try to address the DMA-buf coherency problem

2022-11-04 Thread Nicolas Dufresne
Le vendredi 04 novembre 2022 à 10:03 +0100, Christian König a écrit : > Am 03.11.22 um 23:16 schrieb Nicolas Dufresne: > > [SNIP] > > > > Was there APIs suggested to actually make it manageable by userland to > > allocate > > from the GPU? Yes, this what Linux

Re: Try to address the DMA-buf coherency problem

2022-11-03 Thread Nicolas Dufresne
Le mercredi 02 novembre 2022 à 12:18 +0100, Christian König a écrit : > Am 01.11.22 um 22:09 schrieb Nicolas Dufresne: > > [SNIP] > > > > But the client is just a video player. It doesn't understand how to > > > > allocate BOs for Panfrost or

Re: Try to address the DMA-buf coherency problem

2022-11-01 Thread Nicolas Dufresne
Le mardi 01 novembre 2022 à 18:40 +0100, Christian König a écrit : > Am 28.10.22 um 20:47 schrieb Daniel Stone: > > Hi Christian, > > > > On Fri, 28 Oct 2022 at 18:50, Christian König > > wrote: > > > Am 28.10.22 um 17:46 schrieb Nicolas Dufresne: > > &

Re: Try to address the DMA-buf coherency problem

2022-10-28 Thread Nicolas Dufresne
Hi, just dropping some real live use case, sorry I'm not really proposing solutions, I believe you are much more knowledgeable in this regard. Le vendredi 28 octobre 2022 à 16:26 +0200, Christian König a écrit : > Am 28.10.22 um 13:42 schrieb Lucas Stach: > > Am Freitag, dem 28.10.2022 um 10:40 +

Re: [PATCH 2/2] [WIP]: media: Add Synaptics compressed tiled format

2022-08-24 Thread Nicolas Dufresne
Le vendredi 19 août 2022 à 23:44 +0800, Hsia-Jun Li a écrit : > > On 8/19/22 23:28, Nicolas Dufresne wrote: > > CAUTION: Email originated externally, do not click links or open > > attachments unless you recognize the sender and know the content is safe. > > > >

Re: [PATCH 2/2] [WIP]: media: Add Synaptics compressed tiled format

2022-08-24 Thread Nicolas Dufresne
Le jeudi 18 août 2022 à 14:33 +0800, Hsia-Jun Li a écrit : > > On 8/18/22 14:06, Tomasz Figa wrote: > > CAUTION: Email originated externally, do not click links or open > > attachments unless you recognize the sender and know the content is safe. > > > > > > Hi Randy, > > > > On Tue, Aug 9, 20

Re: [PATCH 2/2] [WIP]: media: Add Synaptics compressed tiled format

2022-08-23 Thread Nicolas Dufresne
gt; On Sat, Aug 20, 2022 at 12:44 AM Hsia-Jun Li wrote: > > > > > > > > > > > > On 8/19/22 23:28, Nicolas Dufresne wrote: > > > > CAUTION: Email originated externally, do not click links or open > > > > attachments unless you recognize

Re: [PATCH 2/2] [WIP]: media: Add Synaptics compressed tiled format

2022-08-23 Thread Nicolas Dufresne
Le mardi 23 août 2022 à 15:40 +0800, Hsia-Jun Li a écrit : > > In current state, If your driver can support it, userland does not strictly > > need > > to re-allocate if the resolution is changed to smaller. In most SVC > > scenarios, > > the largest resolution is known in advance, so pre-allocatio

Re: [PATCH 2/2] [WIP]: media: Add Synaptics compressed tiled format

2022-08-22 Thread Nicolas Dufresne
Le samedi 20 août 2022 à 08:10 +0800, Hsia-Jun Li a écrit : > > On 8/20/22 03:17, Nicolas Dufresne wrote: > > CAUTION: Email originated externally, do not click links or open > > attachments unless you recognize the sender and know the content is safe. > > > > >

Re: [PATCH 2/2] [WIP]: media: Add Synaptics compressed tiled format

2022-08-19 Thread Nicolas Dufresne
Le vendredi 19 août 2022 à 02:13 +0300, Laurent Pinchart a écrit : > On Thu, Aug 18, 2022 at 02:33:42PM +0800, Hsia-Jun Li wrote: > > On 8/18/22 14:06, Tomasz Figa wrote: > > > On Tue, Aug 9, 2022 at 1:28 AM Hsia-Jun Li wrote: > > > > > > > > From: "Hsia-Jun(Randy) Li" > > > > > > > > The most

Re: [EXT] Re: [PATCH 1/3] dma-buf: heaps: add Linaro secure dmabuf heap support

2022-08-19 Thread Nicolas Dufresne
gt; Cc: sumit.sem...@linaro.org; linux-ker...@vger.kernel.org; > linaro-mm-...@lists.linaro.org; christian.koe...@amd.com; > linux-me...@vger.kernel.org; n...@arm.com; Clément Faure > ; dri-devel@lists.freedesktop.org; > benjamin.gaign...@collabora.com > Subject: Re: [EXT] R

Re: [EXT] Re: [PATCH 1/3] dma-buf: heaps: add Linaro secure dmabuf heap support

2022-08-17 Thread Nicolas Dufresne
Hi Folks, Le mardi 16 août 2022 à 11:20 +, Olivier Masse a écrit : > Hi Brian, > > > On ven., 2022-08-12 at 17:39 +0100, Brian Starkey wrote: > > Caution: EXT Ema > > [...] > > > > Interesting, that's not how the devices I've worked on operated. > > > > Are you saying that you have to h

Re: [PATCH 3/5] dma-buf: heaps: add Linaro secure dmabuf heap support

2022-08-16 Thread Nicolas Dufresne
Hi, Le mardi 02 août 2022 à 11:58 +0200, Olivier Masse a écrit : > add Linaro secure heap bindings: linaro,secure-heap Just a curiosity, how is this specific to Linaro OPTEE OS ? Shouldn't it be "de- linaro-ified" somehow ? regards, Nicolas > use genalloc to allocate/free buffer from buffer poo

Re: DMA-buf and uncached system memory

2022-06-27 Thread Nicolas Dufresne
Le lundi 27 juin 2022 à 16:06 +0200, Lucas Stach a écrit : > Am Montag, dem 27.06.2022 um 09:54 -0400 schrieb Nicolas Dufresne: > > Le jeudi 23 juin 2022 à 11:33 +0200, Lucas Stach a écrit : > > > > > > > > See for example on AMD/Intel hardware most of the engines

Re: DMA-buf and uncached system memory

2022-06-27 Thread Nicolas Dufresne
Le jeudi 23 juin 2022 à 11:33 +0200, Lucas Stach a écrit : > > > > See for example on AMD/Intel hardware most of the engines can perfectly > > deal with cache coherent memory accesses. Only the display engines can't. > > > > So on import time we can't even say if the access can be coherent and

Re: DMA-buf and uncached system memory

2022-06-27 Thread Nicolas Dufresne
Hi, Le jeudi 23 juin 2022 à 10:58 +0200, Lucas Stach a écrit : > > > In the DMA API keeping things mapped is also a valid use-case, but then > > > you need to do explicit domain transfers via the dma_sync_* family, > > > which DMA-buf has not inherited. Again those sync are no-ops on cache > > > c

Re: DMA-buf and uncached system memory

2022-06-22 Thread Nicolas Dufresne
Le mardi 16 février 2021 à 10:25 +0100, Daniel Vetter a écrit : > So I think if AMD also guarantees to drop clean cachelines just do the > same thing we do right now for intel integrated + discrete amd, but in > reserve. It's fragile, but it does work. Sorry to disrupt, but if you pass V4L2 vmallo

Re: DMA-buf and uncached system memory

2022-06-21 Thread Nicolas Dufresne
Hi Christian and Andy, Le mardi 21 juin 2022 à 12:34 +0200, Christian König a écrit : >  Hi Andy, >   >  Am 21.06.22 um 12:17 schrieb Andy.Hsieh: >   > > On 2/16/21 4:39 AM, Nicolas Dufresne wrote: > > > Le lundi 15 février 2021 à 09:58 +0100, Christian Köni

Re: [PATCH v7, 04/15] media: mtk-vcodec: Read max resolution from dec_capability

2022-06-21 Thread Nicolas Dufresne
Le vendredi 17 juin 2022 à 14:46 +0800, Chen-Yu Tsai a écrit : > Hi, > > On Mon, Feb 28, 2022 at 04:29:15PM -0500, Nicolas Dufresne wrote: > > Hi Yunfei, > > > > this patch does not work unless userland calls enum_framesizes, which is > > completely optional.

Re: [PATCH v4, 0/3] add h264 decoder driver for mt8186

2022-06-21 Thread Nicolas Dufresne
Le mercredi 15 juin 2022 à 19:37 +0800, yunfei.d...@mediatek.com a écrit : > Hi Nicolas, > > Thanks for your comments. > On Mon, 2022-06-13 at 16:10 -0400, Nicolas Dufresne wrote: > > > > > > Le jeudi 12 mai 2022 à 11:46 +0800, Yunfei Dong a écrit : > >

Re: [PATCH v4, 3/3] media: mediatek: vcodec: add h264 decoder driver for mt8186

2022-06-21 Thread Nicolas Dufresne
Le mercredi 15 juin 2022 à 19:33 +0800, yunfei.d...@mediatek.com a écrit : > Hi Nicolas, > > Thanks for your comments. > On Mon, 2022-06-13 at 16:08 -0400, Nicolas Dufresne wrote: > > Le jeudi 12 mai 2022 à 11:46 +0800, Yunfei Dong a écrit : > > > Add h264 decode driver

Re: [PATCH] media: mediatek: vcodec: Initialize decoder parameters after getting dec_capability

2022-06-21 Thread Nicolas Dufresne
Hi Yunfei, Le samedi 18 juin 2022 à 15:29 +0800, Yunfei Dong a écrit : > Need to get dec_capability from scp first, then initialize decoder > supported format and other parameters according to dec_capability value. Perhaps something to improve in the future. On top of describing the fix, it could

Re: [PATCH v4, 0/3] add h264 decoder driver for mt8186

2022-06-14 Thread Nicolas Dufresne
Le lundi 13 juin 2022 à 16:10 -0400, Nicolas Dufresne a écrit : > Le jeudi 12 mai 2022 à 11:46 +0800, Yunfei Dong a écrit : > > Firstly, add mt8186 compatible and private data, then add document for > > compatible "mediatek,mt8186-vcodec-dec". For mt8186 is single core

Re: [PATCH v4, 0/3] add h264 decoder driver for mt8186

2022-06-13 Thread Nicolas Dufresne
Le jeudi 12 mai 2022 à 11:46 +0800, Yunfei Dong a écrit : > Firstly, add mt8186 compatible and private data, then add document for > compatible "mediatek,mt8186-vcodec-dec". For mt8186 is single core > architecture, need to add new interface for h264 hardware decoder. Would be nice to take the hab

Re: [PATCH v4, 3/3] media: mediatek: vcodec: add h264 decoder driver for mt8186

2022-06-13 Thread Nicolas Dufresne
Le jeudi 12 mai 2022 à 11:46 +0800, Yunfei Dong a écrit : > Add h264 decode driver to support mt8186. For the architecture > is single core, need to add new interface to decode. > > Signed-off-by: Yunfei Dong > --- > .../vcodec/vdec/vdec_h264_req_multi_if.c | 177 +- > 1 fil

Re: [PATCH v7 0/6] Proposal for a GPU cgroup controller

2022-05-12 Thread Nicolas Dufresne
Le mercredi 11 mai 2022 à 13:31 -0700, T.J. Mercier a écrit : > On Wed, May 11, 2022 at 6:21 AM Nicolas Dufresne wrote: > > > > Hi, > > > > Le mardi 10 mai 2022 à 23:56 +, T.J. Mercier a écrit : > > > This patch series revisits the proposal for a GPU

Re: [PATCH v7 0/6] Proposal for a GPU cgroup controller

2022-05-11 Thread Nicolas Dufresne
Hi, Le mardi 10 mai 2022 à 23:56 +, T.J. Mercier a écrit : > This patch series revisits the proposal for a GPU cgroup controller to > track and limit memory allocations by various device/allocator > subsystems. The patch series also contains a simple prototype to > illustrate how Android inten

Re: [PATCH v8, 00/15] media: mtk-vcodec: support for M8192 decoder

2022-04-13 Thread Nicolas Dufresne
Le mercredi 13 avril 2022 à 09:57 +0200, AngeloGioacchino Del Regno a écrit : > Il 13/04/22 09:03, allen-kh.cheng ha scritto: > > Hi Nicolas, > > > > On Tue, 2022-04-12 at 10:48 -0400, Nicolas Dufresne wrote: > > > Le lundi 11 avril 2022 à 11:41 +0800, yunfei.d

Re: [PATCH v8, 00/15] media: mtk-vcodec: support for M8192 decoder

2022-04-12 Thread Nicolas Dufresne
Le lundi 11 avril 2022 à 11:41 +0800, yunfei.d...@mediatek.com a écrit : > Hi Nicolas, > > On Thu, 2022-03-31 at 16:48 -0400, Nicolas Dufresne wrote: > > Hi Yunfei, > > > > thanks for the update, I should be testing this really soon. > > > > Le jeudi 31

Re: [PATCH v8, 16/17] media: mediatek: vcodec: support stateless VP9 decoding

2022-04-07 Thread Nicolas Dufresne
Le mercredi 06 avril 2022 à 15:23 -0400, Nicolas Dufresne a écrit : > Hi Yunfei, > > Le jeudi 31 mars 2022 à 10:48 +0800, Yunfei Dong a écrit : > > Add support for VP9 decoding using the stateless API, > > as supported by MT8192. And the drivers is lat and core architecture

Re: [PATCH v8, 16/17] media: mediatek: vcodec: support stateless VP9 decoding

2022-04-07 Thread Nicolas Dufresne
Le jeudi 31 mars 2022 à 10:48 +0800, Yunfei Dong a écrit : > Add support for VP9 decoding using the stateless API, > as supported by MT8192. And the drivers is lat and core architecture. > > Signed-off-by: George Sun > Signed-off-by: Xiaoyong Lu > Signed-off-by: Yunfei Dong > Reviewed-by: Angel

Re: [PATCH v8, 16/17] media: mediatek: vcodec: support stateless VP9 decoding

2022-04-06 Thread Nicolas Dufresne
Hi Yunfei, Le jeudi 31 mars 2022 à 10:48 +0800, Yunfei Dong a écrit : > Add support for VP9 decoding using the stateless API, > as supported by MT8192. And the drivers is lat and core architecture. > > Signed-off-by: George Sun > Signed-off-by: Xiaoyong Lu > Signed-off-by: Yunfei Dong > Review

Re: [PATCH] media: mediatek: vcodec: Fix v4l2 compliance decoder cmd test fail

2022-04-06 Thread Nicolas Dufresne
27;t use decoder cmd. > > Fixes: 8cdc3794b2e3 ("media: mtk-vcodec: vdec: support stateless API") > Signed-off-by: Yunfei Dong > Reviewed-by: AngeloGioacchino Del Regno > Acked-by: Nicolas Dufresne > --- > changes compared with v2: > - add reviewed

Re: [PATCH v8, 00/15] media: mtk-vcodec: support for M8192 decoder

2022-03-31 Thread Nicolas Dufresne
Hi Yunfei, thanks for the update, I should be testing this really soon. Le jeudi 31 mars 2022 à 10:47 +0800, Yunfei Dong a écrit : > This series adds support for mt8192 h264/vp8/vp9 decoder drivers. Firstly, > refactor > power/clock/interrupt interfaces for mt8192 is lat and core architecture.

Re: [PATCH v7, 15/15] media: mtk-vcodec: support stateless VP9 decoding

2022-03-01 Thread Nicolas Dufresne
Le mercredi 23 février 2022 à 11:40 +0800, Yunfei Dong a écrit : > Add support for VP9 decoding using the stateless API, > as supported by MT8192. And the drivers is lat and core architecture. You already have a reviewed tag, but I'm under the impression that there is a fair amount of duplication

Re: [PATCH v7, 14/15] media: mtk-vcodec: support stateless VP8 decoding

2022-03-01 Thread Nicolas Dufresne
o much code, I'll give you my: Reviewed-by: Nicolas Dufresne > > Signed-off-by: Yunfei Dong > --- > drivers/media/platform/mtk-vcodec/Makefile| 1 + > .../mtk-vcodec/mtk_vcodec_dec_stateless.c | 24 +- > .../platform/mtk-vcodec/mtk_vcodec_drv.h |

Re: [PATCH v7, 13/15] media: mtk-vcodec: support stateless H.264 decoding for mt8192

2022-03-01 Thread Nicolas Dufresne
Le mercredi 23 février 2022 à 11:40 +0800, Yunfei Dong a écrit : > Adds h264 lat and core architecture driver for mt8192, > and the decode mode is frame based for stateless decoder. > > Signed-off-by: Yunfei Dong > --- > drivers/media/platform/mtk-vcodec/Makefile| 1 + > .../mtk-vcodec/vde

Re: [PATCH v7, 12/15] media: mtk-vcodec: Extract H264 common code

2022-03-01 Thread Nicolas Dufresne
Le mercredi 23 février 2022 à 11:40 +0800, Yunfei Dong a écrit : > Mt8192 can use some of common code with mt8183. Moves them to > a new file in order to reuse. With the documentation fixed as per my comments below, you can add: Reviewed-by: Nicolas Dufresne > > Signed-off-by:

Re: [PATCH v7, 09/15] media: mtk-vcodec: disable vp8 4K capability

2022-03-01 Thread Nicolas Dufresne
Le mercredi 23 février 2022 à 11:40 +0800, Yunfei Dong a écrit : > For vp8 not support 4K, need to disable it. This patch will need to be changed after you have moved this code into the proper ioctl. > > Signed-off-by: Yunfei Dong > --- > drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 3

Re: [PATCH v7, 06/15] media: mtk-vcodec: Refactor get and put capture buffer flow

2022-03-01 Thread Nicolas Dufresne
Le mercredi 23 février 2022 à 11:39 +0800, Yunfei Dong a écrit : > For lat and core decode in parallel, need to get capture buffer > when core start to decode and put capture buffer to display > list when core decode done. > > Signed-off-by: Yunfei Dong > --- > .../mtk-vcodec/mtk_vcodec_dec_stat

Re: [PATCH v7, 05/15] media: mtk-vcodec: Call v4l2_m2m_set_dst_buffered() set capture buffer buffered

2022-03-01 Thread Nicolas Dufresne
Le mercredi 23 février 2022 à 11:39 +0800, Yunfei Dong a écrit : > lat thread: output queue \ >-> lat hardware -> lat trans buffer > lat trans buffer / > > core thread: capture queue \ > ->core hardware -> captur

Re: [PATCH v7, 03/15] media: mtk-vcodec: get capture queue buffer size from scp

2022-03-01 Thread Nicolas Dufresne
Thanks for your patch, though perhaps it could be improved, see comment below. Le mercredi 23 février 2022 à 11:39 +0800, Yunfei Dong a écrit : > Different capture buffer format has different buffer size, need to get > real buffer size according to buffer type from scp. > > Signed-off-by: Yunfei

Re: [PATCH v7, 07/15] media: mtk-vcodec: Refactor supported vdec formats and framesizes

2022-03-01 Thread Nicolas Dufresne
Le mercredi 23 février 2022 à 11:40 +0800, Yunfei Dong a écrit : > Supported output and capture format types for mt8192 are different > with mt8183. Needs to get format types according to decoder capability. This patch is both refactoring and changing the behaviour. Can you please split the non-fu

Re: [PATCH v7, 04/15] media: mtk-vcodec: Read max resolution from dec_capability

2022-02-28 Thread Nicolas Dufresne
Hi Yunfei, this patch does not work unless userland calls enum_framesizes, which is completely optional. See comment and suggestion below. Le mercredi 23 février 2022 à 11:39 +0800, Yunfei Dong a écrit : > Supported max resolution for different platforms are not the same: 2K > or 4K, getting it a

Re: [PATCH v6, 06/15] media: mtk-vcodec: Refactor get and put capture buffer flow

2022-02-17 Thread Nicolas Dufresne
Le jeudi 17 février 2022 à 17:03 +0800, yunfei.d...@mediatek.com a écrit : > > > - ret = vdec_if_decode(ctx, bs_src, dst_buf, &res_chg); > > > + ret = vdec_if_decode(ctx, bs_src, NULL, &res_chg); > > >   if (ret) { > > >   mtk_v4l2_err(" <===[%d], src_buf[%d] sz=0x%zx pts=%l

  1   2   >