Re: [PATCH v2] drm/meson: Use 1000ULL when operating with mode->clock

2025-05-09 Thread Neil Armstrong
Hi, On Tue, 06 May 2025 02:43:38 +0800, I Hsin Cheng wrote: > Coverity scan reported the usage of "mode->clock * 1000" may lead to > integer overflow. Use "1000ULL" instead of "1000" > when utilizing it to avoid potential integer overflow issue. > > Thanks, Applied to https://gitlab.freedesktop

Re: [PATCH v2] drm/meson: Use 1000ULL when operating with mode->clock

2025-05-09 Thread Neil Armstrong
On 09/05/2025 20:27, Martin Blumenstingl wrote: On Fri, May 9, 2025 at 5:35 PM wrote: On 05/05/2025 20:43, I Hsin Cheng wrote: Coverity scan reported the usage of "mode->clock * 1000" may lead to integer overflow. Use "1000ULL" instead of "1000" when utilizing it to avoid potential integer ov

Re: [PATCH v2] drm/meson: Use 1000ULL when operating with mode->clock

2025-05-09 Thread neil . armstrong
On 05/05/2025 20:43, I Hsin Cheng wrote: Coverity scan reported the usage of "mode->clock * 1000" may lead to integer overflow. Use "1000ULL" instead of "1000" when utilizing it to avoid potential integer overflow issue. Link: https://scan5.scan.coverity.com/#/project-view/10074/10063?selectedI

[PATCH v2 6/6] drm/panel: visionox-rm69299: support the variant found in the SHIFT6mq

2025-05-09 Thread Neil Armstrong
From: Caleb Connolly Add support for another variant of the rm69299 panel. This panel is 1080x2160 and is found in the shift-axolotl (SHIFT6mq). Signed-off-by: Caleb Connolly [narmstrong: moved to panel_desc] Signed-off-by: Neil Armstrong --- drivers/gpu/drm/panel/panel-visionox-rm69299.c

[PATCH v2 4/6] drm/panel: visionox-rm69299: switch to devm_regulator_bulk_get_const()

2025-05-09 Thread Neil Armstrong
Switch to devm_regulator_bulk_get_const() to move the supply data to const. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/panel/panel-visionox-rm69299.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-visionox-rm69299.c

[PATCH v2 1/6] dt-bindings: display: visionox-rm69299: document new compatible string

2025-05-09 Thread Neil Armstrong
From: Caleb Connolly Document a new compatible string for the second panel variant. Signed-off-by: Caleb Connolly Acked-by: Rob Herring Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/display/panel/visionox,rm69299.yaml | 4 +++- 1 file changed, 3 insertions(+), 1

[PATCH v2 5/6] drm/panel: visionox-rm69299: switch to devm_drm_panel_alloc()

2025-05-09 Thread Neil Armstrong
Switch to devm_drm_panel_alloc() to add panel refcounting. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/panel/panel-visionox-rm69299.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-visionox-rm69299.c b/drivers/gpu/drm/panel/panel

[PATCH v2 3/6] drm/panel: visionox-rm69299: switch to _multi variants

2025-05-09 Thread Neil Armstrong
Switch to the DSI _multi variants to simplify error handling. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/panel/panel-visionox-rm69299.c | 48 +++--- 1 file changed, 13 insertions(+), 35 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-visionox-rm69299.c b

[PATCH v2 0/6] panel: visionox-rm69299: modernize & support the variant found in the SHIFT6mq

2025-05-09 Thread Neil Armstrong
/20220123173650.290349-5-ca...@connolly.tech/ Signed-off-by: Neil Armstrong --- Changes in v2: - Add panel_desc to support the variant - Switch to _multi calls - Switch to const supplies - Switch to new panel alloc - Fix shift panel init seq name - Link to v1: https://lore.kernel.org/r/20250507-topic-misc

[PATCH v2 2/6] drm/panel: visionox-rm69299: add plumbing to support panel variants

2025-05-09 Thread Neil Armstrong
In order to support a panel variant, add plumbing code to pass init sequence and mode as compatible data. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/panel/panel-visionox-rm69299.c | 58 ++ 1 file changed, 32 insertions(+), 26 deletions(-) diff --git a/drivers/gpu

Re: [PATCH 00/46] drm/panel: Use refcounted allocation in place of devm_kzalloc() - Part3

2025-05-09 Thread neil . armstrong
On 08/05/2025 19:24, Anusha Srivatsa wrote: On Mon, Apr 7, 2025 at 6:04 AM Neil Armstrong mailto:neil.armstr...@linaro.org>> wrote: On 03/04/2025 22:20, Anusha Srivatsa wrote: > Start converting drivers to use the API - devm_drm_panel_alloc(). > > Final

Re: [PATCH 2/2] drm/panel: visionox-rm69299: support the variant found in the SHIFT6mq

2025-05-09 Thread neil . armstrong
: removed cosmetic changes, fixed to apply, use enums to select mode] Signed-off-by: Neil Armstrong ---   drivers/gpu/drm/panel/panel-visionox-rm69299.c | 221 ++---   1 file changed, 195 insertions(+), 26 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-visionox-rm69299.c b

Re: [PATCH] dt-bindings: display: panel: convert truly,nt35597.txt to dt-schema

2025-05-08 Thread Neil Armstrong
Hi, On Wed, 07 May 2025 11:19:21 +0200, Neil Armstrong wrote: > Convert the Truly NT35597 2K display panel bindings to dt-schema. > > The vdispp-supply & vdispn-supply are not marked as required since > in practice they are not defined in sdm845-mtp.dts which is the > only use

Re: [PATCH v2 0/2] drm/panel: Add Novatek NT37801 panel driver

2025-05-08 Thread Neil Armstrong
Hi, On Thu, 08 May 2025 16:34:46 +0200, Krzysztof Kozlowski wrote: > Changes in v2: > - Use devm_drm_panel_alloc (Neil) > - Add novatek_nt37801_switch_page (Linus) > - Add Rb tags > - Link to v1: > https://lore.kernel.org/r/20250505-sm8750-display-panel-v1-0-e5b539848...@linaro.org > > Add drive

[PATCH 0/2] panel: visionox-rm69299: support the variant found in the SHIFT6mq

2025-05-07 Thread neil . armstrong
Re-spin of [1] and [2] to finally document and support this panel variant. [1] https://lore.kernel.org/all/20220123173650.290349-4-ca...@connolly.tech/ [2] https://lore.kernel.org/all/20220123173650.290349-5-ca...@connolly.tech/ Signed-off-by: Neil Armstrong --- Caleb Connolly (2): dt

[PATCH 1/2] dt-bindings: display: visionox-rm69299: document new compatible string

2025-05-07 Thread neil . armstrong
From: Caleb Connolly Document a new compatible string for the second panel variant. Signed-off-by: Caleb Connolly Acked-by: Rob Herring Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/display/panel/visionox,rm69299.yaml | 4 +++- 1 file changed, 3 insertions(+), 1

[PATCH 2/2] drm/panel: visionox-rm69299: support the variant found in the SHIFT6mq

2025-05-07 Thread neil . armstrong
From: Caleb Connolly Add support for another variant of the rm69299 panel. This panel is 1080x2160 and is found in the shift-axolotl (SHIFT6mq). Signed-off-by: Caleb Connolly [narmstrong: removed cosmetic changes, fixed to apply, use enums to select mode] Signed-off-by: Neil Armstrong

[PATCH] dt-bindings: display: panel: convert truly,nt35597.txt to dt-schema

2025-05-07 Thread Neil Armstrong
Convert the Truly NT35597 2K display panel bindings to dt-schema. The vdispp-supply & vdispn-supply are not marked as required since in practice they are not defined in sdm845-mtp.dts which is the only used of these bindings. Signed-off-by: Neil Armstrong --- .../display/panel/truly,nt3559

Re: [PATCH v2] drm/panel: simple: Update timings for AUO G101EVN010

2025-05-06 Thread Neil Armstrong
On 06/05/2025 13:59, Dmitry Baryshkov wrote: On Mon, 05 May 2025 12:02:56 -0500, Kevin Baker wrote: Switch to panel timings based on datasheet for the AUO G101EVN01.0 LVDS panel. Default timings were tested on the panel. Previous mode-based timings resulted in horizontal display shift. Appl

Re: [PATCH v2] drm/panel: simple: Update timings for AUO G101EVN010

2025-05-06 Thread Neil Armstrong
Hi, On Mon, 05 May 2025 12:02:56 -0500, Kevin Baker wrote: > Switch to panel timings based on datasheet for the AUO G101EVN01.0 > LVDS panel. Default timings were tested on the panel. > > Previous mode-based timings resulted in horizontal display shift. > > Thanks, Applied to https://gitlab.fr

Re: [PATCH v2] drm/panel: simple: Update timings for AUO G101EVN010

2025-05-06 Thread Neil Armstrong
.width = 216, .height = 135, }, .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, + .bus_flags = DRM_BUS_FLAG_DE_HIGH, .connector_type = DRM_MODE_CONNECTOR_LVDS, }; Reviewed-by: Neil Armstrong

Re: [PATCH 2/2] drm/panel: Add Novatek NT37801 panel driver

2025-05-05 Thread Neil Armstrong
;, ret); + + drm_panel_remove(&ctx->panel); +} + +static const struct of_device_id novatek_nt37801_of_match[] = { + { .compatible = "novatek,nt37801" }, + {} +}; +MODULE_DEVICE_TABLE(of, novatek_nt37801_of_match); + +static struct mipi_dsi_driver novatek_nt37801_driver = { + .probe = novatek_nt37801_probe, + .remove = novatek_nt37801_remove, + .driver = { + .name = "panel-novatek-nt37801", + .of_match_table = novatek_nt37801_of_match, + }, +}; +module_mipi_dsi_driver(novatek_nt37801_driver); + +MODULE_AUTHOR("Krzysztof Kozlowski "); +MODULE_DESCRIPTION("Panel driver for the Novatek NT37801/NT37810 AMOLED DSI panel"); +MODULE_LICENSE("GPL"); With that fixed: Reviewed-by: Neil Armstrong Thanks, Neil

Re: [PATCH v2 2/4] drm: panel: Add support for Renesas R61307 based MIPI DSI panel

2025-05-05 Thread Neil Armstrong
On 05/05/2025 13:41, Svyatoslav Ryhel wrote: пн, 5 трав. 2025 р. о 10:50 Neil Armstrong пише: On 03/05/2025 11:41, Svyatoslav Ryhel wrote: R61307 is liquid crystal driver for high-definition amorphous silicon (a-Si) panels and is ideal for tablets and smartphones. Supported compatibles are

Re: [PATCH v3 0/2] BOE TD4320 panel

2025-05-05 Thread Neil Armstrong
Hi, On Wed, 30 Apr 2025 21:42:11 +0200, Barnabás Czémán wrote: > Add driver for BOE TD4320 DSI panel, used in Xiaomi Redmi Note 7 > smartphones. > > Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next) [1/2] dt-bindings: display: panel: Add BOE TD4320 h

Re: [PATCH] drm/panel: simple: Update timings for AUO G101EVN010

2025-05-05 Thread Neil Armstrong
On 28/04/2025 23:07, Kevin Baker wrote: Switch to panel timings based on datasheet for the AUO G101EVN01.0 LVDS panel. Default timings were tested on the panel. Previous mode-based timings resulted in horizontal display shift. Can you add a Fixes tag ? Thanks, Neil Signed-off-by: Kevin Bak

Re: [PATCH v2 4/4] drm: panel: Add support for Renesas R69328 based MIPI DSI panel

2025-05-05 Thread Neil Armstrong
v->panel); + + ret = mipi_dsi_attach(dsi); + if (ret) { + dev_err(dev, "Failed to attach to DSI host: %d\n", ret); + drm_panel_remove(&priv->panel); + return ret; + } + + return 0; +} + With that fixed: Reviewed-by: Neil Armstrong

Re: [PATCH v2 2/4] drm: panel: Add support for Renesas R61307 based MIPI DSI panel

2025-05-05 Thread Neil Armstrong
SI_MODE_LPM; + + drm_panel_init(&priv->panel, dev, &renesas_r61307_panel_funcs, + DRM_MODE_CONNECTOR_DSI); Please switch to devm_drm_panel_alloc() + + ret = drm_panel_of_backlight(&priv->panel); + if (ret) + return dev_err_probe(dev, ret, "Failed to get backlight\n"); + + drm_panel_add(&priv->panel); + With that: Reviewed-by: Neil Armstrong

Re: [PATCH v3 2/2] drivers: gpu: drm: panel: Add BOE TD4320

2025-05-05 Thread Neil Armstrong
+} + +static const struct of_device_id boe_td4320_of_match[] = { + { .compatible = "boe,td4320" }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(of, boe_td4320_of_match); + +static struct mipi_dsi_driver boe_td4320_driver = { + .probe = boe_td4320_probe, + .remove = boe_td4320_remove, + .driver = { + .name = "panel-boe-td4320", + .of_match_table = boe_td4320_of_match, + }, +}; +module_mipi_dsi_driver(boe_td4320_driver); + +MODULE_AUTHOR("Barnabas Czeman "); +MODULE_DESCRIPTION("DRM driver for boe td4320 fhdplus video mode dsi panel"); +MODULE_LICENSE("GPL"); Reviewed-by: Neil Armstrong

Re: [PATCH RFT v6 2/5] drm/msm/adreno: Add speedbin data for SM8550 / A740

2025-04-30 Thread neil . armstrong
On 30/04/2025 18:39, Konrad Dybcio wrote: On 4/30/25 6:19 PM, neil.armstr...@linaro.org wrote: On 30/04/2025 17:36, Konrad Dybcio wrote: On 4/30/25 4:49 PM, neil.armstr...@linaro.org wrote: On 30/04/2025 15:09, Konrad Dybcio wrote: On 4/30/25 2:49 PM, neil.armstr...@linaro.org wrote: On 30/0

Re: [PATCH RFT v6 1/5] drm/msm/adreno: Implement SMEM-based speed bin

2025-04-30 Thread neil . armstrong
On 30/04/2025 13:34, Konrad Dybcio wrote: From: Konrad Dybcio On recent (SM8550+) Snapdragon platforms, the GPU speed bin data is abstracted through SMEM, instead of being directly available in a fuse. Add support for SMEM-based speed binning, which includes getting "feature code" and "product

Re: [PATCH RFT v6 2/5] drm/msm/adreno: Add speedbin data for SM8550 / A740

2025-04-30 Thread neil . armstrong
On 30/04/2025 17:36, Konrad Dybcio wrote: On 4/30/25 4:49 PM, neil.armstr...@linaro.org wrote: On 30/04/2025 15:09, Konrad Dybcio wrote: On 4/30/25 2:49 PM, neil.armstr...@linaro.org wrote: On 30/04/2025 14:35, Konrad Dybcio wrote: On 4/30/25 2:26 PM, neil.armstr...@linaro.org wrote: Hi, On

Re: [PATCH RFT v6 2/5] drm/msm/adreno: Add speedbin data for SM8550 / A740

2025-04-30 Thread neil . armstrong
On 30/04/2025 15:09, Konrad Dybcio wrote: On 4/30/25 2:49 PM, neil.armstr...@linaro.org wrote: On 30/04/2025 14:35, Konrad Dybcio wrote: On 4/30/25 2:26 PM, neil.armstr...@linaro.org wrote: Hi, On 30/04/2025 13:34, Konrad Dybcio wrote: From: Konrad Dybcio Add speebin data for A740, as foun

Re: [PATCH RFT v6 2/5] drm/msm/adreno: Add speedbin data for SM8550 / A740

2025-04-30 Thread neil . armstrong
On 30/04/2025 14:35, Konrad Dybcio wrote: On 4/30/25 2:26 PM, neil.armstr...@linaro.org wrote: Hi, On 30/04/2025 13:34, Konrad Dybcio wrote: From: Konrad Dybcio Add speebin data for A740, as found on SM8550 and derivative SoCs. For non-development SoCs it seems that "everything except FC_AC

Re: [PATCH RFT v6 2/5] drm/msm/adreno: Add speedbin data for SM8550 / A740

2025-04-30 Thread neil . armstrong
Hi, On 30/04/2025 13:34, Konrad Dybcio wrote: From: Konrad Dybcio Add speebin data for A740, as found on SM8550 and derivative SoCs. For non-development SoCs it seems that "everything except FC_AC, FC_AF should be speedbin 1", but what the values are for said "everything" are not known, so th

Re: [PATCH v2 2/2] drivers: gpu: drm: panel: Add BOE TD4320

2025-04-30 Thread Neil Armstrong
On 29/04/2025 23:33, Barnabás Czémán wrote: Add driver for BOE TD4320 DSI panel, used in Xiaomi Redmi Note 7 mobile phone. Signed-off-by: Barnabás Czémán --- drivers/gpu/drm/panel/Kconfig| 9 ++ drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-boe-

Re: [PATCH v4 00/11] Trusted Execution Environment (TEE) driver for Qualcomm TEE (QTEE)

2025-04-29 Thread neil . armstrong
ing-tee-ss-without-mem-obj-362c66340527 Best regards, Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Neil Armstrong # on SM8650-QRD Tested-by: Neil Armstrong # on SM8650-HDK # /unittest -d [test_print_diagnostics_info][52] 831360 = Total bytes as heap [test_print_diagnostics_info][

Re: [PATCH v2] drm/panel: himax-hx8279: Always initialize goa_{even,odd}_valid in hx8279_check_goa_config()

2025-04-24 Thread Neil Armstrong
Hi, On Wed, 23 Apr 2025 10:41:41 -0700, Nathan Chancellor wrote: > Clang warns (or errors with CONFIG_WERROR=y): > > drivers/gpu/drm/panel/panel-himax-hx8279.c:838:6: error: variable > 'goa_even_valid' is used uninitialized whenever 'if' condition is false > [-Werror,-Wsometimes-uninitialized

Re: [PATCH] drm/panel: samsung-sofef00: Drop s6e3fc2x01 support

2025-04-24 Thread Neil Armstrong
Hi, On Sat, 19 Apr 2025 18:31:44 +0200, David Heidelberg wrote: > We never properly supported this panel and always used the wrong init > sequence. Drop support so we can move it to it's own proper driver. > > Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next

Re: [PATCH] drm: panel: himax-hx8279: avoid using an uninitialized variable

2025-04-24 Thread Neil Armstrong
Hi, On 23/04/2025 18:32, Arnd Bergmann wrote: From: Arnd Bergmann goa_even_valid is only initialized in one branch but not the other: drivers/gpu/drm/panel/panel-himax-hx8279.c:838:6: error: variable 'goa_even_valid' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometime

Re: [PATCH v2] drm/panel: himax-hx8279: Always initialize goa_{even,odd}_valid in hx8279_check_goa_config()

2025-04-24 Thread Neil Armstrong
e! */ if (goa_odd_valid != goa_even_valid) --- base-commit: dcbd5dcc956e2331414fd7020b4655df08deeb87 change-id: 20250422-panel-himax-hx8279-fix-sometimes-uninitialized-207354fb930c Best regards, Reviewed-by: Neil Armstrong

Re: [PATCH] drm/panel: himax-hx8279: Initialize goa_{even, odd}_valid in hx8279_check_goa_config()

2025-04-23 Thread Neil Armstrong
On 23/04/2025 15:45, Neil Armstrong wrote: On 22/04/2025 23:20, Nathan Chancellor wrote: Clang warns (or errors with CONFIG_WERROR=y):    drivers/gpu/drm/panel/panel-himax-hx8279.c:838:6: error: variable 'goa_even_valid' is used uninitialized whenever 'if' conditio

Re: [PATCH] drm/panel: himax-hx8279: Initialize goa_{even, odd}_valid in hx8279_check_goa_config()

2025-04-23 Thread Neil Armstrong
i, num_zero, num_clr = 0; /* Up to 4 zero values is a valid configuration. Check them all. */ --- base-commit: dcbd5dcc956e2331414fd7020b4655df08deeb87 change-id: 20250422-panel-himax-hx8279-fix-sometimes-uninitialized-207354fb930c Best regards, Reviewed-by: Neil Armstrong

Re: [PATCH 32/33] dt-bindings: display: panel: samsung,ams581vf01: Add google,sunfish

2025-04-23 Thread Neil Armstrong
On 22/04/2025 23:31, Danila Tikhonov wrote: This panel is used in Google Pixel 4a (google,sunfish). Document the corresponding string. Signed-off-by: Danila Tikhonov --- .../bindings/display/panel/samsung,ams581vf01.yaml| 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) di

Re: [PATCH 00/33] Add support for Qualcomm Snapdragon SM7150 SoC and Google Pixel 4a

2025-04-23 Thread Neil Armstrong
Hi, On 23/04/2025 00:07, Jens Reidel wrote: Hi everyone, apologies for the mess this created. Danila's mail provider ratelimited him halfway through sending the series and the attempt to re-try sending the second half an hour later ended up with a new message ID (I think due to not using --i

Re: [PATCH 3/7] drm/bridge: analogic_dp: drop panel_is_modeset

2025-04-22 Thread Neil Armstrong
panel_is_modeset; struct analogix_dp_plat_data *plat_data; }; Reviewed-by: Neil Armstrong

Re: [PATCH] drm: panel: jd9365da: fix reset signal polarity in unprepare

2025-04-22 Thread Neil Armstrong
Hi, On Thu, 17 Apr 2025 15:55:06 -0400, Hugo Villeneuve wrote: > commit a8972d5a49b4 ("drm: panel: jd9365da-h3: fix reset signal polarity") > fixed reset signal polarity in jadard_dsi_probe() and jadard_prepare(). > > It was not done in jadard_unprepare() because of an incorrect assumption > abou

Re: [PATCH 0/2] Transition remaining mipi_dsi_dcs_write_seq commands and remove it

2025-04-22 Thread Neil Armstrong
Hi, On Sat, 19 Apr 2025 09:42:08 +0530, Tejas Vipin wrote: > panel-samsung-sofef00 is the last remaining user of > mipi_dsi_dcs_write_seq, so mipi_dsi_dcs_write_seq can be removed after > the panel has been changed to use mipi_dsi_*_multi functions. > > Tejas Vipin (2): > drm/panel: panel-samsu

Re: [PATCH] drm: panel: jd9365da: fix reset signal polarity in unprepare

2025-04-22 Thread Neil Armstrong
} base-commit: 7adf8b1afc14832de099f9e178f08f91dc0dd6d0 Reviewed-by: Neil Armstrong

Re: [PATCH] drm/panel: samsung-sofef00: Drop s6e3fc2x01 support

2025-04-22 Thread Neil Armstrong
a_panel_mode, - }, + { .compatible = "samsung,sofef00" }, { /* sentinel */ } }; MODULE_DEVICE_TABLE(of, sofef00_panel_of_match); --- base-commit: bc8aa6cdadcc00862f2b5720e5de2e17f696a081 change-id: 20250419-drop-s6e3fc2x01-support-d060a14a4791 Best regards, Reviewed-by: Neil Armstrong

Re: [PATCH RFC v2 0/2] drm/meson: vclk: revert and re-fix vclk calculations

2025-04-22 Thread Neil Armstrong
Hi, On Mon, 21 Apr 2025 22:12:58 +0200, Martin Blumenstingl wrote: > This is a successor of a previous patchset by Christian [0] > > Patch 1 reverts a previous fix for loss of HDMI sync when playing YUV420 > @ 59.94 media. The patch does resolve a calculation issue. It also makes > all fractional

Re: [PATCH] drm/meson: fix resource cleanup in meson_drv_bind_master() on error

2025-04-22 Thread Neil Armstrong
On 22/04/2025 09:04, neil.armstr...@linaro.org wrote: On 19/04/2025 23:32, Martin Blumenstingl wrote: Hi Martijn, Hi Neil, On Thu, Apr 10, 2025 at 8:46 PM wrote: Hi Martin, Thank you for the patch. I encountered this issue some time ago as well and had a possible fix in my tree (see below

Re: [PATCH] drm/meson: fix resource cleanup in meson_drv_bind_master() on error

2025-04-22 Thread neil . armstrong
On 19/04/2025 23:32, Martin Blumenstingl wrote: Hi Martijn, Hi Neil, On Thu, Apr 10, 2025 at 8:46 PM wrote: Hi Martin, Thank you for the patch. I encountered this issue some time ago as well and had a possible fix in my tree (see below). My apologies for not upstreaming it earlier. No wor

Re: [PATCH RFC v2 0/2] drm/meson: vclk: revert and re-fix vclk calculations

2025-04-22 Thread neil . armstrong
vclk.c | 195 +++-- drivers/gpu/drm/meson/meson_vclk.h | 13 +- 5 files changed, 126 insertions(+), 115 deletions(-) Thanks for re-spinning, will apply. Reviewed-by: Neil Armstrong Thanks !

Re: [PATCH 1/7] drm/bridge: analogix_dp: drop extra calls to analogix_dp_prepare_panel()

2025-04-18 Thread Neil Armstrong
(!analogix_dp_detect_hpd(dp)) status = connector_status_connected; - ret = analogix_dp_prepare_panel(dp, false, false); - if (ret) - DRM_ERROR("Failed to unprepare panel (%d)\n", ret); - return status; } Reviewed-by: Neil Armstrong

Re: [PATCH v3 2/3] drm/panel: simple: Tianma TM070JDHG34-00: add delays

2025-04-18 Thread Neil Armstrong
ECTOR_LVDS, }; Reviewed-by: Neil Armstrong

Re: [PATCH 0/7] drm/panel: make prepare / enable / disable / unprepare return void

2025-04-18 Thread Neil Armstrong
On 01/04/2025 07:11, Dmitry Baryshkov wrote: While it makes sense for panel callbacks to be able to return an error, the state-management functions from drm_panel API are usually called from atomic callbacks, which can not fails and must return void. Make drm_panel_prepare(), drm_panel_enable(),

Re: [PATCH 4/7] drm/bridge: analogic_dp: drop panel_lock

2025-04-17 Thread Neil Armstrong
_lock; - struct analogix_dp_plat_data *plat_data; }; Reviewed-by: Neil Armstrong

Re: [PATCH v3 0/2] Add Visionox G2647FB105 panel support

2025-04-17 Thread Neil Armstrong
Hi, On Mon, 14 Apr 2025 20:26:30 +0300, Alexander Baransky wrote: > This patch series adds support for the Visionox G2647FB105 panel, used in: > - Xiaomi Mi Note 10 / CC9 Pro (sm7150-xiaomi-tucana) > - Xiaomi Mi Note 10 Lite (sm7150-xiaomi-toco) > > Testing has been done by me on sm7150-xiaomi-tu

Re: [PATCH 2/7] drm/bridge: analogix_dp: drop unused argument to analogix_dp_prepare_panel()

2025-04-17 Thread Neil Armstrong
if (ret) DRM_ERROR("failed to setup the panel ret = %d\n", ret); Reviewed-by: Neil Armstrong

Re: [PATCH 6/7] drm/bridge: analogix_dp: ignore return values of drm_panel_* calls

2025-04-17 Thread Neil Armstrong
@@ void analogix_dp_unbind(struct analogix_dp_device *dp) analogix_dp_bridge_disable(dp->bridge); dp->connector.funcs->destroy(&dp->connector); - if (dp->plat_data->panel) { - if (drm_panel_unprepare(dp->plat_data->panel)) - DRM_ERROR("failed to turnoff the panel\n"); - } + drm_panel_unprepare(dp->plat_data->panel); drm_dp_aux_unregister(&dp->aux); Reviewed-by: Neil Armstrong

Re: [PATCH 5/7] drm/bridge: analogix_dp: inline analogix_dp_prepare_panel()

2025-04-17 Thread Neil Armstrong
ot;failed to setup the panel ret = %d\n", ret); + if (dp->plat_data->panel) { + ret = drm_panel_unprepare(dp->plat_data->panel); + if (ret) + DRM_ERROR("failed to unprepare the panel ret = %d\n", ret); + } dp->fast_train_enable = false; dp->psr_supported = false; Reviewed-by: Neil Armstrong

Re: [PATCH 3/7] drm/bridge: analogic_dp: drop panel_is_modeset

2025-04-17 Thread Neil Armstrong
On 01/04/2025 07:11, Dmitry Baryshkov wrote: The dp->panel_is_modeset is now a write-only field. Drop it completely. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 11 +-- drivers/gpu/drm/bridge/analogix/analogix_dp_core.h | 1 - 2 files ch

Re: [PATCH v3 0/3] drm/panel: simple: add Tianma P0700WXF1MBAA and improve Tianma TM070JDHG34-00

2025-04-17 Thread Neil Armstrong
Hi, On Fri, 11 Apr 2025 21:19:43 +0200, Luca Ceresoli wrote: > This short series adds power on/off timings to the Tianma TM070JDHG34-00 > panel and adds support for the the Tianma P0700WXF1MBAA panel. > > Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next) [1

Re: [PATCH v4 0/3] Add driver for Himax HX8279 DriverIC panels

2025-04-17 Thread Neil Armstrong
Hi, On Mon, 14 Apr 2025 10:29:15 +0200, AngeloGioacchino Del Regno wrote: > Changes in v4: > - Changed hx8279_set_page() and all other utilities to void (Neil) > - Changed hx8279_{on,prepare,unprepare}() to return dsi_ctx.accum_err (Neil) > - Switched to devm_drm_panel_alloc() as suggested (Nei

Re: [PATCH v3 2/2] drm/panel: Add Visionox G2647FB105 panel driver

2025-04-17 Thread neil . armstrong
onox_g2647fb105_driver = { + .probe = visionox_g2647fb105_probe, + .remove = visionox_g2647fb105_remove, + .driver = { + .name = "panel-visionox-g2647fb105", + .of_match_table = visionox_g2647fb105_of_match, + }, +}; +module_mipi_dsi_driver(visionox_g2647fb105_driver); + +MODULE_AUTHOR("Alexander Baransky "); +MODULE_DESCRIPTION("DRM driver for Visionox G2647FB105 AMOLED DSI panel"); +MODULE_LICENSE("GPL"); Reviewed-by: Neil Armstrong

Re: [PATCH v4 3/3] drm: panel: Add driver for Himax HX8279 DDIC panels

2025-04-14 Thread neil . armstrong
On 14/04/2025 10:29, AngeloGioacchino Del Regno wrote: Add a driver for the Himax HX8279-D MIPI-DSI DriverIC with support for the Startek KX070FHFID078 7.0" 1200x1920 IPS panel, found on various MediaTek Genio Evaluation Kit boards and for the Aoly SL101PM1794FOG-v15 10.1" 1200x1920 LCD panel fou

Re: [PATCH] drm/bridge: select DRM_KMS_HELPER for AUX_BRIDGE

2025-04-14 Thread Neil Armstrong
dge that is used by several non-DRM drivers to --- base-commit: 2bdde620f7f2bff2ff1cb7dc166859eaa0c78a7c change-id: 20250411-aux-select-kms-086618b92d6e Best regards, Reviewed-by: Neil Armstrong

Re: [PATCH v2] drm/bridge: dw-hdmi: Avoid including uapi headers

2025-04-14 Thread neil . armstrong
@@ #include -#include -#include +#include +#include #include #include Reviewed-by: Neil Armstrong

Re: [PATCH] drm/bridge: dw-hdmi: Avoid including uapi headers

2025-04-14 Thread neil . armstrong
#include Reviewed-by: Neil Armstrong

Re: [PATCH 7/7] drm/panel: make prepare/enable and disable/unprepare calls return void

2025-04-11 Thread Neil Armstrong
drm_panel_prepare(struct drm_panel *panel); +void drm_panel_unprepare(struct drm_panel *panel); -int drm_panel_enable(struct drm_panel *panel); -int drm_panel_disable(struct drm_panel *panel); +void drm_panel_enable(struct drm_panel *panel); +void drm_panel_disable(struct drm_panel *panel); int drm_panel_get_modes(struct drm_panel *panel, struct drm_connector *connector); LGTM Reviewed-by: Neil Armstrong

Re: [PATCH v3 3/3] drm: panel: Add driver for Himax HX8279 DDIC panels

2025-04-11 Thread neil . armstrong
On 10/04/2025 09:24, AngeloGioacchino Del Regno wrote: Add a driver for the Himax HX8279-D MIPI-DSI DriverIC with support for the Startek KX070FHFID078 7.0" 1200x1920 IPS panel, found on various MediaTek Genio Evaluation Kit boards and for the Aoly SL101PM1794FOG-v15 10.1" 1200x1920 LCD panel fou

Re: [PATCH v3 00/11] Trusted Execution Environment (TEE) driver for Qualcomm TEE (QTEE)

2025-04-09 Thread neil . armstrong
On 28/03/2025 03:47, Amirreza Zarrabi wrote: This patch series introduces a Trusted Execution Environment (TEE) driver for Qualcomm TEE (QTEE). QTEE enables Trusted Applications (TAs) and services to run securely. It uses an object-based interface, where each service is an object with sets of ope

Re: [PATCH v2 13/30] panel/jadard-jd9365da-h3: Use refcounted allocation in place of devm_kzalloc()

2025-04-07 Thread Neil Armstrong
On 03/04/2025 16:16, Anusha Srivatsa wrote: Move to using the new API devm_drm_panel_alloc() to allocate the panel. Signed-off-by: Anusha Srivatsa --- v2: none. --- drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a

Re: [PATCH 00/46] drm/panel: Use refcounted allocation in place of devm_kzalloc() - Part3

2025-04-07 Thread Neil Armstrong
: 20250402-b4-drm_panel_mass_driver_convert_part3-9b06bf9d3b22 Best regards, With the patch 41 build failure fixed: Reviewed-by: Neil Armstrong

Re: [PATCH v2 22/30] panel/newvision-nv3052c: Use refcounted allocation in place of devm_kzalloc()

2025-04-07 Thread Neil Armstrong
On 03/04/2025 16:16, Anusha Srivatsa wrote: Move to using the new API devm_drm_panel_alloc() to allocate the panel. Signed-off-by: Anusha Srivatsa --- v2: none. --- drivers/gpu/drm/panel/panel-newvision-nv3052c.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/

Re: [PATCH v2 00/30] drm/panel: Use refcounted allocation in place of devm_kzalloc() - Part2

2025-04-07 Thread Neil Armstrong
: Reviewed-by: Neil Armstrong

Re: [PATCH 00/10] drm/panel: Use refcounted allocation in place of devm_kzalloc()

2025-04-05 Thread Neil Armstrong
-mass-driver-convert-ddca32e95d16 Best regards, Looks good to me Reviewed-by: Neil Armstrong

Re: [PATCH v3] drm/panel/sharp-ls043t1le01: Use _multi variants

2025-03-27 Thread Neil Armstrong
return dsi_ctx.accum_err; } static int sharp_nt_panel_unprepare(struct drm_panel *panel) --- base-commit: dbe74119ff71c00f2d863a32f72aab2d15e61c39 change-id: 20250316-b4-panel-ls043t1le01-7407b896b7a8 Best regards, Reviewed-by: Neil Armstrong

Re: [PATCH] drm/i2c: tda998x: select CONFIG_DRM_KMS_HELPER

2025-03-25 Thread Neil Armstrong
M_KMS_HELPER + select SND_SOC_HDMI_CODEC if SND_SOC + help + Support for NXP Semiconductors TDA998X HDMI encoders. config DRM_ITE_IT6263 tristate "ITE IT6263 LVDS/HDMI bridge" Reviewed-by: Neil Armstrong

Re: [PATCH 2/2] drm/panel: simple: Add NLT NL13676BC25-03F panel entry

2025-03-18 Thread Neil Armstrong
-03f", + .data = &nlt_nl13676bc25_03f, }, { .compatible = "nlt,nl192108ac18-02d", .data = &nlt_nl192108ac18_02d, Reviewed-by: Neil Armstrong

Re: [PATCH] drm/panel/synaptics-r63353: Use _multi variants

2025-03-17 Thread Neil Armstrong
On 16/03/2025 18:40, Anusha Srivatsa wrote: On Fri, Mar 14, 2025 at 10:20 AM Doug Anderson mailto:diand...@chromium.org>> wrote: Hi, On Thu, Mar 13, 2025 at 9:47 PM Anusha Srivatsa mailto:asriv...@redhat.com>> wrote: > > @@ -181,24 +162,15 @@ static int r63353_panel_prepare(

Re: [PATCH RFC 2/2] drm/panel/panel-simple: Use the new allocation in place of devm_kzalloc()

2025-03-17 Thread Neil Armstrong
On 13/03/2025 01:54, Anusha Srivatsa wrote: Start using the new helper that does the refcounted allocations. Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/panel/panel-simple.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/

Re: [PATCH] drm/panel: novatek-nt36523: transition to mipi_dsi wrapped functions

2025-03-07 Thread neil . armstrong
On 06/03/2025 18:38, Tejas Vipin wrote: On 3/6/25 10:58 PM, Doug Anderson wrote: Hi, On Thu, Mar 6, 2025 at 6:05 AM wrote: On 06/03/2025 14:43, Tejas Vipin wrote: Changes the novatek-nt36523 panel to use multi style functions for improved error handling. Signed-off-by: Tejas Vipin ---

Re: [PATCH v2 2/2] drm/panel: novatek-nt36523: transition to mipi_dsi wrapped functions

2025-03-07 Thread neil . armstrong
On 07/03/2025 10:15, Tejas Vipin wrote: Changes the novatek-nt36523 panel to use multi style functions for improved error handling. Additionally, novatek-nt36523 will now continue to execute the init sequence on one of the DSI devices on an error occurring on the other one. Sorry but I think th

Re: [PATCH v2 1/2] drm/mipi-dsi: Add mipi_dsi_dual_msleep

2025-03-07 Thread neil . armstrong
ile (0) + /** * enum mipi_dsi_dcs_tear_mode - Tearing Effect Output Line mode * @MIPI_DSI_DCS_TEAR_MODE_VBLANK: the TE output line consists of V-Blanking Reviewed-by: Neil Armstrong

Re: [PATCH] drm/panel: novatek-nt36523: transition to mipi_dsi wrapped functions

2025-03-06 Thread neil . armstrong
On 06/03/2025 14:43, Tejas Vipin wrote: Changes the novatek-nt36523 panel to use multi style functions for improved error handling. Signed-off-by: Tejas Vipin --- drivers/gpu/drm/panel/panel-novatek-nt36523.c | 1683 - 1 file changed, 823 insertions(+), 860 deletions(-) diff

Re: [PATCH] drm/bridge: dw-hdmi-cec: fix inconsistent indenting warning

2025-03-06 Thread neil . armstrong
AT0); return 0; } Reviewed-by: Neil Armstrong

Re: [PATCH 2/2] mailmap: remap all addresses to kernel.org alias

2025-03-06 Thread neil . armstrong
yshkov +Dmitry Baryshkov <[dbarysh...@gmail.com]> +Dmitry Baryshkov +Dmitry Baryshkov +Dmitry Baryshkov Dmitry Safonov <0x7f454...@gmail.com> Dmitry Safonov <0x7f454...@gmail.com> Dmitry Safonov <0x7f454...@gmail.com> Reviewed-by: Neil Armstrong

Re: [PATCH 1/2] MAINTAINERS: use kernel.org alias

2025-03-06 Thread neil . armstrong
:Sean Paul R:Marijn Suijten L:linux-arm-...@vger.kernel.org Reviewed-by: Neil Armstrong

Re: [PATCH v8 0/5] Driver for pre-DCP apple display controller.

2025-03-05 Thread Neil Armstrong
On 05/03/2025 15:01, Alyssa Rosenzweig wrote: Er... I only applied 1, 2, and 5. Patch 3 was already merged, and patch 4 is going in via arm soc. I am, new to b4, sorry! Yeah it's because you applied the whole patchset, and discarded/skipped patch 3 & 4 afterwards, so b4 gets confused. Next tim

Re: [PATCH] drm/panel: fix Visionox RM692E5 dependencies

2025-03-04 Thread Neil Armstrong
Say Y here if you want to enable support for Visionox RM692E5 amoled display panels, such as the one found in the Nothing Phone (1) Reviewed-by: Neil Armstrong

Re: [PATCH v7 0/5] Driver for pre-DCP apple display controller.

2025-03-03 Thread Neil Armstrong
On 03/03/2025 17:43, Alyssa Rosenzweig wrote: Sasha Finkelstein (5): dt-bindings: display: Add Apple pre-DCP display controller drm: adp: Add Apple Display Pipe driver drm: panel: Add a panel driver for the Summit display arm64: dts: apple: Add touchbar screen node

Re: [PATCH v7 0/5] Driver for pre-DCP apple display controller.

2025-03-03 Thread Neil Armstrong
Hi, On 17/02/2025 12:39, Sasha Finkelstein via B4 Relay wrote: Hi. This patch series adds support for a secondary display controller present on Apple M1/M2 chips and used to drive the display of the "touchbar" touch panel present on those. Signed-off-by: Sasha Finkelstein --- Changes in v7: -

Re: [PATCH v2 0/8] drm/msm/dpu: improve CTL handling on DPU >= 5.0 platforms

2025-02-28 Thread neil . armstrong
++--- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h | 2 ++ 18 files changed, 65 insertions(+), 39 deletions(-) --- base-commit: be5c7bbb3a64baf884481a1ba0c2f8fb2f93f7c3 change-id: 20250209-dpu-active-ctl-08cca4d8b08a Best regards, Tested-by: Neil Armstrong # on SM8550-QRD Tested

Re: (subset) [PATCH v2 0/4] Add and enable the panel

2025-02-27 Thread Neil Armstrong
Hi, On Tue, 18 Feb 2025 01:24:27 +0300, Danila Tikhonov wrote: > This patch series adds support for the Visionox RM692E5 panel, which is > used on the Nothing Phone (1) and then adds it to the DTS. > > Before integrating the panel into the DTS, we update the DSI code to > allow bits-per-component

Re: [PATCH v3 0/2] Rockchip W552793DBA-V10 panel support

2025-02-27 Thread Neil Armstrong
Hi, On Tue, 25 Feb 2025 17:07:58 +0100, Sebastian Reichel wrote: > This has been tested in combination with the series from Heiko Stübner > enabling DSI support for the RK3588 [0] (DSI controller support has been > merged already, only the PHY support is missing) on the RK3588 EVB1. > > [0] > ht

Re: [PATCH v2 2/4] drm/panel: Add Visionox RM692E5 panel driver

2025-02-27 Thread neil . armstrong
ruct visionox_rm692e5 *ctx = mipi_dsi_get_drvdata(dsi); + + drm_panel_remove(&ctx->panel); +} + +static const struct of_device_id visionox_rm692e5_of_match[] = { + { .compatible = "visionox,rm692e5" }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(of, visionox_rm692e5_of_match); + +static struct mipi_dsi_driver visionox_rm692e5_driver = { + .probe = visionox_rm692e5_probe, + .remove = visionox_rm692e5_remove, + .driver = { + .name = "panel-visionox-rm692e5", + .of_match_table = visionox_rm692e5_of_match, + }, +}; +module_mipi_dsi_driver(visionox_rm692e5_driver); + +MODULE_AUTHOR("Eugene Lepshy "); +MODULE_AUTHOR("Danila Tikhonov "); +MODULE_DESCRIPTION("DRM driver for Visionox RM692E5 cmd mode dsi panel"); +MODULE_LICENSE("GPL"); Reviewed-by: Neil Armstrong

Re: (subset) [PATCH v7 0/5] Driver for pre-DCP apple display controller.

2025-02-25 Thread Neil Armstrong
On 25/02/2025 12:37, Dmitry Baryshkov wrote: On Tue, 25 Feb 2025 at 12:25, Neil Armstrong wrote: Hi, On Mon, 17 Feb 2025 12:39:30 +0100, Sasha Finkelstein wrote: This patch series adds support for a secondary display controller present on Apple M1/M2 chips and used to drive the display of

Re: [PATCH v2] drm/mipi-dsi: extend "multi" functions and use them in sony-td4353-jdi

2025-02-25 Thread Neil Armstrong
Hi, On Thu, 20 Feb 2025 10:27:21 +0530, Tejas Vipin wrote: > Removes mipi_dsi_dcs_set_tear_off and replaces it with a > multi version as after replacing it in sony-td4353-jdi, it doesn't > appear anywhere else. sony-td4353-jdi is converted to use multi style > functions, including mipi_dsi_dcs_set

Re: (subset) [PATCH 00/14] arm64: dts: freescale: Add support for the GOcontroll Moduline Display

2025-02-25 Thread Neil Armstrong
Hi, On Mon, 24 Feb 2025 14:50:50 +0100, Maud Spierings wrote: > Add inital support for 2 variants of the Moduline Display controller. > This system is powered by the Ka-Ro Electronics tx8p-ml81 COM, which > features an imx8mp SoC. > > Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/k

  1   2   3   4   5   6   7   8   9   10   >