Re: [PATCH v8 1/3] drm/tests: bridge: convert to devm_drm_bridge_alloc() API

2025-05-27 Thread Maxime Ripard
On Fri, May 16, 2025 at 06:48:37PM +0200, Luca Ceresoli wrote: > Use the new DRM bridge allocation API, which is the only supported now, for > the kunit tests. > > This change is more massive than for the typical DRM bridge driver because > struct drm_bridge_init_priv currently embeds a struct drm

Re: [PATCH v8 3/3] drm/tests: bridge: add KUnit tests for devm_drm_bridge_alloc()

2025-05-27 Thread Maxime Ripard
ummy_br->bridge); > + KUNIT_ASSERT_TRUE(test, ctx->destroyed); Ditto > +} > + > +static struct kunit_case drm_bridge_alloc_tests[] = { > + KUNIT_CASE(drm_test_drm_bridge_alloc_basic), > + KUNIT_CASE(drm_test_drm_bridge_alloc_get_put), > + { } > +}; > + > +static

Re: [PATCH v18 6/8] drm/vkms: Create KUnit tests for YUV conversions

2025-05-27 Thread Maxime Ripard
On Tue, May 27, 2025 at 03:36:16PM +0200, Louis Chauvet wrote: > > > Le 22/05/2025 à 17:39, Maxime Ripard a écrit : > > On Mon, May 12, 2025 at 03:07:55PM +0200, Louis Chauvet wrote: > > > Hi Maxime, > > > > > > Did you have the time to look at this pa

Re: [PATCH v4 2/4] drm/panel: Add refcount support

2025-05-27 Thread Maxime Ripard
nication. > > > > On Mon, 19 May 2025, Maxime Ripard wrote: > >> You still haven't explained why it would take anything more than > >> registering a dumb device at probe time though. > > > > With that, do you mean a dumb struct device, or any struct dev

Re: [PATCH v4 2/4] drm/panel: Add refcount support

2025-05-27 Thread Maxime Ripard
On Tue, May 20, 2025 at 01:09:47PM +0300, Jani Nikula wrote: > > Maxime - > > I'm cutting a lot of context here. Not because I don't think it deserves > an answer, but because I seem to be failing at communication. > > On Mon, 19 May 2025, Maxime Ripard wrote:

Re: [PATCH] drm/vc4: tests: pv_muxing: Fix locking

2025-05-27 Thread Maxime Ripard
On Sat, May 24, 2025 at 08:09:36AM -0300, Maíra Canal wrote: > On 20/05/25 09:08, Maxime Ripard wrote: > > Commit 30188df0c387 ("drm/tests: Drop drm_kunit_helper_acquire_ctx_alloc()") > > removed a kunit-managed function to get a drm_modeset_acquire_ctx.

Re: [PATCH v4 23/23] drm/tests: hdmi: Add test for unsupported RGB/YUV420 mode

2025-05-27 Thread Maxime Ripard
On Thu, May 22, 2025 at 08:37:31PM +0300, Cristian Ciocaltea wrote: > Hi Maxime, > > On 5/22/25 7:16 PM, Maxime Ripard wrote: > > Hi, > > > > On Mon, May 19, 2025 at 01:55:10PM +0300, Cristian Ciocaltea wrote: > >> On 5/19/25 11:42 AM, Maxime Ripard wrote:

Re: [PATCH v3 3/3] dma-buf: heaps: Give default CMA heap a fixed name

2025-05-27 Thread Maxime Ripard
legacy_cma_name = cma_get_name(default_cma); > + if (!strcmp(legacy_cma_name, DEFAULT_CMA_NAME)) { > + pr_warn("legacy name and default name are the same, > skipping legacy heap\n"); > + return 0; > + } > + > + ret = __add_cma_heap(default_cma, legacy_cma_name); > + if (ret) > + pr_warn("failed to add legacy heap: %pe\n", > + ERR_PTR(-ret)); Are you sure about the -ret? ret should already be a negative number if it failed? With that fixed, Reviewed-by: Maxime Ripard Maxime signature.asc Description: PGP signature

Re: [PATCH v3 2/3] dma-buf: heaps: Parameterize heap name in __add_cma_heap()

2025-05-27 Thread Maxime Ripard
On Thu, 22 May 2025 12:14:17 -0700, Jared Kangas wrote: > Prepare for the introduction of a fixed-name CMA heap by replacing the > unused void pointer parameter in __add_cma_heap() with the heap name. > > Signed-off-by: Jared Kangas Reviewed-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 1/3] Documentation: dma-buf: heaps: Fix code markup

2025-05-27 Thread Maxime Ripard
code snippets to fix this. > > > [ ... ] Reviewed-by: Maxime Ripard Thanks! Maxime

Re: [REGRESSION] [BISECTED] drm/sun4i: hdmi: No HDMI output with BananaPI M1 on 6.9

2025-05-26 Thread Maxime Ripard
Hi, On Mon, May 12, 2025 at 10:27:06PM +0200, Michael wrote: > with v6.9 and later there is no output on the BananaPI HDMI connector. > > I have bisected the issue to the following commit: > > 358e76fd613a ("drm/sun4i: hdmi: Consolidate atomic_check and mode_valid") > > With this patch, sun4i

Re: [PATCH] drm/bridge: adv7511: Do not merge adv7511_mode_set() with atomic_enable()

2025-05-26 Thread Maxime Ripard
comment. > > > > > > On 26/05/25 11:26, Maxime Ripard wrote: > > > > Hi, > > > > > > > > On Mon, May 26, 2025 at 10:54:52AM +0200, Tommaso Merciai wrote: > > > > > After adv7511_mode_set() was merged into .atomic_enable(), on

Re: [PATCH] drm/bridge: adv7511: Do not merge adv7511_mode_set() with atomic_enable()

2025-05-26 Thread Maxime Ripard
Hi, On Mon, May 26, 2025 at 10:54:52AM +0200, Tommaso Merciai wrote: > After adv7511_mode_set() was merged into .atomic_enable(), only the > native resolution is working when using modetest. > > This is caused by incorrect timings: adv7511_mode_set() must not be > merged into .atomic_enable(). >

Re: [PATCH v4 14/23] drm/tests: hdmi: Add macro to support EDEADLK handling

2025-05-25 Thread Maxime Ripard
On Thu, May 22, 2025 at 07:47:00PM +0300, Cristian Ciocaltea wrote: > On 5/22/25 7:06 PM, Maxime Ripard wrote: > > On Mon, May 19, 2025 at 01:35:46PM +0300, Cristian Ciocaltea wrote: > >> On 5/19/25 10:22 AM, Maxime Ripard wrote: > >>> Hi, > >>> >

Re: [PATCH v4 23/23] drm/tests: hdmi: Add test for unsupported RGB/YUV420 mode

2025-05-22 Thread Maxime Ripard
Hi, On Mon, May 19, 2025 at 01:55:10PM +0300, Cristian Ciocaltea wrote: > On 5/19/25 11:42 AM, Maxime Ripard wrote: > > Hi, > > > > On Fri, Apr 25, 2025 at 01:27:14PM +0300, Cristian Ciocaltea wrote: > >> Provide a test to verify that if both driver and screen suppo

Re: [PATCH v4 14/23] drm/tests: hdmi: Add macro to support EDEADLK handling

2025-05-22 Thread Maxime Ripard
On Mon, May 19, 2025 at 01:35:46PM +0300, Cristian Ciocaltea wrote: > On 5/19/25 10:22 AM, Maxime Ripard wrote: > > Hi, > > > > On Fri, Apr 25, 2025 at 01:27:05PM +0300, Cristian Ciocaltea wrote: > >> In preparation to improve error handling throughout all test ca

Re: [PATCH v7 2/2] drm/tests: bridge: add a KUnit test for devm_drm_bridge_alloc()

2025-05-22 Thread Maxime Ripard
On Fri, May 16, 2025 at 05:38:28PM +0200, Luca Ceresoli wrote: > > > Another way would be adding an optional .destroy a callback in struct > > > drm_bridge_funcs that is called in __drm_bridge_free(), and only the > > > kunit test code implements it. Maybe looks cleaner, but it would be > > > invas

Re: [PATCH v8 2/3] dmr/bridge: add a .destroy func

2025-05-22 Thread Maxime Ripard
On Fri, May 16, 2025 at 06:48:38PM +0200, Luca Ceresoli wrote: > Some users of DRM bridges may need to execute specific code just before > deallocation. > > As of now the only known user would be KUnit tests. > > Suggested-by: Maxime Ripard > Signed-off-by: Luca Ceresol

Re: [PATCH v18 6/8] drm/vkms: Create KUnit tests for YUV conversions

2025-05-22 Thread Maxime Ripard
On Mon, May 12, 2025 at 03:07:55PM +0200, Louis Chauvet wrote: > Hi Maxime, > > Did you have the time to look at this patch? > > Pekka added his Acked-by, but as you made some remarks about this patch, I > would like to have your validation before applying it. Yep, thank you

Re: [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc()

2025-05-22 Thread Maxime Ripard
On Thu, May 22, 2025 at 11:20:17AM +0800, Liu Ying wrote: > >> drm: convert many bridge drivers from devm_kzalloc() to > >> devm_drm_bridge_alloc() API > > > > This patch affects multiple drivers. Running get_maintainers.pl > > points at Shawn Guo's repository. After reviewing the MAINTAINE

Re: [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc()

2025-05-22 Thread Maxime Ripard
On Wed, May 21, 2025 at 04:22:16PM +0200, Luca Ceresoli wrote: > Hello Maxime, Shawn, Liu, all, > > On Fri, 09 May 2025 15:53:26 +0200 > Luca Ceresoli wrote: > > > devm_drm_bridge_alloc() [0] is the new API to allocate and initialize a DRM > > bridge, and the only one supported from now on. It i

Re: [PATCH v2 2/2] dma-buf: heaps: Give default CMA heap a fixed name

2025-05-21 Thread Maxime Ripard
Hi Jared, On Thu, Apr 24, 2025 at 09:11:24AM -0700, Jared Kangas wrote: > > > struct cma_heap { > > > struct dma_heap *heap; > > > @@ -394,15 +395,26 @@ static int __init __add_cma_heap(struct cma *cma, > > > const char *name) > > > static int __init add_default_cma_heap(void) > > > { > > >

Re: [PATCH v3 00/30] drm/panel: Use refcounted allocation in place of devm_kzalloc() - Part2

2025-05-21 Thread Maxime Ripard
On Tue, 20 May 2025 22:03:31 -0500, Anusha Srivatsa wrote: > Convert drivers to use the API - devm_drm_panel_alloc(). > There are a lot of occurences of the panel allocation across the > subsystem. Much thanks to Maxime for the semanic patch which actually > gives a list of panels allocated unsafel

[PATCH v4] dma-buf: heaps: Introduce a new heap for reserved memory

2025-05-20 Thread Maxime Ripard
Some reserved memory regions might have particular memory setup or attributes that make them good candidates for heaps. Let's provide a heap type that will create a new heap for each reserved memory region flagged as such. Signed-off-by: Maxime Ripard --- Hi, This series is the follow-

Re: [PATCH v2] drm/tests: Drop drm_kunit_helper_acquire_ctx_alloc()

2025-05-20 Thread Maxime Ripard
Hi Catalin, On Wed, Apr 16, 2025 at 10:34:05AM +0100, Catalin Marinas wrote: > On Thu, Feb 20, 2025 at 02:25:37PM +0100, Maxime Ripard wrote: > > lockdep complains when a lock is released in a separate thread the > > lock is taken in, and it turns out that kunit does run i

[PATCH] drm/vc4: tests: pv_muxing: Fix locking

2025-05-20 Thread Maxime Ripard
m_vc4_test_pv_muxing() and drm_vc4_test_pv_muxing_invalid(). Fixes: 30188df0c387 ("drm/tests: Drop drm_kunit_helper_acquire_ctx_alloc()") Reported-by: Catalin Marinas Closes: https://lore.kernel.org/r/z_95jwm2ymtgy...@arm.com/ Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/t

[PATCH] Documentation: dma-buf: heaps: Add naming guidelines

2025-05-20 Thread Maxime Ripard
We've discussed a number of times of how some heap names are bad, but not really what makes a good heap name. Let's document what we expect the heap names to look like. Signed-off-by: Maxime Ripard --- Documentation/userspace-api/dma-buf-heaps.rst | 19 +++ 1 file c

Re: [PATCH v4 18/23] drm/tests: hdmi: Add limited range tests for YUV420 mode

2025-05-19 Thread Maxime Ripard
of > Broadcast RGB property is. > > > [ ... ] Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v4 2/4] drm/panel: Add refcount support

2025-05-19 Thread Maxime Ripard
On Wed, May 14, 2025 at 12:22:40PM +0300, Jani Nikula wrote: > On Tue, 13 May 2025, Maxime Ripard wrote: > > Is it really surprising you get some pushback when you are using a > > design that is the complete opposite to what every user of it for the > > last decade has

Re: [PATCH v4 20/23] drm/tests: hdmi: Provide EDID supporting 4K@30Hz with RGB/YUV

2025-05-19 Thread Maxime Ripard
On Fri, 25 Apr 2025 13:27:11 +0300, Cristian Ciocaltea wrote: > Create a test EDID advertising the following capabilities: > > Max resolution: 3840x2160@30Hz with RGB, YUV444, YUV422, YUV420 > Max BPC:16 for all modes > Max TMDS clock: 340 MHz > > [ ... ] Ac

Re: [PATCH v4 19/23] drm/tests: hdmi: Rename max TMDS rate fallback tests

2025-05-19 Thread Maxime Ripard
d test cases. > > > [ ... ] Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v4 21/23] drm/tests: hdmi: Add max TMDS rate fallback tests for YUV420 mode

2025-05-19 Thread Maxime Ripard
On Fri, 25 Apr 2025 13:27:12 +0300, Cristian Ciocaltea wrote: > Provide tests to verify drm_atomic_helper_connector_hdmi_check() helper > fallback behavior when using YUV420 output format. > > Signed-off-by: Cristian Ciocaltea Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH] drm/virtio: implement virtio_gpu_shutdown

2025-05-19 Thread Maxime Ripard
On Sun, May 18, 2025 at 05:53:59PM -0400, Michael S. Tsirkin wrote: > On Tue, May 13, 2025 at 12:18:44PM +0200, Gerd Hoffmann wrote: > > > > diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.c > > > > b/drivers/gpu/drm/virtio/virtgpu_drv.c > > > > index e32e680c7197..71c6ccad4b99 100644 > > > > ---

Re: [PATCH v4 23/23] drm/tests: hdmi: Add test for unsupported RGB/YUV420 mode

2025-05-19 Thread Maxime Ripard
Hi, On Fri, Apr 25, 2025 at 01:27:14PM +0300, Cristian Ciocaltea wrote: > Provide a test to verify that if both driver and screen support RGB and > YUV420 formats, drm_atomic_helper_connector_hdmi_check() cannot succeed > when trying to set a mode unsupported by the display. > > Signed-off-by: Cr

Re: [PATCH v4 22/23] drm/tests: hdmi: Add test for unsuccessful fallback to YUV420

2025-05-19 Thread Maxime Ripard
On Fri, 25 Apr 2025 13:27:13 +0300, Cristian Ciocaltea wrote: > Provide test to verify a mandatory fallback to YUV420 output cannot > succeed when driver doesn't advertise YUV420 support. > > Signed-off-by: Cristian Ciocaltea Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v4 17/23] drm/tests: hdmi: Provide EDID supporting 4K@30Hz with YUV420 only

2025-05-19 Thread Maxime Ripard
On Fri, 25 Apr 2025 13:27:08 +0300, Cristian Ciocaltea wrote: > Create a test EDID advertising the following capabilities: > > Max resolution: > - 1920x1080@60Hz with RGB, YUV444, YUV422 > - 3840x2160@30Hz with YUV420 only > > [ ... ] Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v6 05/10] drm/display: add CEC helpers code

2025-05-19 Thread Maxime Ripard
ate it or to unregister CEC data. Unlike drm_connector_cec_funcs > (which provides interface common to all implementations, including, but > > [ ... ] Reviewed-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v6 10/10] drm/bridge: adv7511: switch to the HDMI connector helpers

2025-05-19 Thread Maxime Ripard
he connector to be provided by the bridge. > > > [ ... ] Reviewed-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v6 07/10] drm/vc4: hdmi: switch to generic CEC helpers

2025-05-19 Thread Maxime Ripard
On Sat, 17 May 2025 04:59:43 +0300, Dmitry Baryshkov wrote: > Switch VC4 driver to using CEC helpers code, simplifying hotplug and > registration / cleanup. The existing vc4_hdmi_cec_release() is kept for > now. > > Signed-off-by: Dmitry Baryshkov > > [ ... ] Revie

Re: [PATCH v6 03/10] drm/connector: add CEC-related fields

2025-05-19 Thread Maxime Ripard
; CEC data is a void pointer as it allows us to make CEC data > > [ ... ] Reviewed-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v4 16/23] drm/tests: hdmi: Switch to drm_atomic_get_new_connector_state() where possible

2025-05-19 Thread Maxime Ripard
to only read the new connector state. > > > [ ... ] Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v4 14/23] drm/tests: hdmi: Add macro to support EDEADLK handling

2025-05-19 Thread Maxime Ripard
Hi, On Fri, Apr 25, 2025 at 01:27:05PM +0300, Cristian Ciocaltea wrote: > In preparation to improve error handling throughout all test cases, > introduce a macro to check for EDEADLK and automate the restart of the > atomic sequence. > > Signed-off-by: Cristian Ciocaltea > --- > drivers/gpu/drm

Re: [PATCH v4 12/23] drm/tests: helpers: Add a (re)try helper variant to enable CRTC connector

2025-05-16 Thread Maxime Ripard
Hi, On Fri, Apr 25, 2025 at 01:27:03PM +0300, Cristian Ciocaltea wrote: > Provide a wrapper over drm_kunit_helper_enable_crtc_connector() to > automatically handle EDEADLK. > > This is going to help improve the error handling in a bunch of test > cases without open coding the restart of the atomi

Re: [PATCH v4 10/23] drm/tests: hdmi: Drop unused drm_kunit_helper_connector_hdmi_init_funcs()

2025-05-16 Thread Maxime Ripard
On Fri, 25 Apr 2025 13:27:01 +0300, Cristian Ciocaltea wrote: > After updating the code to make use of the new EDID setup helper, > drm_kunit_helper_connector_hdmi_init_funcs() became unused, hence drop > it. > > Signed-off-by: Cristian Ciocaltea > > [ ... ] Acked-by: M

Re: [PATCH v4 09/23] drm/tests: hdmi: Replace open coded EDID setup

2025-05-15 Thread Maxime Ripard
On Fri, 25 Apr 2025 13:27:00 +0300, Cristian Ciocaltea wrote: > Make use of the recently introduced macros to reduce boilerplate code > around EDID setup. This also helps dropping the redundant calls to > set_connector_edid(). > > No functional changes intended. > > [ ..

Re: [PATCH v4 06/23] drm/connector: hdmi: Use YUV420 output format as an RGB fallback

2025-05-15 Thread Maxime Ripard
On Thu, May 15, 2025 at 03:44:18PM +0300, Cristian Ciocaltea wrote: > Hi Maxime, > > On 5/13/25 4:35 PM, Maxime Ripard wrote: > > Hi, > > > > On Fri, Apr 25, 2025 at 01:26:57PM +0300, Cristian Ciocaltea wrote: > >> Try to make use of YUV420 when computing

Re: [PATCH v7 2/2] drm/tests: bridge: add a KUnit test for devm_drm_bridge_alloc()

2025-05-15 Thread Maxime Ripard
On Tue, Apr 15, 2025 at 01:22:14PM +0200, Luca Ceresoli wrote: > > > +/* > > > + * Mimick the typical struct defined by a bridge driver, which embeds a > > > + * bridge plus other fields. > > > + */ > > > +struct dummy_drm_bridge { > > > + int dummy; // ensure we test non-zero @bridge offset > > >

Re: [PATCH v10 09/11] drm: sun4i: de33: vi_scaler: add Display Engine 3.3 (DE33) support

2025-05-14 Thread Maxime Ripard
On Sun, 11 May 2025 22:31:18 +1200, Ryan Walklin wrote: > From: Jernej Skrabec > > The vi_scaler appears to be used in preference to the ui_scaler module > for hardware video scaling in the DE33. > > > [ ... ] Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v10 01/11] drm: sun4i: de2/de3: add mixer version enum

2025-05-14 Thread Maxime Ripard
On Sun, 11 May 2025 22:31:10 +1200, Ryan Walklin wrote: > From: Jernej Skrabec > > The Allwinner DE2 and DE3 display engine mixers are currently identified > by a simple boolean flag. This will not scale to support additional DE > variants. > > [ ... ] Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v10 02/11] drm: sun4i: de2/de3: refactor mixer initialisation

2025-05-14 Thread Maxime Ripard
On Sun, 11 May 2025 22:31:11 +1200, Ryan Walklin wrote: > From: Jernej Skrabec > > Now that the DE variant can be selected by enum, take the oppportunity > to factor out some common initialisation code to a separate function. > > > [ ... ] Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v10 04/11] drm: sun4i: de2/de3: use generic register reference function for layer configuration

2025-05-14 Thread Maxime Ripard
On Sun, 11 May 2025 22:31:13 +1200, Ryan Walklin wrote: > From: Jernej Skrabec > > Use the new blender register lookup function where required in the layer > commit and update code. > > > [ ... ] Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v10 03/11] drm: sun4i: de2/de3: add generic blender register reference function

2025-05-14 Thread Maxime Ripard
On Sun, 11 May 2025 22:31:12 +1200, Ryan Walklin wrote: > From: Jernej Skrabec > > The DE2 and DE3 engines have a blender register range within the > mixer engine register map, whereas the DE33 separates this out into > a separate display group. > > [ ... ] Acked-by: M

Re: [PATCH v10 11/11] drm: sun4i: de33: mixer: add mixer configuration for the H616

2025-05-14 Thread Maxime Ripard
On Sun, 11 May 2025 22:31:20 +1200, Ryan Walklin wrote: > From: Jernej Skrabec > > The H616 (and related SoC packages sharing the same die) carry the new > DE33 display engine. > > > [ ... ] Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v10 10/11] drm: sun4i: de33: mixer: add Display Engine 3.3 (DE33) support

2025-05-14 Thread Maxime Ripard
_control_get(dev, NULL); > if (IS_ERR(mixer->reset)) { > dev_err(dev, "Couldn't get our reset line\n"); > diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.h > b/drivers/gpu/drm/sun4i/sun8i_mixer.h > index 43c413052a22..d87d197610e1 100644 >

Re: [PATCH 1/2] drm/tidss: Add some support for splash-screen

2025-05-14 Thread Maxime Ripard
Hi Tomi, On Wed, Apr 16, 2025 at 02:06:29PM +0300, Tomi Valkeinen wrote: > Currently when the driver's probe is called, we do a full DSS reset. If > the bootloader has set up a splash-screen, the reset will disable the > video output, and after that it may still take time until the display is > us

Re: [PATCH v4 08/23] drm/tests: hdmi: Add macro to simplify EDID setup

2025-05-13 Thread Maxime Ripard
efault) EDID data. > > > [ ... ] Reviewed-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v4 06/23] drm/connector: hdmi: Use YUV420 output format as an RGB fallback

2025-05-13 Thread Maxime Ripard
Hi, On Fri, Apr 25, 2025 at 01:26:57PM +0300, Cristian Ciocaltea wrote: > Try to make use of YUV420 when computing the best output format and > RGB cannot be supported for any of the available color depths. > > Signed-off-by: Cristian Ciocaltea > --- > drivers/gpu/drm/display/drm_hdmi_state_hel

Re: [PATCH v4 2/4] drm/panel: Add refcount support

2025-05-13 Thread Maxime Ripard
On Fri, May 09, 2025 at 03:45:36PM +0300, Jani Nikula wrote: > On Fri, 09 May 2025, Maxime Ripard wrote: > > On Thu, May 08, 2025 at 05:27:21PM +0300, Jani Nikula wrote: > >> On Mon, 05 May 2025, Anusha Srivatsa wrote: > >> > On Mon, May 5, 2025 at 2:54 AM Maxime Ri

Re: [PATCH] drm/virtio: implement virtio_gpu_shutdown

2025-05-10 Thread Maxime Ripard
Hi, On Wed, May 07, 2025 at 10:28:21AM +0200, Gerd Hoffmann wrote: > Calling drm_dev_unplug() is the drm way to say the device > is gone and can not be accessed any more. > > Cc: Michael S. Tsirkin > Signed-off-by: Gerd Hoffmann > Reviewed-by: Eric Auger > Tested-by: Eric Auger > --- > drive

Re: [PATCH v3 22/22] drm/todo: add entry to remove devm_drm_put_bridge()

2025-05-10 Thread Maxime Ripard
On Fri, 9 May 2025 15:53:48 +0200, Luca Ceresoli wrote: > devm_drm_put_bridge() is a temporary workaround waiting for the panel > bridge lifetime rework. Add a TODO entry to not forget it must be removed > after such rework. > > Suggested-by: Maxime Ripard > > [ ... ] Ac

Re: [PATCH v3 21/22] drm/bridge: panel: convert to devm_drm_bridge_alloc() API

2025-05-10 Thread Maxime Ripard
->dev). However the panel_bridge allocation is not > > [ ... ] Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 12/22] drm/omap: dss: sdi: convert to devm_drm_bridge_alloc() API

2025-05-10 Thread Maxime Ripard
mplify the code flow by removing now unnecessary gotos. > > [ ... ] Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 20/22] drm/bridge: add devm_drm_put_bridge()

2025-05-10 Thread Maxime Ripard
f they bind the devm removal action to a > > [ ... ] Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 16/22] drm/sti: dvo: convert to devm_drm_bridge_alloc() API

2025-05-10 Thread Maxime Ripard
y replacing the struct drm_bridge pointer with an > > [ ... ] Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 14/22] drm/rcar-du: dsi: convert to devm_drm_bridge_alloc() API

2025-05-10 Thread Maxime Ripard
On Fri, 9 May 2025 15:53:40 +0200, Luca Ceresoli wrote: > This is the new API for allocating DRM bridges. > > Signed-off-by: Luca Ceresoli > Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 07/22] drm/bridge: sii902x: convert to devm_drm_bridge_alloc() API

2025-05-10 Thread Maxime Ripard
On Fri, 9 May 2025 15:53:33 +0200, Luca Ceresoli wrote: > This is the new API for allocating DRM bridges. > > Signed-off-by: Luca Ceresoli Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 17/22] drm: zynqmp_dp: convert to devm_drm_bridge_alloc() API

2025-05-10 Thread Maxime Ripard
drm_bridge and its initialization, however it > > [ ... ] Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 15/22] drm/bridge: stm_lvds: convert to devm_drm_bridge_alloc() API

2025-05-10 Thread Maxime Ripard
On Fri, 9 May 2025 15:53:41 +0200, Luca Ceresoli wrote: > This is the new API for allocating DRM bridges. > > Signed-off-by: Luca Ceresoli > Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 13/22] drm/omap: dss: venc: convert to devm_drm_bridge_alloc() API

2025-05-10 Thread Maxime Ripard
mplify the code flow by removing now unnecessary gotos. > > [ ... ] Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 11/22] drm/omap: dss: hdmi5: convert to devm_drm_bridge_alloc() API

2025-05-10 Thread Maxime Ripard
mplify the code flow by removing now unnecessary gotos. > > [ ... ] Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 10/22] drm/omap: dss: hdmi4: convert to devm_drm_bridge_alloc() API

2025-05-10 Thread Maxime Ripard
mplify the code flow by removing now unnecessary gotos. > > [ ... ] Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 09/22] drm/omap: dss: dsi: convert to devm_drm_bridge_alloc() API

2025-05-10 Thread Maxime Ripard
On Fri, 9 May 2025 15:53:35 +0200, Luca Ceresoli wrote: > This is the new API for allocating DRM bridges. > > Signed-off-by: Luca Ceresoli > Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 08/22] drm/omap: dss: dpi: convert to devm_drm_bridge_alloc() API

2025-05-10 Thread Maxime Ripard
On Fri, 9 May 2025 15:53:34 +0200, Luca Ceresoli wrote: > This is the new API for allocating DRM bridges. > > Signed-off-by: Luca Ceresoli > Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 06/22] drm/bridge: nxp-ptn3460: convert to devm_drm_bridge_alloc() API

2025-05-10 Thread Maxime Ripard
On Fri, 9 May 2025 15:53:32 +0200, Luca Ceresoli wrote: > This is the new API for allocating DRM bridges. > > Signed-off-by: Luca Ceresoli Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 05/22] drm/bridge: megachips-stdpxxxx-ge-b850v3-fw: convert to devm_drm_bridge_alloc() API

2025-05-10 Thread Maxime Ripard
On Fri, 9 May 2025 15:53:31 +0200, Luca Ceresoli wrote: > This is the new API for allocating DRM bridges. > > Signed-off-by: Luca Ceresoli > Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 04/22] drm/bridge: cdns-dsi: convert to devm_drm_bridge_alloc() API

2025-05-10 Thread Maxime Ripard
On Fri, May 09, 2025 at 03:53:30PM +0200, Luca Ceresoli wrote: > This is the new API for allocating DRM bridges. > > Signed-off-by: Luca Ceresoli Acked-by: Maxime Ripard Maxime signature.asc Description: PGP signature

Re: [PATCH v3 03/22] drm/bridge: anx7625: convert to devm_drm_bridge_alloc() API

2025-05-10 Thread Maxime Ripard
On Fri, May 09, 2025 at 03:53:29PM +0200, Luca Ceresoli wrote: > This is the new API for allocating DRM bridges. > > Signed-off-by: Luca Ceresoli Acked-by: Maxime Ripard signature.asc Description: PGP signature

Re: [PATCH v3 02/22] drm: convert many bridge drivers from devm_kzalloc() to devm_drm_bridge_alloc() API

2025-05-10 Thread Maxime Ripard
R_ERR(C); > ) >... > -C->BR.funcs = FUNCS; > > Reviewed-by: Manikandan Muralidharan # > microchip-lvds.c > Reviewed-by: Douglas Anderson # parade-ps8640 > Tested-by: Douglas Anderson # parade-ps8640 > Signed-off-by: Luca Ceresoli Acked-by: Maxime Ripard Maxime signature.asc Description: PGP signature

Re: [PATCH v4 2/4] drm/panel: Add refcount support

2025-05-09 Thread Maxime Ripard
On Thu, May 08, 2025 at 05:27:21PM +0300, Jani Nikula wrote: > On Mon, 05 May 2025, Anusha Srivatsa wrote: > > On Mon, May 5, 2025 at 2:54 AM Maxime Ripard wrote: > > > >> Hi Jani, > >> > >> On Tue, Apr 29, 2025 at 12:22:00PM +0300, Jani Nikula wrote:

Re: [PATCH v2 2/2] dma-buf: heaps: Give default CMA heap a fixed name

2025-05-06 Thread Maxime Ripard
On Tue, Apr 29, 2025 at 09:25:00AM -0700, John Stultz wrote: > On Mon, Apr 28, 2025 at 7:52 AM Maxime Ripard wrote: > > On Fri, Apr 25, 2025 at 12:39:40PM -0700, John Stultz wrote: > > > To your larger point about policy, I do get the tension that you want > > > to

Re: [PATCH v4 2/4] drm/panel: Add refcount support

2025-05-04 Thread Maxime Ripard
Hi Jani, On Tue, Apr 29, 2025 at 12:22:00PM +0300, Jani Nikula wrote: > On Tue, 29 Apr 2025, Maxime Ripard wrote: > > Hi Jani, > > > > On Mon, Apr 28, 2025 at 07:31:50PM +0300, Jani Nikula wrote: > >> On Mon, 31 Mar 2025, Anusha Srivatsa wrote: > >> >

Re: [PATCH v2 34/34] drm/bridge: panel: convert to devm_drm_bridge_alloc() API

2025-05-04 Thread Maxime Ripard
On Mon, Apr 28, 2025 at 05:25:16PM +0200, Luca Ceresoli wrote: > Hi Maxime, > > On Mon, 28 Apr 2025 13:39:23 +0200 > Maxime Ripard wrote: > > > On Thu, Apr 24, 2025 at 10:05:49PM +0200, Luca Ceresoli wrote: > > > This is the new API for allocating DRM bridges.

Re: (subset) [PATCH v2 00/34] drm: convert all bridges to devm_drm_bridge_alloc()

2025-04-30 Thread Maxime Ripard
On Tue, Apr 29, 2025 at 02:41:42PM +0200, Louis Chauvet wrote: > Le 29/04/2025 à 11:27, Louis Chauvet a écrit : > > > > On Thu, 24 Apr 2025 20:59:07 +0200, Luca Ceresoli wrote: > > > devm_drm_bridge_alloc() [0] is the new API to allocate and initialize a > > > DRM > > > bridge, and the only one s

Re: (subset) [PATCH v2 00/34] drm: convert all bridges to devm_drm_bridge_alloc()

2025-04-30 Thread Maxime Ripard
On Wed, Apr 30, 2025 at 10:21:48AM +0200, Louis Chauvet wrote: > > > Le 29/04/2025 à 16:42, Dmitry Baryshkov a écrit : > > On Tue, Apr 29, 2025 at 11:27:51AM +0200, Louis Chauvet wrote: > > > > > > On Thu, 24 Apr 2025 20:59:07 +0200, Luca Ceresoli wrote: > > > > devm_drm_bridge_alloc() [0] is th

[PULL] drm-misc-fixes

2025-04-30 Thread Maxime Ripard
ELPER from DRM_DEBUG_DP_MST_TOPOLOGY_REFS Karol Wachowski (1): accel/ivpu: Correct DCT interrupt handling Maxime Ripard (1): drm/tests: shmem: Fix memleak Philipp Stanner (1): drm/nouveau: Fix WARN_ON in nouveau_fence_context_kill() Russell Cloran (1): drm/mipi-dbi: Fix blanking

Re: [PATCH v5 06/11] drm/display: add CEC helpers code

2025-04-29 Thread Maxime Ripard
On Tue, Apr 15, 2025 at 07:01:25PM +0300, Dmitry Baryshkov wrote: > On 14/04/2025 17:58, Maxime Ripard wrote: > > On Mon, Apr 07, 2025 at 06:11:03PM +0300, Dmitry Baryshkov wrote: > > > +static void drm_connector_hdmi_cec_adapter_unregister(struct > > &g

Re: [PATCH v5 04/11] drm/connector: unregister CEC data

2025-04-29 Thread Maxime Ripard
On Tue, Apr 15, 2025 at 12:03:23PM +0300, Dmitry Baryshkov wrote: > On 14/04/2025 17:47, Maxime Ripard wrote: > > Hi, > > > > On Mon, Apr 07, 2025 at 06:11:01PM +0300, Dmitry Baryshkov wrote: > > > In order to make sure that CEC adapters or notifiers are unregistered

Re: [PATCH v5 03/11] drm/connector: add CEC-related fields

2025-04-29 Thread Maxime Ripard
On Tue, Apr 15, 2025 at 12:10:06PM +0300, Dmitry Baryshkov wrote: > On 14/04/2025 17:52, Maxime Ripard wrote: > > Hi, > > > > On Mon, Apr 07, 2025 at 06:11:00PM +0300, Dmitry Baryshkov wrote: > > > +/** > > > + * struct drm_connector_ce

Re: [PATCH] drm/mipi-dbi: Fix blanking for non-16 bit formats

2025-04-29 Thread Maxime Ripard
On Mon, 14 Apr 2025 22:32:59 -0700, Russell Cloran wrote: > On r6x2b6x2g6x2 displays not enough blank data is sent to blank the > entire screen. When support for these displays was added, the dirty > function was updated to handle the different amount of data, but > blanking was not, and remained h

Re: [PATCH] drm/tests: shmem: Fix memleak

2025-04-29 Thread Maxime Ripard
On Tue, 08 Apr 2025 16:07:58 +0200, Maxime Ripard wrote: > The drm_gem_shmem_test_get_pages_sgt() gets a scatter-gather table using > the drm_gem_shmem_get_sg_table() function and rightfully calls > sg_free_table() on it. However, it's also supposed to kfree() the > returned sg_t

Re: [PATCH v4 2/4] drm/panel: Add refcount support

2025-04-29 Thread Maxime Ripard
nsuring panel pointer is valid and can be usable till the last > > reference is put. > > > > Reviewed-by: Luca Ceresoli > > Reviewed-by: Maxime Ripard > > Signed-off-by: Anusha Srivatsa > > > > --- > > v4: Add refcounting documentation in this p

Re: [PATCH v2 00/34] drm: convert all bridges to devm_drm_bridge_alloc()

2025-04-28 Thread Maxime Ripard
On Mon, Apr 28, 2025 at 05:24:57PM +0200, Luca Ceresoli wrote: > Hi Maxime, other DRM maintainers, > > On Thu, 24 Apr 2025 20:59:07 +0200 > Luca Ceresoli wrote: > > > devm_drm_bridge_alloc() [0] is the new API to allocate and initialize a DRM > > bridge, and the only one supported from now on. I

Re: [PATCH v2 2/2] dma-buf: heaps: Give default CMA heap a fixed name

2025-04-28 Thread Maxime Ripard
Hi John, On Fri, Apr 25, 2025 at 12:39:40PM -0700, John Stultz wrote: > On Thu, Apr 24, 2025 at 11:58 PM Maxime Ripard wrote: > > On Thu, Apr 24, 2025 at 05:13:47PM -0700, John Stultz wrote: > > > On Thu, Apr 24, 2025 at 1:34 AM Maxime Ripard wrote: > > > > I appre

Re: [PATCH v2 34/34] drm/bridge: panel: convert to devm_drm_bridge_alloc() API

2025-04-28 Thread Maxime Ripard
On Thu, Apr 24, 2025 at 10:05:49PM +0200, Luca Ceresoli wrote: > This is the new API for allocating DRM bridges. > > The devm lifetime management of this driver is peculiar. The underlying > device for the panel_bridge is the panel, and the devm lifetime is tied the > panel device (panel->dev). Ho

Re: [PATCH v3 0/2] dma-buf: heaps: Support carved-out heaps

2025-04-25 Thread Maxime Ripard
Hi, On Mon, Apr 07, 2025 at 06:29:06PM +0200, Maxime Ripard wrote: > Hi, > > This series is the follow-up of the discussion that John and I had some > time ago here: > > https://lore.kernel.org/all/candhncqujn6bh3kxkf65bwitylvqsd9892-xtfdhhqqyrro...@mail.gmail.com/ > >

Re: [PATCH v3 2/2] dma-buf: heaps: Introduce a new heap for reserved memory

2025-04-25 Thread Maxime Ripard
On Mon, Apr 14, 2025 at 12:43:44PM -0500, Andrew Davis wrote: > On 4/11/25 3:26 PM, T.J. Mercier wrote: > > On Mon, Apr 7, 2025 at 9:29 AM Maxime Ripard wrote: > > > > > > Some reserved memory regions might have particular memory setup or > > > attributes that

Re: [PATCH v2 1/4] PM: device: Introduce platform_resources_managed flag

2025-04-25 Thread Maxime Ripard
Hi, On Thu, Apr 24, 2025 at 06:51:00PM +0200, Ulf Hansson wrote: > On Thu, 17 Apr 2025 at 18:19, Michal Wilczynski > wrote: > > On 4/16/25 16:48, Rafael J. Wysocki wrote: > > > On Wed, Apr 16, 2025 at 3:32 PM Michal Wilczynski > > > wrote: > > >> > > >> On 4/15/25 18:42, Rafael J. Wysocki wrote:

Re: [PATCH v2 2/2] dma-buf: heaps: Give default CMA heap a fixed name

2025-04-25 Thread Maxime Ripard
On Thu, Apr 24, 2025 at 05:13:47PM -0700, John Stultz wrote: > On Thu, Apr 24, 2025 at 1:34 AM Maxime Ripard wrote: > > On Tue, Apr 22, 2025 at 12:19:39PM -0700, Jared Kangas wrote: > > > @@ -22,6 +22,7 @@ > > > #include > > > #include > > >

Re: [PATCH v2 2/2] dma-buf: heaps: Give default CMA heap a fixed name

2025-04-24 Thread Maxime Ripard
Hi Jared, Thanks for working on this On Tue, Apr 22, 2025 at 12:19:39PM -0700, Jared Kangas wrote: > The CMA heap's name in devtmpfs can vary depending on how the heap is > defined. Its name defaults to "reserved", but if a CMA area is defined > in the devicetree, the heap takes on the devicetree

Re: [PATCH v7 1/2] drm/bridge: documentat bridge allocation and lifecycle

2025-04-15 Thread Maxime Ripard
Hi, On Wed, Apr 09, 2025 at 04:50:34PM +0200, Luca Ceresoli wrote: > Document in detail the DRM bridge allocation and refcounting process based > on the recently introduced devm_drm_bridge_alloc(). > > Signed-off-by: Luca Ceresoli There's a typo in your commit title. > --- > > Changes in v7:

  1   2   3   4   5   6   7   8   9   10   >