Re: [PATCH v5] drm/msm/dp: add logs across DP driver for ease of debugging

2021-07-26 Thread maitreye
Thank you Stephen for reviewing. On 2021-07-26 14:31, Stephen Boyd wrote: Quoting maitreye (2021-07-26 10:36:26) @@ -509,6 +515,7 @@ static int dp_display_usbpd_attention_cb(struct device *dev) DRM_ERROR("invalid dev\n"); retu

[PATCH v6] drm/msm/dp: add logs across DP driver for ease of debugging

2021-07-26 Thread maitreye
From: Maitreyee Rao Add trace points across the MSM DP driver to help debug interop issues. Changes in v2: - Got rid of redundant log messages. - Added %#x instead of 0x%x wherever required. - Got rid of __func__ calls in debug messages. - Added newline wherever missing. Changes in v3: - G

[PATCH v5] drm/msm/dp: add logs across DP driver for ease of debugging

2021-07-26 Thread maitreye
From: Maitreyee Rao Add trace points across the MSM DP driver to help debug interop issues. Changes in v2: - Got rid of redundant log messages. - Added %#x instead of 0x%x wherever required. - Got rid of __func__ calls in debug messages. - Added newline wherever missing. Changes in v3: - G

Re: [PATCH v4] drm/msm/dp: add logs across DP driver for ease of debugging

2021-07-22 Thread maitreye
On 2021-07-22 15:09, Stephen Boyd wrote: Thank you for the comments . Quoting maitr...@codeaurora.org (2021-07-22 14:33:43) Thank you Stephen. On 2021-07-22 13:31, Stephen Boyd wrote: > Quoting maitreye (2021-07-21 16:19:40) >> From: Maitreyee Rao >> >> Add trace poi

Re: [PATCH v4] drm/msm/dp: add logs across DP driver for ease of debugging

2021-07-22 Thread maitreye
Thank you Stephen. On 2021-07-22 13:31, Stephen Boyd wrote: Quoting maitreye (2021-07-21 16:19:40) From: Maitreyee Rao Add trace points across the MSM DP driver to help debug interop issues. Changes in v4: - Changed goto statement and used if else-if I think drm likes to see all the

[PATCH v4] drm/msm/dp: add logs across DP driver for ease of debugging

2021-07-21 Thread maitreye
From: Maitreyee Rao Add trace points across the MSM DP driver to help debug interop issues. Changes in v4: - Changed goto statement and used if else-if Signed-off-by: Maitreyee Rao --- drivers/gpu/drm/msm/dp/dp_catalog.c | 8 ++-- drivers/gpu/drm/msm/dp/dp_ctrl.c| 5 - drivers/

Re: [PATCH v3] drm/msm/dp: add logs across DP driver for ease of debugging

2021-07-21 Thread maitreye
Hello Stephen, Thanks again for the review comments On 2021-07-20 22:31, Stephen Boyd wrote: Quoting maitreye (2021-07-20 15:39:30) diff --git a/drivers/gpu/drm/msm/dp/dp_link.c b/drivers/gpu/drm/msm/dp/dp_link.c index be986da..316e8e6 100644 --- a/drivers/gpu/drm/msm/dp/dp_link.c +++ b

[PATCH v3] drm/msm/dp: add logs across DP driver for ease of debugging

2021-07-20 Thread maitreye
From: Maitreyee Rao Add trace points across the MSM DP driver to help debug interop issues. Changes in v3: - Got rid of redundant log messages. - Unstuck colon from printf specifier in various places. Signed-off-by: Maitreyee Rao --- drivers/gpu/drm/msm/dp/dp_catalog.c | 8 ++-- driver

Re: [PATCH v2] drm/msm/dp: add logs across DP driver for ease of debugging

2021-07-15 Thread maitreye
Hi Stephen, Thanks for reviewing my code. On 2021-07-08 18:27, Stephen Boyd wrote: Quoting maitreye (2021-07-08 12:13:44) From: Maitreyee Rao Add trace points across the MSM DP driver to help debug interop issues. Changes in v2: - Got rid of redundant log messages. - Added %#x instead of

[PATCH v2] drm/msm/dp: add logs across DP driver for ease of debugging

2021-07-08 Thread maitreye
From: Maitreyee Rao Add trace points across the MSM DP driver to help debug interop issues. Changes in v2: - Got rid of redundant log messages. - Added %#x instead of 0x%x wherever required. - Got rid of __func__ calls in debug messages. - Added newline wherever missing. Signed-off-by: Mait

[PATCH v2] drm/msm/dp: add logs across DP driver for ease of debugging

2021-06-30 Thread maitreye
From: Maitreyee Rao Add trace points across the MSM DP driver to help debug interop issues. Changes in v2: - Got rid of redundant log messages. - Added %#x instead of 0x%x wherever required. - Got rid of __func__ calls in debug messages. - Added newline wherever missing. Signed-off-by: Mait

Re: [PATCH] drm/msm/dp: add logs across DP driver for ease of debugging

2021-06-28 Thread maitreye
Hi Stephen, Thanks for the review. On 2021-06-17 15:33, Stephen Boyd wrote: Quoting maitreye (2021-06-16 18:08:54) From: Maitreyee Rao Add trace points across the MSM DP driver to help debug interop issues. Signed-off-by: Maitreyee Rao --- drivers/gpu/drm/msm/dp/dp_aux.c | 5

[PATCH] drm/msm/dp: add logs across DP driver for ease of debugging

2021-06-16 Thread maitreye
From: Maitreyee Rao Add trace points across the MSM DP driver to help debug interop issues. Signed-off-by: Maitreyee Rao --- drivers/gpu/drm/msm/dp/dp_aux.c | 5 +++-- drivers/gpu/drm/msm/dp/dp_catalog.c | 4 drivers/gpu/drm/msm/dp/dp_ctrl.c| 7 +++ drivers/gpu/drm/msm/dp/d