[PATCH v2] drm/imagination: properly support stopping LAYOUT_MARS = 1 cores

2024-09-02 Thread Icenowy Zheng
logic mimics RGXStop() function in the DDK kernel mode source code. Tested on BXE-4-32 (36.50.54.182) with firmware build 6503725 OS provided by Imagination Technologies. Signed-off-by: Icenowy Zheng --- Changes in v2: - Fixed some wrong change that moves the original logic into if(mars

Re: [PATCH] drm/imagination: properly support stopping LAYOUT_MARS = 1 cores

2024-09-02 Thread Icenowy Zheng
在 2024-09-02星期一的 09:24 +,Matt Coster写道: > On 11/08/2024 09:28, Icenowy Zheng wrote: > > Some new Rogue GPU cores have an extra MARS power domain, which > > controlls the power of the firmware core and allows the firmware > > core to > > power down most parts of the

Re: [PATCH 1/2] drm/msm/dpu: Add MSM8996 support

2024-08-18 Thread Icenowy Zheng
在 2024-06-28星期五的 16:39 +0200,Barnabás Czémán写道: > From: Konrad Dybcio > > Add support for MSM8996, which - fun fact - was the SoC that this > driver > (or rather SDE, its downstream origin) was meant for and first tested > on. > > It has some hardware that differs from the modern SoCs, so not a

[PATCH] drm/imagination: properly support stopping LAYOUT_MARS = 1 cores

2024-08-11 Thread Icenowy Zheng
logic mimics RGXStop() function in the DDK kernel mode source code. Tested on BXE-4-32 (36.50.54.182) with firmware build 6503725 OS provided by Imagination Technologies. Signed-off-by: Icenowy Zheng --- .../gpu/drm/imagination/pvr_fw_startstop.c| 49 +-- 1 file changed, 35

Re: [PATCH 4/6] drm/imagination: Add compatible string entry for Series6XT

2024-08-10 Thread Icenowy Zheng
在 2024-05-31星期五的 11:18 +,Frank Binns写道: > On Thu, 2024-05-30 at 16:35 +0800, Chen-Yu Tsai wrote: > > The MediaTek MT8173 comes with a PowerVR Rogue GX6250, which is > > part > > of the Series6XT, another variation of the Rogue family of GPUs. > > > > Signed-off-by: Chen-Yu Tsai > > --- > >  d

Re: PCIe coherency in spec (was: [RFC PATCH 2/2] drm/ttm: downgrade cached to write_combined when snooping not available)

2024-07-03 Thread Icenowy Zheng
在 2024-07-03星期三的 23:11 -0700,Christoph Hellwig写道: > On Thu, Jul 04, 2024 at 10:00:52AM +0800, Icenowy Zheng wrote: > > So I here want to ask a question as an individual hacker: what's > > the > > policy of linux-pci towards these non-coherent PCIe > > implementatio

Re: PCIe coherency in spec (was: [RFC PATCH 2/2] drm/ttm: downgrade cached to write_combined when snooping not available)

2024-07-03 Thread Icenowy Zheng
在 2024-07-03星期三的 16:08 -0500,Bjorn Helgaas写道: > On Wed, Jul 03, 2024 at 04:52:30PM +0800, Jiaxun Yang wrote: > > 在2024年7月2日七月 下午6:03,Jiaxun Yang写道: > > > 在2024年7月2日七月 下午5:27,Christian König写道: > > > > Am 02.07.24 um 11:06 schrieb Icenowy Zheng: > > > > >

Re: [RFC PATCH 2/2] drm/ttm: downgrade cached to write_combined when snooping not available

2024-07-02 Thread Icenowy Zheng
在 2024-07-02星期二的 11:27 +0200,Christian König写道: > Am 02.07.24 um 11:06 schrieb Icenowy Zheng: > > [SNIP] > > However I don't think the definition of the AGP spec could apply on > > all > > PCI(e) implementations. The AGP spec itself don't apply on > >

Re: [RFC PATCH 2/2] drm/ttm: downgrade cached to write_combined when snooping not available

2024-07-02 Thread Icenowy Zheng
在 2024-07-02星期二的 10:10 +0200,Christian König写道: > Am 02.07.24 um 10:08 schrieb Christian König: > > Am 02.07.24 um 03:46 schrieb Icenowy Zheng: > > > 在 2024-07-01星期一的 13:40 +0200,Christian König写道: > > > > Am 29.06.24 um 22:51 schrieb Icenowy Zheng: > > > >

Re: [RFC PATCH 2/2] drm/ttm: downgrade cached to write_combined when snooping not available

2024-07-02 Thread Icenowy Zheng
在 2024-07-02星期二的 10:08 +0200,Christian König写道: > Am 02.07.24 um 03:46 schrieb Icenowy Zheng: > > 在 2024-07-01星期一的 13:40 +0200,Christian König写道: > > > Am 29.06.24 um 22:51 schrieb Icenowy Zheng: > > > > 于 2024年6月30日 GMT+08:00 03:57:47,Jiaxun Yang > > >

Re: [RFC PATCH 2/2] drm/ttm: downgrade cached to write_combined when snooping not available

2024-07-01 Thread Icenowy Zheng
在 2024-07-01星期一的 13:40 +0200,Christian König写道: > Am 29.06.24 um 22:51 schrieb Icenowy Zheng: > > > > 于 2024年6月30日 GMT+08:00 03:57:47,Jiaxun Yang > > 写道: > > > > > > 在2024年6月29日六月 上午6:22,Icenowy Zheng写道: > > > [...] > >

Re: [RFC PATCH 2/2] drm/ttm: downgrade cached to write_combined when snooping not available

2024-06-29 Thread Icenowy Zheng
在 2024-06-29星期六的 20:57 +0100,Jiaxun Yang写道: > > > 在2024年6月29日六月 上午6:22,Icenowy Zheng写道: > [...] > > @@ -302,6 +302,10 @@ pgprot_t ttm_io_prot(struct ttm_buffer_object > > *bo, > > struct ttm_resource *res, > >   

Re: [RFC PATCH 2/2] drm/ttm: downgrade cached to write_combined when snooping not available

2024-06-29 Thread Icenowy Zheng
于 2024年6月30日 GMT+08:00 03:57:47,Jiaxun Yang 写道: > > >在2024年6月29日六月 上午6:22,Icenowy Zheng写道: >[...] >> @@ -302,6 +302,10 @@ pgprot_t ttm_io_prot(struct ttm_buffer_object *bo, >> struct ttm_resource *res, >> caching = res->bus.caching; >>

[RFC PATCH 2/2] drm/ttm: downgrade cached to write_combined when snooping not available

2024-06-28 Thread Icenowy Zheng
As we can now acquire the presence of the full DMA coherency (snooping capability) from ttm_device, we can now map the CPU side memory as write-combined when cached is requested and snooping is not avilable. Signed-off-by: Icenowy Zheng --- drivers/gpu/drm/ttm/ttm_bo_util.c | 4 drivers

[RFC PATCH 1/2] drm/ttm: save the device's DMA coherency status in ttm_device

2024-06-28 Thread Icenowy Zheng
f the transmission between the CPU and the device). Signed-off-by: Icenowy Zheng --- drivers/gpu/drm/ttm/ttm_device.c | 2 ++ include/drm/ttm/ttm_device.h | 5 + 2 files changed, 7 insertions(+) diff --git a/drivers/gpu/drm/ttm/ttm_device.c b/drivers/gpu/drm/ttm/ttm_device.c index 434cf025

[RFC PATCH 0/2] drm/ttm: support device w/o coherency

2024-06-28 Thread Icenowy Zheng
has a PCIe slot that can directly be seated with a PCIe graphics card) Icenowy Zheng (2): drm/ttm: save the device's DMA coherency status in ttm_device drm/ttm: downgrade cached to write_combined when snooping not available drivers/gpu/drm/ttm/ttm_bo_util.c | 4 drivers/gpu/drm/t

Re: [etnaviv-next v14 0/8] drm/etnaviv: Add driver wrapper for vivante GPUs attached on PCI(e) device

2024-06-25 Thread Icenowy Zheng
在 2024-06-25星期二的 14:01 +0200,Lucas Stach写道: > Am Dienstag, dem 25.06.2024 um 11:18 +0800 schrieb Icenowy Zheng: > > 在 2024-05-20星期一的 00:53 +0800,Sui Jingfeng写道: > > > drm/etnaviv use the component framework to bind multiple GPU > > > cores to > > > a > &g

Re: [etnaviv-next v14 0/8] drm/etnaviv: Add driver wrapper for vivante GPUs attached on PCI(e) device

2024-06-24 Thread Icenowy Zheng
在 2024-05-20星期一的 00:53 +0800,Sui Jingfeng写道: > drm/etnaviv use the component framework to bind multiple GPU cores to > a > virtual master, the virtual master is manually create during driver > load > time. This works well for various SoCs, yet there are some PCIe card > has > the vivante GPU cores

Re: [PATCH 1/2] drm/amdgpu: make duplicated EOP packet for GFX7/8 have real content

2024-06-17 Thread Icenowy Zheng
在 2024-06-17星期一的 15:59 +0200,Christian König写道: > Am 17.06.24 um 15:43 schrieb Icenowy Zheng: > > 在 2024-06-17星期一的 15:09 +0200,Christian König写道: > > > Am 17.06.24 um 15:03 schrieb Icenowy Zheng: > > > > 在 2024-06-17星期一的 14:35 +0200,Christian König写道: > > > &

Re: [PATCH 1/2] drm/amdgpu: make duplicated EOP packet for GFX7/8 have real content

2024-06-17 Thread Icenowy Zheng
在 2024-06-17星期一的 16:42 +0200,Christian König写道: > Am 17.06.24 um 16:30 schrieb Icenowy Zheng: > > 在 2024-06-17星期一的 15:59 +0200,Christian König写道: > > > Am 17.06.24 um 15:43 schrieb Icenowy Zheng: > > > > 在 2024-06-17星期一的 15:09 +0200,Christian König写道: > > > &

Re: [PATCH 1/2] drm/amdgpu: make duplicated EOP packet for GFX7/8 have real content

2024-06-17 Thread Icenowy Zheng
在 2024-06-17星期一的 15:59 +0200,Christian König写道: > Am 17.06.24 um 15:43 schrieb Icenowy Zheng: > > 在 2024-06-17星期一的 15:09 +0200,Christian König写道: > > > Am 17.06.24 um 15:03 schrieb Icenowy Zheng: > > > > 在 2024-06-17星期一的 14:35 +0200,Christian König写道: > > > &

Re: [PATCH 1/2] drm/amdgpu: make duplicated EOP packet for GFX7/8 have real content

2024-06-17 Thread Icenowy Zheng
在 2024-06-17星期一的 15:09 +0200,Christian König写道: > Am 17.06.24 um 15:03 schrieb Icenowy Zheng: > > 在 2024-06-17星期一的 14:35 +0200,Christian König写道: > > > Am 17.06.24 um 12:58 schrieb Icenowy Zheng: > > > > The duplication of EOP packets for GFX7/8, with the former

Re: [PATCH 1/2] drm/amdgpu: make duplicated EOP packet for GFX7/8 have real content

2024-06-17 Thread Icenowy Zheng
在 2024-06-17星期一的 14:35 +0200,Christian König写道: > Am 17.06.24 um 12:58 schrieb Icenowy Zheng: > > The duplication of EOP packets for GFX7/8, with the former one have > > seq-1 written and the latter one have seq written, seems to confuse > > some > > hardware platform (e

[PATCH 2/2] drm/radeon: repeat the same EOP packet for EOP workaround on CIK

2024-06-17 Thread Icenowy Zheng
Ths first EOP packet with a sequence number as seq-1 seems to confuse some PCIe hardware (e.g. Loongson 7A PCHs). Use the real sequence number instead. Fixes: a9c73a0e022c ("drm/radeon: workaround for CP HW bug on CIK") Signed-off-by: Icenowy Zheng --- drivers/gpu/drm/radeon

[PATCH 1/2] drm/amdgpu: make duplicated EOP packet for GFX7/8 have real content

2024-06-17 Thread Icenowy Zheng
possible interrupts. Fixes: bf26da927a1c ("drm/amdgpu: add cache flush workaround to gfx8 emit_fence") Fixes: a2e73f56fa62 ("drm/amdgpu: Add support for CIK parts") Signed-off-by: Icenowy Zheng --- drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 12 +--- drivers/gpu/drm/amd/am

[PATCH 0/2] Fixes of AMD GFX7/8 hang on Loongson platforms

2024-06-17 Thread Icenowy Zheng
This patchset tries to fix some workaround code in amdgpu/radeon driver, that makes Loongson 3A+7A platform suffering from GPU crashes. Icenowy Zheng (2): drm/amdgpu: make duplicated EOP packet for GFX7/8 have real content drm/radeon: repeat the same EOP packet for EOP workaround on CIK

Re: [PATCH v2 5/6] drm/panel: st7703: Drive XBD599 panel at higher clock rate

2024-02-25 Thread Icenowy Zheng
; options for > > > using a different divisor than 4. > > > > Like I said, I'm not against the patch at all, it looks great to me > > on > > principle. I just think you should completely rephrase the commit > > log > > using the datasheet as

dri-devel@lists.freedesktop.org

2023-12-26 Thread Icenowy Zheng
在 2023-12-07星期四的 19:31 +0800,Keith Zhao写道: > > > On 2023/12/7 16:41, Icenowy Zheng wrote: > > 在 2023-12-04星期一的 20:33 +0800,Keith Zhao写道: > > *snip* > > > > > +static void update_cursor_plane(struct vs_dc *dc, struct > > > vs_plane > > >

dri-devel@lists.freedesktop.org

2023-12-07 Thread Icenowy Zheng
在 2023-12-07星期四的 19:31 +0800,Keith Zhao写道: > > > On 2023/12/7 16:41, Icenowy Zheng wrote: > > 在 2023-12-04星期一的 20:33 +0800,Keith Zhao写道: > > *snip* > > > > > +static void update_cursor_plane(struct vs_dc *dc, struct > > > vs_plane > > >

dri-devel@lists.freedesktop.org

2023-12-07 Thread Icenowy Zheng
在 2023-12-04星期一的 20:33 +0800,Keith Zhao写道: *snip* > +static void update_cursor_plane(struct vs_dc *dc, struct vs_plane > *plane, > +   struct drm_plane *drm_plane, > +   struct drm_atomic_state *drm_state) > +{ > +   struct drm_plane_stat

Re: [PATCH] drm/loongson: Add support for the DC in LS2K1000 SoC

2023-10-13 Thread Icenowy Zheng
在 2023-10-12星期四的 00:26 +0800,Sui Jingfeng写道: > LS2K1000 is a low end SoC (two core 1.0gHz), it don't has dedicated > VRAM. > It requires the framebuffer to be phisically continguous to scanout. > The > display controller in LS2K1000 don't has built-in GPIO hardware, the > structure (register bit fi

[PATCH] drm/amdgpu: fix SI failure due to doorbells allocation

2023-10-08 Thread Icenowy Zheng
t;) Signed-off-by: Icenowy Zheng --- drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c index d0249ada91d30..599aece42017a 100644 --- a/drive

Re: [PATCH 2/3] clk: sunxi-ng: a64: keep tcon0 clock rate when pll-video0's rate changes

2023-08-07 Thread Icenowy Zheng
在 2023-08-07星期一的 11:48 +0200,Frank Oltmanns写道: > > On 2023-08-07 at 17:43:52 +0800, Icenowy Zheng > wrote: > > 在 2023-08-07星期一的 11:36 +0200,Frank Oltmanns写道: > > > From: Icenowy Zheng > > > > > > Notify TCON0 clock (and in consequence PLL-MIPI by >

Re: [PATCH 2/3] clk: sunxi-ng: a64: keep tcon0 clock rate when pll-video0's rate changes

2023-08-07 Thread Icenowy Zheng
在 2023-08-07星期一的 11:36 +0200,Frank Oltmanns写道: > From: Icenowy Zheng > > Notify TCON0 clock (and in consequence PLL-MIPI by > CLK_SET_RATE_PARENT) > to reset when PLL-Video0 changes (because of HDMI PHY clk which is a > child of PLL-Video0 and has CLK_SET_RATE_PARENT set). In

Re: [PATCH 1/3] clk: sunxi-ng: add support for rate resetting notifier

2023-08-07 Thread Icenowy Zheng
在 2023-08-07星期一的 11:36 +0200,Frank Oltmanns写道: > From: Icenowy Zheng > > In some situaitons, we will want a clock rate be kept while its > parent > can change, for example, to make dual-head work on A64, TCON0 clock > needs to be kept for LCD display and its parent (or grandpa

Re: [PATCH] drm/bridge: ps8640: Drop the ability of ps8640 to fetch the EDID

2023-06-14 Thread Icenowy Zheng
在 2023-06-14星期三的 14:31 -0700,Doug Anderson写道: > Hi, > > On Wed, Jun 14, 2023 at 1:22 AM AngeloGioacchino Del Regno > wrote: > > > > Il 13/06/23 01:32, Douglas Anderson ha scritto: > > > In order to read the EDID from an eDP panel, you not only need to > > > power on the bridge chip itself but al

Re: [PATCH] arm64: dts: mediatek: mt8173-elm: remove panel model number in DT

2023-05-29 Thread Icenowy Zheng
在 2023-05-29星期一的 18:28 +0200,Matthias Brugger写道: > > > On 29/05/2023 10:45, Icenowy Zheng wrote: > > 在 2023-05-29星期一的 10:02 +0200,AngeloGioacchino Del Regno写道: > > > Il 26/05/23 16:24, Doug Anderson ha scritto: > > > > Hi, > > > > >

Re: [PATCH] arm64: dts: mediatek: mt8173-elm: remove panel model number in DT

2023-05-29 Thread Icenowy Zheng
在 2023-05-29星期一的 10:02 +0200,AngeloGioacchino Del Regno写道: > Il 26/05/23 16:24, Doug Anderson ha scritto: > > Hi, > > > > On Fri, May 26, 2023 at 3:09 AM Icenowy Zheng > > wrote: > > > > > > Currently a specific panel number is used in the Elm DT

Re: [PATCH] arm64: dts: mediatek: mt8173-elm: remove panel model number in DT

2023-05-28 Thread Icenowy Zheng
在 2023-05-26星期五的 07:24 -0700,Doug Anderson写道: > Hi, > > On Fri, May 26, 2023 at 3:09 AM Icenowy Zheng wrote: > > > > Currently a specific panel number is used in the Elm DTSI, which is > > corresponded to a 12" panel. However, according to the official > &g

[PATCH] arm64: dts: mediatek: mt8173-elm: remove panel model number in DT

2023-05-28 Thread Icenowy Zheng
ces from 11" to 14", a certain panel model number shouldn't be present, and driving the panel according to its EDID information is necessary. Signed-off-by: Icenowy Zheng --- arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

Re: [PATCH] drm/sun4i: mixer: fix scanline for V3s and D1

2022-05-23 Thread Icenowy Zheng
在 2022-05-22星期日的 10:36 +0200,Jernej Škrabec写道: > Hi! > > Dne sobota, 21. maj 2022 ob 15:34:43 CEST je Genfu Pan napisal(a): > > Accrording the SDK from Allwinner, the scanline value of yuv and > > rgb for > > V3s are both 1024. > > s/scanline value/scanline length/ > > Which SDK? All SDKs that I

Re: [PATCH] drm/nouveau/bios: Use HWSQ entry 1 for PowerBook6,1

2022-02-14 Thread Icenowy Zheng
Created at https://gitlab.freedesktop.org/drm/nouveau/-/issues/158 . > > On Mon, Feb 14, 2022 at 11:03 AM Icenowy Zheng wrote: > > > > On PowerBook6,1 (PowerBook G4 867 12") HWSQ entry 0 (which is > > currently > > always used by nouveau) fails, but the BIOS declares 2 HW

[PATCH] drm/nouveau/bios: Use HWSQ entry 1 for PowerBook6,1

2022-02-14 Thread Icenowy Zheng
On PowerBook6,1 (PowerBook G4 867 12") HWSQ entry 0 (which is currently always used by nouveau) fails, but the BIOS declares 2 HWSQ entries and entry 1 works. Add a quirk to use HWSQ entry 1. Signed-off-by: Icenowy Zheng --- drivers/gpu/drm/nouveau/nouveau_bios.c | 7 +++ 1 file chang

Re: [PATCH] drm/panel: k101-im2ba02: Make use of the helper function dev_err_probe()

2021-09-16 Thread Icenowy Zheng
value > gets printed. > > Signed-off-by: Cai Huoqing Looks good to me, and thanks for pointing out this helper. Acked-by: Icenowy Zheng > --- >  drivers/gpu/drm/panel/panel-feixin-k101-im2ba02.c | 13 + >  1 file changed, 5 insertions(+), 8 deletions(-) > > diff

Re: [PATCH 3/4] drm/tiny: add simple-dbi driver

2021-08-02 Thread Icenowy Zheng
在 2021-08-02星期一的 17:08 +0200,Thomas Zimmermann写道: > Hi > > Am 02.08.21 um 08:35 schrieb Icenowy Zheng: > > Add a driver for generic MIPI DBI panels initialized with MIPI DCS > > commands. > > > > Currently a ST7789V-based panel is added to it. This panel has its

Re: [PATCH 3/4] drm/tiny: add simple-dbi driver

2021-08-02 Thread Icenowy Zheng
在 2021-08-02星期一的 14:35 +0800,Icenowy Zheng写道: > Add a driver for generic MIPI DBI panels initialized with MIPI DCS > commands. > > Currently a ST7789V-based panel is added to it. This panel has its > configuration pre-programmed into the controller, so no vendor- > specific

[PATCH 4/4] MAINTAINERS: add simple-dbi driver

2021-08-02 Thread Icenowy Zheng
As I pushed the simple-dbi driver, add myself as the maintainer now. Signed-off-by: Icenowy Zheng --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 3a00771b9fe2..e05c4910c062 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5803,6 +5803,13

[PATCH 2/4] dt-bindings: display: add binding for simple-dbi panels

2021-08-02 Thread Icenowy Zheng
ff-by: Icenowy Zheng --- .../bindings/display/simple-dbi.yaml | 72 +++ 1 file changed, 72 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/simple-dbi.yaml diff --git a/Documentation/devicetree/bindings/display/simple-dbi.yaml b/Document

[PATCH 1/4] dt-bindings: vendor-prefixes: add Zhishengxin

2021-08-02 Thread Icenowy Zheng
Shenzhen Zhishengxin Technology Co., Ltd. is a LCD module supplier. Add vendor prefix for it. Signed-off-by: Icenowy Zheng --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b

[PATCH 0/4] Add simple-dbi tinydrm driver

2021-08-02 Thread Icenowy Zheng
This patchset adds a tinydrm driver called simple-dbi, which is a driver that utilizes only standardized commands in MIPI DCS to activate a MIPI DBI panel that requires no extra configuration, usually because the configuration is pre-programmed into the OTP of the LCD controller. Icenowy Zheng (4

[PATCH 3/4] drm/tiny: add simple-dbi driver

2021-08-02 Thread Icenowy Zheng
Add a driver for generic MIPI DBI panels initialized with MIPI DCS commands. Currently a ST7789V-based panel is added to it. This panel has its configuration pre-programmed into the controller, so no vendor-specific configuration is needed. Signed-off-by: Icenowy Zheng --- drivers/gpu/drm/tiny

[PATCH] drm/rockchip: kick firmware-based framebuffer when initializing

2021-05-26 Thread Icenowy Zheng
although it's still /dev/fb0 and fbcon is bound to it). Add some code for removing firmware-based FB when initializing KMS of rockchipdrm. Tested on Pinebook Pro (RK3399) with U-Boot patchset for initializing eDP display applied. Signed-off-by: Icenowy Zheng --- drivers/gpu/drm/roc

Re: [PATCH] drm/panel: feiyang-fy07024di26a30d: cleanup if panel attaching failed

2021-01-07 Thread Icenowy Zheng
于 2021年1月6日 GMT+08:00 下午5:47:20, Jagan Teki 写到: >On Sat, Nov 28, 2020 at 6:23 PM Icenowy Zheng wrote: >> >> Attaching the panel can fail, so cleanup work is necessary, otherwise >> a pointer to freed struct drm_panel* will remain in drm_panel code. >> >>

[PATCH] drm/panel: ilitek-ili9881c: fix attach failure cleanup

2020-12-31 Thread Icenowy Zheng
: 26aec25593c2 ("drm/panel: Add Ilitek ILI9881c panel driver") Cc: sta...@vger.kernel.org Signed-off-by: Icenowy Zheng --- drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c

[PATCH] drm/panel: feiyang-fy07024di26a30d: cleanup if panel attaching failed

2020-11-29 Thread Icenowy Zheng
Attaching the panel can fail, so cleanup work is necessary, otherwise a pointer to freed struct drm_panel* will remain in drm_panel code. Do the cleanup if panel attaching failed. Fixes: 69dc678abc2b ("drm/panel: Add Feiyang FY07024DI26A30-D MIPI-DSI LCD panel") Signed-off-by: Ice

[PATCH 2/4] dt-bindings: ili9881c: add compatible string for Feixin K101-IM2BYL02

2020-07-20 Thread Icenowy Zheng
for it. Signed-off-by: Icenowy Zheng --- .../devicetree/bindings/display/panel/ilitek,ili9881c.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.yaml b/Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.yaml

[PATCH 1/4] drm/panel: ilitek-ili9881c: prepare for adding support for extra panels

2020-07-20 Thread Icenowy Zheng
There're more panels with ILI9881C controller than the Bananapi one supported by this driver. Extract the mode and init sequence part, to prepare the driver for adding new panels. Signed-off-by: Icenowy Zheng --- drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 56 --- 1

[PATCH 0/4] Add support for Feixin K101-IM2BYL02 panel

2020-07-20 Thread Icenowy Zheng
/DTB combo? K101-IM2BYL02 has the same pinout with K101-IM2BA02, and PineTab schedule to switch to it w/o modifying the mainboard. Icenowy Zheng (4): drm/panel: ilitek-ili9881c: prepare for adding support for extra panels dt-bindings: ili9881c: add compatible string for Feixin K101-IM2BYL02

[PATCH 3/4] drm/panel: ilitek-ili9881c: add support for Feixin K101-IM2BYL02 panel

2020-07-20 Thread Icenowy Zheng
Feixin K101-IM2BYL02 is a new panel by Feixin designed as a replacement to their K101-IM2BA02 panel. This panel utilizes the Ilitek ILI9881C controller. Add this panel's initialzation sequence and timing to ILI9881C driver. Signed-off-by: Icenowy Zheng --- drivers/gpu/drm/panel/panel-i

[PATCH 4/4] [DO NOT MERGE] arm64: allwinner: dts: a64: enable K101-IM2BYL02 panel for PineTab

2020-07-20 Thread Icenowy Zheng
Newer PineTab may switch to K101-IM2BYL02. Signed-off-by: Icenowy Zheng --- arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab.dts | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64

Re: [PATCH v6 13/13] arm64: dts: sun50i-a64-pinephone: Add touchscreen support

2020-07-02 Thread Icenowy Zheng
于 2020年7月1日 GMT+08:00 下午6:31:26, Ondrej Jirman 写到: >Pinephone has a Goodix GT917S capacitive touchscreen controller on >I2C0 bus. Add support for it. > >Signed-off-by: Ondrej Jirman >Acked-by: Linus Walleij >--- > .../dts/allwinner/sun50i-a64-pinephone.dtsi | 19 +++ > 1 file

Re: [PATCH v2 2/5] dt-bindings: panel: add binding for Xingbangda XBD599 panel

2020-03-21 Thread Icenowy Zheng
于 2020年3月20日 GMT+08:00 下午5:11:22, Linus Walleij 写到: >On Fri, Mar 20, 2020 at 9:07 AM Icenowy Zheng wrote: >> 于 2020年3月19日 GMT+08:00 下午10:14:27, Linus Walleij > 写到: >> >On Mon, Mar 16, 2020 at 2:37 PM Icenowy Zheng >wrote: > >> >As noticed in the review

Re: [PATCH v2 2/5] dt-bindings: panel: add binding for Xingbangda XBD599 panel

2020-03-21 Thread Icenowy Zheng
于 2020年3月19日 GMT+08:00 下午10:14:27, Linus Walleij 写到: >Hi Icenowy, > >On Mon, Mar 16, 2020 at 2:37 PM Icenowy Zheng wrote: > >> Xingbangda XBD599 is a 5.99" 720x1440 MIPI-DSI LCD panel. >> >> Add its device tree binding. >> >> Signed

Re: [linux-sunxi] [PATCH v2 5/5] arm64: allwinner: dts: a64: add LCD-related device nodes for PinePhone

2020-03-20 Thread Icenowy Zheng
在 2020-03-16星期一的 21:35 +0800,Icenowy Zheng写道: > PinePhone uses PWM backlight and a XBD599 LCD panel over DSI for > display. > > Add its device nodes. > > Signed-off-by: Icenowy Zheng > --- > No changes in v2. > > .../dts/allwinner/sun50i-a64-pinephone.dtsi |

[PATCH v2 3/5] drm: panel: add Xingbangda XBD599 panel

2020-03-17 Thread Icenowy Zheng
Xingbangda XBD599 is a 5.99" 720x1440 MIPI-DSI IPS LCD panel made by Xingbangda, which is used on PinePhone final assembled phones. Add support for it. Signed-off-by: Icenowy Zheng --- Changes in v2: - Raised copyright info to 2020. - Sort panel operation functions. - Sort inclusion. dr

[PATCH v2 5/5] arm64: allwinner: dts: a64: add LCD-related device nodes for PinePhone

2020-03-17 Thread Icenowy Zheng
PinePhone uses PWM backlight and a XBD599 LCD panel over DSI for display. Add its device nodes. Signed-off-by: Icenowy Zheng --- No changes in v2. .../dts/allwinner/sun50i-a64-pinephone.dtsi | 37 +++ 1 file changed, 37 insertions(+) diff --git a/arch/arm64/boot/dts

[PATCH v2 0/5] Add support for PinePhone LCD panel

2020-03-17 Thread Icenowy Zheng
This patchset adds support for the LCD panel of PinePhone. The first 3 patches are for the panel itself, and the last 2 patches are for enabling it on PinePhone. PATCH 4 is the fix of a bug in sun6i_mipi_dsi which will gets triggered on XBD599. Icenowy Zheng (5): dt-bindings: vendor-prefixes

[PATCH v2 4/5] drm/sun4i: sun6i_mipi_dsi: fix horizontal timing calculation

2020-03-17 Thread Icenowy Zheng
The max() function call in horizontal timing calculation shouldn't pad a length already subtracted with overhead to overhead, instead it should only prevent the set timing to underflow. Signed-off-by: Icenowy Zheng --- No changes in v2. drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 10 +---

[PATCH v2 1/5] dt-bindings: vendor-prefixes: Add Xingbangda

2020-03-17 Thread Icenowy Zheng
Shenzhen Xingbangda Display Technology Co., Ltd is a company which produces LCD modules. It supplies the LCD panels of the PinePhone series (the developers' kit and the final phone). Add the vendor prefix of it. Signed-off-by: Icenowy Zheng --- No changes in v2. Documentation/devic

[PATCH v2 2/5] dt-bindings: panel: add binding for Xingbangda XBD599 panel

2020-03-17 Thread Icenowy Zheng
Xingbangda XBD599 is a 5.99" 720x1440 MIPI-DSI LCD panel. Add its device tree binding. Signed-off-by: Icenowy Zheng --- Changes in v2: - Example fix. - Format fix. .../display/panel/xingbangda,xbd599.yaml | 50 +++ 1 file changed, 50 insertions(+) create mode 1

Re: [PATCH 3/5] drm: panel: add Xingbangda XBD599 panel

2020-03-15 Thread Icenowy Zheng
于 2020年3月14日 GMT+08:00 下午4:00:00, Sam Ravnborg 写到: >Hi Icenowy > >A few details in the following. > > Sam > >On Thu, Mar 12, 2020 at 12:33:27AM +0800, Icenowy Zheng wrote: >> Xingbangda XBD599 is a 5.99" 720x1440 MIPI-DSI IPS LCD panel made by >>

[PATCH 0/5] Add support for PinePhone LCD panel

2020-03-12 Thread Icenowy Zheng
This patchset adds support for the LCD panel of PinePhone. The first 3 patches are for the panel itself, and the last 2 patches are for enabling it on PinePhone. PATCH 4 is the fix of a bug in sun6i_mipi_dsi which will gets triggered on XBD599. Icenowy Zheng (5): dt-bindings: vendor-prefixes

[PATCH 5/5] arm64: allwinner: dts: a64: add LCD-related device nodes for PinePhone

2020-03-12 Thread Icenowy Zheng
PinePhone uses PWM backlight and a XBD599 LCD panel over DSI for display. Add its device nodes. Signed-off-by: Icenowy Zheng --- .../dts/allwinner/sun50i-a64-pinephone.dtsi | 37 +++ 1 file changed, 37 insertions(+) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64

[PATCH 4/5] drm/sun4i: sun6i_mipi_dsi: fix horizontal timing calculation

2020-03-12 Thread Icenowy Zheng
The max() function call in horizontal timing calculation shouldn't pad a length already subtracted with overhead to overhead, instead it should only prevent the set timing to underflow. Signed-off-by: Icenowy Zheng --- drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 10 +- 1 file chang

[PATCH 0/5] Add support for PinePhone LCD panel

2020-03-12 Thread Icenowy Zheng
This patchset adds support for the LCD panel of PinePhone. The first 3 patches are for the panel itself, and the last 2 patches are for enabling it on PinePhone. PATCH 4 is the fix of a bug in sun6i_mipi_dsi which will gets triggered on XBD599. Icenowy Zheng (5): dt-bindings: vendor-prefixes

[PATCH 3/5] drm: panel: add Xingbangda XBD599 panel

2020-03-12 Thread Icenowy Zheng
Xingbangda XBD599 is a 5.99" 720x1440 MIPI-DSI IPS LCD panel made by Xingbangda, which is used on PinePhone final assembled phones. Add support for it. Signed-off-by: Icenowy Zheng --- drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile

[PATCH 2/5] dt-bindings: panel: add binding for Xingbangda XBD599 panel

2020-03-12 Thread Icenowy Zheng
Xingbangda XBD599 is a 5.99" 720x1440 MIPI-DSI LCD panel. Add its device tree binding. Signed-off-by: Icenowy Zheng --- .../display/panel/xingbangda,xbd599.yaml | 50 +++ 1 file changed, 50 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/

[PATCH 1/5] dt-bindings: vendor-prefixes: Add Xingbangda

2020-03-12 Thread Icenowy Zheng
Shenzhen Xingbangda Display Technology Co., Ltd is a company which produces LCD modules. It supplies the LCD panels of the PinePhone series (the developers' kit and the final phone). Add the vendor prefix of it. Signed-off-by: Icenowy Zheng --- Documentation/devicetree/bindings/v

Re: [PATCH v2 2/2] drm/bridge: anx7688: Add anx7688 bridge driver support

2020-03-07 Thread Icenowy Zheng
erra > > > wrote: > > > > Hi Vasily, > > > > > > CC: Icenowy and Ondrej > > > > Would you mind to check which firmware version is running the > > > > anx7688 in > > > > PinePhone, I think should be easy to check with i2c-tools. > &

Re: [PATCH v2 2/2] drm/bridge: anx7688: Add anx7688 bridge driver support

2020-03-06 Thread Icenowy Zheng
于 2020年3月6日 GMT+08:00 上午2:29:33, Vasily Khoruzhick 写到: >On Thu, Mar 5, 2020 at 7:28 AM Enric Balletbo i Serra > wrote: >> >> Hi Vasily, > >CC: Icenowy and Ondrej >> >> Would you mind to check which firmware version is running the anx7688 >in >> Pi

Re: [PATCH 03/33] drm/panel-feixin-k101-im2ba02: Fix dotclock

2020-03-03 Thread Icenowy Zheng
correct? dotclock is correct and vrefresh is only a placeholder value. > >Cc: Icenowy Zheng >Cc: Sam Ravnborg >Signed-off-by: Ville Syrjälä >--- > drivers/gpu/drm/panel/panel-feixin-k101-im2ba02.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/driv

Re: [PATCH] drm/bridge: analogix-anx6345: fix set of link bandwidth

2020-02-27 Thread Icenowy Zheng
Maybe it should enter fixes? > >Best regards >Thomas > >Am 22.02.20 um 03:43 schrieb Icenowy Zheng: >> >> >> 于 2020年2月22日 GMT+08:00 上午1:13:28, Torsten Duwe 写到: >>> On Sat, Feb 22, 2020 at 12:51:27AM +0800, Icenowy Zheng wrote: >>>> Current code

[PATCH] drm/bridge: analogix-anx6345: fix set of link bandwidth

2020-02-24 Thread Icenowy Zheng
link rate and then converting back. Fixes: e1cff82c1097 ("drm/bridge: fix anx6345 compilation for v5.5") Signed-off-by: Icenowy Zheng --- drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/an

Re: [PATCH] drm/bridge: analogix-anx6345: fix set of link bandwidth

2020-02-24 Thread Icenowy Zheng
于 2020年2月22日 GMT+08:00 上午1:13:28, Torsten Duwe 写到: >On Sat, Feb 22, 2020 at 12:51:27AM +0800, Icenowy Zheng wrote: >> Current code tries to store the link rate (in bps, which is a big >> number) in a u8, which surely overflow. Then it's converted back to >> bandwidth

[PATCH v2 2/5] dt-bindings: panel: add Feixin K101 IM2BA02 MIPI-DSI panel

2020-01-16 Thread Icenowy Zheng
Feixin K101 IM2BA02 is a 10.1" 800x1280 4-lane MIPI-DSI panel. Add device tree binding for it. Signed-off-by: Icenowy Zheng --- Changes in v2: - Set backlight property to optional. (Technically this panel requires backlight, but theortically it can be not adjustable.) - Tweaked the examp

[PATCH v2 4/5] dt-bindings: arm: sunxi: add binding for PineTab tablet

2020-01-16 Thread Icenowy Zheng
Add the device tree binding for Pine64's PineTab tablet, which uses Allwinner A64 SoC. Signed-off-by: Icenowy Zheng Reviewed-by: Rob Herring --- Changes in v2: - Added Review tag by Rob. Documentation/devicetree/bindings/arm/sunxi.yaml | 5 + 1 file changed, 5 insertions(+) diff --

[PATCH v2 0/5] Add support for Pine64 PineTab

2020-01-16 Thread Icenowy Zheng
because a DT binding is lacked (although a proper driver exists). Icenowy Zheng (5): dt-bindings: vendor-prefix: add Shenzhen Feixin Photoelectics Co., Ltd dt-bindings: panel: add Feixin K101 IM2BA02 MIPI-DSI panel drm/panel: Add Feixin K101 IM2BA02 panel dt-bindings: arm: sunxi: add binding

[PATCH v2 3/5] drm/panel: Add Feixin K101 IM2BA02 panel

2020-01-16 Thread Icenowy Zheng
Feixin K101 IM2BA02 is a 800x1280 4-lane MIPI-DSI LCD panel. Add a panel driver for it. Signed-off-by: Icenowy Zheng --- Changes in v2: - Use regulator_bulk. - Small code fixes. MAINTAINERS | 6 + drivers/gpu/drm/panel/Kconfig | 9

[PATCH v2 1/5] dt-bindings: vendor-prefix: add Shenzhen Feixin Photoelectics Co., Ltd

2020-01-16 Thread Icenowy Zheng
Shenzhen Feixin Photoelectics Co., Ltd is a company to provide LCD modules. Add its vendor prefix. Signed-off-by: Icenowy Zheng Acked-by: Sam Ravnborg Acked-by: Rob Herring --- Changes in v2: - Added ACKs from Sam and Rob. Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1

[PATCH v2 5/5] arm64: dts: allwinner: a64: add support for PineTab

2020-01-16 Thread Icenowy Zheng
ing most of the features mentioned above. HDMI is not supported now because bad LCD-HDMI coexistence situation of mainline A64 display driver, the front camera currently lacks a driver and a facility to share the bus with the rear one, and the accelerometer currently lacks a DT binding. Signed-

[PATCH 3/5] drm/panel: Add Feixin K101 IM2BA02 panel

2020-01-12 Thread Icenowy Zheng
Feixin K101 IM2BA02 is a 800x1280 4-lane MIPI-DSI LCD panel. Add a panel driver for it. Signed-off-by: Icenowy Zheng --- MAINTAINERS | 6 + drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile| 1 + .../gpu

[PATCH 0/5] Add support for Pine64 PineTab

2020-01-12 Thread Icenowy Zheng
f the functionalities of the tablet available in this device tree. Icenowy Zheng (5): dt-bindings: vendor-prefix: add Shenzhen Feixin Photoelectics Co., Ltd dt-bindings: panel: add Feixin K101 IM2BA02 MIPI-DSI panel drm/panel: Add Feixin K101 IM2BA02 panel dt-bindings: arm: sunxi: add bindin

[PATCH 4/5] dt-bindings: arm: sunxi: add binding for PineTab tablet

2020-01-12 Thread Icenowy Zheng
Add the device tree binding for Pine64's PineTab tablet, which uses Allwinner A64 SoC. Signed-off-by: Icenowy Zheng --- Documentation/devicetree/bindings/arm/sunxi.yaml | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Document

[PATCH 1/5] dt-bindings: vendor-prefix: add Shenzhen Feixin Photoelectics Co., Ltd

2020-01-12 Thread Icenowy Zheng
Shenzhen Feixin Photoelectics Co., Ltd is a company to provide LCD modules. Add its vendor prefix. Signed-off-by: Icenowy Zheng --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor

[PATCH 5/5] arm64: dts: allwinner: a64: add support for PineTab

2020-01-12 Thread Icenowy Zheng
ing most of the features mentioned above. HDMI is not supported now because bad LCD-HDMI coexistence situation of mainline A64 display driver, and the front camera currently lacks a driver and a facility to share the bus with the rear one. Signed-off-by: Icenowy Zheng --- arch/arm64/boot/dts/all

[PATCH 2/5] dt-bindings: panel: add Feixin K101 IM2BA02 MIPI-DSI panel

2020-01-12 Thread Icenowy Zheng
Feixin K101 IM2BA02 is a 10.1" 800x1280 4-lane MIPI-DSI panel. Add device tree binding for it. Signed-off-by: Icenowy Zheng --- .../display/panel/feixin,k101-im2ba02.yaml| 54 +++ 1 file changed, 54 insertions(+) create mode 100644 Documentation/devicetree/bin

Re: [Lima] [RFC v1 0/1] drm: lima: devfreq and cooling device support

2019-12-24 Thread Icenowy Zheng
于 2019年12月24日 GMT+08:00 下午7:28:41, Martin Blumenstingl 写到: >Hi Alyssa, > >On Mon, Dec 16, 2019 at 4:48 PM Alyssa Rosenzweig > wrote: >> >> If so much code is being duplicated over, I'm wondering if it makes >> sense for us to move some of the common devfreq code to core DRM >> helpers? >if you

Re: [PATCH v2 1/3] drm/sun4i: dsi: Fix video start delay computation

2019-10-07 Thread Icenowy Zheng
于 2019年10月7日 GMT+08:00 下午7:51:48, Maxime Ripard 写到: >On Mon, Oct 07, 2019 at 12:03:00AM +0800, Icenowy Zheng wrote: >> From: Jagan Teki >> >> The LCD timing definitions between Linux DRM vs Allwinner are >different, >> below diagram shows this clear differ

[PATCH v2 3/3] drm/sun4i: sun6i_mipi_dsi: fix DCS long write packet length

2019-10-06 Thread Icenowy Zheng
The packet length of DCS long write packet should not be added with 1 when constructing long write packet. Fix this. Signed-off-by: Icenowy Zheng --- drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/sun4i

[PATCH v2 2/3] drm/sun4i: dsi: fix the overhead of the horizontal front porch

2019-10-06 Thread Icenowy Zheng
The formula in the BSP kernel indicates that a 16-byte overhead is used when sending the HFP. However, this value is currently set to 6 in the sun6i_mipi_dsi driver, which makes some panels flashing. Fix this overhead value. Signed-off-by: Icenowy Zheng --- drivers/gpu/drm/sun4i

  1   2   3   4   5   >