Re: (subset) [PATCH v2 00/57] irqdomain: Cleanups and Documentation

2025-03-25 Thread Christophe Leroy
> during merges. > > === > > [...] Applied, thanks! [48/57] irqdomain: soc: Switch to irq_find_mapping() commit: a70a3a6322131632cc6cf71e9d2fa6409a029fd7 Best regards, -- Christophe Leroy

Re: [PATCH v4 07/14] arm64: Add support for suppressing warning backtraces

2025-03-19 Thread Christophe Leroy
Le 18/03/2025 à 16:59, Will Deacon a écrit : On Thu, Mar 13, 2025 at 05:40:59PM +0100, Alessandro Carminati wrote: On Thu, Mar 13, 2025 at 1:25 PM Will Deacon wrote: On Thu, Mar 13, 2025 at 11:43:22AM +, Alessandro Carminati wrote: diff --git a/arch/arm64/include/asm/bug.h b/arch/arm6

Re: [PATCH v2 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-13 Thread Christophe Leroy
Le 13/12/2024 à 09:41, Thomas Zimmermann a écrit : Hi Am 13.12.24 um 09:33 schrieb Christophe Leroy: The attached patch selects backlight support in the defconfigs that also have PMAC_BACKLIGHT=y. Can you please apply it on top of the patchset and report on the results? That works

Re: [PATCH v2 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-13 Thread Christophe Leroy
Le 13/12/2024 à 09:35, Thomas Zimmermann a écrit : Hi Am 13.12.24 um 09:33 schrieb Christophe Leroy: Le 13/12/2024 à 09:05, Thomas Zimmermann a écrit : Hi Am 13.12.24 um 08:44 schrieb Christophe Leroy: Le 12/12/2024 à 11:04, Thomas Zimmermann a écrit : Do not select

Re: [PATCH v2 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-13 Thread Christophe Leroy
Le 13/12/2024 à 09:05, Thomas Zimmermann a écrit : Hi Am 13.12.24 um 08:44 schrieb Christophe Leroy: Le 12/12/2024 à 11:04, Thomas Zimmermann a écrit : Do not select BACKLIGHT_CLASS_DEVICE from FB_BACKLIGHT. The latter only controls backlight support within fbdev core code and data

Re: [PATCH v2 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-12 Thread Christophe Leroy
Le 12/12/2024 à 11:04, Thomas Zimmermann a écrit : Do not select BACKLIGHT_CLASS_DEVICE from FB_BACKLIGHT. The latter only controls backlight support within fbdev core code and data structures. Make fbdev drivers depend on BACKLIGHT_CLASS_DEVICE and let users select it explicitly. Fixes warni

Re: [PATCH v2 2/3] drm/fbdev: Select FB_CORE dependency for fbdev on DMA and TTM

2024-12-12 Thread Christophe Leroy
Le 13/12/2024 à 08:40, Christophe Leroy a écrit : Le 12/12/2024 à 11:04, Thomas Zimmermann a écrit : Select FB_CORE if GEM's DMA and TTM implementations support fbdev emulation. Fixes linker errors about missing symbols from the fbdev subsystem. Also see [1] for a related SHME

Re: [PATCH v3 05/19] powerpc/papr_scm: Convert timeouts to secs_to_jiffies()

2024-12-10 Thread Christophe Leroy
ng scripts/coccinelle/misc/secs_to_jiffies.cocci with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan Reviewed-by: Christophe Leroy

Re: [PATCH v3 18/19] livepatch: Convert timeouts to secs_to_jiffies()

2024-12-10 Thread Christophe Leroy
Le 10/12/2024 à 23:02, Easwar Hariharan a écrit : Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced secs_to_jiffies(). As the value here is a multiple of 1000, use secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication. This is converted using scripts/coc

Re: [PATCH v2 00/21] Converge on using secs_to_jiffies()

2024-12-09 Thread Christophe Leroy
Le 09/12/2024 à 13:01, Przemek Kitszel a écrit : On 12/6/24 9:58 PM, Easwar Hariharan wrote: On 11/29/2024 4:57 AM, Przemek Kitszel wrote: [removed most non-list recipients, it's just too much] On 11/15/24 10:26 PM, Easwar Hariharan wrote: Regarding code - you could also convert msec

Re: [PATCH v2 03/21] arm: pxa: Convert timeouts to use secs_to_jiffies()

2024-11-16 Thread Christophe Leroy
Le 15/11/2024 à 22:26, Easwar Hariharan a écrit : [Vous ne recevez pas souvent de courriers de eahar...@linux.microsoft.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_

Re: [PATCH v2 00/21] Converge on using secs_to_jiffies()

2024-11-16 Thread Christophe Leroy
Le 15/11/2024 à 22:26, Easwar Hariharan a écrit : [Vous ne recevez pas souvent de courriers de eahar...@linux.microsoft.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] This is a series that follows up on my previous series to introduce secs_to_ji

Re: [PATCH v2 21/21] nfp: Convert timeouts to secs_to_jiffies()

2024-11-16 Thread Christophe Leroy
Le 15/11/2024 à 22:26, Easwar Hariharan a écrit : [Vous ne recevez pas souvent de courriers de eahar...@linux.microsoft.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] As you plan to get those merged independant in each tree, I guess it should be

Re: [PATCH v2 19/21] livepatch: Convert timeouts to secs_to_jiffies()

2024-11-16 Thread Christophe Leroy
Le 15/11/2024 à 22:26, Easwar Hariharan a écrit : [Vous ne recevez pas souvent de courriers de eahar...@linux.microsoft.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_

Re: [PATCH v2 05/21] powerpc/papr_scm: Convert timeouts to secs_to_jiffies()

2024-11-16 Thread Christophe Leroy
Le 15/11/2024 à 22:26, Easwar Hariharan a écrit : [Vous ne recevez pas souvent de courriers de eahar...@linux.microsoft.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_

Re: [PATCH v2 02/21] coccinelle: misc: Add secs_to_jiffies script

2024-11-16 Thread Christophe Leroy
Le 15/11/2024 à 22:26, Easwar Hariharan a écrit : [Vous ne recevez pas souvent de courriers de eahar...@linux.microsoft.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] There should be some explaination in the commit message, what the script do

Re: [PATCH v2 01/21] netfilter: conntrack: Cleanup timeout definitions

2024-11-16 Thread Christophe Leroy
Le 15/11/2024 à 22:26, Easwar Hariharan a écrit : [Vous ne recevez pas souvent de courriers de eahar...@linux.microsoft.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] None of the higher order definitions are used anymore, so remove definitions f

Re: [PATCH v2 00/21] Converge on using secs_to_jiffies()

2024-11-16 Thread Christophe Leroy
Le 15/11/2024 à 22:29, Easwar Hariharan a écrit : [Vous ne recevez pas souvent de courriers de eahar...@linux.microsoft.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] On 11/15/2024 1:26 PM, Easwar Hariharan wrote: This is a series that follows

Re: [PATCH] drm/radeon: add late_register for connector

2024-10-06 Thread Christophe Leroy
Le 06/10/2024 à 18:56, Christian Zigotzky a écrit : On 03 October 2024 at 08:06 am, Wu Hoi Pok wrote: This is a fix patch not tested yet, for a bug I introduce in previous rework of radeon driver. The bug is a null dereference in 'aux.dev', which is the 'device' not registered, resulting in k

Re: Kernel doesn't boot after DRM updates (drm-next-2024-09-19)

2024-10-01 Thread Christophe Leroy
Hi All, Le 01/10/2024 à 14:09, Hoi Pok Wu a écrit : [Vous ne recevez pas souvent de courriers de wuhoi...@gmail.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] Hi Thomas, Could you help on this issue? I do not have access to the hardware now. Thank

Re: FSL P5040 board doesn't boot after DRM updates (drm-next-2024-09-19)

2024-09-28 Thread Christophe Leroy
Hi Christian, Le 28/09/2024 à 09:40, Christian Zigotzky a écrit : On 28 September 2024 at 09:21am, Christian Zigotzky wrote: > >> On Sun, Sep 22, 2024 at 12:28 AM Christian Zigotzky >> wrote: >>> >>> Hi All, >>> >>> The lastest Git kernel doesn't boot anymore after the latest DRM updat

Re: [PATCH v2 3/3] arch/powerpc: Remove from backlight code

2024-03-05 Thread Christophe Leroy
Le 05/03/2024 à 11:04, Thomas Zimmermann a écrit : > Hi > > Am 05.03.24 um 10:25 schrieb Christophe Leroy: >> >> Le 05/03/2024 à 10:01, Thomas Zimmermann a écrit : >>> Replace with a forward declaration in to >>> resolves an unnecessary dependency. Remov

Re: [PATCH v2 3/3] arch/powerpc: Remove from backlight code

2024-03-05 Thread Christophe Leroy
Le 05/03/2024 à 10:01, Thomas Zimmermann a écrit : > Replace with a forward declaration in to > resolves an unnecessary dependency. Remove pmac_backlight_curve_lookup() > and struct fb_info from source and header files. The function and the > framebuffer struct is unused. No functional changes.

Re: [PATCH] powerpc: include linux/backlight.h from asm/backlight.h

2024-03-04 Thread Christophe Leroy
Le 04/03/2024 à 11:32, Thomas Zimmermann a écrit : > Hi > > Am 04.03.24 um 10:55 schrieb Jani Nikula: >> Removal of the backlight include from fb.h uncovered an implicit >> dependency in powerpc asm/backlight.h. Add the explicit include. >> >> Reported-by: Naresh Kamboju >> Closes: >> https://

Re: drm_format_helper_test fails Subtest: drm_test_fb_xrgb8888_to_xrgb2101010 on Big Endian machines (kernel 6.7.5, ppc64)

2024-02-22 Thread Christophe Leroy
Hi, Le 20/02/2024 à 00:45, Erhard Furtner a écrit : > Greetings! > > I ran some kernel drm/ttm unit tests to check for quirks in the drm/ttm > subsystem. One thing I found out that the drm_format_helper_test fails > Subtest: drm_test_fb_xrgb_to_xrgb2101010 on my Talos II (ppc64) which I >

Re: [PATCH 15/22] arch: vdso: consolidate gettime prototypes

2023-11-09 Thread Christophe Leroy
Le 09/11/2023 à 11:18, Michael Ellerman a écrit : > "Arnd Bergmann" writes: >> On Wed, Nov 8, 2023, at 19:31, Christophe Leroy wrote: >>> Le 08/11/2023 à 13:58, Arnd Bergmann a écrit : >> >>> powerpc has functions doing more or less the same, they ar

Re: [PATCH 15/22] arch: vdso: consolidate gettime prototypes

2023-11-08 Thread Christophe Leroy
Le 08/11/2023 à 20:37, Arnd Bergmann a écrit : > On Wed, Nov 8, 2023, at 19:31, Christophe Leroy wrote: >> Le 08/11/2023 à 13:58, Arnd Bergmann a écrit : > >> powerpc has functions doing more or less the same, they are called >> __c_kernel_clock_gettime() and alike with

Re: [PATCH 15/22] arch: vdso: consolidate gettime prototypes

2023-11-08 Thread Christophe Leroy
Hi Arnd, Le 08/11/2023 à 13:58, Arnd Bergmann a écrit : > From: Arnd Bergmann > > The VDSO functions are defined as globals in the kernel sources but intended > to be called from userspace, so there is no need to declare them in a kernel > side header. > > Without a prototype, this now causes w

Re: [PATCH v2 00/15] sysctl: Remove sentinel elements from drivers

2023-10-02 Thread Christophe Leroy
Le 02/10/2023 à 10:55, Joel Granados via B4 Relay a écrit : > From: Joel Granados > > What? > These commits remove the sentinel element (last empty element) from the > sysctl arrays of all the files under the "drivers/" directory that use a > sysctl array for registration. The merging of the pr

Re: [PATCH 00/15] sysctl: Remove sentinel elements from drivers

2023-10-02 Thread Christophe Leroy
Le 02/10/2023 à 10:47, Joel Granados a écrit : > On Thu, Sep 28, 2023 at 04:31:30PM +0000, Christophe Leroy wrote: > I followed this trace and proc_handler is correctly defined in tty_table > (struct ctl_table) in drivers/tty/tty_io.c:tty_init and there is not > path that changes

Re: [PATCH 04/15] tty: Remove now superfluous sentinel element from ctl_table array

2023-10-02 Thread Christophe Leroy
Le 02/10/2023 à 10:17, Jiri Slaby a écrit : > On 28. 09. 23, 15:21, Joel Granados via B4 Relay wrote: >> From: Joel Granados >> >> This commit comes at the tail end of a greater effort to remove the >> empty elements at the end of the ctl_table arrays (sentinels) which >> will reduce the overall

Re: [PATCH 00/15] sysctl: Remove sentinel elements from drivers

2023-09-28 Thread Christophe Leroy
Le 28/09/2023 à 15:21, Joel Granados via B4 Relay a écrit : > From: Joel Granados Automatic test fails on powerpc, see https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20230928-jag-sysctl_remove_empty_elem_drivers-v1-15-e59120fca...@samsung.com/ Kernel attempted to read user page (1a11

Re: [PATCH v3 2/5] fbdev: Replace fb_pgprotect() with fb_pgprot_device()

2023-09-11 Thread Christophe Leroy
Le 11/09/2023 à 15:08, Thomas Zimmermann a écrit : > Rename the fbdev mmap helper fb_pgprotect() to pgprot_framebuffer(). > The helper sets VMA page-access flags for framebuffers in device I/O > memory. > > Also clean up the helper's parameters and return value. Instead of > the VMA instance, pas

Re: Framebuffer mmap on PowerPC

2023-08-31 Thread Christophe Leroy
Le 31/08/2023 à 19:38, Christophe Leroy a écrit : > > > Le 31/08/2023 à 16:41, Thomas Zimmermann a écrit : >> Hi, >> >> there's a per-architecture function called fb_pgprotect() that sets >> VMA's vm_page_prot for mmaped framebuffers. Most architec

Re: Framebuffer mmap on PowerPC

2023-08-31 Thread Christophe Leroy
Le 31/08/2023 à 16:41, Thomas Zimmermann a écrit : > Hi, > > there's a per-architecture function called fb_pgprotect() that sets > VMA's vm_page_prot for mmaped framebuffers. Most architectures use a > simple implementation based on pgprot_writecomine() [1] or > pgprot_noncached(). [2] > > O

Re: [PATCH 02/15] video: fbdev: atyfb: Introduce backlight_get_brightness()

2023-01-09 Thread Christophe Leroy
Le 07/01/2023 à 19:26, Sam Ravnborg via B4 Submission Endpoint a écrit : > From: Sam Ravnborg > > Introduce backlight_get_brightness() to simplify logic > and avoid direct access to backlight properties. When I read 'introduce' I understand that you are adding a new function. In fact backligh

Re: [PATCH v3 3/5] treewide: use get_random_u32() when possible

2022-10-06 Thread Christophe Leroy
Le 07/10/2022 à 01:36, Jason A. Donenfeld a écrit : > On 10/6/22, Christophe Leroy wrote: >> >> >> Le 06/10/2022 à 19:31, Christophe Leroy a écrit : >>> >>> >>> Le 06/10/2022 à 19:24, Jason A. Donenfeld a écrit : >>>> Hi Christophe

Re: [PATCH v3 3/5] treewide: use get_random_u32() when possible

2022-10-06 Thread Christophe Leroy
Le 06/10/2022 à 19:31, Christophe Leroy a écrit : Le 06/10/2022 à 19:24, Jason A. Donenfeld a écrit : Hi Christophe, On Thu, Oct 6, 2022 at 11:21 AM Christophe Leroy wrote: Le 06/10/2022 à 18:53, Jason A. Donenfeld a écrit : The prandom_u32() function has been a deprecated inline

Re: [PATCH v3 3/5] treewide: use get_random_u32() when possible

2022-10-06 Thread Christophe Leroy
Le 06/10/2022 à 19:24, Jason A. Donenfeld a écrit : > Hi Christophe, > > On Thu, Oct 6, 2022 at 11:21 AM Christophe Leroy > wrote: >> Le 06/10/2022 à 18:53, Jason A. Donenfeld a écrit : >>> The prandom_u32() function has been a deprecated inline wrapper around >&

Re: [PATCH v3 4/5] treewide: use get_random_bytes when possible

2022-10-06 Thread Christophe Leroy
eal function. > > Reviewed-by: Kees Cook > Signed-off-by: Jason A. Donenfeld Reviewed-by: Christophe Leroy (Powerpc part) > --- > arch/powerpc/crypto/crc-vpmsum_test.c | 2 +- > > diff --git a/arch/powerpc/crypto/crc-vpmsum_test.c > b/arch/powerpc/crypto/cr

Re: [PATCH v3 3/5] treewide: use get_random_u32() when possible

2022-10-06 Thread Christophe Leroy
Le 06/10/2022 à 18:53, Jason A. Donenfeld a écrit : > The prandom_u32() function has been a deprecated inline wrapper around > get_random_u32() for several releases now, and compiles down to the > exact same code. Replace the deprecated wrapper with a direct call to > the real function. The same

[PATCH] video: fbdev: mb862xx: Replace NO_IRQ by 0

2022-10-05 Thread Christophe Leroy
NO_IRQ is used to check the return of irq_of_parse_and_map(). On some architecture NO_IRQ is 0, on other architectures it is -1. irq_of_parse_and_map() returns 0 on error, independent of NO_IRQ. So use 0 instead of using NO_IRQ. Signed-off-by: Christophe Leroy --- drivers/video/fbdev/mb862xx

[PATCH v3 2/4] scsi: cxlflash: Include missing linux/irqdomain.h

2022-07-08 Thread Christophe Leroy
aration of function 'irq_find_mapping'; did you mean 'is_cow_mapping'? [-Werror=implicit-function-declaration] 264 | if (irq_find_mapping(NULL, irq->hwirq)) { | ^~~~ | is_cow_mapping cc1: some warnings being treated as er

[PATCH v3 4/4] powerpc: Finally remove unnecessary headers from asm/prom.h

2022-07-08 Thread Christophe Leroy
Remove all headers included from asm/prom.h which are not used by asm/prom.h itself. Declare struct device_node and struct property locally to avoid including of.h Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/prom.h | 10 ++ 1 file changed, 2 insertions(+), 8 deletions

[PATCH v3 1/4] video: fbdev: offb: Include missing linux/platform_device.h

2022-07-08 Thread Christophe Leroy
h to allow cleaning asm/pci.h Cc: Thomas Zimmermann Fixes: 52b1b46c39ae ("of: Create platform devices for OF framebuffers") Signed-off-by: Christophe Leroy Acked-by: Helge Deller --- drivers/video/fbdev/offb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/fbdev/of

[PATCH v3 3/4] powerpc: Remove asm/prom.h from asm/mpc52xx.h and asm/pci.h

2022-07-08 Thread Christophe Leroy
asm/pci.h and asm/mpc52xx.h don't need asm/prom.h Declare struct device_node locally to avoid including of.h Signed-off-by: Christophe Leroy --- v3: Add prom.h to prom.c --- arch/powerpc/include/asm/mpc52xx.h | 3 ++- arch/powerpc/include/asm/pci.h | 1 - arch/powerpc/kernel/p

Re: [PATCH 6/6] i2c: Make remove callback return void

2022-06-29 Thread Christophe Leroy
Le 29/06/2022 à 09:23, Uwe Kleine-König a écrit : > Hello, > > [I dropped nearly all individuals from the Cc: list because various > bounces reported to be unhappy about the long (logical) line.] Good idea, even patchwork made a mess of it, see https://patchwork.ozlabs.org/project/linuxppc-dev

[PATCH 4/4] powerpc: Finally remove unnecessary headers from asm/prom.h

2022-06-11 Thread Christophe Leroy
Remove all headers included from asm/prom.h which are not used by asm/prom.h itself. Declare struct device_node and struct property locally to avoid including of.h Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/prom.h | 12 +++- 1 file changed, 3 insertions(+), 9

[PATCH 3/4] powerpc: Remove asm/prom.h from asm/mpc52xx.h and asm/pci.h

2022-06-11 Thread Christophe Leroy
asm/pci.h and asm/mpc52xx.h don't need asm/prom.h Declare struct device_node locally to avoid including of.h Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/mpc52xx.h | 3 ++- arch/powerpc/include/asm/pci.h | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --

[PATCH 1/4] video: fbdev: offb: Include missing linux/platform_device.h

2022-06-11 Thread Christophe Leroy
h to allow cleaning asm/pci.h Cc: Thomas Zimmermann Fixes: 52b1b46c39ae ("of: Create platform devices for OF framebuffers") Signed-off-by: Christophe Leroy --- drivers/video/fbdev/offb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/fbdev/offb.c b/drivers/vide

[PATCH 2/4] scsi: cxlflash: Include missing linux/irqdomain.h

2022-06-11 Thread Christophe Leroy
aration of function 'irq_find_mapping'; did you mean 'is_cow_mapping'? [-Werror=implicit-function-declaration] 264 | if (irq_find_mapping(NULL, irq->hwirq)) { | ^~~~ | is_cow_mapping cc1: some warnings being treated as er

Re: [PATCH v5 1/2] module: update dependencies at try_module_get()

2022-05-01 Thread Christophe Leroy
Le 30/04/2022 à 22:04, Mauro Carvalho Chehab a écrit : > Sometimes, device drivers are bound into each other via try_module_get(), > making such references invisible when looking at /proc/modules or lsmod. > > Add a function to allow setting up module references for such > cases, and call it whe

[PATCH] video: fbdev: Prepare cleanup of powerpc's asm/prom.h

2022-04-02 Thread Christophe Leroy
powerpc's asm/prom.h brings some headers that it doesn't need itself. In order to clean it up, first add missing headers in users of asm/prom.h Signed-off-by: Christophe Leroy --- drivers/video/fbdev/aty/aty128fb.c | 1 - drivers/video/fbdev/aty/atyfb_base.c | 1 - dri

[PATCH] drm/radeon/combios: Prepare cleanup of powerpc's asm/prom.h

2022-04-02 Thread Christophe Leroy
powerpc's asm/prom.h brings some headers that it doesn't need itself. In order to clean it up, first add missing headers in users of asm/prom.h Signed-off-by: Christophe Leroy --- drivers/gpu/drm/radeon/radeon_combios.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/

[PATCH v2] drm/nouveau/bios: Rename prom_init() and friends functions

2022-03-19 Thread Christophe Leroy
the ops structure as 'nvbios_prom' instead of 'nvbios_rom' in order to make it clear that it refers to the NV_PROM device. Signed-off-by: Christophe Leroy --- v2: using nvbios_prom prefix instead of nvbios_rom. Changed structure name to keep things consistant. drivers/gpu/drm

Re: [PATCH] drm/nouveau/bios: Rename prom_init() and friends functions

2022-03-18 Thread Christophe Leroy
Hi Paul, Le 05/03/2022 à 10:51, Christophe Leroy a écrit : Le 05/03/2022 à 08:38, Christophe Leroy a écrit : Le 04/03/2022 à 21:24, Lyude Paul a écrit : This mostly looks good to me. Just one question (and one comment down below that needs addressing). Is this with ppc32? (I ask because

Re: [PATCH] drm/nouveau/bios: Rename prom_init() and friends functions

2022-03-05 Thread Christophe Leroy
Le 05/03/2022 à 08:38, Christophe Leroy a écrit : Le 04/03/2022 à 21:24, Lyude Paul a écrit : This mostly looks good to me. Just one question (and one comment down below that needs addressing). Is this with ppc32? (I ask because ppc64le doesn't seem to hit this compilation

Re: [PATCH] drm/nouveau/bios: Rename prom_init() and friends functions

2022-03-04 Thread Christophe Leroy
Le 04/03/2022 à 21:24, Lyude Paul a écrit : > This mostly looks good to me. Just one question (and one comment down below > that needs addressing). Is this with ppc32? (I ask because ppc64le doesn't > seem to hit this compilation error). That's with PPC64, see http://kisskb.ellerman.id.au/kissk

[PATCH] drm/nouveau/bios: Rename prom_init() and friends functions

2022-03-04 Thread Christophe Leroy
88: drivers/gpu/drm/nouveau/nvkm/subdev/bios/shadowrom.o] Error 1 powerpc and a few other architectures have a prom_init() global function. One day or another it will conflict with the one in shadowrom.c Those being static, they can easily be renamed. Do it. Signed-off-by: Christophe Leroy

Re: [PATCH v3 4/8] powerpc/pseries/svm: Add a powerpc version of cc_platform_has()

2021-09-15 Thread Christophe Leroy
Le 15/09/2021 à 12:08, Borislav Petkov a écrit : On Wed, Sep 15, 2021 at 10:28:59AM +1000, Michael Ellerman wrote: I don't love it, a new C file and an out-of-line call to then call back to a static inline that for most configuration will return false ... but whatever :) Yeah, hch thinks it

[PATCH] video: fbdev: use memset_io() instead of memset()

2021-09-15 Thread Christophe Leroy
t;[PATCH] ppc32: Remove CONFIG_PMAC_PBOOK") Reported-by: Stan Johnson Cc: Finn Thain Signed-off-by: Christophe Leroy --- drivers/video/fbdev/chipsfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/chipsfb.c b/drivers/video/fbdev/chipsfb.c index 9

Re: [PATCH v3 4/8] powerpc/pseries/svm: Add a powerpc version of cc_platform_has()

2021-09-14 Thread Christophe Leroy
Le 14/09/2021 à 13:58, Borislav Petkov a écrit : On Wed, Sep 08, 2021 at 05:58:35PM -0500, Tom Lendacky wrote: Introduce a powerpc version of the cc_platform_has() function. This will be used to replace the powerpc mem_encrypt_active() implementation, so the implementation will initially only

Re: [PATCH v3 4/8] powerpc/pseries/svm: Add a powerpc version of cc_platform_has()

2021-09-09 Thread Christophe Leroy
On 9/8/21 10:58 PM, Tom Lendacky wrote: Introduce a powerpc version of the cc_platform_has() function. This will be used to replace the powerpc mem_encrypt_active() implementation, so the implementation will initially only support the CC_ATTR_MEM_ENCRYPT attribute. Cc: Michael Ellerman Cc: B

Re: [PATCH v3 2/8] mm: Introduce a function to check for confidential computing features

2021-09-09 Thread Christophe Leroy
On 9/8/21 10:58 PM, Tom Lendacky wrote: In prep for other confidential computing technologies, introduce a generic helper function, cc_platform_has(), that can be used to check for specific I have little problem with that naming. For me CC has always meant Compiler Collection. active conf

Re: [PATCH v3 8/8] treewide: Replace the use of mem_encrypt_active() with cc_platform_has()

2021-09-09 Thread Christophe Leroy
On 9/8/21 10:58 PM, Tom Lendacky wrote: diff --git a/arch/powerpc/include/asm/mem_encrypt.h b/arch/powerpc/include/asm/mem_encrypt.h index ba9dab07c1be..2f26b8fc8d29 100644 --- a/arch/powerpc/include/asm/mem_encrypt.h +++ b/arch/powerpc/include/asm/mem_encrypt.h @@ -10,11 +10,6 @@ #incl

Re: [PATCH v2 57/63] powerpc/signal32: Use struct_group() to zero spe regs

2021-08-20 Thread Christophe Leroy
ribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Werror=attribute-warning] 195 |__write_overflow_field(); |^~~~ Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Christophe Leroy

Re: [PATCH v2 61/63] powerpc: Split memset() to avoid multi-field overflow

2021-08-17 Thread Christophe Leroy
Le 18/08/2021 à 08:05, Kees Cook a écrit : In preparation for FORTIFY_SOURCE performing compile-time and run-time field bounds checking for memset(), avoid intentionally writing across neighboring fields. Instead of writing across a field boundary with memset(), move the call to just the arra

Re: [PATCH 07/11] treewide: Replace the use of mem_encrypt_active() with prot_guest_has()

2021-08-02 Thread Christophe Leroy
Le 28/07/2021 à 00:26, Tom Lendacky a écrit : Replace occurrences of mem_encrypt_active() with calls to prot_guest_has() with the PATTR_MEM_ENCRYPT attribute. What about https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20210730114231.23445-1-w...@kernel.org/ ? Christophe Cc: T

[PATCH RESEND] drm/i915/gem: Use user_write_access_begin() instead of user_access_begin()

2021-05-01 Thread Christophe Leroy
eb_copy_relocations() only do unsafe_put_user(), it only requires write access to user. Use user_write_access_begin() instead of user_access_begin(). Signed-off-by: Christophe Leroy --- Resending with mm list in addition drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 6 +++--- 1 file

[PATCH] drm/i915/gem: Use user_write_access_begin() instead of user_access_begin()

2021-03-10 Thread Christophe Leroy
eb_copy_relocations() only do unsafe_put_user(), it only requires write access to user. Use user_write_access_begin() instead of user_access_begin(). Signed-off-by: Christophe Leroy --- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions

Re: [PATCH 02/13] module: add a module_loaded helper

2021-01-22 Thread Christophe Leroy
Le 21/01/2021 à 08:49, Christoph Hellwig a écrit : > Add a helper that takes modules_mutex and uses find_module to check if a > given module is loaded. This provides a better abstraction for the two > callers, and allows to unexport modules_mutex and find_module. > > Signed-off-by: Christoph H

Re: [PATCH 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-11-25 Thread Christophe Leroy
Le 21/05/2020 à 12:38, Christophe Leroy a écrit : Le 21/05/2020 à 09:02, Michael Ellerman a écrit : Arnd Bergmann writes: +On Wed, Apr 8, 2020 at 2:04 PM Michael Ellerman wrote: Benjamin Herrenschmidt writes: On Fri, 2020-04-03 at 15:59 +1100, Michael Ellerman wrote: Benjamin

[PATCH] drm/amd/display: Fix missing declaration of enable_kernel_vsx()

2020-10-19 Thread Christophe Leroy
rs/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.o] Error 1 Fixes: 16a9dea110a6 ("amdgpu: Enable initial DCN support on POWER") Cc: sta...@vger.kernel.org Signed-off-by: Christophe Leroy --- drivers/gpu/drm/amd/display/dc/os_types.h | 1 + 1 file changed, 1 insertion(+) diff --g

Re: [PATCH] drm/amd/display: Fix missing declaration of enable_kernel_vsx()

2020-10-19 Thread Christophe Leroy
patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Christophe-Leroy/drm-amd-display-Fix-missing-declaration-of-enable_kernel_vsx/20201019-174155 base: https://git.kernel.org/pub/scm/linux/

Re: [PATCH v2 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-06-04 Thread Christophe Leroy
t for v5.8, assuming there's no major objections. Sure. Just to let you know Christophe Leroy included this patch in his series about ppc405 removal. It should be the same. If you don't want to take that alsa patch I can send it separately and this patch can be taken from his series. I do

Re: [PATCH 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-05-21 Thread Christophe Leroy
Le 21/05/2020 à 09:02, Michael Ellerman a écrit : Arnd Bergmann writes: +On Wed, Apr 8, 2020 at 2:04 PM Michael Ellerman wrote: Benjamin Herrenschmidt writes: On Fri, 2020-04-03 at 15:59 +1100, Michael Ellerman wrote: Benjamin Herrenschmidt writes: IBM still put 40x cores inside POWER

[PATCH 1/5] drivers/powerpc: Replace _ALIGN_UP() by ALIGN()

2020-04-20 Thread Christophe Leroy
_ALIGN_UP() is specific to powerpc ALIGN() is generic and does the same Replace _ALIGN_UP() by ALIGN() Signed-off-by: Christophe Leroy --- drivers/ps3/ps3-lpm.c | 6 +++--- drivers/vfio/pci/vfio_pci_nvlink2.c | 2 +- drivers/video/fbdev/ps3fb.c | 4 ++-- sound/ppc/snd_ps3

[PATCH 3/5] powerpc: Replace _ALIGN_UP() by ALIGN()

2020-04-20 Thread Christophe Leroy
_ALIGN_UP() is specific to powerpc ALIGN() is generic and does the same Replace _ALIGN_UP() by ALIGN() Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/iommu.h | 4 ++-- arch/powerpc/kernel/head_booke.h | 2 +- arch/powerpc/kernel/nvram_64.c

[PATCH 4/5] powerpc: Replace _ALIGN() by ALIGN()

2020-04-20 Thread Christophe Leroy
_ALIGN() is specific to powerpc ALIGN() is generic and does the same Replace _ALIGN() by ALIGN() Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/book3s/32/pgtable.h | 2 +- arch/powerpc/include/asm/nohash/32/pgtable.h | 2 +- arch/powerpc/kernel/prom_init.c | 8

[PATCH 5/5] powerpc: Remove _ALIGN_UP(), _ALIGN_DOWN() and _ALIGN()

2020-04-20 Thread Christophe Leroy
These three powerpc macros have been replaced by equivalent generic macros and are not used anymore. Remove them. Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/page.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/arch/powerpc/include/asm/page.h b/arch/powerpc/include

[PATCH 2/5] powerpc: Replace _ALIGN_DOWN() by ALIGN_DOWN()

2020-04-20 Thread Christophe Leroy
_ALIGN_DOWN() is specific to powerpc ALIGN_DOWN() is generic and does the same Replace _ALIGN_DOWN() by ALIGN_DOWN() Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/book3s/32/pgtable.h | 2 +- arch/powerpc/include/asm/nohash/32/pgtable.h | 2 +- arch/powerpc/kernel/pci_64.c

Re: [PATCH 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-04-09 Thread Christophe Leroy
Le 08/04/2020 à 01:32, Benjamin Herrenschmidt a écrit : On Fri, 2020-04-03 at 15:59 +1100, Michael Ellerman wrote: Benjamin Herrenschmidt writes: On Tue, 2020-03-31 at 16:30 +1100, Michael Ellerman wrote: I have no attachment to 40x, and I'd certainly be happy to have less code in the tree,

Re: [PATCH 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-04-01 Thread Christophe Leroy
Le 31/03/2020 à 12:04, Michal Simek a écrit : On 31. 03. 20 11:49, Christophe Leroy wrote: Le 31/03/2020 à 09:19, Christophe Leroy a écrit : Le 31/03/2020 à 08:59, Michal Simek a écrit : On 31. 03. 20 8:56, Christophe Leroy wrote: Le 31/03/2020 à 07:30, Michael Ellerman a écrit

Re: [PATCH 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-04-01 Thread Christophe Leroy
Le 31/03/2020 à 09:19, Christophe Leroy a écrit : Le 31/03/2020 à 08:59, Michal Simek a écrit : On 31. 03. 20 8:56, Christophe Leroy wrote: Le 31/03/2020 à 07:30, Michael Ellerman a écrit : Christophe Leroy writes: Le 27/03/2020 à 15:14, Andy Shevchenko a écrit : On Fri, Mar 27, 2020

Re: [PATCH 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-04-01 Thread Christophe Leroy
Le 31/03/2020 à 08:59, Michal Simek a écrit : On 31. 03. 20 8:56, Christophe Leroy wrote: Le 31/03/2020 à 07:30, Michael Ellerman a écrit : Christophe Leroy writes: Le 27/03/2020 à 15:14, Andy Shevchenko a écrit : On Fri, Mar 27, 2020 at 02:22:55PM +0100, Arnd Bergmann wrote: On Fri

Re: [PATCH 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-03-31 Thread Christophe Leroy
Le 31/03/2020 à 07:30, Michael Ellerman a écrit : Christophe Leroy writes: Le 27/03/2020 à 15:14, Andy Shevchenko a écrit : On Fri, Mar 27, 2020 at 02:22:55PM +0100, Arnd Bergmann wrote: On Fri, Mar 27, 2020 at 2:15 PM Andy Shevchenko wrote: On Fri, Mar 27, 2020 at 03:10:26PM +0200, Andy

Re: [PATCH 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-03-30 Thread Christophe Leroy
Le 27/03/2020 à 15:14, Andy Shevchenko a écrit : On Fri, Mar 27, 2020 at 02:22:55PM +0100, Arnd Bergmann wrote: On Fri, Mar 27, 2020 at 2:15 PM Andy Shevchenko wrote: On Fri, Mar 27, 2020 at 03:10:26PM +0200, Andy Shevchenko wrote: On Fri, Mar 27, 2020 at 01:54:33PM +0100, Arnd Bergmann wro

Re: [PATCH v3 2/7] uaccess: Tell user_access_begin() if it's for a write or not

2020-01-24 Thread christophe leroy
Le 23/01/2020 à 19:02, Linus Torvalds a écrit : On Thu, Jan 23, 2020 at 4:59 AM Christophe Leroy wrote: On 32 bits powerPC (book3s/32), only write accesses to user are protected and there is no point spending time on unlocking for reads. Honestly, I'm starting to think that 32-bi

[PATCH v3 2/7] uaccess: Tell user_access_begin() if it's for a write or not

2020-01-24 Thread Christophe Leroy
s for write and return an opaque key that will be used by user_access_end() to know what was done by user_access_begin(). Signed-off-by: Christophe Leroy --- v3: new --- arch/x86/include/asm/uaccess.h | 5 +++-- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 15 ++

Re: [RFT 00/13] iomap: Constify ioreadX() iomem argument

2020-01-09 Thread Christophe Leroy
Le 08/01/2020 à 09:18, Krzysztof Kozlowski a écrit : On Wed, 8 Jan 2020 at 09:13, Geert Uytterhoeven wrote: Hi Krzysztof, On Wed, Jan 8, 2020 at 9:07 AM Geert Uytterhoeven wrote: On Tue, Jan 7, 2020 at 5:53 PM Krzysztof Kozlowski wrote: The ioread8/16/32() and others have inconsistent i

Re: [RFT 00/13] iomap: Constify ioreadX() iomem argument

2020-01-09 Thread Christophe Leroy
Hi Geert, Le 08/01/2020 à 09:43, Geert Uytterhoeven a écrit : Hi Christophe, On Wed, Jan 8, 2020 at 9:35 AM Christophe Leroy wrote: Le 08/01/2020 à 09:18, Krzysztof Kozlowski a écrit : On Wed, 8 Jan 2020 at 09:13, Geert Uytterhoeven wrote: On Wed, Jan 8, 2020 at 9:07 AM Geert Uytterhoeven

Re: [PATCH 09/22] docs: mark orphan documents as such

2019-06-03 Thread Christophe Leroy
Le 30/05/2019 à 01:23, Mauro Carvalho Chehab a écrit : Sphinx doesn't like orphan documents: Documentation/accelerators/ocxl.rst: WARNING: document isn't included in any toctree Documentation/arm/stm32/overview.rst: WARNING: document isn't included in any toctree Documentatio

Re: Crash on FSL Book3E due to pte_pgprot()? (was Re: [PATCH v3 12/24] powerpc/mm: use pte helpers in generic code)

2018-10-16 Thread Christophe Leroy
On 10/17/2018 12:59 AM, Michael Ellerman wrote: Christophe Leroy writes: Get rid of platform specific _PAGE_ in powerpc common code and use helpers instead. mm/dump_linuxpagetables.c will be handled separately Reviewed-by: Aneesh Kumar K.V Signed-off-by: Christophe Leroy --- arch

Re: [PATCH v3 02/24] drivers/video/fbdev: use ioremap_wc/wt() instead of __ioremap()

2018-10-12 Thread Christophe LEROY
Le 09/10/2018 à 15:51, Christophe Leroy a écrit : _PAGE_NO_CACHE is a platform specific flag. In addition, this flag is misleading because one would think it requests a noncached page whereas a noncached page is _PAGE_NO_CACHE | _PAGE_GUARDED _PAGE_NO_CACHE alone means write combined

[PATCH v3 17/24] powerpc/mm: Move pte_user() into nohash/pgtable.h

2018-10-10 Thread Christophe Leroy
Now the pte-common.h is only for nohash platforms, lets move pte_user() helper out of pte-common.h to put it together with other helpers. Reviewed-by: Aneesh Kumar K.V Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/nohash/pgtable.h | 10 ++ arch/powerpc/include/asm/pte

[PATCH v3 01/24] powerpc/32: Add ioremap_wt() and ioremap_coherent()

2018-10-10 Thread Christophe Leroy
Other arches have ioremap_wt() to map IO areas write-through. Implement it on PPC as well in order to avoid drivers using __ioremap(_PAGE_WRITETHRU) Also implement ioremap_coherent() to avoid drivers using __ioremap(_PAGE_COHERENT) Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm

[PATCH v3 03/24] drivers/block/z2ram: use ioremap_wt() instead of __ioremap(_PAGE_WRITETHRU)

2018-10-10 Thread Christophe Leroy
_PAGE_WRITETHRU is a target specific flag. Prefer generic functions. Acked-by: Geert Uytterhoeven Signed-off-by: Christophe Leroy --- drivers/block/z2ram.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/z2ram.c b/drivers/block/z2ram.c index d0c5bc4e0703

[PATCH v3 16/24] powerpc/book3s/32: do not include pte-common.h

2018-10-10 Thread Christophe Leroy
-by: Aneesh Kumar K.V Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/book3s/32/pgtable.h | 97 ++-- arch/powerpc/include/asm/pte-common.h| 16 + 2 files changed, 96 insertions(+), 17 deletions(-) diff --git a/arch/powerpc/include/asm/book3s/32

[PATCH v3 24/24] powerpc/book3s64: Avoid multiple endian conversion in pte helpers

2018-10-10 Thread Christophe Leroy
In the same spirit as already done in pte query helpers, this patch changes pte setting helpers to perform endian conversions on the constants rather than on the pte value. In the meantime, it changes pte_access_permitted() to use pte helpers for the same reason. Signed-off-by: Christophe Leroy

[PATCH v3 00/24] ban the use of _PAGE_XXX flags outside platform specific code

2018-10-10 Thread Christophe Leroy
e_at(), see discussion at https://patchwork.ozlabs.org/patch/972630/ - compilation result: http://kisskb.ellerman.id.au/kisskb/head/914a399c8f1434f3c52013e625fb1665571033ef/ Christophe Leroy (24): powerpc/32: Add ioremap_wt() and ioremap_coherent() drivers/video/fbdev: use ioremap_wc/wt() instead of _

  1   2   >