[PATCH] drm/ast: Return value when do not get edid

2021-07-17 Thread ainux . wang
From: "Ainux.Wang" There is should a status when do not get edid. Signed-off-by: Ainux.Wang --- drivers/gpu/drm/ast/ast_mode.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c index e5996ae03c49..05df48b3d223

Re: [PATCH] drm/ast: Zero is missing in detect function

2021-07-17 Thread Ainux Wang
#x27;s clearly an error and we > should return 'disconnected'. If (r == 0), we were able to retrieve the > EDID, but could not find any meaningful modes. Still, it's 'connected'. > Hi,Thomas Thanks review. I see, the drm_add_edid_modes() will retrun0 in ast_get_mode

Re: [PATCH] drm/ast: Return value when do not get edid

2021-07-17 Thread Ainux Wang
Thomas Zimmermann 于2021年7月16日周五 下午8:00写道: > > Hi > > Am 16.07.21 um 11:55 schrieb ainux.w...@gmail.com: > > From: "Ainux.Wang" > > > > There is should a status when do not get edid. > > Well, not really. > > So, the problem is that VGA is not hotplug-able. It's supposed to be > connected when the

[PATCH] drm/ast: Zero is missing in detect function

2021-07-16 Thread ainux . wang
From: "Ainux.Wang" The function ast_get_modes() will also return 0, when it try to get the edid, but it also do not get the edid. Signed-off-by: Ainux.Wang --- drivers/gpu/drm/ast/ast_mode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ast/ast_mode.c b/dr

Re: [PATCH v2] drm/ast: Add detect function support

2021-05-26 Thread Ainux Wang
You're welcome! Best regards Ainux Wang Thomas Zimmermann 于2021年5月27日周四 上午3:15写道: > > Hi > > Am 26.05.21 um 13:15 schrieb ainux.w...@gmail.com: > > From: Ainux > > > > The existence of the connector cannot be detected, > > so add the detect function

[PATCH v2] drm/ast: Add detect function support

2021-05-26 Thread ainux . wang
From: Ainux The existence of the connector cannot be detected, so add the detect function to support. Signed-off-by: Ainux --- drivers/gpu/drm/ast/ast_mode.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/

[PATCH] drm/ast: Add detect function support

2021-05-24 Thread ainux . wang
From: Ainux The existence of the connector cannot be detected, so add the detect function to support. Signed-off-by: Ainux --- drivers/gpu/drm/ast/ast_drv.c | 2 ++ drivers/gpu/drm/ast/ast_mode.c | 19 ++- 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/drivers