Re: [PATCH]] drm/dp check aux_dev before use in drm_dp_aux_dev_get_by_minor()

2020-09-09 Thread Zwane Mwaikambo
On Mon, 7 Sep 2020, Ville Syrjälä wrote: > On Fri, Sep 04, 2020 at 12:21:26AM -0700, Zwane Mwaikambo wrote: > > I observed this when unplugging a DP monitor whilst a computer is asleep > > and then waking it up. This left DP chardev nodes still being present on > > the fil

[PATCH]] drm/dp check aux_dev before use in drm_dp_aux_dev_get_by_minor()

2020-09-04 Thread Zwane Mwaikambo
*inode, struct file *file) { unsigned int minor = iminor(inode); struct drm_dp_aux_dev *aux_dev; aux_dev = drm_dp_aux_dev_get_by_minor(minor); < if (!aux_dev) return -ENODEV; file->private_data = aux_dev; return 0; } Fixes: e94cb37b34eb8 ("Add a d

Re: [PATCH] drm: assure aux_dev is nonzero before using it

2020-08-18 Thread Zwane Mwaikambo
On Wed, 12 Aug 2020, Lyude Paul wrote: > On Wed, 2020-08-12 at 16:10 +0200, Daniel Vetter wrote: > > On Wed, Aug 12, 2020 at 12:16 AM Zwane Mwaikambo wrote: > > > On Tue, 11 Aug 2020, Daniel Vetter wrote: > > > > > > > On Mon, Aug 10, 2020 at

Re: [PATCH] drm: assure aux_dev is nonzero before using it

2020-08-13 Thread Zwane Mwaikambo
On Wed, 12 Aug 2020, Lyude Paul wrote: > On Wed, 2020-08-12 at 16:10 +0200, Daniel Vetter wrote: > > On Wed, Aug 12, 2020 at 12:16 AM Zwane Mwaikambo wrote: > > > On Tue, 11 Aug 2020, Daniel Vetter wrote: > > > > > > > On Mon, Aug 10, 2020 at

Re: [PATCH] drm: assure aux_dev is nonzero before using it

2020-08-12 Thread Zwane Mwaikambo
On Tue, 11 Aug 2020, Daniel Vetter wrote: > On Mon, Aug 10, 2020 at 10:11:50AM -0700, Zwane Mwaikambo wrote: > > Hi Folks, > > I know this thread eventually dropped off due to not identifying > > the underlying issue. It's still occuring on 5.8 and in my case it

Re: [PATCH] drm: assure aux_dev is nonzero before using it

2020-08-11 Thread Zwane Mwaikambo
Hi Folks, I know this thread eventually dropped off due to not identifying the underlying issue. It's still occuring on 5.8 and in my case it happened because the udev device nodes for the DP aux devices were not cleaned up whereas the kernel had no association with them. I can reproduc