On Thu, Feb 27, 2025 at 11:38:05AM +0200, Jani Nikula wrote:
> Update GVT-g MAINTAINERS entry to reflect the current status of
> maintenance and repositories.
>
> Cc: Dave Airlie
> Cc: Joonas Lahtinen
> Cc: Rodrigo Vivi
> Cc: Simona Vetter
> Cc: Tvrtko Ursulin
>
On Fri, Jan 10, 2025 at 12:49:27PM +0200, Jani Nikula wrote:
> On Thu, 09 Jan 2025, Rodrigo Vivi wrote:
> > On Mon, Jan 06, 2025 at 04:30:20PM +0900, Zhenyu Wang wrote:
> >> On Sun, Dec 22, 2024 at 12:25:09AM +, Dr. David Alan Gilbert wrote:
> >> > Note: zhe
On Thu, Jan 09, 2025 at 04:10:24PM -0500, Rodrigo Vivi wrote:
> On Mon, Jan 06, 2025 at 04:30:20PM +0900, Zhenyu Wang wrote:
> > On Sun, Dec 22, 2024 at 12:25:09AM +, Dr. David Alan Gilbert wrote:
> > > Note: zhen...@linux.intel.com's address bounces:
> > >
&
On Sun, Dec 22, 2024 at 12:25:09AM +, Dr. David Alan Gilbert wrote:
> Note: zhen...@linux.intel.com's address bounces:
>
yeah, I've left Intel so can't use that box any more, looks Rodrigo hasn't
queue up my address change patch yet. Rodrigo?
5/gvt: Remove intel_gvt_ggtt_h2g<->index
> drm/i915/gvt: Remove unused intel_vgpu_decode_sprite_plane
> drm/i915/gvt: Remove unused intel_gvt_in_force_nonpriv_whitelist
>
All three cleanups are fine with me.
Reviewed-by: Zhenyu Wang
> drivers/gpu/drm/i915/gvt/fb_decoder.
ODO comment about EDID extension block support.
>
> Acked-by: Zhi Wang
> Signed-off-by: Jani Nikula
>
Looks fine to me. Feel free to merge.
Reviewed-by: Zhenyu Wang
> ---
>
> Cc: Zhenyu Wang
> Cc: Zhi Wang
> Cc: intel-gvt-...@lists.freedesktop.org
> Cc:
quot;,
> - info->offset);
> + WARN(1, "dup mmio definition offset %x\n", i);
>
> /* We return -EEXIST here to make GVT-g load fail.
>* So duplicated MMIO can be found as soon as
> --
> 2.43.0
>
Thanks for the fix.
Reviewed-by: Zhenyu Wang
signature.asc
Description: PGP signature
tus))
> - return -ESRCH;
> - if (vgpu->msi_trigger && eventfd_signal(vgpu->msi_trigger, 1) != 1)
> - return -EFAULT;
> - return 0;
> + return;
> + if (!vgpu->msi_trigger)
> + return;
> + eventfd_signal(v
related
> 3.Add '&& !idr_is_empty()' like the original code '&& !list_empty()'
Looks good to me. I'll send it for some regression test before upstream.
Reviewed-by: Zhenyu Wang
Thanks!
>
> v1 link:
>
> https://lore.kernel.o
On 2023.03.02 19:53:18 +0800, Cai Huoqing wrote:
> This patch uses the already existing IDR mechanism to simplify
> and improve the dmabuf code.
>
> Using 'vgpu.object_idr' directly instead of 'dmabuf_obj_list_head'
> or 'dmabuf.list', because the dmabuf_obj can be found by 'idr_find'
> or 'idr_fo
mem = (fw->data + h->cfg_space_offset);
>
> id = *(u16 *)(mem + PCI_VENDOR_ID);
> - VERIFY("vender id", id, pdev->vendor);
> + VERIFY("vendor id", id, pdev->vendor);
>
> id = *(u16 *)(mem + PCI_DEVICE_ID);
> VERIFY(&
, just
> > call debugfs_lookup_and_remove() instead which handles all of the logic
> > at once.
> >
> > Cc: Zhenyu Wang
> > Cc: Zhi Wang
> > Cc: Jani Nikula
> > Cc: Joonas Lahtinen
> > Cc: Rodrigo Vivi
> > Cc: Tvrtko Ursulin
> > Cc: David Airlie
On 2023.02.16 22:32:33 -0800, Randy Dunlap wrote:
> Hi,
>
> On 2/16/23 17:52, Zhenyu Wang wrote:
> > On 2023.02.14 20:45:33 -0800, Randy Dunlap wrote:
> >> Inserting a Kconfig symbol that does not have a dependency (DRM_I915_GVT)
> >> into a list of other symb
ot;)
> Signed-off-by: Randy Dunlap
> Cc: Christoph Hellwig
> Cc: Zhi Wang
> Cc: Jani Nikula
> Cc: Joonas Lahtinen
> Cc: Rodrigo Vivi
> Cc: Tvrtko Ursulin
> Cc: Zhenyu Wang
> Cc: intel-...@lists.freedesktop.org
> Cc: intel-gvt-...@lists.freedesktop.org
> Cc: d
On 2023.01.19 17:05:56 -0500, Rodrigo Vivi wrote:
>
> It still doesn't apply in drm-intel-next.
> Could you please take it through your branch?
>
sure, I'll pick it.
signature.asc
Description: PGP signature
gpu *vgpu,
> ret = idr_alloc(&gvt->vgpu_idr, vgpu, IDLE_VGPU_IDR + 1, GVT_MAX_VGPU,
> GFP_KERNEL);
> if (ret < 0)
> - goto out_unlock;;
> + goto out_unlock;
>
> vgpu->id = ret;
> vgpu->sched_ctl.we
On 2023.01.18 11:44:55 -0500, Rodrigo Vivi wrote:
> On Wed, Jan 18, 2023 at 10:18:11AM +0530, Deepak R Varma wrote:
> > On Tue, Jan 17, 2023 at 02:29:37PM -0500, Rodrigo Vivi wrote:
> > > On Mon, Jan 16, 2023 at 01:44:46PM +0800, Zhenyu Wang wrote:
> > > > On 2023
ess they ack and I apply in the drm-intel along with the other
> ones.
>
yeah, they're fine with me, feel free to apply them directly.
Acked-by: Zhenyu Wang
thanks!
> > ---
> > drivers/gpu/drm/i915/gvt/debugfs.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 d
_pte(sub_spt, &sub_se);
> + }
> + /* Release the new allocated spt. */
> + trace_spt_change(sub_spt->vgpu->id, "release", sub_spt,
> + sub_spt->guest_page.gfn, sub_spt->shadow_page.type);
> + ppgtt_free_spt(sub_spt);
> + sub_spt =
nsigned char data[];
> };
>
> #define dev_to_drm_minor(d) dev_get_drvdata((d))
> @@ -77,7 +77,7 @@ static int expose_firmware_sysfs(struct intel_gvt *gvt)
> unsigned long size, crc32_start;
> int ret;
>
> - size = sizeof(*h) + info->mmio_size + info->cfg
On 2022.12.19 20:52:04 +0800, Zheng Wang wrote:
> If intel_gvt_dma_map_guest_page failed, it will call
> ppgtt_invalidate_spt, which will finally free the spt. But the caller does
> not notice that, it will free spt again in error path.
>
It's not clear from this description which caller is actu
nt get_pt_type(int type)
> -{
> - return gtt_type_table[type].pt_type;
> -}
> -
> static inline int get_entry_type(int type)
> {
> return gtt_type_table[type].entry_type;
> --
> 2.20.1.7.g153144c
>
Reviewed-by: Zhenyu Wang
thanks!
signature.asc
Description: PGP signature
> * @gvt: GVT device
> *
> - * This function is called at the driver unloading stage, to clean up the
> + * This function is called at the driver unloading stage, to clean up
> * the mm components of a GVT device.
> *
> */
> --
> 2.36.1
>
Reviewed-by: Zhenyu Wang
thanks
signature.asc
Description: PGP signature
py(p, gvt->firmware.mmio, info->mmio_size);
>
> - crc32_start = offsetof(struct gvt_firmware_header, crc32) + 4;
> + crc32_start = offsetof(struct gvt_firmware_header, version);
> h->crc32 = crc32_le(0, firmware + crc32_start, size - crc32_start);
>
> firmware_attr.size = size;
> --
> 2.25.4
>
Reviewed-by: Zhenyu Wang
thanks!
signature.asc
Description: PGP signature
ewed-by: Jason Gunthorpe
> ---
Looks good to me.
Reviewed-by: Zhenyu Wang
> drivers/gpu/drm/i915/gvt/gvt.h | 5 ++-
> drivers/gpu/drm/i915/gvt/kvmgt.c | 52 ++--
> drivers/gpu/drm/i915/gvt/vgpu.c | 33
> 3 files changed, 50 insertion
On 2022.09.06 19:36:56 +0800, Zheng Hacker wrote:
> Hi Greg,
>
> Alex has explained how we figured out the patch. We did analyze the
> code and found it possible to reach the vulnerability code. But we
> have no physical device in hand to test the driver. So we'd like to
> discuss with developers
a virtual GPU.
> @@ -219,7 +219,7 @@ void intel_gvt_activate_vgpu(struct intel_vgpu *vgpu)
> }
>
> /**
> - * intel_gvt_deactive_vgpu - deactivate a virtual GPU
> + * intel_gvt_deactivate_vgpu - deactivate a virtual GPU
> * @vgpu: virtual GPU
> *
> * This funct
On 2022.07.11 21:24:49 +0100, Mauro Carvalho Chehab wrote:
> Some functions seem to have been renamed without updating the kernel-doc
> markup causing warnings. Also, struct intel_vgpu_dmabuf_obj is not
> properly documented, but has a kerneld-doc markup.
>
> Fix those warnings:
> drivers/gp
This function is used to free the HW resource owned by a vGPU.
> @@ -328,7 +328,7 @@ void intel_vgpu_reset_resource(struct intel_vgpu *vgpu)
> }
>
> /**
> - * intel_alloc_vgpu_resource - allocate HW resource for a vGPU
> + * intel_vgpu_alloc_resource() - allocate HW resource for a vG
gine
> + * intel_gvt_switch_mmio - switch mmio context of specific engine
> * @pre: the last vGPU that own the engine
> * @next: the vGPU to switch to
> * @engine: the engine
> --
> 2.20.1.7.g153144c
>
Acked-by: Zhenyu Wang
Thanks!
signature.asc
Description: PGP signature
te handler
> + * intel_vgpu_default_mmio_write() - default MMIO write handler
> * @vgpu: a vGPU
> * @offset: access offset
> * @p_data: write data buffer
> --
> 2.20.1.7.g153144c
>
Sorry for late reply!
Acked-by: Zhenyu Wang
signature.asc
Description: PGP signature
* settting the shadow entry to point to a scratch page
> + * setting the shadow entry to point to a scratch page
>*/
> ops->set_pfn(&m, gvt->gtt.scratch_mfn);
> } else
>
Sorry for late reply!
Acked-by: Zhenyu Wang
signature.asc
Description: PGP signature
ewed-by: Christoph Hellwig
> Reviewed-by: Kevin Tian
> Reviewed-by: Tony Krowiak
> Reviewed-by: Eric Farman
> Signed-off-by: Jason Gunthorpe
> ---
> drivers/gpu/drm/i915/gvt/gvt.h| 1 -
> drivers/gpu/drm/i915/gvt/kvmgt.c | 75 ---
gvt change look
fine to me. Thanks!
Reviewed-by: Zhenyu Wang
signature.asc
Description: PGP signature
(fmt, args...) \
> - pr_debug("gvt: dpy: "fmt, ##args)
> + pr_debug("gvt:dpy: " fmt, ##args)
>
> #define gvt_dbg_el(fmt, args...) \
> - pr_debug("gvt: el: "fmt, ##args)
> + pr_debug("gvt:el: " fmt, ##args)
>
>
On 2021.08.20 12:56:34 -0700, Luis Chamberlain wrote:
> On Fri, Aug 20, 2021 at 04:17:24PM +0200, Christoph Hellwig wrote:
> > On Thu, Aug 19, 2021 at 04:29:29PM +0800, Zhenyu Wang wrote:
> > > I'm working on below patch to resolve this. But I met a weird issue in
> >
On 2021.08.20 16:17:24 +0200, Christoph Hellwig wrote:
> On Thu, Aug 19, 2021 at 04:29:29PM +0800, Zhenyu Wang wrote:
> > I'm working on below patch to resolve this. But I met a weird issue in
> > case when building i915 as module and also kvmgt module, it caused
> > b
On 2021.08.19 17:43:43 +0300, Joonas Lahtinen wrote:
> Quoting Zhenyu Wang (2021-08-19 11:29:29)
> > On 2021.08.17 13:22:03 +0800, Zhenyu Wang wrote:
> > > > On 2021.08.16 19:34:58 +0200, Christoph Hellwig wrote:
> > > > > Any updates on this? I
On 2021.08.17 13:22:03 +0800, Zhenyu Wang wrote:
> > On 2021.08.16 19:34:58 +0200, Christoph Hellwig wrote:
> > > Any updates on this? I'd really hate to miss this merge window.
> >
> > I'm still waiting for our validation team's report on this. I
On 2021.08.17 09:08:55 +0800, Zhenyu Wang wrote:
> On 2021.08.16 19:34:58 +0200, Christoph Hellwig wrote:
> > On Wed, Aug 04, 2021 at 01:26:06PM +0800, Zhenyu Wang wrote:
> > > On 2021.08.03 11:30:58 -0300, Jason Gunthorpe wrote:
> > > > On Tue, Aug 03, 2021 at 05:43
On 2021.08.16 19:34:58 +0200, Christoph Hellwig wrote:
> On Wed, Aug 04, 2021 at 01:26:06PM +0800, Zhenyu Wang wrote:
> > On 2021.08.03 11:30:58 -0300, Jason Gunthorpe wrote:
> > > On Tue, Aug 03, 2021 at 05:43:15PM +0800, Zhenyu Wang wrote:
> > > > Acked-by: Zhenyu W
On 2021.08.03 11:30:58 -0300, Jason Gunthorpe wrote:
> On Tue, Aug 03, 2021 at 05:43:15PM +0800, Zhenyu Wang wrote:
> > Acked-by: Zhenyu Wang
> >
> > Thanks a lot for this effort!
>
> Great, do we have a submission plan for this? how much does it clash
> with my
gt; If we were to support another upstream hypervisor we'd just need to
> union a few fields in struct intel_gpu and maybe introduce a few
> methods. Preferably in a way that avoids expensive indirect calls
> in the fast path.
ok, agree on that.
Acked-by: Zhenyu Wang
Thanks a lot for this effort!
signature.asc
Description: PGP signature
On 2021.07.21 17:53:35 +0200, Christoph Hellwig wrote:
> Remove the separately included Makefile and just use the relative
> reference from the main i915 Makefile as for source files in other
> subdirectories.
>
We agreed to make gvt mostly self-contained in its own directory
before. Although I do
On 2021.07.21 17:53:34 +0200, Christoph Hellwig wrote:
> Hi all,
>
> the GVT code in the i915 is a bit of a mess right now due to strange
> abstractions and lots of indirect calls. This series refactors various
> bits to clean that up. The main user visible change is that almost all
> of the GVT
On 2021.07.16 18:41:38 +0800, Xiyu Yang wrote:
> refcount_t type and corresponding API can protect refcounters from
> accidental underflow and overflow and further use-after-free situations
>
Thanks for the patch. Is there any specific problem you run with current code?
Any shadow ppgtt error?
>
>
> - .open = intel_vgpu_open,
> - .release= intel_vgpu_release,
> + .open_device= intel_vgpu_open_device,
> + .close_device = intel_vgpu_close_device,
>
> .read = intel_vgpu_read,
> .write = intel_vgpu_write,
Looks ok to me. Thanks!
Reviewed-by: Zhenyu Wang
signature.asc
Description: PGP signature
> - dmabuf_obj = container_of(pos, struct intel_vgpu_dmabuf_obj,
> - list);
> + dmabuf_obj = list_entry(pos, struct intel_vgpu_dmabuf_obj,
> list);
> dmabuf_obj->vgpu = NULL;
>
> idr_remove(&vgpu->object_idr, dmabuf_obj->dmabuf_id);
> --
Sorry for late reply! Looks good to me.
Reviewed-by: Zhenyu Wang
signature.asc
Description: PGP signature
On 2021.05.22 21:19:38 +0200, Thomas Zimmermann wrote:
> Hi,
>
> after creating drm-tip today as part of [1], building drm-tip is now broken
> with the error message shown below.
>
> Some register constants appear to be missing from the GVT code. Please fix
> ASAP.
>
Thanks, Thomas. Looks DMC re
On 2021.05.19 10:31:18 +0200, Greg Kroah-Hartman wrote:
> On Wed, May 19, 2021 at 04:03:13PM +0800, Zhenyu Wang wrote:
> > On 2021.05.18 18:28:53 +0200, Greg Kroah-Hartman wrote:
> > > On Tue, May 18, 2021 at 06:17:05PM +0200, Greg Kroah-Hartman wrote:
> > > > There
gt; > Simplify the structure by removing the dentry and relying on debugfs
> > to find the dentry to remove when we want to.
> >
> > By doing this change, we remove the last in-kernel user that was storing
> > the result of debugfs_create_long(), so that api can be cleaned u
he dentry to remove when we want to.
>
> By doing this change, we remove the last in-kernel user that was storing
> the result of debugfs_create_long(), so that api can be cleaned up.
>
> Cc: Zhenyu Wang
> Cc: Zhi Wang
> Cc: Jani Nikula
> Cc: Joonas Lahtinen
> Cc: Rodrigo
On 2021.04.23 09:20:09 -0600, Alex Williamson wrote:
> On Fri, 23 Apr 2021 09:07:09 -0300
> Jason Gunthorpe wrote:
>
> > On Fri, Apr 23, 2021 at 11:54:26AM +0800, Zhenyu Wang wrote:
> > > On 2021.04.22 10:58:10 -0300, Jason Gunthorpe wrote:
> > > > On T
On 2021.04.22 10:58:10 -0300, Jason Gunthorpe wrote:
> On Thu, Apr 22, 2021 at 03:35:33PM +0200, Arnd Bergmann wrote:
> > From: Arnd Bergmann
> >
> > The Kconfig dependency is incomplete since DRM_I915_GVT is a 'bool'
> > symbol that depends on the 'tristate' VFIO_MDEV. This allows a
> > configur
ero/success. The fix is to modify it to return zero
> or negative error codes and make everything consistent.
>
> Fixes: c5d71cb31723 ("drm/i915/gvt: Move vGPU type related code into gvt
> file")
> Signed-off-by: Dan Carpenter
> ---
Reviewed-by: Zhenyu Wang
Thanks
entry *entry, unsigned long index)
> -{
> - _ppgtt_set_root_entry(mm, entry, index, true);
> -}
> -
> static inline void ppgtt_set_shadow_root_entry(struct intel_vgpu_mm *mm,
> struct intel_gvt_gtt_entry *entry, unsigned long index)
> {
> --
Reviewed-by:
evin Tian
> Reviewed-by: Christoph Hellwig
> Signed-off-by: Jason Gunthorpe
> ---
Reviewed-by: Zhenyu Wang
For two gvt specific changes in this series, it's better to just merge through
vfio tree.
Thanks
> drivers/gpu/drm/i915/gvt/gvt.c | 24 +++-
&g
> +++ b/drivers/gpu/drm/i915/Kconfig
> @@ -101,6 +101,7 @@ config DRM_I915_GVT
> bool "Enable Intel GVT-g graphics virtualization host support"
> depends on DRM_I915
> depends on 64BIT
> + depends on VFIO_MDEV
> default n
> help
On 2021.03.23 16:39:36 -0300, Jason Gunthorpe wrote:
> On Tue, Mar 23, 2021 at 08:26:30PM +0100, Christoph Hellwig wrote:
> > On Tue, Mar 23, 2021 at 02:55:32PM -0300, Jason Gunthorpe wrote:
> > > Ideally all of this would be moved to kvmgt.c, but it is entangled with
> > > the rest of the "generic
On 2021.02.22 06:22:37 -0800, Randy Dunlap wrote:
> On 2/22/21 6:21 AM, Randy Dunlap wrote:
> > On 2/22/21 12:18 AM, Bhaskar Chowdhury wrote:
> >>
> >> s/negtive/negative/
> >> s/possilbe/possible/
> >>
> >> Signed-off-by: Bhaskar Chowdhury
> >
> > Acked-by: Randy Dunlap
>
> except the Subject
On 2021.02.09 02:52:10 +0800, Yu Zhang wrote:
> Previously, commit 531810caa9f4 ("KVM: x86/mmu: Use
> an rwlock for the x86 MMU") replaced KVM's mmu_lock
> with type rwlock_t. This will cause a build failure
> in kvmgt, which uses the same lock when trying to add/
> remove some GFNs to/from the pag
On 2021.01.25 09:44:53 +, Chris Wilson wrote:
> Quoting Dan Carpenter (2021-01-25 08:48:30)
> > Smatch found an uninitialized variable bug in this code:
> >
> > drivers/gpu/drm/i915/gvt/cmd_parser.c:3191
> > intel_gvt_update_reg_whitelist()
> > error: uninitialized symbol 'ret'.
> >
> /* Take a module reference as mdev core doesn't take
>* a reference for vendor driver.
>*/
> - if (!try_module_get(THIS_MODULE))
> + if (!try_module_get(THIS_MODULE)) {
> + ret = -ENODEV;
> goto undo_group;
> + }
>
uct
> intel_gvt *gvt,
> mutex_init(&vgpu->dmabuf_lock);
> INIT_LIST_HEAD(&vgpu->dmabuf_obj_list_head);
> INIT_RADIX_TREE(&vgpu->page_track_tree, GFP_KERNEL);
> - idr_init(&vgpu->object_idr);
> + idr_init_base(&vgpu->object_idr,
ite);
> } else {
> pos -= EDID_BLOB_OFFSET;
Thanks for reporting this! Sorry that we failed to do sanity validation on older
platform when enabling vfio edid function for all platform.
Could you try below one to see if it fixes your problem? Instead of refusing
possible rea
what actions a user can
> take to resolve this situation.
>
> Cc: Thomas Prescher
> Cc: Zhenyu Wang
> Signed-off-by: Julian Stecklina
> ---
> drivers/gpu/drm/i915/gvt/aperture_gm.c | 9 ++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git
On 2020.05.18 22:00:52 +0100, Chris Wilson wrote:
> Quoting Aishwarya Ramakrishnan (2020-05-18 16:03:36)
> > Prefer ARRAY_SIZE instead of using sizeof
> >
> > Fixes coccicheck warning: Use ARRAY_SIZE
> >
> > Signed-off-by: Aishwarya Ramakrishnan
> Reviewed-by: Chris Wilson
Applied, thanks!
--
ruct execlist_ring_context *c, struct
> intel_vgpu_mm *m)
> {
> if (m->ppgtt_mm.root_entry_type == GTT_TYPE_PPGTT_ROOT_L4_ENTRY) {
>
> base-commit: bdecf38f228bcca73b31ada98b5b7ba1215eb9c9
Thanks for the fix!
Acked-by: Zhenyu Wang
I'll pick up for gvt-next-fixes pull.
--
Open Source Technol
On 2020.04.10 00:58:16 +0300, Jani Nikula wrote:
> On Fri, 10 Apr 2020, Masahiro Yamada wrote:
> > Including subdirectory Makefile from the driver main Makefile does not
> > buy us much because this is not real isolation.
>
> The isolation it does buy us is that gvt/ subdirectory is developed and
On 2020.02.24 13:11:05 +0200, Jani Nikula wrote:
> On Mon, 24 Feb 2020, Zhenyu Wang wrote:
> > On 2020.02.23 18:09:35 +0200, Jani Nikula wrote:
> >> On Thu, 20 Feb 2020, Pankaj Bharadiya
> >> wrote:
> >> > drm/i915/gvt: Make WARN* drm specific where drm_
tches, pushed everything except these, which are for
> Zhenyu & Zhi.
>
For GVT changes.
Acked-by: Zhenyu Wang
Please also cc intel-gvt-dev list in future for gvt change.
Thanks!
--
Open Source Technology Center, Intel ltd.
$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
signat
nd.
> Signed-off-by: Julian Stecklina
> Acked-by: Zhenyu Wang
> ---
> drivers/gpu/drm/i915/gvt/gvt.h | 32 +---
> drivers/gpu/drm/i915/gvt/kvmgt.c | 287 +++
> 2 files changed, 184 insertions(+), 135 deletions(-)
>
> diff --git a/drivers/g
mutex_unlock(&mm->vgpu->gvt->gtt.ppgtt_mm_lock);
> +
> invalidate_ppgtt_mm(mm);
> } else {
> vfree(mm->ggtt_mm.virtual_ggtt);
> --
Thanks for the fix!
Reviewed-by: Zhenyu Wang
--
Open Sou
t;cfg_space = mem;
>
> - mem = kmalloc(info->mmio_size, GFP_KERNEL);
> + mem = vmalloc(info->mmio_size);
> if (!mem) {
> kfree(path);
> kfree(firmware->cfg_space);
> --
> 2.7.4
>
Looks fine to me. Thanks!
Reviewed-by: Zheny
On 2020.01.20 14:22:10 +0800, Zhenyu Wang wrote:
> On 2020.01.09 19:13:54 +0200, Julian Stecklina wrote:
> > Instead of defining KVMGT per-device state in struct intel_vgpu
> > directly, add an indirection. This makes the GVT code oblivious of
> > what state KVMGT needs
On 2020.01.09 19:13:55 +0200, Julian Stecklina wrote:
> This variable is used nowhere, so remove it.
>
> Cc: Zhenyu Wang
>
> Signed-off-by: Julian Stecklina
> ---
Thanks for catching this.
Acked-by: Zhenyu Wang
> drivers/gpu/drm/i915/gvt/gvt.h | 2 --
> drivers/
ssible to build
> hypervisor backends for the mediator, without having to touch the
> mediator itself. This is a first step.
>
> Cc: Zhenyu Wang
>
> Signed-off-by: Julian Stecklina
> ---
Acked-by: Zhenyu Wang
> drivers/gpu/drm/i915/gvt/gvt.h | 32 +---
&g
On 2020.01.16 15:13:01 +0100, Julian Stecklina wrote:
> Hi Greg, Christoph,
>
> On Wed, 2020-01-15 at 16:22 +0100, Greg KH wrote:
> > On Thu, Jan 09, 2020 at 07:13:57PM +0200, Julian Stecklina wrote:
> > > Now that the GVT interface to hypervisors does not depend on i915/GVT
> > > internals anymor
On 2020.01.06 16:06:20 +0200, Julian Stecklina wrote:
> The documentation had some stale paths to i915 graphics virtualization
> code. Fix them to point to existing files.
>
> Cc: Zhenyu Wang
> Cc: zhiyuan...@intel.com
> Cc: hang.y...@intel.com
>
> Signed-
/gtt.c
> @@ -1282,7 +1282,7 @@ static int ppgtt_populate_shadow_entry(struct
> intel_vgpu *vgpu,
> return -EINVAL;
> default:
> GEM_BUG_ON(1);
> - };
> + }
>
> /* direct shadow */
> ret = intel_gvt_hypervisor_dma
id)
> file_count(dmabuf->file),
> kref_read(&obj->base.refcount));
>
> + i915_gem_object_put(obj);
> +
> return dmabuf_fd;
>
> out_free_dmabuf:
Looks fine to me. Thanks!
Reviewed-by: Zhenyu Wang
--
Open S
On 2019.08.08 11:44:21 +0100, Chris Wilson wrote:
> Quoting Dan Carpenter (2019-08-08 11:32:36)
> > We can't free "workload" until after the printk or it's a use after
> > free.
> >
> > Fixes: 2089a76ade90 ("drm/i915/gvt: Checking workload's gma earlier")
> > Signed-off-by: Dan Carpenter
>
> Tha
iom.
Reviewed-by: Zhenyu Wang
>
> Because there is no need to check these functions, a number of local
> functions can be made to return void to simplify things as nothing can
> fail.
>
> Cc: Zhenyu Wang
> Cc: Zhi Wang
> Cc: Jani Nikula
> Cc: Joonas Lahtinen
>
gpu/drm/i915/i915.ko] undefined!
ERROR: "__tracepoint_oos_change" [drivers/gpu/drm/i915/i915.ko] undefined!
scripts/Makefile.modpost:91: recipe for target '__modpost' failed
Looks we need fix like below.
Subject: [PATCH] drm/i915/gvt: remove duplicate include of trace.h
This
On 2018.12.20 12:33:35 +0100, Gerd Hoffmann wrote:
> On Thu, Dec 20, 2018 at 08:45:09AM +, Zhang, Tina wrote:
> >
> >
> > > -Original Message-
> > > From: intel-gvt-dev [mailto:intel-gvt-dev-boun...@lists.freedesktop.org]
> > > On
> > > Behalf Of Gerd Hoffmann
> > > Sent: Wednesday,
On 2018.11.25 23:25:24 +, Colin King wrote:
> From: Colin Ian King
>
> There is a spelling mistake in an error message, fix it.
>
> Signed-off-by: Colin Ian King
> ---
> drivers/gpu/drm/i915/gvt/interrupt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/g
vmgt_guest_exit, or maybe mmget_not_zero.
>
yeah, that's the clear way to fix this imo. We only depend on guest
life cycle to access guest memory properly. Here's proposed fix, will
verify and integrate it later.
Thanks!
From 5e5a8d0409aa150884adf5a4d0b956fd0b9906b3 Mon Sep 17 00:00:00 2001
From: Zhen
On 2018.08.03 08:41:19 +0800, Yi Wang wrote:
> The 'sparse' variable may leak when return in function
> intel_vgpu_ioctl(), and this patch fixes this.
>
> Signed-off-by: Yi Wang
> Reviewed-by: Jiang Biao
> ---
> drivers/gpu/drm/i915/gvt/kvmgt.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> di
On 2018.08.02 22:40:19 -0500, Gustavo A. R. Silva wrote:
> info.index can be indirectly controlled by user-space, hence leading
> to a potential exploitation of the Spectre variant 1 vulnerability.
>
> This issue was detected with the help of Smatch:
>
> drivers/gpu/drm/i915/gvt/kvmgt.c:1232 inte
On 2018.08.03 08:41:19 +0800, Yi Wang wrote:
> The 'sparse' variable may leak when return in function
> intel_vgpu_ioctl(), and this patch fixes this.
>
> Signed-off-by: Yi Wang
> Reviewed-by: Jiang Biao
> ---
Looks fine to me, will queue this up.
Thanks for the patch!
> drivers/gpu/drm/i915
On 2018.03.22 21:31:33 +, Chris Wilson wrote:
> Quoting Gustavo A. R. Silva (2018-03-22 18:21:54)
> > The checks are misleading and not required [1].
> >
> > [1] https://lkml.org/lkml/2018/3/19/1792
> >
> > Addresses-Coverity-ID: 1466017
> > Cc: Chris Wilson
> > Signed-off-by: Gustavo A. R.
On 2018.03.21 09:44:32 -0600, Alex Williamson wrote:
> On Wed, 21 Mar 2018 15:08:47 +0100
> Gerd Hoffmann wrote:
>
> > On unknown/unhandled ioctls the driver should return an error, so
> > userspace knows it tried to use something unsupported.
> >
> > Cc: sta...@vger.kernel.org
> > Signed-off-by
On 2018.03.12 12:43:58 +0100, Colin King wrote:
> From: Colin Ian King
>
> Trivial fix to spelling mistake in gvt_err error message text.
>
> Signed-off-by: Colin Ian King
> ---
Thanks Colin, will pick up.
> drivers/gpu/drm/i915/gvt/gtt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(
On 2017.12.09 00:37:59 -0600, Gustavo A. R. Silva wrote:
> In case function skl_format_to_drm returns -EINVAL, fmt turns into a huge
> number as fmt is of type u32, hence there is an out-of-bounds read when
> using fmt as an index for array skl_pixel_formats at line 225:
> plane->bpp = skl_pixel_fo
On 2017.12.04 10:57:35 +1100, Stephen Rothwell wrote:
> Hi all,
>
> There is a series of commits
>
> 54cff6479fd8 - c1802534e5a6
> (not all in that range)
>
> that are missing a Signed-off-by from their committer.
>
They were originally committed by Zhi himself, but I had to rebase
onto inte
On 2017.09.19 19:35:23 -0700, Joe Perches wrote:
> On Wed, 2017-09-20 at 05:46 +0800, Zhenyu Wang wrote:
> > On 2017.09.19 16:55:34 +0100, Colin King wrote:
> > > From: Colin Ian King
> > >
> > > An earlier fix changed the return type from find_bb_size howev
On 2017.09.19 16:55:34 +0100, Colin King wrote:
> From: Colin Ian King
>
> An earlier fix changed the return type from find_bb_size however the
> integer return is being assigned to a unsigned int so the -ve error
> check will never be detected. Make bb_size an int to fix this.
>
> Detected by C
On 2017.07.17 11:06:24 +0800, Tina Zhang wrote:
> Framebuffer decoder returns guest framebuffer information.
> Guest framebuffer includes primary, cursor and sprite plane.
>
> Signed-off-by: Xiaoguang Chen
> Signed-off-by: Tina Zhang
> ---
> drivers/gpu/drm/i915/gvt/Makefile | 3 +-
> dri
On 2017.05.21 00:15:27 -0700, Nick Desaulniers wrote:
> This flag is already set in the top level Makefile of the kernel.
>
> Also, by having set CONFIG_DRM_I915_GVT, thereby appending -Wall to
> ccflags, you undo all the -Wno-* cflags previously set in the Make
> variable KBUILD_CFLAGS.
>
> For
On 2017.05.24 16:50:39 +0800, changbin...@intel.com wrote:
> From: Changbin Du
>
> At least we need one MPT module (currently only have one) selected
> to get GVTg functional. When GVTg is enabled while no MPT selected,
> the build just includes useless GVTg code. This doesn't make sense.
>
The
1 - 100 of 159 matches
Mail list logo
