Re: [PATCH 3/3] drm/v3d: Add job timeout module param

2021-02-10 Thread Yukimasa Sugizaki
On 11/02/2021, Chema Casanova wrote: > > On 5/2/21 13:28, Yukimasa Sugizaki wrote: >> On 05/02/2021, Eric Anholt wrote: >>> On Thu, Feb 4, 2021 at 10:09 AM Chema Casanova >>> wrote: >>>> On 3/9/20 18:48, Yukimasa Sugizaki wrote: >>>>> Fr

Re: [PATCH 3/3] drm/v3d: Add job timeout module param

2021-02-05 Thread Yukimasa Sugizaki
On 05/02/2021, Eric Anholt wrote: > On Thu, Feb 4, 2021 at 10:09 AM Chema Casanova > wrote: >> >> On 3/9/20 18:48, Yukimasa Sugizaki wrote: >> > From: Yukimasa Sugizaki >> > >> > The default timeout is 500 ms which is too short for some workloads

[PATCH 3/3] drm/v3d: Add job timeout module param

2020-09-04 Thread Yukimasa Sugizaki
The default timeout is 500 ms which is too short for some workloads including Piglit. Adding this parameter will help users to run heavier tasks. Signed-off-by: Yukimasa Sugizaki --- drivers/gpu/drm/v3d/v3d_sched.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions

[PATCH 2/3] drm/v3d: Correctly restart the timer when progress is made

2020-09-04 Thread Yukimasa Sugizaki
rearm the timer. Fixes: 135517d3565b ("drm/scheduler: Avoid accessing freed bad job.") Signed-off-by: Yukimasa Sugizaki --- drivers/gpu/drm/v3d/v3d_sched.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/drivers/gpu/drm/v3d/v3d_sched.c b/drivers/g

[PATCH 1/3] drm/v3d: Don't resubmit guilty CSD jobs

2020-09-04 Thread Yukimasa Sugizaki
(-125) , where -125 is -ECANCELED, though users currently have no way other than inspecting the dmesg to check if the timeout has occurred. Signed-off-by: Yukimasa Sugizaki --- drivers/gpu/drm/v3d/v3d_sched.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/v3d

[PATCH 0/3] drm/v3d: CL/CSD job timeout fixes

2020-09-04 Thread Yukimasa Sugizaki
without kernel warnings and errors. Regards, Sugizaki (Re-sending this series because I failed to post the previous one to dri-devel.) [1] https://patchwork.kernel.org/patch/11732895/ [2] https://github.com/Idein/py-videocore6 [3] https://github.com/raspberrypi/linux/tree/rpi-5.8.y Yukimasa Sugizaki

[PATCH 3/3] drm/v3d: Add job timeout module param

2020-09-04 Thread Yukimasa Sugizaki
From: Yukimasa Sugizaki The default timeout is 500 ms which is too short for some workloads including Piglit. Adding this parameter will help users to run heavier tasks. Signed-off-by: Yukimasa Sugizaki --- drivers/gpu/drm/v3d/v3d_sched.c | 24 +--- 1 file changed, 13

[PATCH 0/3] drm/v3d: CL/CSD job timeout fixes

2020-09-04 Thread Yukimasa Sugizaki
From: Yukimasa Sugizaki Hi, The current V3D scheduler has two issues where CSD jobs are resubmitted regardless of the previous timed-out flag, and where the timer is not restarted for timed-out CL/CSD jobs (which we wish to continue running). The second one is due to the DRM scheduler API

[PATCH 2/3] drm/v3d: Correctly restart the timer when progress is made

2020-09-04 Thread Yukimasa Sugizaki
From: Yukimasa Sugizaki The V3D scheduler wants a timed-out job to continue running if it made progress. However, the current DRM scheduler removes the timed-out job from ring_mirror_list and thus the timer is not restarted automatically, resulting in an infinite timeout. We need stop and

[PATCH 1/3] drm/v3d: Don't resubmit guilty CSD jobs

2020-09-04 Thread Yukimasa Sugizaki
From: Yukimasa Sugizaki The previous code misses a check for the timeout error set by drm_sched_resubmit_jobs(), which results in an infinite GPU reset loop if once a timeout occurs: [ 178.799106] v3d fec0.v3d: [drm:v3d_reset [v3d]] *ERROR* Resetting GPU for hang. [ 178.807836] v3d