Re: BUG: drm_crtc_helper_set_config does not work

2012-03-10 Thread Yufeng Shen
On Fri, Mar 9, 2012 at 3:15 AM, Maarten Maathuis wrote: > On Fri, Mar 9, 2012 at 2:50 AM, Yufeng Shen wrote: >> So a simple case of  disabling a CRTC and then re-enabling it. >> >> Disabling: >> >> CRTC X is originally connected to output Y >> >>

BUG: drm_crtc_helper_set_config does not work

2012-03-09 Thread Yufeng Shen
On Fri, Mar 9, 2012 at 3:15 AM, Maarten Maathuis wrote: > On Fri, Mar 9, 2012 at 2:50 AM, Yufeng Shen wrote: >> So a simple case of ?disabling a CRTC and then re-enabling it. >> >> Disabling: >> >> CRTC X is originally connected to output Y >> >>

BUG: drm_crtc_helper_set_config does not work

2012-03-08 Thread Yufeng Shen
So a simple case of disabling a CRTC and then re-enabling it. Disabling: CRTC X is originally connected to output Y 1. XRRSetCrtcConfig()is called to disable CRTC X 2. drm_helper_connector_dpms() then gets called on the connector connected to CRTC X, in the function, the connec

BUG: drm_crtc_helper_set_config does not work

2012-03-08 Thread Yufeng Shen
So a simple case of disabling a CRTC and then re-enabling it. Disabling: CRTC X is originally connected to output Y 1. XRRSetCrtcConfig()is called to disable CRTC X 2. drm_helper_connector_dpms() then gets called on the connector connected to CRTC X, in the function, the connec

[PATCH] drm/i915: Fix race condition in accessing GMBUS

2012-02-13 Thread Yufeng Shen
there is a race condition in using the underlying GMBUS controller. Fixing this by adding a mutex lock when calling gmbus_xfer(). Signed-off-by: Yufeng Shen --- drivers/gpu/drm/i915/i915_drv.h |8 drivers/gpu/drm/i915/intel_i2c.c | 24 +--- 2 files change

[PATCH] [PATCH] drm/i915: Fix race condition in accessing GMBUS

2012-02-13 Thread Yufeng Shen
that the LVDS port , or the DDC port. But when there are I2C transactions on both LVDS and DDC ports, since they share the same GMBUS registers, there will be race condition. Does this make sense to you ? --- Yufeng Shen On Mon, Feb 13, 2012 at 4:04 AM, Ben Widawsky wrote: > On Fri, Feb 10, 2

[PATCH] drm/i915: Fix race condition in accessing GMBUS

2012-02-13 Thread Yufeng Shen
there is a race condition in using the underlying GMBUS controller. Fixing this by adding a mutex lock when calling gmbus_xfer(). Signed-off-by: Yufeng Shen --- drivers/gpu/drm/i915/i915_drv.h |8 drivers/gpu/drm/i915/intel_i2c.c | 24 +--- 2 files change

Re: [PATCH] [PATCH] drm/i915: Fix race condition in accessing GMBUS

2012-02-13 Thread Yufeng Shen
that the LVDS port , or the DDC port. But when there are I2C transactions on both LVDS and DDC ports, since they share the same GMBUS registers, there will be race condition. Does this make sense to you ? --- Yufeng Shen On Mon, Feb 13, 2012 at 4:04 AM, Ben Widawsky wrote: > On Fri, Feb 10, 2

[PATCH] [PATCH] drm/i915: Fix race condition in accessing GMBUS

2012-02-11 Thread Yufeng Shen
GMBUS has several ports and each has it's own corresponding I2C adpater. When multiple I2C adapters call gmbus_xfer() at the same time there is a race condition in using the underlying GMBUS controller. Fixing this by adding a mutex lock when calling gmbus_xfer(). Signed-off-by: Yufeng

[PATCH] [PATCH] drm/i915: Fix race condition in accessing GMBUS

2012-02-10 Thread Yufeng Shen
GMBUS has several ports and each has it's own corresponding I2C adpater. When multiple I2C adapters call gmbus_xfer() at the same time there is a race condition in using the underlying GMBUS controller. Fixing this by adding a mutex lock when calling gmbus_xfer(). Signed-off-by: Yufeng

[PATCH] drm/i915: Fix race condition in accessing GMBUS

2012-02-09 Thread Yufeng Shen
GMBUS has several ports and each has it's own corresponding I2C adpater. When multiple I2C adapters call gmbus_xfer() at the same time there is a race condition in using the underlying GMBUS controller. Fixing this by adding a mutex lock when calling gmbus_xfer(). Signed-off-by: Yufeng

[PATCH] drm/i915: Fix race condition in accessing GMBUS

2012-02-09 Thread Yufeng Shen
GMBUS has several ports and each has it's own corresponding I2C adpater. When multiple I2C adapters call gmbus_xfer() at the same time there is a race condition in using the underlying GMBUS controller. Fixing this by adding a mutex lock when calling gmbus_xfer(). Signed-off-by: Yufeng