[PATCH] drm/amdkfd: Fix wrong usage of INIT_WORK()

2024-11-05 Thread Yuan Can
In kfd_procfs_show(), the sdma_activity_work_handler is a local variable and the sdma_activity_work_handler.sdma_activity_work should initialize with INIT_WORK_ONSTACK() instead of INIT_WORK(). Fixes: 32cb59f31362 ("drm/amdkfd: Track SDMA utilization per process") Signed-off-by

[PATCH] drm/mediatek: Add checks for devm_kcalloc

2022-11-24 Thread Yuan Can
As the devm_kcalloc may return NULL, the return value needs to be checked to avoid NULL poineter dereference. Fixes: 66b2cf9623fa ("drm/mediatek: use layer_nr function to get layer number to init plane") Signed-off-by: Yuan Can --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 2 ++ 1 fi

Re: [PATCH] drm/panel/raspberrypi-touchscreen: Fix error handling in rpi_touchscreen_init()

2022-11-14 Thread Yuan Can
在 2022/11/14 19:55, Dave Stevenson 写道: Hi Yuan On Mon, 14 Nov 2022 at 08:21, Yuan Can wrote: A problem about modprobe panel-raspberrypi-touchscreen is triggered with the following log given: [ 542.980748] Error: Driver 'rpi-ts-dsi' is already registered, aborting... And wit

[PATCH] drm/panel/raspberrypi-touchscreen: Fix error handling in rpi_touchscreen_init()

2022-11-14 Thread Yuan Can
rror message printed, register failed! i2c_add_driver() # succeed and return Fix by checking the return value of both functions and unregister rpi_touchscreen_dsi_driver if i2c_add_driver() failed. Fixes: 2f733d6194bd ("drm/panel: Add support for the Raspberry Pi 7" Touchscreen.") Si

[PATCH v2] drm/bridge: megachips: Fix error handling in i2c_register_driver()

2022-11-08 Thread Yuan Can
# return without delete stdp4028_ge_b850v3_fw_driver Fix by calling i2c_del_driver() on stdp4028_ge_b850v3_fw_driver when i2c_add_driver() returns error. Fixes: fcfa0ddc18ed ("drm/bridge: Drivers for megachips-stdp-ge-b850v3-fw (LVDS-DP++)") Signed-off-by: Yuan Can Reviewed-by: A

Re: [PATCH] drm/bridge: megachips: Fix error handling in i2c_register_driver()

2022-11-08 Thread Yuan Can
在 2022/11/8 16:50, Andrzej Hajda 写道: On 08.11.2022 09:29, Yuan Can wrote: A problem about insmod megachips-stdp-ge-b850v3-fw.ko failed is triggered with the following log given: [ 4497.981497] Error: Driver 'stdp4028-ge-b850v3-fw' is already registered, aborting... ins

[PATCH] drm/bridge: megachips: Fix error handling in i2c_register_driver()

2022-11-08 Thread Yuan Can
# return without delete stdp4028_ge_b850v3_fw_driver Fix by calling i2c_del_driver() on stdp4028_ge_b850v3_fw_driver when i2c_add_driver() returns error. Fixes: fcfa0ddc18ed ("drm/bridge: Drivers for megachips-stdp-ge-b850v3-fw (LVDS-DP++)") Signed-off-by: Yuan Can --- driv

[PATCH v2] drm/ingenic: Fix missing platform_driver_unregister() call in ingenic_drm_init()

2022-11-03 Thread Yuan Can
river_register() and do platform_unregister_drivers() if error happened. Fixes: fc1acf317b01 ("drm/ingenic: Add support for the IPU") Signed-off-by: Yuan Can Cc: sta...@vger.kernel.org --- Changes in v2: - Add missing Cc: sta...@vger.kernel.org drivers/gpu/drm/ingenic/ingenic-drm-drv.c

Re: [PATCH] drm/ingenic: Fix missing platform_driver_unregister() call in ingenic_drm_init()

2022-11-03 Thread Yuan Can
在 2022/11/3 22:52, Paul Cercueil 写道: Hi Yuan, Le jeu. 3 nov. 2022 à 14:01:48 +, Yuan Can a écrit : A problem about modprobe ingenic-drm failed is triggered with the following log given:  [  303.561088] Error: Driver 'ingenic-ipu' is already registered, aborting...  modpr

[PATCH] drm/ingenic: Fix missing platform_driver_unregister() call in ingenic_drm_init()

2022-11-03 Thread Yuan Can
river_register() and do platform_unregister_drivers() if error happened. Fixes: fc1acf317b01 ("drm/ingenic: Add support for the IPU") Signed-off-by: Yuan Can --- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drive

[PATCH] drm/vc4: Fix missing platform_unregister_drivers() call in vc4_drm_register()

2022-11-02 Thread Yuan Can
the return value of platform_driver_register() and do platform_unregister_drivers() if error happened. Fixes: c8b75bca92cb ("drm/vc4: Add KMS support for Raspberry Pi.") Signed-off-by: Yuan Can --- drivers/gpu/drm/vc4/vc4_drv.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) di

[PATCH] drm/mcde: Fix missing platform_unregister_drivers() call in mcde_drm_register()

2022-11-02 Thread Yuan Can
xing this problem by checking the return value of platform_driver_register() and do platform_unregister_drivers() if error happened. Fixes: 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE") Signed-off-by: Yuan Can --- drivers/gpu/drm/mcde/mcde_drv.c | 7 ++- 1 file change

[PATCH 1/2] drm/vkms: Fix memory leak in vkms_init()

2022-10-31 Thread Yuan Can
es: 2df7af93fdad ("drm/vkms: Add vkms_config type") Signed-off-by: Yuan Can --- drivers/gpu/drm/vkms/vkms_drv.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c index 0ffe5f0e33f7..dfe983eaa07f 100

[PATCH 0/2] drm/vkms: Fix some memory related bug

2022-10-31 Thread Yuan Can
This series contains two memory related bugfixes about vkms driver. Yuan Can (2): drm/vkms: Fix memory leak in vkms_init() drm/vkms: Fix null-ptr-deref in vkms_release() drivers/gpu/drm/vkms/vkms_drv.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) -- 2.17.1

[PATCH 2/2] drm/vkms: Fix null-ptr-deref in vkms_release()

2022-10-31 Thread Yuan Can
ase(). Fixes: 6c234fe37c57 ("drm/vkms: Implement CRC debugfs API") Signed-off-by: Yuan Can --- drivers/gpu/drm/vkms/vkms_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c index dfe983eaa07f.

[PATCH v2] drm/omapdrm: Remove unused struct csc_coef_rgb2yuv

2022-10-13 Thread Yuan Can
After commit 64ff18911878, struct csc_coef_rgb2yuv is not used any more and can be removed as well. Fixes: 64ff18911878 ("drm/omap: Enable COLOR_ENCODING and COLOR_RANGE properties for planes") Signed-off-by: Yuan Can --- changes in v2: - adjust commit msg --- drivers/gpu/drm/o

Re: [PATCH] drm/omapdrm: Remove unused struct csc_coef_rgb2yuv

2022-10-13 Thread Yuan Can
在 2022/10/13 14:39, Cai Huoqing 写道: On 27 9月 22 13:38:47, Yuan Can wrote: After commit 64ff18911878("drm/omap: Enable COLOR_ENCODING and COLOR_RANGE Hi yuan, This is not a valid Fixes: tag. Add to your ~/.gitconfig and add: [pretty] fixes = Fixes: %h (\"%s\") You c

Re: [PATCH v2 2/2] drm/panel: simple: Use dev_err_probe() to simplify code

2022-09-29 Thread Yuan Can
在 2022/9/30 5:08, Doug Anderson 写道: Hi, On Wed, Sep 28, 2022 at 6:57 PM Yuan Can wrote: In the probe path, dev_err() can be replaced with dev_err_probe() which will check if error code is -EPROBE_DEFER and prints the error name. It also sets the defer probe reason which can be checked later

[PATCH v2 2/2] drm/panel: simple: Use dev_err_probe() to simplify code

2022-09-28 Thread Yuan Can
In the probe path, dev_err() can be replaced with dev_err_probe() which will check if error code is -EPROBE_DEFER and prints the error name. It also sets the defer probe reason which can be checked later through debugfs. Signed-off-by: Yuan Can Reviewed-by: Douglas Anderson --- drivers/gpu/drm

[PATCH v2 1/2] drm/panel: panel-edp: Use dev_err_probe() to simplify code

2022-09-28 Thread Yuan Can
In the probe path, dev_err() can be replaced with dev_err_probe() which will check if error code is -EPROBE_DEFER and prints the error name. It also sets the defer probe reason which can be checked later through debugfs. Signed-off-by: Yuan Can Reviewed-by: Douglas Anderson --- drivers/gpu/drm

[PATCH v2 0/2] drm/panel: Use dev_err_probe() to simplify code

2022-09-28 Thread Yuan Can
This series contains two patchs simplify the error handling in probe function by switching from dev_err() to dev_err_probe(). --- changes in v2: - simplify the same case in panel_edp_probe - add Reviewed-by from Douglas Anderson Yuan Can (2): drm/panel: panel-edp: Use dev_err_probe() to

Re: [PATCH 10/10] drm/panel: simple: Use dev_err_probe() to simplify code

2022-09-28 Thread Yuan Can
在 2022/9/29 7:03, Doug Anderson 写道: Hi, On Fri, Sep 23, 2022 at 6:59 PM Yuan Can wrote: In the probe path, dev_err() can be replaced with dev_err_probe() which will check if error code is -EPROBE_DEFER and prints the error name. It also sets the defer probe reason which can be checked later

[PATCH] drm/amd/display: Remove unused struct i2c_id_config_access

2022-09-27 Thread Yuan Can
After commit 5a8132b9f606("drm/amd/display: remove dead dc vbios code"), no one use struct i2c_id_config_access, so remove it. Signed-off-by: Yuan Can --- drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/amd/

[PATCH] drm/omapdrm: Remove unused struct csc_coef_rgb2yuv

2022-09-27 Thread Yuan Can
After commit 64ff18911878("drm/omap: Enable COLOR_ENCODING and COLOR_RANGE properties for planes"), no one use struct csc_coef_rgb2yuv, so remove it. Signed-off-by: Yuan Can --- drivers/gpu/drm/omapdrm/dss/dispc.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/d

[PATCH 02/10] drm/panel: panel-edp: Use dev_err_probe() to simplify code

2022-09-23 Thread Yuan Can
In the probe path, dev_err() can be replaced with dev_err_probe() which will check if error code is -EPROBE_DEFER and prints the error name. It also sets the defer probe reason which can be checked later through debugfs. Signed-off-by: Yuan Can --- drivers/gpu/drm/panel/panel-edp.c | 13

[PATCH 10/10] drm/panel: simple: Use dev_err_probe() to simplify code

2022-09-23 Thread Yuan Can
In the probe path, dev_err() can be replaced with dev_err_probe() which will check if error code is -EPROBE_DEFER and prints the error name. It also sets the defer probe reason which can be checked later through debugfs. Signed-off-by: Yuan Can --- drivers/gpu/drm/panel/panel-simple.c | 9

[PATCH 03/10] drm/panel: elida-kd35t133: Use dev_err_probe() to simplify code

2022-09-23 Thread Yuan Can
In the probe path, dev_err() can be replaced with dev_err_probe() which will check if error code is -EPROBE_DEFER and prints the error name. It also sets the defer probe reason which can be checked later through debugfs. Signed-off-by: Yuan Can --- drivers/gpu/drm/panel/panel-elida-kd35t133.c

[PATCH 06/10] drm/panel: lvds: Use dev_err_probe() to simplify code

2022-09-23 Thread Yuan Can
In the probe path, dev_err() can be replaced with dev_err_probe() which will check if error code is -EPROBE_DEFER and prints the error name. It also sets the defer probe reason which can be checked later through debugfs. Signed-off-by: Yuan Can --- drivers/gpu/drm/panel/panel-lvds.c | 9

[PATCH 05/10] drm/panel: leadtek-ltk500hd1829: Use dev_err_probe() to simplify code

2022-09-23 Thread Yuan Can
In the probe path, dev_err() can be replaced with dev_err_probe() which will check if error code is -EPROBE_DEFER and prints the error name. It also sets the defer probe reason which can be checked later through debugfs. Signed-off-by: Yuan Can --- .../gpu/drm/panel/panel-leadtek-ltk500hd1829.c

[PATCH 07/10] drm/panel: otm8009a: Use dev_err_probe() to simplify code

2022-09-23 Thread Yuan Can
In the probe path, dev_err() can be replaced with dev_err_probe() which will check if error code is -EPROBE_DEFER and prints the error name. It also sets the defer probe reason which can be checked later through debugfs. Signed-off-by: Yuan Can --- drivers/gpu/drm/panel/panel-orisetech

[PATCH 09/10] drm/panel: s6d16d0: Use dev_err_probe() to simplify code

2022-09-23 Thread Yuan Can
In the probe path, dev_err() can be replaced with dev_err_probe() which will check if error code is -EPROBE_DEFER and prints the error name. It also sets the defer probe reason which can be checked later through debugfs. Signed-off-by: Yuan Can --- drivers/gpu/drm/panel/panel-samsung-s6d16d0.c

[PATCH 04/10] drm/panel: leadtek-ltk050h3146w: Use dev_err_probe() to simplify code

2022-09-23 Thread Yuan Can
In the probe path, dev_err() can be replaced with dev_err_probe() which will check if error code is -EPROBE_DEFER and prints the error name. It also sets the defer probe reason which can be checked later through debugfs. Signed-off-by: Yuan Can --- .../gpu/drm/panel/panel-leadtek-ltk050h3146w.c

[PATCH 08/10] drm/panel: rm68200: Use dev_err_probe() to simplify code

2022-09-23 Thread Yuan Can
In the probe path, dev_err() can be replaced with dev_err_probe() which will check if error code is -EPROBE_DEFER and prints the error name. It also sets the defer probe reason which can be checked later through debugfs. Signed-off-by: Yuan Can --- drivers/gpu/drm/panel/panel-raydium-rm68200.c

[PATCH 01/10] drm/panel: himax8279d: Use dev_err_probe() to simplify code

2022-09-23 Thread Yuan Can
In the probe path, dev_err() can be replaced with dev_err_probe() which will check if error code is -EPROBE_DEFER and prints the error name. It also sets the defer probe reason which can be checked later through debugfs. Signed-off-by: Yuan Can --- drivers/gpu/drm/panel/panel-boe-himax8279d.c

[PATCH 00/10] drm/panel: Use dev_err_probe() to simplify code

2022-09-23 Thread Yuan Can
This series simplify the error handling in probe function by switching from dev_err() to dev_err_probe(). Yuan Can (10): drm/panel: himax8279d: Use dev_err_probe() to simplify code drm/panel: panel-edp: Use dev_err_probe() to simplify code drm/panel: elida-kd35t133: Use dev_err_probe() to