Hi,
在 2024/11/13 23:17, Chuck Lever 写道:
On Mon, Nov 11, 2024 at 11:20:17PM +0800, yangerkun wrote:
在 2024/11/11 22:39, Chuck Lever III 写道:
On Nov 10, 2024, at 9:36 PM, Yu Kuai wrote:
I'm in the cc list ,so I assume you saw my set, then I don't know why
you're ignoring
Hi,
在 2024/11/11 8:52, c...@kernel.org 写道:
From: yangerkun
[ Upstream commit 64a7ce76fb901bf9f9c36cf5d681328fc0fd4b5a ]
After we switch tmpfs dir operations from simple_dir_operations to
simple_offset_dir_operations, every rename happened will fill new dentry
to dest dir's maple tree(&SHMEM_I
Hi,
在 2024/11/10 0:58, Chuck Lever III 写道:
On Nov 8, 2024, at 8:30 PM, Yu Kuai wrote:
Hi,
在 2024/11/08 21:23, Chuck Lever III 写道:
On Nov 7, 2024, at 8:19 PM, Yu Kuai wrote:
Hi,
在 2024/11/07 22:41, Chuck Lever 写道:
On Thu, Nov 07, 2024 at 08:57:23AM +0800, Yu Kuai wrote:
Hi,
在 2024
Hi,
在 2024/11/09 1:03, Liam R. Howlett 写道:
* Chuck Lever III [241108 08:23]:
On Nov 7, 2024, at 8:19 PM, Yu Kuai wrote:
Hi,
在 2024/11/07 22:41, Chuck Lever 写道:
On Thu, Nov 07, 2024 at 08:57:23AM +0800, Yu Kuai wrote:
Hi,
在 2024/11/06 23:19, Chuck Lever III 写道:
On Nov 6, 2024, at
Hi,
在 2024/11/08 21:23, Chuck Lever III 写道:
On Nov 7, 2024, at 8:19 PM, Yu Kuai wrote:
Hi,
在 2024/11/07 22:41, Chuck Lever 写道:
On Thu, Nov 07, 2024 at 08:57:23AM +0800, Yu Kuai wrote:
Hi,
在 2024/11/06 23:19, Chuck Lever III 写道:
On Nov 6, 2024, at 1:16 AM, Greg KH wrote:
On Thu
Hi,
在 2024/11/07 22:41, Chuck Lever 写道:
On Thu, Nov 07, 2024 at 08:57:23AM +0800, Yu Kuai wrote:
Hi,
在 2024/11/06 23:19, Chuck Lever III 写道:
On Nov 6, 2024, at 1:16 AM, Greg KH wrote:
On Thu, Oct 24, 2024 at 09:19:41PM +0800, Yu Kuai wrote:
From: Yu Kuai
Fix patch is patch 27, relied
to go research this for you, especially one you've 'addressed' in this
totally bizarre fashion.
On Thu, Oct 24, 2024 at 09:19:41PM +0800, Yu Kuai wrote:
From: Yu Kuai
Fix patch is patch 27, relied patches are from:
- patches from set [1] to add helpers to maple_tree, the last p
Hi,
在 2024/11/06 23:02, Lorenzo Stoakes 写道:
On Thu, Oct 24, 2024 at 09:22:25PM +0800, Yu Kuai wrote:
diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index 5328e08723d7..c57b6fc4db2e 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -2239,6 +2239,8 @@ static inline void mas_node_or_none
Hi,
在 2024/11/06 23:19, Chuck Lever III 写道:
On Nov 6, 2024, at 1:16 AM, Greg KH wrote:
On Thu, Oct 24, 2024 at 09:19:41PM +0800, Yu Kuai wrote:
From: Yu Kuai
Fix patch is patch 27, relied patches are from:
I assume patch 27 is:
libfs: fix infinite directory reads for offset dir
in user mode almost always results in a
near 100% hit rate for this optimization.
Link:
https://lkml.kernel.org/r/20231215074632.82045-1-zhangpeng...@bytedance.com
Signed-off-by: Peng Zhang
Reviewed-by: Liam R. Howlett
Signed-off-by: Andrew Morton
Signed-off-by: Yu Kuai
---
lib/maple_tree.c
5c5f ("shmem: stable directory offsets")
Signed-off-by: yangerkun
Link: https://lore.kernel.org/r/20240731043835.1828697-1-yanger...@huawei.com
Reviewed-by: Chuck Lever
[brauner: only update last_index after seek when offset is zero like Jan
suggested]
Signed-off-by:
-off-by: Andrew Morton
Signed-off-by: Yu Kuai
---
lib/maple_tree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index 6f1addbbc820..97a610307d38 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -6774,7 +6774,7 @@ void __mt_destroy
a
Cc: Suren Baghdasaryan
Signed-off-by: Andrew Morton
Signed-off-by: Yu Kuai
---
include/linux/maple_tree.h | 3 +
lib/maple_tree.c | 274 +
2 files changed, 277 insertions(+)
diff --git a/include/linux/maple_tree.h b/include/linux/maple_tree.h
-off-by: Liam R. Howlett
Cc: Peng Zhang
Signed-off-by: Andrew Morton
Signed-off-by: Yu Kuai
---
lib/maple_tree.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index d19fb14a9635..e0dcc8412da0 100644
--- a/lib/maple_t
3612299-10-liam.howl...@oracle.com
Signed-off-by: Liam R. Howlett
Cc: Peng Zhang
Signed-off-by: Andrew Morton
Signed-off-by: Yu Kuai
---
lib/maple_tree.c | 66
tools/testing/radix-tree/maple.c | 4 +-
2 files changed, 19 insertions(+), 51 deletion
: Matthew Wilcox
Cc: Michael S. Tsirkin
Cc: Mike Christie
Cc: Nicholas Piggin
Cc: Peter Zijlstra
Cc: Suren Baghdasaryan
Signed-off-by: Andrew Morton
Signed-off-by: Yu Kuai
---
include/linux/maple_tree.h | 4
tools/include/linux/spinlock.h | 1 +
2 files changed, 5 insertions(+)
diff
.host.secureserver.net
Signed-off-by: Christian Brauner
Signed-off-by: Yu Kuai
---
fs/libfs.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/fs/libfs.c b/fs/libfs.c
index 430f7c95336c..c3dc58e776f9 100644
--- a/fs/libfs.c
+++ b/fs/libfs.c
@@ -239,6 +239,11 @@ const
cases.
Link: https://lkml.kernel.org/r/20231101171629.3612299-2-liam.howl...@oracle.com
Signed-off-by: Liam R. Howlett
Suggested-by: Andrew Morton
Signed-off-by: Andrew Morton
Signed-off-by: Yu Kuai
---
lib/maple_tree.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/lib/maple_tree
Cc: Peng Zhang
Signed-off-by: Andrew Morton
Signed-off-by: Yu Kuai
---
lib/maple_tree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index e0dcc8412da0..3df7e3456205 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -5587,7 +5587
Care
must be taken to update & invalidate as necessary.
Link: https://lkml.kernel.org/r/20231101171629.3612299-5-liam.howl...@oracle.com
Signed-off-by: Liam R. Howlett
Cc: Peng Zhang
Signed-off-by: Andrew Morton
Signed-off-by: Yu Kuai
---
include/linux/maple_tree.h | 1 +
li
hael S. Tsirkin
Cc: Mike Christie
Cc: Nicholas Piggin
Cc: Peter Zijlstra
Cc: Suren Baghdasaryan
Signed-off-by: Andrew Morton
Signed-off-by: Yu Kuai
---
lib/maple_tree.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index 4
170820145616.6328.12620992971699079156.st...@91.116.238.104.host.secureserver.net
Reviewed-by: Jan Kara
Signed-off-by: Christian Brauner
Signed-off-by: Yu Kuai
---
fs/libfs.c | 47 +++---
include/linux/fs.h | 5 +++--
2 files changed, 26 insertions(+),
head of
0de56e38b307, for 6.7-rc.
This fixlet undoes the damage.
Fixes: 0de56e38b307 ("maple_tree: use maple state end for write operations")
Cc: Liam R. Howlett
Cc: Sidhartha Kumar
Signed-off-by: Andrew Morton
Signed-off-by: Yu Kuai
---
lib/maple_tree.c | 2 +-
1 file chang
...@91.116.238.104.host.secureserver.net
Signed-off-by: Christian Brauner
Signed-off-by: Yu Kuai
---
fs/libfs.c | 32
include/linux/fs.h | 1 +
mm/shmem.c | 4 ++--
3 files changed, 35 insertions(+), 2 deletions(-)
diff --git a/fs/libfs.c b/fs/libfs.c
index
-liam.howl...@oracle.com
Signed-off-by: Liam R. Howlett
Cc: Peng Zhang
Signed-off-by: Andrew Morton
Signed-off-by: Yu Kuai
---
lib/maple_tree.c | 27 ---
1 file changed, 12 insertions(+), 15 deletions(-)
diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index ad8bf3413889..d9
viewed-by: Jan Kara
Signed-off-by: Christian Brauner
Signed-off-by: Yu Kuai
---
fs/libfs.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/fs/libfs.c b/fs/libfs.c
index dc0f7519045f..430f7c95336c 100644
--- a/fs/libfs.c
+++ b/fs/libfs.c
@@ -401,12 +401,
ch gcc was not inlining, so make this more strict and use
__always_line for these functions.
Link: https://lkml.kernel.org/r/20231101171629.3612299-8-liam.howl...@oracle.com
Signed-off-by: Liam R. Howlett
Cc: Peng Zhang
Signed-off-by: Andrew Morton
Signed-off-by: Yu Kuai
---
lib/maple_t
. Howlett
Cc: Christian Brauner
Cc: Jonathan Corbet
Cc: Mateusz Guzik
Cc: Mathieu Desnoyers
Cc: Matthew Wilcox
Cc: Michael S. Tsirkin
Cc: Mike Christie
Cc: Nicholas Piggin
Cc: Peter Zijlstra
Cc: Suren Baghdasaryan
Signed-off-by: Andrew Morton
Signed-off-by: Yu Kuai
---
lib
.@web.de/
Tested-by: Bert Karwatzki
Reported-by: Mikhail Gavrilov
Closes:
https://lore.kernel.org/all/cabxgcsopwuonoqsmmavwo2fz4tempnjfj-b7if+xfru1h7-...@mail.gmail.com/
Acked-by: Vlastimil Babka
Reviewed-by: Liam R. Howlett
Tested-by: Mikhail Gavrilov
Reviewed-by: Wei Yang
Cc: Matthew Wilc
Zijlstra
Cc: Suren Baghdasaryan
Signed-off-by: Andrew Morton
Signed-off-by: Yu Kuai
---
tools/testing/radix-tree/maple.c | 361 +++
1 file changed, 361 insertions(+)
diff --git a/tools/testing/radix-tree/maple.c b/tools/testing/radix-tree/maple.c
index 27a3a31ba662
rnel.org/r/20231101171629.3612299-12-liam.howl...@oracle.com
Signed-off-by: Liam R. Howlett
Cc: Peng Zhang
Signed-off-by: Andrew Morton
Signed-off-by: Yu Kuai
---
lib/maple_tree.c | 12 +++-
lib/test_maple_tree.c | 21 +
2 files changed, 24 insertions(+), 9 deletions(-)
.3612299-3-liam.howl...@oracle.com
Signed-off-by: Liam R. Howlett
Cc: Peng Zhang
Signed-off-by: Andrew Morton
Signed-off-by: Yu Kuai
---
lib/maple_tree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index 9de2e3dfdfcc..e4d0df3980e0 100644
.host.secureserver.net
Signed-off-by: Christian Brauner
Signed-off-by: Yu Kuai
---
include/linux/maple_tree.h | 7 +++
lib/maple_tree.c | 93 ++
2 files changed, 100 insertions(+)
diff --git a/include/linux/maple_tree.h b/include/linux/maple_tree.h
index b3d63123b945
inclusion of the header to after the atomic
define. None of those changes have functional changes.
Link: https://lkml.kernel.org/r/20231101171629.3612299-4-liam.howl...@oracle.com
Signed-off-by: Liam R. Howlett
Cc: Peng Zhang
Signed-off-by: Andrew Morton
Signed-off-by: Yu Kuai
---
inc
the end of the
node and uses the maple state end instead.
Link:
https://lkml.kernel.org/r/20231101171629.3612299-11-liam.howl...@oracle.com
Signed-off-by: Liam R. Howlett
Cc: Peng Zhang
Signed-off-by: Andrew Morton
Signed-off-by: Yu Kuai
---
include/linux/maple_tree.h | 1 -
lib/ma
e.com: fix mas_prev() state separation code]
Link:
https://lkml.kernel.org/r/20231207193319.4025462-1-liam.howl...@oracle.com
Link: https://lkml.kernel.org/r/20231101171629.3612299-9-liam.howl...@oracle.com
Signed-off-by: Liam R. Howlett
Cc: Peng Zhang
Signed-off-by: Andrew Morton
Signed-off-b
From: Yu Kuai
Fix patch is patch 27, relied patches are from:
- patches from set [1] to add helpers to maple_tree, the last patch to
improve fork() performance is not backported;
- patches from set [2] to change maple_tree, and follow up fixes;
- patches from set [3] to convert offset_ctx
From: Yu Kuai
This reverts commit 677f1df179cb68c12ddf7707ec325eb50e99c7d9.
Above commit contain manual changes and will cause conflicts for
following patches. The commit be backported from mainline later, without
conflicts.
Signed-off-by: Yu Kuai
---
lib/maple_tree.c | 12 ++--
1
arning: Function parameter or member '__i' not
described in 'for_each_new_plane_in_state_reverse'
Fixes: a6c3c37b661d ("drm/amd/display: fix gcc set but not used warning of
variable 'old_plane_state'")
Signed-off-by: Yu Kuai
---
include/drm/drm_atomic.h | 4 +++
pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.
Reported-by: Hulk Robot
Signed-off-by: Yu Kuai
---
changes in V2
t not used [-Wunused-but-set-variable]
Signed-off-by: Yu Kuai
---
changes in V2:
- fix that forgetting to change position of '#endif'
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdg
pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.
Reported-by: Hulk Robot
Signed-off-by: Yu Kuai
---
changes in V2
t not used [-Wunused-but-set-variable]
Signed-off-by: Yu Kuai
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index f0
state’ set but not used [-Wunused-but-set-variable]
Signed-off-by: Yu Kuai
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++--
include/drm/drm_atomic.h | 12
2 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/a
Yu Kuai (2):
drm/v3d: Fix PM reference leak in v3d_get_param_ioctl()
drm/v3d: Fix PM reference leak in v3d_v3d_debugfs_ident()
drivers/gpu/drm/v3d/v3d_debugfs.c | 4 ++--
drivers/gpu/drm/v3d/v3d_drv.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
--
2.25.4
pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.
Reported-by: Hulk Robot
Signed-off-by: Yu Kuai
---
drivers/gpu/drm/v3d
pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.
Reported-by: Hulk Robot
Signed-off-by: Yu Kuai
---
drivers/gpu/drm
pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.
Reported-by: Hulk Robot
Signed-off-by: Yu Kuai
---
drivers/gpu/drm/v3d
pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.
Reported-by: Hulk Robot
Signed-off-by: Yu Kuai
---
drivers/gpu/drm/amd
if of_find_device_by_node() succeed, mtk_drm_kms_init() doesn't have
a corresponding put_device(). Thus add jump target to fix the exception
handling for this function implementation.
Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.")
Signed-
if of_find_device_by_node() succeed, mtk_drm_kms_init() doesn't have
a corresponding put_device(). Thus add jump target to fix the exception
handling for this function implementation.
Fixes: 8f83f26891e1 ("drm/mediatek: Add HDMI support")
Signed-off-by: Yu Kuai
---
drivers/g
if of_find_device_by_node() succeed, rcar_du_vsp_init() doesn't have
a corresponding put_device(). Thus add a jump target to fix the exception
handling for this function implementation.
Fixes: 6d62ef3ac30b ("drm: rcar-du: Expose the VSP1 compositor through KMS
planes")
Signed-
Signed-off-by: Yu Kuai
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index 040a8f393fe2..75a6cf231fd7 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_d
if of_find_device_by_node() succeed, mtk_ddp_comp_init() doesn't have
a corresponding put_device(). Thus add put_device() to fix the exception
handling for this function implementation.
Fixes: d0afe37f5209 ("drm/mediatek: support CMDQ interface in ddp component")
Signed-
If sun8i_r40_tcon_tv_set_mux() succeed, at_dma_xlate() doesn't have a
corresponding put_device(). Thus add put_device() to fix the exception
handling for this function implementation.
Fixes: 0305189afb32 ("drm/sun4i: tcon: Add support for R40 TCON")
Signed-off-by: Yu Kuai
---
If sun8i_r40_tcon_tv_set_mux() succeed, sun8i_r40_tcon_tv_set_mux()
doesn't have a corresponding put_device(). Thus add put_device()
to fix the exception handling for this function implementation.
Fixes: 0305189afb32 ("drm/sun4i: tcon: Add support for R40 TCON")
Signed-
).
The latter one should fail since there is a conflict, however, it got
merged somehow.
Fix it by removing the function call which is introduced later.
Fixes: 29cd13cfd762 ("drm/v3d: Fix memory leak in v3d_submit_cl_ioctl")
Signed-off-by: yu kuai
---
drivers/gpu/drm/v3d/v3d_gem.c | 1 -
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/video/fbdev/aty/radeon_base.c: In function
‘radeonfb_set_par’:
drivers/video/fbdev/aty/radeon_base.c:1660:32: warning:
variable ‘bytpp’ set but not used [-Wunused-but-set-variable]
It is never used, and so can be removed.
Signed-
yu kuai (4):
video: fbdev: remove set but not used variable 'hSyncPol'
video: fbdev: remove set but not used variable 'vSyncPol'
video: fbdev: remove set but not used variable 'vSyncPol'
video: fbdev: remove set but not used variable 'bytpp'
dr
ned-off-by: yu kuai
---
drivers/video/fbdev/aty/radeon_base.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/video/fbdev/aty/radeon_base.c
b/drivers/video/fbdev/aty/radeon_base.c
index d2e68ec580c2..0666f848bf70 100644
--- a/drivers/video/fbdev/aty/radeon_base.c
+++
Signed-off-by: yu kuai
---
drivers/video/fbdev/aty/mach64_gx.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/video/fbdev/aty/mach64_gx.c
b/drivers/video/fbdev/aty/mach64_gx.c
index 27cb65fa2ba2..1b71a5aa2baa 100644
--- a/drivers/video/fbdev/aty/mach64_gx.c
+++ b/drivers/video
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/video/fbdev/aty/radeon_base.c: In function
‘radeonfb_set_par’:
drivers/video/fbdev/aty/radeon_base.c:1653:48: warning: variable
‘cSync’ set but not used [-Wunused-but-set-variable]
It is never used, and so can be removed.
Signed-
Signed-off-by: yu kuai
---
changes in V2:
Fix the mistake that definition of 'mach64MinFreq' and 'mach64MaxFreq'
was removed.
drivers/video/fbdev/aty/mach64_gx.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/aty/mach64_gx.c
b/drive
ned-off-by: yu kuai
---
drivers/video/fbdev/aty/radeon_base.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/aty/radeon_base.c
b/drivers/video/fbdev/aty/radeon_base.c
index 3af00e3b965e..d2e68ec580c2 100644
--- a/drivers/video/fbdev/aty/radeon_base.c
+++
so can be removed.
Signed-off-by: yu kuai
---
drivers/video/fbdev/kyro/STG4000OverlayDevice.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/kyro/STG4000OverlayDevice.c
b/drivers/video/fbdev/kyro/STG4000OverlayDevice.c
index 0aeeaa10708b..9fde0e3b6
kfree() was called for the same variable twice within an if branch.
Fix it by deleting a duplicate function call.
Fixes: 29cd13cfd762 ("drm/v3d: Fix memory leak in v3d_submit_cl_ioctl")
Signed-off-by: yu kuai
---
drivers/gpu/drm/v3d/v3d_gem.c | 1 -
1 file changed, 1 deletion(-)
di
rs/gpu/drm/radeon/radeon_atombios.c:651:13: warning: variable
‘grph_obj_id’ set but not used [-Wunused-but-set-variable]
drivers/gpu/drm/radeon/radeon_atombios.c:573:37: warning: variable
‘con_obj_type’ set but not used [-Wunused-but-set-variable]
They are never used, and so can be removed.
Signed-
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/bridge/cdns-dsi.c: In function ‘cdns_dsi_mode2cfg’:
drivers/gpu/drm/bridge/cdns-dsi.c:515:11: warning: variable ‘nlanes’
set but not used [-Wunused-but-set-variable]
It is never used, and so can be removed.
Signed-off-b
v3d_submit_cl_ioctl call kfree() with variable 'bin' twice.
Fix it by removing the latter one.
Signed-off-by: yu kuai
---
drivers/gpu/drm/v3d/v3d_gem.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/v3d/v3d_gem.c b/drivers/gpu/drm/v3d/v3d_gem.c
index 54
no functional change, just to make the code simpler
Signed-off-by: yu kuai
---
drivers/gpu/drm/omapdrm/dss/hdmi4.c | 5 +
drivers/gpu/drm/omapdrm/dss/hdmi4_core.c| 6 ++
drivers/gpu/drm/omapdrm/dss/hdmi5_core.c| 4 +---
drivers/gpu/drm/omapdrm/dss/hdmi_phy.c | 4
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/bridge/cdns-dsi.c: In function
‘cdns_dsi_bridge_enable’:
drivers/gpu/drm/bridge/cdns-dsi.c:788:6: warning: variable ‘bpp’
set but not used [-Wunused-but-set-variable]
It is never used, and so can be removed.
Signed-off-b
'dc_fixpt_e' and 'dc_fixpt_pi' are set in 'fixed31_32.h'. However, they
are never used and so can be removed.
Fixes: eb0e515464e4 ("drm/amd/display: get rid of 32.32 unsigned fixed point")
Signed-off-by: yu kuai
---
drivers/gpu/drm/amd/display/includ
The first patch remove two set but not used variable.
The second patch make the variables in fixed31_32.h 'global'
instead of 'static'.
yu kuai (2):
drm/amd/display: remove set but not used variable 'dc_fixpt_e' and
'dc_fixpt_pi'
drm/amd/display
nings related to the variables.
Fix it by initializing the variables in a new file "fixed31_32.c", and
declare them 'extern' in "fixed31_32.h".
Fixes: eb0e515464e4 ("drm/amd/display: get rid of 32.32 unsigned fixed point")
Signed-off-by: yu kuai
---
BTW, th
gpu/gfx7: rework gpu_init()")
Signed-off-by: yu kuai
---
drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 3 +--
drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c
can be removed. Thus 'atomic_dec_return'
can be replaced as 'atomic_dec'
Fixes: e42051d2133b ("drm/amdkfd: Implement GPU reset handlers in KFD")
Signed-off-by: yu kuai
---
drivers/gpu/drm/amd/amdkfd/kfd_device.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
' is never used, so can be removed. Thus 'atomic_inc_return'
can be replaced as 'atomic_inc'
Fixes: 5ae0283e831a ("drm/amdgpu: Add userptr support for KFD")
Signed-off-by: yu kuai
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 4 ++--
1 file changed, 2 i
This patch set fixes various unrelated gcc '-Wunused-but-set-variable'
warnings.
yu kuai (7):
drm/amdgpu: remove set but not used variable 'mc_shared_chmap' from
'gfx_v6_0.c' and 'gfx_v7_0.c'
drm/amdgpu: remove set but not used variable 'amdgp
t is never used, so can be removed.
Fixes: 2e112b4ae3ba ("drm/amd/pp: remove fiji_smc/smumgr split.")
Signed-off-by: yu kuai
---
drivers/gpu/drm/amd/powerplay/smumgr/fiji_smumgr.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/smu
e]
It is never used, so can be removed.
Fixes: ac7822b0026f ("drm/amd/powerplay: add smumgr support for VEGAM (v2)")
Signed-off-by: yu kuai
---
drivers/gpu/drm/amd/powerplay/smumgr/vegam_smumgr.c | 12
1 file changed, 12 deletions(-)
diff --git a/drivers/gpu/drm/amd/powe
le]
Fixes: d38ceaf99ed0 ("drm/amdgpu: add core driver (v4)")
Signed-off-by: yu kuai
---
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
index d2dd59a..
t is never used, so can be removed.
Fixes: 2e112b4ae3ba ("drm/amd/pp: remove fiji_smc/smumgr split.")
Signed-off-by: yu kuai
---
drivers/gpu/drm/amd/powerplay/smumgr/fiji_smumgr.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/smu
Fixes gcc warning:
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1954: warning: Function
parameter or member 'state' not described in 'amdgpu_device_set_cg_state'
Fixes: e3ecdffac9cc ("drm/amdgpu: add documentation for amdgpu_device.c")
Signed-off-by: yu kuai
-
mdgpu: add core driver (v4)")
Signed-off-by: yu kuai
---
drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/atombios_dp.c
b/drivers/gpu/drm/amd/amdgpu/atombios_dp.c
index 9426530..ea702a6 100644
--- a/drivers/gpu/drm/amd/
so can be removed.
Fixes: d38ceaf99ed0 ("drm/amdgpu: add core driver (v4)")
Signed-off-by: yu kuai
---
drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/atombios_dp.c
b/drivers/gpu/drm/amd/amdgpu/atombios_dp.c
in
gpu: split gfx8 gpu init into sw and hw parts")
Signed-off-by: yu kuai
---
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
index e4c645d..80b7958 100644
-
Fixes gcc warning:
drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c:313: warning: Function
parameter or member 'flags' not described in 'amdgpu_gart_bind'
Fixes: d38ceaf99ed0 ("drm/amdgpu: add core driver (v4)")
Signed-off-by: yu kuai
---
drivers/gpu/drm/amd/amdgpu/amdgp
able]
drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:341:24: warning: variable
'con_obj_num' set but not used [-Wunused-but-set-variable]
They are never used, so can be removed.
Fixes: d38ceaf99ed0 ("drm/amdgpu: add core driver (v4)")
Signed-off-by: yu kuai
---
drivers/gpu/drm
x27;u8', so it will never be greater than 'TOM_MAX_HW_I2C_READ',
which is defined as 255. Therefore, the comparison can be removed.
Fixes: d38ceaf99ed0 ("drm/amdgpu: add core driver (v4)")
Signed-off-by: yu kuai
---
drivers/gpu/drm/amd/amdgpu/atombios_i2c.c | 5 -
1
This patch set fixes various gcc warnings.
yu kuai (7):
drm/amdgpu: remove 4 set but not used variable in
amdgpu_atombios_get_connector_info_from_object_table
drm/amdgpu: add function parameter description in
'amdgpu_device_set_cg_state'
drm/amdgpu: add function
be removed.
Reported-by: Hulk Robot
Signed-off-by: yu kuai
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
index f9bef31..c1035a3 100644
--- a/drivers/g
cn_v2_5_enable_clock_gating'
Fixes: cbead2bdfcf1 ("drm/amdgpu: add VCN2.5 VCPU start and stop")
Signed-off-by: yu kuai
---
drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
b/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
i
92 matches
Mail list logo
