Re: [PATCH v9 drm-dp 0/9] Add HPD, getting EDID, colorbar features in DP function

2025-04-10 Thread Yongbang Shi
Gracious ping for this series, it's been posted over 10 days. Baihan, Thanks. From: Baihan Li To support DP HPD, edid printing, and colorbar display features based on the Hisislcon DP devices. --- ChangeLog: v8 -> v9: - modify the adaptation of hibmc_dp_link_reduce_rate(). - fix the le

[PATCH v8 drm-dp 7/9] drm/hisilicon/hibmc: Enable this hot plug detect of irq feature

2025-04-05 Thread Yongbang Shi
: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- ChangeLog: v5 -> v6: - add detect_ctx with 200ms delay, suggested by Dmitry Baryshkov. v4 -> v5: - separate the vga part commit, suggested by Dmitry Baryshkov. v3 -> v4: - add link reset of rates and lanes in pre link trainin

[PATCH v9 drm-dp 9/9] drm/hisilicon/hibmc: Add vga connector detect functions

2025-03-31 Thread Yongbang Shi
From: Baihan Li Because the connected VGA connector would make driver can't get the userspace call, adding detect_ctx in vga connector to make HPD active userspace. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/hisilicon/

[PATCH v9 drm-dp 6/9] drm/hisilicon/hibmc: Add colorbar-cfg feature and its debugfs file

2025-03-31 Thread Yongbang Shi
color bar register to display cat: print the color bar configuration Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- ChangeLog: v3 -> v4: - add comments in hibmc_control_write(), suggested by Dmitry Baryshkov. v2 -> v3: - rewrite the comm

[PATCH v9 drm-dp 5/9] drm/hisilicon/hibmc: Getting connector info and EDID by using AUX channel

2025-03-31 Thread Yongbang Shi
From: Baihan Li Add registering drm_aux and use it to get connector edid with drm functions. Add ddc channel in connector initialization to put drm_aux in drm_connector. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- ChangeLog: v8 -> v9: - fix

[PATCH v9 drm-dp 0/9] Add HPD, getting EDID, colorbar features in DP function

2025-03-31 Thread Yongbang Shi
From: Baihan Li To support DP HPD, edid printing, and colorbar display features based on the Hisislcon DP devices. --- ChangeLog: v8 -> v9: - modify the adaptation of hibmc_dp_link_reduce_rate(). - fix the leak problem in hibmc_dp_aux_init(), suggested by Jani Nikula. v8: https://lore.kern

[PATCH v9 drm-dp 1/9] drm/hisilicon/hibmc: Restructuring the header dp_reg.h

2025-03-31 Thread Yongbang Shi
From: Baihan Li Move the macros below their corresponding registers to make them more obvious. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- ChangeLog: v2 -> v3: - restructuring the header dp_reg.h, suggested by Dmitry Baryshkov. --- drivers/

[PATCH v9 drm-dp 2/9] drm/hisilicon/hibmc: Add dp serdes cfg to adjust serdes rate, voltage and pre-emphasis

2025-03-31 Thread Yongbang Shi
ng, we can cfg different serdes ffe value. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- ChangeLog: v5 -> v6: - fix the DP_SERDES_VOL2_PRE0 value after electrical test. v3 -> v4: - fix the serdes cfg in hibmc_dp_serdes_set_tx_cfg(), suggested by D

[PATCH v9 drm-dp 7/9] drm/hisilicon/hibmc: Enable this hot plug detect of irq feature

2025-03-31 Thread Yongbang Shi
: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- ChangeLog: v5 -> v6: - add detect_ctx with 200ms delay, suggested by Dmitry Baryshkov. v4 -> v5: - separate the vga part commit, suggested by Dmitry Baryshkov. v3 -> v4: - add link reset of rates and lanes in pre link trainin

[PATCH v9 drm-dp 8/9] drm/hisilicon/hibmc: Add MSI irq getting and requesting for HPD

2025-03-31 Thread Yongbang Shi
From: Baihan Li To realize HPD feature, request irq for HPD , add its handler function. We use pci_alloc_irq_vectors() to get our msi irq, because we have two interrupts now. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- ChangeLog: v4 ->

[PATCH v9 drm-dp 3/9] drm/hisilicon/hibmc: Add dp serdes cfg in dp process

2025-03-31 Thread Yongbang Shi
cfgs is changed and used in hibmc_kms_init(), we changed the if-statement to check whether the value is 0. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- ChangeLog: v8 -> v9: - modify the adaptation of hibmc_dp_link_reduce_rate(). v4 -> v5: - add

[PATCH v9 drm-dp 4/9] drm/hisilicon/hibmc: Refactor the member of drm_aux in struct hibmc_dp

2025-03-31 Thread Yongbang Shi
From: Baihan Li Because the drm_aux of struct hibmc_dp_dev's member is not easy to get in hibmc_drm_dp.c, move the drm_aux to struct hibmc_dp. Then there are some adaptations and modifications to make this patch compile. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: D

Re: [PATCH v8 drm-dp 5/9] drm/hisilicon/hibmc: Getting connector info and EDID by using AUX channel

2025-03-31 Thread Yongbang Shi
dp->aux.name = kasprintf(GFP_KERNEL, "HIBMC DRM dp aux"); As being discussed in the feedback for v7, this is a memory leak. Can you simply assign the string here? Alright!

Re: [PATCH v7 drm-dp 5/9] drm/hisilicon/hibmc: Getting connector info and EDID by using AUX channel

2025-03-28 Thread Yongbang Shi
On Fri, Mar 28, 2025 at 12:28:14PM +0200, Jani Nikula wrote: On Fri, 28 Mar 2025, Yongbang Shi wrote: On Thu, 27 Mar 2025, Yongbang Shi wrote: 在 2025/3/26 17:32, Jani Nikula 写道: On Tue, 25 Mar 2025, Yongbang Shi wrote: On Mon, 24 Mar 2025, Yongbang Shi wrote: On Wed, 19 Mar 2025

Re: [PATCH v7 drm-dp 5/9] drm/hisilicon/hibmc: Getting connector info and EDID by using AUX channel

2025-03-27 Thread Yongbang Shi
On Thu, 27 Mar 2025, Yongbang Shi wrote: 在 2025/3/26 17:32, Jani Nikula 写道: On Tue, 25 Mar 2025, Yongbang Shi wrote: On Mon, 24 Mar 2025, Yongbang Shi wrote: On Wed, 19 Mar 2025, Yongbang Shi wrote: From: Baihan Li Add registering drm_aux and use it to get connector edid with drm

Re: [PATCH v8 drm-dp 0/9] Add HPD, getting EDID, colorbar features in DP function

2025-03-26 Thread Yongbang Shi
Gently ping! Hi, Dmitry. There is no more comment for v8 patch set for one week, is this good to be applied. Thanks, Baihan From: Baihan Li To support DP HPD, edid printing, and colorbar display features based on the Hisislcon DP devices. --- ChangeLog: v7 -> v8: - use drm_edid_read() in

Re: [PATCH v7 drm-dp 5/9] drm/hisilicon/hibmc: Getting connector info and EDID by using AUX channel

2025-03-26 Thread Yongbang Shi
在 2025/3/26 17:32, Jani Nikula 写道: On Tue, 25 Mar 2025, Yongbang Shi wrote: On Mon, 24 Mar 2025, Yongbang Shi wrote: On Wed, 19 Mar 2025, Yongbang Shi wrote: From: Baihan Li Add registering drm_aux and use it to get connector edid with drm functions. Add ddc channel in connector

Re: [PATCH v7 drm-dp 5/9] drm/hisilicon/hibmc: Getting connector info and EDID by using AUX channel

2025-03-24 Thread Yongbang Shi
On Mon, 24 Mar 2025, Yongbang Shi wrote: On Wed, 19 Mar 2025, Yongbang Shi wrote: From: Baihan Li Add registering drm_aux and use it to get connector edid with drm functions. Add ddc channel in connector initialization to put drm_aux in drm_connector. Signed-off-by: Baihan Li Signed

Re: [PATCH v7 drm-dp 5/9] drm/hisilicon/hibmc: Getting connector info and EDID by using AUX channel

2025-03-24 Thread Yongbang Shi
On Wed, 19 Mar 2025, Yongbang Shi wrote: From: Baihan Li Add registering drm_aux and use it to get connector edid with drm functions. Add ddc channel in connector initialization to put drm_aux in drm_connector. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry

[PATCH v8 drm-dp 5/9] drm/hisilicon/hibmc: Getting connector info and EDID by using AUX channel

2025-03-20 Thread Yongbang Shi
From: Baihan Li Add registering drm_aux and use it to get connector edid with drm functions. Add ddc channel in connector initialization to put drm_aux in drm_connector. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- ChangeLog: v7 -> v8: -

[PATCH v8 drm-dp 2/9] drm/hisilicon/hibmc: Add dp serdes cfg to adjust serdes rate, voltage and pre-emphasis

2025-03-20 Thread Yongbang Shi
ng, we can cfg different serdes ffe value. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- ChangeLog: v5 -> v6: - fix the DP_SERDES_VOL2_PRE0 value after electrical test. v3 -> v4: - fix the serdes cfg in hibmc_dp_serdes_set_tx_cfg(), suggested by D

[PATCH v8 drm-dp 4/9] drm/hisilicon/hibmc: Refactor the member of drm_aux in struct hibmc_dp

2025-03-20 Thread Yongbang Shi
From: Baihan Li Because the drm_aux of struct hibmc_dp_dev's member is not easy to get in hibmc_drm_dp.c, move the drm_aux to struct hibmc_dp. Then there are some adaptations and modifications to make this patch compile. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: D

[PATCH v8 drm-dp 9/9] drm/hisilicon/hibmc: Add vga connector detect functions

2025-03-20 Thread Yongbang Shi
From: Baihan Li Because the connected VGA connector would make driver can't get the userspace call, adding detect_ctx in vga connector to make HPD active userspace. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/hisilicon/

[PATCH v8 drm-dp 6/9] drm/hisilicon/hibmc: Add colorbar-cfg feature and its debugfs file

2025-03-20 Thread Yongbang Shi
color bar register to display cat: print the color bar configuration Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- ChangeLog: v3 -> v4: - add comments in hibmc_control_write(), suggested by Dmitry Baryshkov. v2 -> v3: - rewrite the comm

[PATCH v8 drm-dp 8/9] drm/hisilicon/hibmc: Add MSI irq getting and requesting for HPD

2025-03-20 Thread Yongbang Shi
From: Baihan Li To realize HPD feature, request irq for HPD , add its handler function. We use pci_alloc_irq_vectors() to get our msi irq, because we have two interrupts now. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- ChangeLog: v4 ->

[PATCH v8 drm-dp 1/9] drm/hisilicon/hibmc: Restructuring the header dp_reg.h

2025-03-20 Thread Yongbang Shi
From: Baihan Li Move the macros below their corresponding registers to make them more obvious. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- ChangeLog: v2 -> v3: - restructuring the header dp_reg.h, suggested by Dmitry Baryshkov. --- drivers/

[PATCH v8 drm-dp 0/9] Add HPD, getting EDID, colorbar features in DP function

2025-03-20 Thread Yongbang Shi
From: Baihan Li To support DP HPD, edid printing, and colorbar display features based on the Hisislcon DP devices. --- ChangeLog: v7 -> v8: - use drm_edid_read() in hibmc_dp_connector_get_modes(), suggested by Jani Nikula v7: https://lore.kernel.org/all/20250319032435.1119469-1-shiyongb...@

[PATCH v8 drm-dp 3/9] drm/hisilicon/hibmc: Add dp serdes cfg in dp process

2025-03-20 Thread Yongbang Shi
cfgs is changed and used in hibmc_kms_init(), we changed the if-statement to check whether the value is 0. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- ChangeLog: v4 -> v5: - add commit log about hibmc_kms_init(), suggested by Dmitry Baryshkov. -

Re: [PATCH v6 drm-dp 5/9] drm/hisilicon/hibmc: Getting connector info and EDID by using AUX channel

2025-03-19 Thread Yongbang Shi
On Mon, 10 Mar 2025, Yongbang Shi wrote: @@ -15,11 +15,17 @@ static int hibmc_dp_connector_get_modes(struct drm_connector *connector) { + struct hibmc_dp *dp = to_hibmc_dp(connector); + const struct drm_edid *drm_edid; int count; - count = drm_add_modes_noedid

Re: [PATCH v7 drm-dp 0/9] Add HPD, getting EDID, colorbar features in DP function

2025-03-19 Thread Yongbang Shi
On Wed, Mar 19, 2025 at 11:24:26AM +0800, Yongbang Shi wrote: From: Baihan Li To support DP HPD, edid printing, and colorbar display features based on the Hisislcon DP devices. --- ChangeLog: v6 -> v7: - add if statement about drm aux in hibmc_dp_connector_get_modes(), suggested by J

[PATCH v7 drm-dp 4/9] drm/hisilicon/hibmc: Refactor the member of drm_aux in struct hibmc_dp

2025-03-18 Thread Yongbang Shi
From: Baihan Li Because the drm_aux of struct hibmc_dp_dev's member is not easy to get in hibmc_drm_dp.c, move the drm_aux to struct hibmc_dp. Then there are some adaptations and modifications to make this patch compile. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: D

[PATCH v7 drm-dp 8/9] drm/hisilicon/hibmc: Add MSI irq getting and requesting for HPD

2025-03-18 Thread Yongbang Shi
From: Baihan Li To realize HPD feature, request irq for HPD , add its handler function. We use pci_alloc_irq_vectors() to get our msi irq, because we have two interrupts now. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- ChangeLog: v4 ->

[PATCH v7 drm-dp 0/9] Add HPD, getting EDID, colorbar features in DP function

2025-03-18 Thread Yongbang Shi
From: Baihan Li To support DP HPD, edid printing, and colorbar display features based on the Hisislcon DP devices. --- ChangeLog: v6 -> v7: - add if statement about drm aux in hibmc_dp_connector_get_modes(), suggested by Jani Nikula v6: https://lore.kernel.org/all/20250310040138.2025715-1-s

[PATCH v7 drm-dp 1/9] drm/hisilicon/hibmc: Restructuring the header dp_reg.h

2025-03-18 Thread Yongbang Shi
From: Baihan Li Move the macros below their corresponding registers to make them more obvious. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- ChangeLog: v2 -> v3: - restructuring the header dp_reg.h, suggested by Dmitry Baryshkov. --- drivers/

[PATCH v7 drm-dp 9/9] drm/hisilicon/hibmc: Add vga connector detect functions

2025-03-18 Thread Yongbang Shi
From: Baihan Li Because the connected VGA connector would make driver can't get the userspace call, adding detect_ctx in vga connector to make HPD active userspace. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/hisilicon/

[PATCH v7 drm-dp 5/9] drm/hisilicon/hibmc: Getting connector info and EDID by using AUX channel

2025-03-18 Thread Yongbang Shi
From: Baihan Li Add registering drm_aux and use it to get connector edid with drm functions. Add ddc channel in connector initialization to put drm_aux in drm_connector. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- ChangeLog: v6 -> v7: - add

[PATCH v7 drm-dp 7/9] drm/hisilicon/hibmc: Enable this hot plug detect of irq feature

2025-03-18 Thread Yongbang Shi
: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- ChangeLog: v5 -> v6: - add detect_ctx with 200ms delay, suggested by Dmitry Baryshkov. v4 -> v5: - separate the vga part commit, suggested by Dmitry Baryshkov. v3 -> v4: - add link reset of rates and lanes in pre link trainin

[PATCH v7 drm-dp 3/9] drm/hisilicon/hibmc: Add dp serdes cfg in dp process

2025-03-18 Thread Yongbang Shi
cfgs is changed and used in hibmc_kms_init(), we changed the if-statement to check whether the value is 0. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- ChangeLog: v4 -> v5: - add commit log about hibmc_kms_init(), suggested by Dmitry Baryshkov. -

[PATCH v7 drm-dp 6/9] drm/hisilicon/hibmc: Add colorbar-cfg feature and its debugfs file

2025-03-18 Thread Yongbang Shi
color bar register to display cat: print the color bar configuration Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- ChangeLog: v3 -> v4: - add comments in hibmc_control_write(), suggested by Dmitry Baryshkov. v2 -> v3: - rewrite the comm

[PATCH v7 drm-dp 2/9] drm/hisilicon/hibmc: Add dp serdes cfg to adjust serdes rate, voltage and pre-emphasis

2025-03-18 Thread Yongbang Shi
ng, we can cfg different serdes ffe value. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- ChangeLog: v5 -> v6: - fix the DP_SERDES_VOL2_PRE0 value after electrical test. v3 -> v4: - fix the serdes cfg in hibmc_dp_serdes_set_tx_cfg(), suggested by D

Re: [PATCH v6 drm-dp 0/9] Add HPD, getting EDID, colorbar features in DP function

2025-03-17 Thread Yongbang Shi
Gently ping! Hi, Dmitry. There is no more comment for this patch set for one week, I wonder, could this patch be applied, or wait for more comments. Thanks, Baihan From: Baihan Li To support DP HPD, edid printing, and colorbar display features based on the Hisislcon DP devices. --- ChangeLo

[PATCH v6 drm-dp 2/9] drm/hisilicon/hibmc: Add dp serdes cfg to adjust serdes rate, voltage and pre-emphasis

2025-03-15 Thread Yongbang Shi
ng, we can cfg different serdes ffe value. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- ChangeLog: v5 -> v6: - fix the DP_SERDES_VOL2_PRE0 value after electrical test. v3 -> v4: - fix the serdes cfg in hibmc_dp_serdes_set_tx_cfg(), suggested by D

[PATCH v6 drm-dp 6/9] drm/hisilicon/hibmc: Add colorbar-cfg feature and its debugfs file

2025-03-15 Thread Yongbang Shi
color bar register to display cat: print the color bar configuration Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- ChangeLog: v3 -> v4: - add comments in hibmc_control_write(), suggested by Dmitry Baryshkov. v2 -> v3: - rewrite the comm

[PATCH v6 drm-dp 3/9] drm/hisilicon/hibmc: Add dp serdes cfg in dp process

2025-03-11 Thread Yongbang Shi
cfgs is changed and used in hibmc_kms_init(), we changed the if-statement to check whether the value is 0. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- ChangeLog: v4 -> v5: - add commit log about hibmc_kms_init(), suggested by Dmitry Baryshkov. -

[PATCH v6 drm-dp 8/9] drm/hisilicon/hibmc: Add MSI irq getting and requesting for HPD

2025-03-09 Thread Yongbang Shi
From: Baihan Li To realize HPD feature, request irq for HPD , add its handler function. We use pci_alloc_irq_vectors() to get our msi irq, because we have two interrupts now. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- ChangeLog: v4 ->

[PATCH v6 drm-dp 5/9] drm/hisilicon/hibmc: Getting connector info and EDID by using AUX channel

2025-03-09 Thread Yongbang Shi
From: Baihan Li Add registering drm_aux and use it to get connector edid with drm functions. Add ddc channel in connector initialization to put drm_aux in drm_connector. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- ChangeLog: v5 -> v6: - move

[PATCH v6 drm-dp 9/9] drm/hisilicon/hibmc: Add vga connector detect functions

2025-03-09 Thread Yongbang Shi
From: Baihan Li Because the connected VGA connector would make driver can't get the userspace call, adding detect_ctx in vga connector to make HPD active userspace. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/hisilicon/

[PATCH v6 drm-dp 7/9] drm/hisilicon/hibmc: Enable this hot plug detect of irq feature

2025-03-09 Thread Yongbang Shi
-off-by: Yongbang Shi --- ChangeLog: v5 -> v6: - add detect_ctx with 200ms delay, suggested by Dmitry Baryshkov. v4 -> v5: - separate the vga part commit, suggested by Dmitry Baryshkov. v3 -> v4: - add link reset of rates and lanes in pre link training process, suggested by Dmitry

[PATCH v6 drm-dp 4/9] drm/hisilicon/hibmc: Refactor the member of drm_aux in struct hibmc_dp

2025-03-09 Thread Yongbang Shi
From: Baihan Li Because the drm_aux of struct hibmc_dp_dev's member is not easy to get in hibmc_drm_dp.c, move the drm_aux to struct hibmc_dp. Then there are some adaptations and modifications to make this patch compile. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: D

[PATCH v6 drm-dp 1/9] drm/hisilicon/hibmc: Restructuring the header dp_reg.h

2025-03-09 Thread Yongbang Shi
From: Baihan Li Move the macros below their corresponding registers to make them more obvious. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- ChangeLog: v2 -> v3: - restructuring the header dp_reg.h, suggested by Dmitry Baryshkov. --- drivers/

[PATCH v6 drm-dp 0/9] Add HPD, getting EDID, colorbar features in DP function

2025-03-09 Thread Yongbang Shi
From: Baihan Li To support DP HPD, edid printing, and colorbar display features based on the Hisislcon DP devices. --- ChangeLog: v5 -> v6: - fix the DP_SERDES_VOL2_PRE0 value after electrical test. - move the detect_ctx() to the patch 7/9. - add detect_ctx with 200ms delay, suggested by Dm

[PATCH v5 drm-dp 3/9] drm/hisilicon/hibmc: Add dp serdes cfg in dp process

2025-03-07 Thread Yongbang Shi
cfgs is changed and used in hibmc_kms_init(), we changed the if-statement to check whether the value is 0. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi --- ChangeLog: v4 -> v5: - add commit log about hibmc_kms_init(), suggested by Dmitry Baryshkov. - fix the format of block comme

[PATCH v5 drm-dp 2/9] drm/hisilicon/hibmc: Add dp serdes cfg to adjust serdes rate, voltage and pre-emphasis

2025-03-07 Thread Yongbang Shi
ng, we can cfg different serdes ffe value. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi --- ChangeLog: v3 -> v4: - fix the serdes cfg in hibmc_dp_serdes_set_tx_cfg(), suggested by Dmitry Baryshkov. - move the dp serdes registers to dp_reg.h, suggested by Dmitry Baryshkov. - v2 -

[PATCH v5 drm-dp 9/9] drm/hisilicon/hibmc: Add vga connector detect functions

2025-03-07 Thread Yongbang Shi
From: Baihan Li Because the connected VGA connector would make driver can't get the userspace call, adding detect_ctx in vga connector to make HPD active userspace. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 3 +++ 1

[PATCH v5 drm-dp 0/9] Add HPD, getting EDID, colorbar features in DP function

2025-03-07 Thread Yongbang Shi
From: Baihan Li To support DP HPD, edid printing, and colorbar display features based on the Hisislcon DP devices. --- ChangeLog: v4 -> v5: - add commit log about hibmc_kms_init(), suggested by Dmitry Baryshkov. - fix the format of block comments, suggested by Dmitry Baryshkov. - add hibmc

[PATCH v5 drm-dp 7/9] drm/hisilicon/hibmc: Enable this hot plug detect of irq feature

2025-03-07 Thread Yongbang Shi
From: Baihan Li Add HPD interrupt enable functions in drm framework. Add link reset process to reset link status when a new connector pulgged in. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi --- ChangeLog: v4 -> v5: - separate the vga part commit, suggested by Dmitry Baryshkov.

[PATCH v5 drm-dp 6/9] drm/hisilicon/hibmc: Add colorbar-cfg feature and its debugfs file

2025-03-07 Thread Yongbang Shi
color bar register to display cat: print the color bar configuration Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- ChangeLog: v3 -> v4: - add comments in hibmc_control_write(), suggested by Dmitry Baryshkov. v2 -> v3: - rewrite the comm

[PATCH v5 drm-dp 5/9] drm/hisilicon/hibmc: Getting connector info and EDID by using AUX channel

2025-03-07 Thread Yongbang Shi
: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- ChangeLog: v2 -> v3: - Capitalized EDID and AUX, suggested by Dmitry Baryshkov. v1 -> v2: - deleting type conversion, suggested by Dmitry Baryshkov. - deleting hibmc_dp_connector_get_modes() and using drm_connector_helper_get_modes(), sug

[PATCH v5 drm-dp 4/9] drm/hisilicon/hibmc: Refactor the member of drm_aux in struct hibmc_dp

2025-03-07 Thread Yongbang Shi
From: Baihan Li Because the drm_aux of struct hibmc_dp_dev's member is not easy to get in hibmc_drm_dp.c, move the drm_aux to struct hibmc_dp. Then there are some adaptations and modifications to make this patch compile. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: D

[PATCH v5 drm-dp 1/9] drm/hisilicon/hibmc: Restructuring the header dp_reg.h

2025-03-07 Thread Yongbang Shi
From: Baihan Li Move the macros below their corresponding registers to make them more obvious. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- ChangeLog: v2 -> v3: - restructuring the header dp_reg.h, suggested by Dmitry Baryshkov. --- drivers/

[PATCH v5 drm-dp 8/9] drm/hisilicon/hibmc: Add MSI irq getting and requesting for HPD

2025-03-07 Thread Yongbang Shi
From: Baihan Li To realize HPD feature, request irq for HPD , add its handler function. We use pci_alloc_irq_vectors() to get our msi irq, because we have two interrupts now. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- ChangeLog: v4 ->

Re: [PATCH v4 drm-dp 7/8] drm/hisilicon/hibmc: Enable this hot plug detect of irq feature

2025-03-06 Thread Yongbang Shi
On Wed, Mar 05, 2025 at 07:26:46PM +0800, Yongbang Shi wrote: From: Baihan Li Add HPD interrupt enable functions in drm framework. Add link reset process to reset link status when a new connector pulgged in. Because the connected VGA connector would make driver can't get the userspace

Re: [PATCH v4 drm-dp 3/8] drm/hisilicon/hibmc: Add dp serdes cfg in dp process

2025-03-06 Thread Yongbang Shi
On Wed, Mar 05, 2025 at 07:26:42PM +0800, Yongbang Shi wrote: From: Baihan Li Add dp serdes cfg in link training process, and related adapting and modificating. Change some init values about training, because we want completely to negotiation process, so we start with the maximum rate and the

[PATCH v4 drm-dp 8/8] drm/hisilicon/hibmc: Add MSI irq getting and requesting for HPD

2025-03-05 Thread Yongbang Shi
From: Baihan Li To realize HPD feature, request irq for HPD , add its handler function. We use pci_alloc_irq_vectors() to get our msi irq, because we have two interrupts now. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/hisilicon

[PATCH v4 drm-dp 4/8] drm/hisilicon/hibmc: Refactor the member of drm_aux in struct hibmc_dp

2025-03-05 Thread Yongbang Shi
From: Baihan Li Because the drm_aux of struct hibmc_dp_dev's member is not easy to get in hibmc_drm_dp.c, move the drm_aux to struct hibmc_dp. Then there are some adaptations and modifications to make this patch compile. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: D

[PATCH v4 drm-dp 3/8] drm/hisilicon/hibmc: Add dp serdes cfg in dp process

2025-03-05 Thread Yongbang Shi
Signed-off-by: Yongbang Shi --- ChangeLog: v3 -> v4: - add comments for if-statement of dp_init(), suggested by Dmitry Baryshkov. v2 -> v3: - change commit to an imperative sentence, suggested by Dmitry Baryshkov. - put HIBMC_DP_HOST_SERDES_CTRL in dp_serdes.h, suggested by Dmitry Bar

[PATCH v4 drm-dp 7/8] drm/hisilicon/hibmc: Enable this hot plug detect of irq feature

2025-03-05 Thread Yongbang Shi
space. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi --- ChangeLog: v3 -> v4: - add link reset of rates and lanes in pre link training process, suggested by Dmitry Baryshkov. - add vdac detect and connected/disconnected status to enable HPD process, suggested by Dmitry Baryshkov.

[PATCH v4 drm-dp 1/8] drm/hisilicon/hibmc: Restructuring the header dp_reg.h

2025-03-05 Thread Yongbang Shi
From: Baihan Li Move the macros below their corresponding registers to make them more obvious. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- ChangeLog: v2 -> v3: - restructuring the header dp_reg.h, suggested by Dmitry Baryshkov. --- drivers/

[PATCH v4 drm-dp 5/8] drm/hisilicon/hibmc: Getting connector info and EDID by using AUX channel

2025-03-05 Thread Yongbang Shi
: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- ChangeLog: v2 -> v3: - Capitalized EDID and AUX, suggested by Dmitry Baryshkov. v1 -> v2: - deleting type conversion, suggested by Dmitry Baryshkov. - deleting hibmc_dp_connector_get_modes() and using drm_connector_helper_get_modes(), sug

[PATCH v4 drm-dp 2/8] drm/hisilicon/hibmc: Add dp serdes cfg to adjust serdes rate, voltage and pre-emphasis

2025-03-05 Thread Yongbang Shi
ng, we can cfg different serdes ffe value. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi --- ChangeLog: v3 -> v4: - fix the serdes cfg in hibmc_dp_serdes_set_tx_cfg(), suggested by Dmitry Baryshkov. - move the dp serdes registers to dp_reg.h, suggested by Dmitry Baryshkov. - v2 -

[PATCH v4 drm-dp 6/8] drm/hisilicon/hibmc: Add colorbar-cfg feature and its debugfs file

2025-03-05 Thread Yongbang Shi
color bar register to display cat: print the color bar configuration Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi --- ChangeLog: v3 -> v4: - add comments in hibmc_control_write(), suggested by Dmitry Baryshkov. v2 -> v3: - rewrite the commit log, suggested by Dmitry Baryshkov.

[PATCH v4 drm-dp 0/8] Add HPD, getting EDID, colorbar features in DP function

2025-03-05 Thread Yongbang Shi
From: Baihan Li To support DP HPD, edid printing, and colorbar display features based on the Hisislcon DP devices. --- ChangeLog: v3 -> v4: - fix the serdes cfg in hibmc_dp_serdes_set_tx_cfg(), suggested by Dmitry Baryshkov. - move the dp serdes registers to dp_reg.h, suggested by Dmitry Ba

Re: [PATCH v3 drm-dp 7/8] drm/hisilicon/hibmc: Enable this hot plug detect of irq feature

2025-03-05 Thread Yongbang Shi
On Wed, 5 Mar 2025 at 08:29, Yongbang Shi wrote: On Tue, Mar 04, 2025 at 10:23:14AM +0800, Yongbang Shi wrote: On Mon, Mar 03, 2025 at 01:02:44PM +0800, Yongbang Shi wrote: On Sat, 1 Mar 2025 at 11:54, Yongbang Shi wrote: On Sat, Mar 01, 2025 at 04:45:40PM +0800, Yongbang Shi wrote: On

Re: [PATCH v3 drm-dp 7/8] drm/hisilicon/hibmc: Enable this hot plug detect of irq feature

2025-03-04 Thread Yongbang Shi
On Tue, Mar 04, 2025 at 10:23:14AM +0800, Yongbang Shi wrote: On Mon, Mar 03, 2025 at 01:02:44PM +0800, Yongbang Shi wrote: On Sat, 1 Mar 2025 at 11:54, Yongbang Shi wrote: On Sat, Mar 01, 2025 at 04:45:40PM +0800, Yongbang Shi wrote: On Thu, Feb 27, 2025 at 09:46:10PM +0800, Yongbang Shi

Re: [PATCH v3 drm-dp 7/8] drm/hisilicon/hibmc: Enable this hot plug detect of irq feature

2025-03-03 Thread Yongbang Shi
On Mon, Mar 03, 2025 at 01:02:44PM +0800, Yongbang Shi wrote: On Sat, 1 Mar 2025 at 11:54, Yongbang Shi wrote: On Sat, Mar 01, 2025 at 04:45:40PM +0800, Yongbang Shi wrote: On Thu, Feb 27, 2025 at 09:46:10PM +0800, Yongbang Shi wrote: On Tue, Feb 25, 2025 at 09:57:17PM +0800, Yongbang Shi

Re: [PATCH v3 drm-dp 7/8] drm/hisilicon/hibmc: Enable this hot plug detect of irq feature

2025-03-02 Thread Yongbang Shi
On Sat, 1 Mar 2025 at 11:54, Yongbang Shi wrote: On Sat, Mar 01, 2025 at 04:45:40PM +0800, Yongbang Shi wrote: On Thu, Feb 27, 2025 at 09:46:10PM +0800, Yongbang Shi wrote: On Tue, Feb 25, 2025 at 09:57:17PM +0800, Yongbang Shi wrote: On Mon, 24 Feb 2025 at 16:03, Yongbang Shi wrote

Re: [PATCH v3 drm-dp 7/8] drm/hisilicon/hibmc: Enable this hot plug detect of irq feature

2025-03-01 Thread Yongbang Shi
On Sat, Mar 01, 2025 at 04:45:40PM +0800, Yongbang Shi wrote: On Thu, Feb 27, 2025 at 09:46:10PM +0800, Yongbang Shi wrote: On Tue, Feb 25, 2025 at 09:57:17PM +0800, Yongbang Shi wrote: On Mon, 24 Feb 2025 at 16:03, Yongbang Shi wrote: On Sat, Feb 22, 2025 at 06:35:48PM +0800, Yongbang

Re: [PATCH v3 drm-dp 7/8] drm/hisilicon/hibmc: Enable this hot plug detect of irq feature

2025-03-01 Thread Yongbang Shi
On Thu, Feb 27, 2025 at 09:46:10PM +0800, Yongbang Shi wrote: On Tue, Feb 25, 2025 at 09:57:17PM +0800, Yongbang Shi wrote: On Mon, 24 Feb 2025 at 16:03, Yongbang Shi wrote: On Sat, Feb 22, 2025 at 06:35:48PM +0800, Yongbang Shi wrote: +static int hibmc_dp_hpd_event(struct drm_client_dev

Re: [PATCH v3 drm-dp 7/8] drm/hisilicon/hibmc: Enable this hot plug detect of irq feature

2025-02-27 Thread Yongbang Shi
On Tue, Feb 25, 2025 at 09:57:17PM +0800, Yongbang Shi wrote: On Mon, 24 Feb 2025 at 16:03, Yongbang Shi wrote: On Sat, Feb 22, 2025 at 06:35:48PM +0800, Yongbang Shi wrote: +static int hibmc_dp_hpd_event(struct drm_client_dev *client) +{ + struct hibmc_dp *dp = container_of(client

Re: [PATCH v3 drm-dp 7/8] drm/hisilicon/hibmc: Enable this hot plug detect of irq feature

2025-02-25 Thread Yongbang Shi
On Mon, 24 Feb 2025 at 16:03, Yongbang Shi wrote: On Sat, Feb 22, 2025 at 06:35:48PM +0800, Yongbang Shi wrote: +static int hibmc_dp_hpd_event(struct drm_client_dev *client) +{ + struct hibmc_dp *dp = container_of(client, struct hibmc_dp, client); + struct hibmc_drm_private *priv

Re: [PATCH v3 drm-dp 7/8] drm/hisilicon/hibmc: Enable this hot plug detect of irq feature

2025-02-24 Thread Yongbang Shi
On Sat, Feb 22, 2025 at 06:35:48PM +0800, Yongbang Shi wrote: +static int hibmc_dp_hpd_event(struct drm_client_dev *client) +{ + struct hibmc_dp *dp = container_of(client, struct hibmc_dp, client); + struct hibmc_drm_private *priv = to_hibmc_drm_private(dp->drm_dev); + str

Re: [PATCH v3 drm-dp 7/8] drm/hisilicon/hibmc: Enable this hot plug detect of irq feature

2025-02-24 Thread Yongbang Shi
On Sat, Feb 22, 2025 at 10:51:00AM +0800, Yongbang Shi wrote: From: Baihan Li Enable HPD feature and add its isr and event function. Add a drm client dev and realized the hotplug callback in it. What for? There should be no need to add a separate drm client just for the hotplug. Signed-off

Re: [PATCH v3 drm-dp 2/8] drm/hisilicon/hibmc: Add dp serdes cfg to adjust serdes rate, voltage and pre-emphasis

2025-02-22 Thread Yongbang Shi
On Sat, Feb 22, 2025 at 10:50:55AM +0800, Yongbang Shi wrote: From: Baihan Li This dp controller need features of digital-to-analog conversion and high-speed transmission in chip by its extern serdes controller. Our serdes cfg is relatively simple, just need two register configurations. Don&#

Re: [PATCH v3 drm-dp 3/8] drm/hisilicon/hibmc: Add dp serdes cfg in dp process

2025-02-22 Thread Yongbang Shi
On Sat, Feb 22, 2025 at 10:50:56AM +0800, Yongbang Shi wrote: From: Baihan Li Add dp serdes cfg in link training process, and related adapting and modificating. Change some init values about training, because we want completely to negotiation process, so we start with the maximum rate and the

Re: [PATCH v3 drm-dp 7/8] drm/hisilicon/hibmc: Enable this hot plug detect of irq feature

2025-02-22 Thread Yongbang Shi
+static int hibmc_dp_hpd_event(struct drm_client_dev *client) +{ + struct hibmc_dp *dp = container_of(client, struct hibmc_dp, client); + struct hibmc_drm_private *priv = to_hibmc_drm_private(dp->drm_dev); + struct drm_display_mode *mode = &priv->crtc.state->adjusted_mode; +

Re: [PATCH v3 drm-dp 7/8] drm/hisilicon/hibmc: Enable this hot plug detect of irq feature

2025-02-22 Thread Yongbang Shi
On Sat, Feb 22, 2025 at 10:51:00AM +0800, Yongbang Shi wrote: From: Baihan Li Enable HPD feature and add its isr and event function. Add a drm client dev and realized the hotplug callback in it. What for? There should be no need to add a separate drm client just for the hotplug. Signed-off

Re: [PATCH v3 drm-dp 6/8] drm/hisilicon/hibmc: Add colorbar-cfg feature and its debugfs file

2025-02-22 Thread Yongbang Shi
On Sat, Feb 22, 2025 at 10:50:59AM +0800, Yongbang Shi wrote: From: Baihan Li DP controller can support generating a color bar signal over the DisplayPort interface. This can be useful to check for possible DDR or GPU problems, as the signal generator resides completely in the DP block. Add

[PATCH v3 drm-dp 3/8] drm/hisilicon/hibmc: Add dp serdes cfg in dp process

2025-02-21 Thread Yongbang Shi
Signed-off-by: Yongbang Shi --- ChangeLog: v2 -> v3: - change commit to an imperative sentence, suggested by Dmitry Baryshkov. - put HIBMC_DP_HOST_SERDES_CTRL in dp_serdes.h, suggested by Dmitry Baryshkov. v1 -> v2: - splittting the patch and add more detailed the changes in the

[PATCH v3 drm-dp 7/8] drm/hisilicon/hibmc: Enable this hot plug detect of irq feature

2025-02-21 Thread Yongbang Shi
From: Baihan Li Enable HPD feature and add its isr and event function. Add a drm client dev and realized the hotplug callback in it. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi --- ChangeLog: v2 -> v3: - remove mdelay(100) hpd function in ISR, suggested by Dmitry Barysh

[PATCH v3 drm-dp 2/8] drm/hisilicon/hibmc: Add dp serdes cfg to adjust serdes rate, voltage and pre-emphasis

2025-02-21 Thread Yongbang Shi
ng, we can cfg different serdes ffe value. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi --- ChangeLog: v2 - > v3: - add commit log about dp serdes, suggested by Dmitry Baryshkov. - return value in hibmc_dp_serdes_init(), suggested by Dmitry Baryshkov. - add static const in

[PATCH v3 drm-dp 8/8] drm/hisilicon/hibmc: Add MSI irq getting and requesting for HPD

2025-02-21 Thread Yongbang Shi
From: Baihan Li To realize HPD feature, request irq for HPD , add its handler function. We use pci_alloc_irq_vectors() to get our msi irq, because we have two interrupts now. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi --- drivers/gpu/drm/hisilicon/hibmc/dp/dp_reg.h | 3

[PATCH v3 drm-dp 1/8] drm/hisilicon/hibmc: Restructuring the header dp_reg.h

2025-02-21 Thread Yongbang Shi
From: Baihan Li Move the macros below their corresponding registers to make them more obvious. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi --- ChangeLog: v2 -> v3: - restructuring the header dp_reg.h, suggested by Dmitry Baryshkov. --- drivers/gpu/drm/hisilicon/hibmc/dp/dp_re

[PATCH v3 drm-dp 5/8] drm/hisilicon/hibmc: Getting connector info and EDID by using AUX channel

2025-02-21 Thread Yongbang Shi
: Yongbang Shi --- ChangeLog: v2 -> v3: - Capitalized EDID and AUX, suggested by Dmitry Baryshkov. v1 -> v2: - deleting type conversion, suggested by Dmitry Baryshkov. - deleting hibmc_dp_connector_get_modes() and using drm_connector_helper_get_modes(), suggested by Dmitry Bar

[PATCH v3 drm-dp 4/8] drm/hisilicon/hibmc: Refactor the member of drm_aux in struct hibmc_dp

2025-02-21 Thread Yongbang Shi
From: Baihan Li Because the drm_aux of struct hibmc_dp_dev's member is not easy to get in hibmc_drm_dp.c, we move the drm_aux to struct hibmc_dp. Then there are some adaptations and modifications to make this patch compile. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi --- Chan

[PATCH v3 drm-dp 6/8] drm/hisilicon/hibmc: Add colorbar-cfg feature and its debugfs file

2025-02-21 Thread Yongbang Shi
color bar register to display cat: print the color bar configuration Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi --- ChangeLog: v2 -> v3: - rewrite the commit log, suggested by Dmitry Baryshkov. - move colorbar debugfs entry to this patch, suggested by Dmitry Baryshkov. - cha

[PATCH v3 drm-dp 0/8] Add HPD, getting EDID, colorbar features in DP function

2025-02-21 Thread Yongbang Shi
From: Baihan Li To support DP HPD, edid printing, and colorbar display features based on the Hisislcon DP devices. --- ChangeLog: v2 -> v3: - restructuring the header p_reg.h, suggested by Dmitry Baryshkov. - add commit log about dp serdes, suggested by Dmitry Baryshkov. - return value in

Re: [PATCH v2 drm-dp 6/7] drm/hisilicon/hibmc: Add drm debugfs functions

2025-02-20 Thread Yongbang Shi
On Mon, Feb 10, 2025 at 10:49:58PM +0800, Yongbang Shi wrote: From: Baihan Li We use the previous two patches as our debug functions and generate two files. "hibmc-dp" and "color-bar". hibmc-dp: read only, print the dp link status and dpcd version Please define a generic D

Re: [PATCH v2 drm-dp 6/7] drm/hisilicon/hibmc: Add drm debugfs functions

2025-02-18 Thread Yongbang Shi
On Mon, Feb 10, 2025 at 10:49:58PM +0800, Yongbang Shi wrote: From: Baihan Li We use the previous two patches as our debug functions and generate two files. "hibmc-dp" and "color-bar". hibmc-dp: read only, print the dp link status and dpcd version Please define a generic D

Re: [PATCH v2 drm-dp 4/7] drm/hisilicon/hibmc: Add colorbar-cfg: set color bar cfg

2025-02-18 Thread Yongbang Shi
On Mon, Feb 10, 2025 at 10:49:56PM +0800, Yongbang Shi wrote: From: Baihan Li This is a DP IP controller's feature. It can be used as a debug method which can check DP controller is working good. The colorbar displaying doesn't rely on other IPs work in the chip, like: GPU or DDR (vr

Re: [PATCH v2 drm-dp 2/7] drm/hisilicon/hibmc: Add dp serdes cfg in dp process

2025-02-18 Thread Yongbang Shi
On Mon, Feb 10, 2025 at 10:49:54PM +0800, Yongbang Shi wrote: From: Baihan Li Add dp serdes cfg in link training process, and related adapting and modificating. We change some init values about training, Imperative language, please. Use 'change', not 'we change'. becaus

  1   2   >