[PATCH] drm/vmwgfx: make vmw_pt_sys_placement static

2022-02-23 Thread Wambui Karuga
Converts the variable vmw_pt_sys_placement to static to fix the following Sparse warning: warning: symbol 'vmw_pt_sys_placement' was not declared. Should it be static? Signed-off-by: Wambui Karuga --- drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c | 2 +- 1 file changed, 1 insertion(+),

[RFC PATCH 1/3] drm/debugfs: create debugfs files during drm_dev_register().

2020-05-14 Thread Wambui Karuga
by functions. Each drm_simple_info_entry is added to the new struct drm_device->debugfs_list for file requests. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/drm_debugfs.c | 59 --- drivers/gpu/drm/drm_drv.c | 2 ++ include/drm/drm_debugfs.h |

[RFC PATCH 0/3] drm: introduce new method of creating debugfs files.

2020-05-14 Thread Wambui Karuga
rrent progress of this series. Thanks, wambui karuga Wambui Karuga (3): drm/debugfs: create debugfs files during drm_dev_register(). drm/vc4: use new debugfs functions for file creation. drm: use new debugfs functions for various files. drivers/gpu/drm/drm_atomic.c | 11 +++--- driver

[RFC PATCH 3/3] drm: use new debugfs functions for various files.

2020-05-14 Thread Wambui Karuga
Replace the use of drm_debugfs_create_files with the new drm_debugfs_add_files() to create various drm core debugfs files. DRM debugfs files are also represented using the new drm_simple_info struct for use with the new functions. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/drm_atomic.c

[RFC PATCH 2/3] drm/vc4: use new debugfs functions for file creation.

2020-05-14 Thread Wambui Karuga
at drm_dev_register() time on each minor. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/vc4/vc4_bo.c | 4 ++-- drivers/gpu/drm/vc4/vc4_debugfs.c | 38 +++ drivers/gpu/drm/vc4/vc4_hdmi.c| 4 ++-- drivers/gpu/drm/vc4/vc4_hvs.c | 4 ++-- drivers/gpu/drm/vc4/vc4_v3

Re: [RFC PATCH 1/3] drm/debugfs: create debugfs files during drm_dev_register().

2020-05-14 Thread Wambui Karuga
On Wed, 13 May 2020, Thomas Zimmermann wrote: Hi Am 13.05.20 um 13:41 schrieb Wambui Karuga: Introduce the ability to track requests for the addition of drm debugfs files at any time and have them added all at once during drm_dev_register(). Drivers can add drm debugfs file requests to a

[PATCH] drm/vram-helper: remove unneeded #if defined/endif guards.

2020-03-24 Thread Wambui Karuga
Remove unneeded #if/#endif guards for checking whether the CONFIG_DEBUG_FS option is set or not. If the option is not set, the compiler optimizes the functions making the guards unnecessary. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/drm_gem_vram_helper.c | 4 1 file changed, 4

Re: [PATCH v2 10/17] drm/vram-helper: make drm_vram_mm_debugfs_init() return 0

2020-03-20 Thread Wambui Karuga
, 2020 at 5:03 PM Wambui Karuga wrote: On Wed, 18 Mar 2020, Daniel Vetter wrote: On Tue, Mar 10, 2020 at 04:31:14PM +0300, Wambui Karuga wrote: Since 987d65d01356 (drm: debugfs: make drm_debugfs_create_files() never fail), drm_debugfs_create_files() never fails and should return void

Re: [PATCH v2 10/17] drm/vram-helper: make drm_vram_mm_debugfs_init() return 0

2020-03-19 Thread Wambui Karuga
On Wed, 18 Mar 2020, Daniel Vetter wrote: On Tue, Mar 10, 2020 at 04:31:14PM +0300, Wambui Karuga wrote: Since 987d65d01356 (drm: debugfs: make drm_debugfs_create_files() never fail), drm_debugfs_create_files() never fails and should return void. Therefore, remove its use as the return

Re: [PATCH 10/21] drm/tegra: remove checks for debugfs functions return value

2020-03-12 Thread Wambui Karuga
Hey Thierry, On Wed, 11 Mar 2020, Thierry Reding wrote: On Thu, Feb 27, 2020 at 03:02:21PM +0300, Wambui Karuga wrote: Since 987d65d01356 (drm: debugfs: make drm_debugfs_create_files() never fail) there is no need to check the return value of drm_debugfs_create_files(). Therefore, remove the

[PATCH v2 15/17] drm: make various debugfs_init() functions return 0

2020-03-10 Thread Wambui Karuga
debugfs_init() functions to return 0 instead of void to avoid build breakage. References: https://lists.freedesktop.org/archives/dri-devel/2020-February/257183.html Signed-off-by: Wambui Karuga --- drivers/gpu/drm/drm_atomic.c | 7 --- drivers/gpu/drm/drm_client.c | 8

[PATCH v2 06/17] drm/arm: make hdlcd_debugfs_init() return 0

2020-03-10 Thread Wambui Karuga
() return 0 instead of void to ensure that each patch compiles individually. References: https://lists.freedesktop.org/archives/dri-devel/2020-February/257183.html Signed-off-by: Wambui Karuga --- drivers/gpu/drm/arm/hdlcd_drv.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

[PATCH v2 17/17] drm: convert .debugfs_init() hook to return void.

2020-03-10 Thread Wambui Karuga
/archives/dri-devel/2020-February/257183.html Signed-off-by: Wambui Karuga --- drivers/gpu/drm/arc/arcpgu_drv.c | 3 +-- drivers/gpu/drm/arm/hdlcd_drv.c | 3 +-- drivers/gpu/drm/arm/malidp_drv.c | 3 +-- drivers/gpu/drm/drm_atomic.c | 3 +-- drivers/gpu/drm

[PATCH v2 10/17] drm/vram-helper: make drm_vram_mm_debugfs_init() return 0

2020-03-10 Thread Wambui Karuga
() return 0 instead of void to avoid introducing build issues and build breakage. References: https://lists.freedesktop.org/archives/dri-devel/2020-February/257183.html Signed-off-by: Wambui Karuga Acked-by: Thomas Zimmermann --- drivers/gpu/drm/drm_gem_vram_helper.c | 10 -- 1 file changed

[PATCH v2 01/17] drm/tegra: remove checks for debugfs functions return value

2020-03-10 Thread Wambui Karuga
and have them return 0 directly. v2: remove conversion of tegra_debugfs_init() to void to avoid build breakage. References: https://lists.freedesktop.org/archives/dri-devel/2020-February/257183.html Signed-off-by: Wambui Karuga --- drivers/gpu/drm/tegra/dc.c | 11 +-- drivers/gpu/drm

[PATCH v2 04/17] drm/vc4: remove check of return value of drm_debugfs functions

2020-03-10 Thread Wambui Karuga
vc4_debugfs_init() to void to enable individual compilation and avoid build issues and breakage. References: https://lists.freedesktop.org/archives/dri-devel/2020-February/257183.html Signed-off-by: Wambui Karuga --- drivers/gpu/drm/vc4/vc4_debugfs.c | 7 ++- 1 file changed, 2 insertions

[PATCH v2 13/17] drm/omap: remove checks for return value of drm_debugfs functions

2020-03-10 Thread Wambui Karuga
: Wambui Karuga --- drivers/gpu/drm/omapdrm/omap_debugfs.c | 27 +++--- 1 file changed, 7 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/omap_debugfs.c b/drivers/gpu/drm/omapdrm/omap_debugfs.c index 34dfb33145b4..ed63dcced79a 100644 --- a/drivers/gpu/drm/omapdrm

[PATCH v2 02/17] drm/tilcdc: remove check for return value of debugfs functions.

2020-03-10 Thread Wambui Karuga
are not used after the changes. v2: remove conversion of tilcdc_debugfs_init() to void to avoid build breakage and enable individual compilation. References: https://lists.freedesktop.org/archives/dri-devel/2020-February/257183.html Signed-off-by: Wambui Karuga --- drivers/gpu/drm/tilcdc

[PATCH v2 12/17] drm/pl111: make pl111_debugfs_init return 0

2020-03-10 Thread Wambui Karuga
avoid build breakage for individual compilation. References: https://lists.freedesktop.org/archives/dri-devel/2020-February/257183.html Signed-off-by: Wambui Karuga --- drivers/gpu/drm/pl111/pl111_debugfs.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm

[PATCH v2 08/17] drm/msm: remove checks for return value of drm_debugfs_create_files()

2020-03-10 Thread Wambui Karuga
directly. v2: have debug functions return 0 instead of void to avoid build breakage and ensure standalone compilation. References: https://lists.freedesktop.org/archives/dri-devel/2020-February/257183.html Signed-off-by: Wambui Karuga --- drivers/gpu/drm/msm/adreno/a5xx_debugfs.c | 12

[PATCH v2 03/17] drm/v3d: make v3d_debugfs_init() return 0

2020-03-10 Thread Wambui Karuga
v3d_debugfs_init() to void to avoid build breakage and enable individual compilation. References: https://lists.freedesktop.org/archives/dri-devel/2020-February/257183.html Signed-off-by: Wambui Karuga --- drivers/gpu/drm/v3d/v3d_debugfs.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions

[PATCH v2 14/17] drm/i915: have *_debugfs_init() functions return void.

2020-03-10 Thread Wambui Karuga
intel_display_debugfs_register() stub to return void too. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/i915/display/intel_display_debugfs.c | 8 drivers/gpu/drm/i915/display/intel_display_debugfs.h | 4 ++-- drivers/gpu/drm/i915/i915_debugfs.c | 8 drivers/gpu/drm/i915/i915_debugfs.h

[PATCH v2 16/17] drm/debugfs: remove checks for return value of drm_debugfs functions.

2020-03-10 Thread Wambui Karuga
drm_debugfs_create_files() to return void. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/drm_debugfs.c | 33 +++-- include/drm/drm_debugfs.h | 16 +++- 2 files changed, 14 insertions(+), 35 deletions(-) diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers

[PATCH v2 07/17] drm/etnaviv: remove check for return value of drm_debugfs_create_files()

2020-03-10 Thread Wambui Karuga
: have etnaviv_debugfs_init() return 0 instead of void to ensure individual compilation and avoid build breakage. References: https://lists.freedesktop.org/archives/dri-devel/2020-February/257183.html Signed-off-by: Wambui Karuga --- drivers/gpu/drm/etnaviv/etnaviv_drv.c | 16 1

[PATCH v2 00/17] drm: subsytem-wide debugfs functions refactor

2020-03-10 Thread Wambui Karuga
have been converted to have debugfs functions return 0 instead of void to prevent breaking individual driver builds. The last patch then converts the .debugfs_hook() and its users across all drivers to return void. Wambui Karuga (17): drm/tegra: remove checks for debugfs functions return value

[PATCH v2 09/17] drm/sti: remove use of drm_debugfs functions as return values

2020-03-10 Thread Wambui Karuga
: Wambui Karuga --- drivers/gpu/drm/sti/sti_compositor.c | 6 ++ drivers/gpu/drm/sti/sti_compositor.h | 4 ++-- drivers/gpu/drm/sti/sti_crtc.c | 2 +- drivers/gpu/drm/sti/sti_cursor.c | 14 -- drivers/gpu/drm/sti/sti_drv.c| 13 +++-- drivers/gpu/drm/sti

[PATCH v2 05/17] drm/arc: make arcgpu_debugfs_init() return 0.

2020-03-10 Thread Wambui Karuga
return 0 instead of void to avoid breaking the build and ensure that this individual patch compiles properly. References: https://lists.freedesktop.org/archives/dri-devel/2020-February/257183.html Signed-off-by: Wambui Karuga --- drivers/gpu/drm/arc/arcpgu_drv.c | 6 -- 1 file changed, 4

[PATCH v2 11/17] drm/nouveau: make nouveau_drm_debugfs_init() return 0

2020-03-10 Thread Wambui Karuga
function return 0 directly. v2: have nouveau_drm_debugfs_init() return 0 instead of void so as not to introduce any build warnings to enable individual patch compilation. References: https://lists.freedesktop.org/archives/dri-devel/2020-February/257183.html Signed-off-by: Wambui Karuga --- drivers/gpu

[PATCH 16/21] drm/i915: make *_debugfs_register() functions return void.

2020-02-27 Thread Wambui Karuga
-off-by: Wambui Karuga --- drivers/gpu/drm/i915/display/intel_display_debugfs.c | 8 drivers/gpu/drm/i915/display/intel_display_debugfs.h | 4 ++-- drivers/gpu/drm/i915/i915_debugfs.c | 8 drivers/gpu/drm/i915/i915_debugfs.h | 4 ++-- 4 files

[PATCH 10/21] drm/tegra: remove checks for debugfs functions return value

2020-02-27 Thread Wambui Karuga
and have them return 0 directly. This change also includes removing the use of drm_debugfs_create_files as a return value in tegra_debugfs_init() and have the function declared as void. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/tegra/dc.c | 11 +-- drivers/gpu/drm/tegra/drm.c

[PATCH 06/21] drm/arc: make arcpgu_debugfs_init return void

2020-02-27 Thread Wambui Karuga
Since commit 987d65d01356 (drm: debugfs: make drm_debugfs_create_files() never fail), drm_debugfs_create_files never fails and should return void. Therefore, remove its use as the return value of arcpgu_debugfs_init and have the latter function also return void. Signed-off-by: Wambui Karuga

[PATCH 15/21] drm/sti: remove use drm_debugfs functions as return value

2020-02-27 Thread Wambui Karuga
changed to use a void return value. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/sti/sti_cursor.c | 14 -- drivers/gpu/drm/sti/sti_drv.c| 16 drivers/gpu/drm/sti/sti_dvo.c| 13 + drivers/gpu/drm/sti/sti_gdp.c| 7 --- drivers/gpu/drm/sti

[PATCH 14/21] drm/pl111: make pl111_debugfs_init return void

2020-02-27 Thread Wambui Karuga
Since 987d65d01356 (drm: debugfs: make drm_debugfs_create_files() never fail) drm_debugfs_create_files() should return void. Therefore, remove its use as the return value in pl111_debugfs_init, and have the function declared as void instead. Signed-off-by: Wambui Karuga --- drivers/gpu/drm

[PATCH 09/21] drm/nouveau: remove checks for return value of debugfs functions

2020-02-27 Thread Wambui Karuga
enable nouveau_drm_debugfs_init() to be declared as void. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/nouveau/nouveau_debugfs.c | 26 +-- drivers/gpu/drm/nouveau/nouveau_debugfs.h | 5 ++--- 2 files changed, 12 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 20/21] drm/qxl: have debugfs functions return void.

2020-02-27 Thread Wambui Karuga
can be converted to return void as a result of the changes to qxl_debugfs_init(). Signed-off-by: Wambui Karuga --- drivers/gpu/drm/qxl/qxl_debugfs.c | 21 +++-- drivers/gpu/drm/qxl/qxl_drv.h | 13 + drivers/gpu/drm/qxl/qxl_ttm.c | 6 ++ 3 files changed

[PATCH 01/21] drm/debugfs: remove checks for return value of drm_debugfs functions.

2020-02-27 Thread Wambui Karuga
drm_debugfs_create_files() to return void. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/drm_debugfs.c | 49 --- include/drm/drm_debugfs.h | 6 ++--- 2 files changed, 14 insertions(+), 41 deletions(-) diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm

[PATCH 12/21] drm/msm: remove checks for return value of drm_debugfs functions.

2020-02-27 Thread Wambui Karuga
various debugfs_init() functions to return void. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/msm/adreno/a5xx_debugfs.c | 18 +- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 14 +++--- drivers/gpu/drm/msm/msm_debugfs.c | 21 ++--- drivers/gpu/drm

Re: [PATCH 17/21] drm/tilcdc: remove check for return value of debugfs functions.

2020-02-27 Thread Wambui Karuga
On Thu, 27 Feb 2020, Jyri Sarha wrote: On 27/02/2020 14:02, Wambui Karuga wrote: Since 987d65d01356 (drm: debugfs: make drm_debugfs_create_files() never fail), drm_debugfs_create_files() never fails. Therefore, remove the check and error handling of the return value of

[PATCH 18/21] drm/virtio: make virtio_gpu_debugfs() return void.

2020-02-27 Thread Wambui Karuga
Since 987d65d01356 (drm: debugfs: make drm_debugfs_create_files() never fail), drm_debugfs_create_files() never fails and should return void. Therefore, remove its use as the return value of virtio_gpu_debugfs() and have the latter function return void. Signed-off-by: Wambui Karuga --- drivers

[PATCH 11/21] drm/v3d: make v3d_debugfs_init return void

2020-02-27 Thread Wambui Karuga
Since commit 987d65d01356 (drm: debugfs: make drm_debugfs_create_files() never fail), drm_debugfs_create_files() never fails and should return void. Therefore, remove its use as the return value of v3d_debugfs_init and have the function return void instead. Signed-off-by: Wambui Karuga

Re: [PATCH 02/21] drm: convert the drm_driver.debugfs_init() hook to return void.

2020-02-27 Thread Wambui Karuga
On Thu, 27 Feb 2020, Greg KH wrote: On Thu, Feb 27, 2020 at 03:02:13PM +0300, Wambui Karuga wrote: As a result of commit 987d65d01356 (drm: debugfs: make drm_debugfs_create_files() never fail) and changes to various debugfs functions in drm/core and across various drivers, there is no need

[PATCH 03/21] drm: convert drm_debugfs functions to return void

2020-02-27 Thread Wambui Karuga
: Wambui Karuga --- drivers/gpu/drm/drm_atomic.c| 8 drivers/gpu/drm/drm_client.c| 8 drivers/gpu/drm/drm_crtc_internal.h | 2 +- drivers/gpu/drm/drm_framebuffer.c | 8 drivers/gpu/drm/drm_internal.h | 2 +- include/drm/drm_client.h| 2

[PATCH 00/21] drm: subsytem-wide debugfs functions refactor

2020-02-27 Thread Wambui Karuga
the left over error handling and checks for its return value across drm drivers. As a result of these changes, most drm_debugfs functions are converted to return void in this series. This also enables the drm_driver,debugfs_init() hook to be changed to return void. Wambui Karuga (21): drm

[PATCH 17/21] drm/tilcdc: remove check for return value of debugfs functions.

2020-02-27 Thread Wambui Karuga
are not used after the changes, and declare tilcdc_debugfs_init() as void. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc

[PATCH 13/21] drm/omapdrm: remove checks for return value of drm_debugfs functions.

2020-02-27 Thread Wambui Karuga
changing of omap_debugfs_init() to return void. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/omapdrm/omap_debugfs.c | 29 +++--- drivers/gpu/drm/omapdrm/omap_drv.h | 2 +- 2 files changed, 8 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/omapdrm

[PATCH 05/21] drm/vc4: remove check of return value of drm_debugfs functions

2020-02-27 Thread Wambui Karuga
vc4_debugfs_init() to be declared as void. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/vc4/vc4_debugfs.c | 11 +++ drivers/gpu/drm/vc4/vc4_drv.h | 2 +- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_debugfs.c b/drivers/gpu/drm/vc4

[PATCH 07/21] drm/arm: make hdlcd_debugfs_init() return void

2020-02-27 Thread Wambui Karuga
Since commit 987d65d01356 (drm: debugfs: make drm_debugfs_create_files() never fail), drm_debugfs_create_files() never fails, and should return void. Therefore, remove its use as a return value in hdlcd_debugfs_init and have the latter function return void. Signed-off-by: Wambui Karuga

[PATCH 02/21] drm: convert the drm_driver.debugfs_init() hook to return void.

2020-02-27 Thread Wambui Karuga
-by: Wambui Karuga --- include/drm/drm_drv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h index 97109df5beac..c6ae888c672b 100644 --- a/include/drm/drm_drv.h +++ b/include/drm/drm_drv.h @@ -323,7 +323,7 @@ struct drm_driver

[PATCH 21/21] drm/arm: have malidp_debufs_init() return void

2020-02-27 Thread Wambui Karuga
As there's no need for the return value in malidp_debugfs_init() after the conversion of the drm_driver.debugfs_init() hook, (drm: convert the .debugs_init() hook to return void), convert the malidp_debugfs_init() function to return void. Signed-off-by: Wambui Karuga --- drivers/gpu/dr

[PATCH 19/21] drm/mipi_dbi: make midi_dbi_debugfs_init() return void.

2020-02-27 Thread Wambui Karuga
As midi_dbi_debugfs_init() never fails and does not return anything other than zero, declare its return value as void. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/drm_mipi_dbi.c | 6 +- include/drm/drm_mipi_dbi.h | 2 +- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git

[PATCH 08/21] drm/etnaviv: remove check for return value of drm_debugfs function

2020-02-27 Thread Wambui Karuga
. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/etnaviv/etnaviv_drv.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c index 6b43c1c94e8f..a39735316ca5 100644 --- a/drivers/gpu

[PATCH 04/21] drm/vram-helper: make drm_vram_mm_debugfs_init() return void

2020-02-27 Thread Wambui Karuga
Since 987d65d01356 (drm: debugfs: make drm_debugfs_create_files() never fail), drm_debugfs_create_files() never fails and should return void. Therefore, remove its use as the return value of drm_vram_mm_debugfs_init(), and have the function declared as void instead. Signed-off-by: Wambui Karuga

[PATCH] drm/i915: make i915_debugfs_register return void.

2020-02-19 Thread Wambui Karuga
As drm_debugfs_create_files should return void, remove its use as the return value of i915_debugfs_register and have i915_debugfs_register return void. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/i915/i915_debugfs.c | 8 drivers/gpu/drm/i915/i915_debugfs.h | 4 ++-- 2 files

[PATCH] drm/arm: make hdlcd_debugfs_init return 0

2020-02-19 Thread Wambui Karuga
As drm_debugfs_create_files should return void, remove its use as a return value in hdlcd_debugfs_init and have the latter function return 0 directly. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/arm/hdlcd_drv.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a

[PATCH 2/2] drm: convert drm_debugfs functions to return void

2020-02-19 Thread Wambui Karuga
As drm_debug_create_files will be converted to return void, drop return value from various drm_debugfs functions that return drm_debug_create_files and convert the functions to return void. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/drm_atomic.c| 8 drivers/gpu/drm

[PATCH] drm/vram-helper: make drm_vram_mm_debugfs_init return 0

2020-02-19 Thread Wambui Karuga
As drm_debugfs_create_files() should return 0, remove its use as the return value of drm_vram_mm_debugfs_init(), and have the function return 0 directly. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/drm_gem_vram_helper.c | 13 + 1 file changed, 5 insertions(+), 8 deletions

[PATCH] drm/vc4: remove check of return value of drm_debugfs functions

2020-02-19 Thread Wambui Karuga
Remove unnecessary check and error handling for the return value of drm_debugfs_create_files in vc4_debugfs_init. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/vc4/vc4_debugfs.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_debugfs.c b

Re: [PATCH] drm/etnaviv: remove check for return value of drm_debugfs function

2020-02-19 Thread Wambui Karuga
On Tue, 18 Feb 2020, Lucas Stach wrote: On Di, 2020-02-18 at 20:28 +0300, Wambui Karuga wrote: As there is no need to check the return value if drm_debugfs_create_files, And here is where the commit message skips a very important information: Since 987d65d01356 (drm: debugfs: make

[PATCH] drm/v3d: make v3d_debugfs_init return 0

2020-02-19 Thread Wambui Karuga
As drm_debugfs_create_files should return void, remove its use as the return value of v3d_debugfs_init and have the function return 0 directly. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/v3d/v3d_debugfs.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH] drm/etnaviv: remove check for return value of drm_debugfs function

2020-02-19 Thread Wambui Karuga
As there is no need to check the return value if drm_debugfs_create_files, remove the check and error handling in etnaviv_debugfs_init and have the function return 0 directly. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/etnaviv/etnaviv_drv.c | 16 1 file changed, 4

[PATCH 1/2] drm/debugfs: remove checks for return value of drm_debugfs functions.

2020-02-19 Thread Wambui Karuga
As there is no need to check the return value of drm_debugfs_create_files, remove unnecessary checks and error handling statement blocks. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/drm_debugfs.c | 28 +--- 1 file changed, 5 insertions(+), 23 deletions(-) diff

[PATCH] drm/arc: make arcpgu_debugfs_init return 0

2020-02-19 Thread Wambui Karuga
As drm_debugfs_create_files should return void, remove its use as the return value of arcpgu_debugfs_init and have the latter function return 0 directly. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/arc/arcpgu_drv.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a

[PATCH] drm/tilcdc: remove check for return value of debugfs functions.

2020-02-19 Thread Wambui Karuga
Remove the check and error handling of the return value of drm_debugfs_create_files as it is not needed in tilcdc_debugfs_init. Also remove local variables that are not used after the changes. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 15 --- 1 file

[PATCH] drm/nouveau: remove checks for return value of debugfs functions

2020-02-19 Thread Wambui Karuga
As there is no need to check for the return value of debugfs_create_file and drm_debugfs_create_files, remove unnecessary checks and error handling in nouveau_drm_debugfs_init. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/nouveau/nouveau_debugfs.c | 20 1 file changed

[PATCH] drm/tegra: remove checks for debugfs functions return value

2020-02-19 Thread Wambui Karuga
Remove the return checks and error handling of the drm_debugfs_create_files function from various debugfs init functions in drm/tegra and have them return 0 directly. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/tegra/dc.c | 11 +-- drivers/gpu/drm/tegra/drm.c | 7

[PATCH v2 04/12] drm/i915/color: conversion to drm_device based logging macros.

2020-02-06 Thread Wambui Karuga
Initial conversion of the straightforward printk based logging macros to the struct drm_device based logging macros in i915/display/intel_color.c. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/i915/display/intel_color.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a

[PATCH v2 10/12] drm/i915/dsi_vbt: convert to drm_device based logging macros.

2020-02-06 Thread Wambui Karuga
to drm_dbg(). References: https://lists.freedesktop.org/archives/dri-devel/2020-January/253381.html Signed-off-by: Wambui Karuga --- drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 162 +++ 1 file changed, 99 insertions(+), 63 deletions(-) diff --git a/drivers/gpu/drm/i915

[PATCH v2 07/12] drm/i915/dpll_mgr: convert to drm_device based logging macros.

2020-02-06 Thread Wambui Karuga
converts DRM_DEBUG_DRIVER to drm_dbg(). References: https://lists.freedesktop.org/archives/dri-devel/2020-January/253381.html Signed-off-by: Wambui Karuga --- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 254 ++ 1 file changed, 142 insertions(+), 112 deletions(-) diff --git a

[PATCH v2 03/12] drm/i915/atomic: conversion to drm_device based logging macros.

2020-02-06 Thread Wambui Karuga
rm, ...) | -DRM_DEBUG( +drm_dbg(&T->drm, ...) | -DRM_DEBUG_KMS( +drm_dbg_kms(&T->drm, ...) | -DRM_DEBUG_DRIVER( +drm_dbg(&T->drm, ...) | -DRM_DEBUG_ATOMIC( +drm_dbg_atomic(&T->drm, ...) ) ...+> } Checkpatch warnings were fixed manually. Signed-off-by: Wambui Karuga ---

[PATCH v2 05/12] drm/i915/crt: automatic conversion to drm_device based logging macros.

2020-02-06 Thread Wambui Karuga
..) | -DRM_DEBUG( +drm_dbg(&T->drm, ...) | -DRM_DEBUG_KMS( +drm_dbg_kms(&T->drm, ...) | -DRM_DEBUG_DRIVER( +drm_dbg(&T->drm, ...) | -DRM_DEBUG_ATOMIC( +drm_dbg_atomic(&T->drm, ...) ) ...+> } Checkpatch warnings were addressed manually. Signed-off-by: Wambui Karuga --- drivers/

[PATCH v2 02/12] drm/i915/dp_link_training: convert to drm_device based logging macros.

2020-02-06 Thread Wambui Karuga
Converts various instances of the printk based drm logging macros to the struct drm_device based logging macros in i915/display/intel_dp_link_training.c. This also involves extracting the drm_i915_private device pointer from the intel_dp type to use in the various macros. Signed-off-by: Wambui

[PATCH v2 00/12] drm/i915/display: convert to drm_device based logging macros.

2020-02-06 Thread Wambui Karuga
This patchset continues the conversion of the printk based drm logging macros in drm/i915 to use the struct drm_device based logging macros. This series was done both using coccinelle and manually. v2: rebase onto drm-tip to fix conflicts with new changes in drm/i915. Wambui Karuga (12): drm

[PATCH v2 06/12] drm/i915/dp_aux_backlight: convert to drm_device based logging macros.

2020-02-06 Thread Wambui Karuga
(). References: https://lists.freedesktop.org/archives/dri-devel/2020-January/253381.html Signed-off-by: Wambui Karuga --- .../drm/i915/display/intel_dp_aux_backlight.c | 72 --- 1 file changed, 45 insertions(+), 27 deletions(-) diff --git a/drivers/gpu/drm/i915/display

[PATCH v2 12/12] drm/i915/dpio_phy: convert to drm_device based logging macros.

2020-02-06 Thread Wambui Karuga
rnings were fixed manually. References: https://lists.freedesktop.org/archives/dri-devel/2020-January/253381.html Signed-off-by: Wambui Karuga --- drivers/gpu/drm/i915/display/intel_dpio_phy.c | 28 +++ 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/dri

[PATCH v2 09/12] drm/i915/dp_mst: convert to drm_device based logging macros.

2020-02-06 Thread Wambui Karuga
Conversion of instances of the printk based drm logging macros to the struct drm_device based logging macros in i915/display/intel_dp_mst.c. This also involves extracting the drm_i915_private device pointer from various intel types to use in the macros. Signed-off-by: Wambui Karuga --- drivers

[PATCH v2 08/12] drm/i915/combo_phy: convert to struct drm_device logging macros.

2020-02-06 Thread Wambui Karuga
eckpatch warnings were addressed manually. References: https://lists.freedesktop.org/archives/dri-devel/2020-January/253381.html Signed-off-by: Wambui Karuga --- .../gpu/drm/i915/display/intel_combo_phy.c| 23 +++ 1 file changed, 14 insertions(+), 9 deletions(-) diff

[PATCH v2 11/12] drm/i915/hdmi: convert to struct drm_device based logging macros.

2020-02-06 Thread Wambui Karuga
DRM_DEBUG_DRIVER() to drm_dbg(). References: https://lists.freedesktop.org/archives/dri-devel/2020-January/253381.html Signed-off-by: Wambui Karuga --- drivers/gpu/drm/i915/display/intel_hdmi.c | 193 ++ 1 file changed, 128 insertions(+), 65 deletions(-) diff --git a/drivers/gpu

[PATCH v2 01/12] drm/i915/dp: convert to struct drm_device based logging macros.

2020-02-06 Thread Wambui Karuga
Converts various instances of the printk based drm logging macros to the struct drm_device based logging macros in i915/display/intel_dp.c. This also involves extracting the struct drm_i915_private device pointer from various intel types to be used in the macros. Signed-off-by: Wambui Karuga

[PATCH 12/12] drm/i915/panel: automatic conversion to drm_device based logging macros.

2020-01-31 Thread Wambui Karuga
drm, ...) | -DRM_DEBUG( +drm_dbg(&T->drm, ...) | -DRM_DEBUG_DRIVER( +drm_dbg(&T->drm, ...) | -DRM_DEBUG_KMS( +drm_dbg_kms(&T->drm, ...) | -DRM_DEBUG_ATOMIC( +drm_dbg_atomic(&T->drm, ...) ) ...+> } Checkpatch warnings were addressed manually. Signed-off-by: Wambui Karu

[PATCH 01/12] drm/i915/vlv_dsi_pll: conversion to struct drm_device logging macros.

2020-01-31 Thread Wambui Karuga
t;drm, ...) | -DRM_DEBUG_DRIVER( +drm_dbg(&T->drm, ...) | -DRM_DEBUG_KMS( +drm_dbg_kms(&T->drm, ...) | -DRM_DEBUG_ATOMIC( +drm_dbg_atomic(&T->drm, ...) ) ...+> } Checkpatch warnings were fixed manually. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/i915/display/vlv_dsi_

[PATCH 05/12] drm/i915/tv: automatic conversion to drm_device based logging macros.

2020-01-31 Thread Wambui Karuga
_dbg(&T->drm, ...) | -DRM_DEBUG_DRIVER( +drm_dbg(&T->drm, ...) | -DRM_DEBUG_KMS( +drm_dbg_kms(&T->drm, ...) | -DRM_DEBUG_ATOMIC( +drm_dbg_atomic(&T->drm, ...) ) ...+> } Checkpatch warnings were fixed manually. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/i915/di

[PATCH 08/12] drm/i915/sdvo: automatic conversion to drm_device based logging macros.

2020-01-31 Thread Wambui Karuga
n(&T->drm, ...) | -DRM_DEBUG( +drm_dbg(&T->drm, ...) | -DRM_DEBUG_DRIVER( +drm_dbg(&T->drm, ...) | -DRM_DEBUG_KMS( +drm_dbg_kms(&T->drm, ...) | -DRM_DEBUG_ATOMIC( +drm_dbg_atomic(&T->drm, ...) ) ...+> } Checkpatch warnings were fixed manually. Signed-off-by:

[PATCH 00/12] drm/i915/display: conversion to drm_device based logging macros

2020-01-31 Thread Wambui Karuga
drm, ...) | -DRM_WARN( +drm_warn(&T->drm, ...) | -DRM_DEBUG( +drm_dbg(&T->drm, ...) | -DRM_DEBUG_DRIVER( +drm_dbg(&T->drm, ...) | -DRM_DEBUG_KMS( +drm_dbg_kms(&T->drm, ...) | -DRM_DEBUG_ATOMIC( +drm_dbg_atomic(&T->drm, ...) ) ...+> } Wambui Karuga (12): drm/

[PATCH 10/12] drm/i915/psr: automatic conversion to drm_device based logging macros.

2020-01-31 Thread Wambui Karuga
...) | -DRM_DEBUG( +drm_dbg(&T->drm, ...) | -DRM_DEBUG_DRIVER( +drm_dbg(&T->drm, ...) | -DRM_DEBUG_KMS( +drm_dbg_kms(&T->drm, ...) | -DRM_DEBUG_ATOMIC( +drm_dbg_atomic(&T->drm, ...) ) ...+> } Checkpatch warnings were addressed manually. Signed-off-by: Wambui Karuga --- drivers/

[PATCH 04/12] drm/i915/vdsc: convert to struct drm_device based logging macros.

2020-01-31 Thread Wambui Karuga
...) | -DRM_DEBUG( +drm_dbg(&T->drm, ...) | -DRM_DEBUG_DRIVER( +drm_dbg(&T->drm, ...) | -DRM_DEBUG_KMS( +drm_dbg_kms(&T->drm, ...) | -DRM_DEBUG_ATOMIC( +drm_dbg_atomic(&T->drm, ...) ) ...+> } Checkpatch warnings were fixed manually. Signed-off-by: Wambui Karuga ---

[PATCH 02/12] drm/i915/vlv_dsi: conversion to drm_device based logging macros.

2020-01-31 Thread Wambui Karuga
...) | -DRM_DEBUG( +drm_dbg(&T->drm, ...) | -DRM_DEBUG_DRIVER( +drm_dbg(&T->drm, ...) | -DRM_DEBUG_KMS( +drm_dbg_kms(&T->drm, ...) | -DRM_DEBUG_ATOMIC( +drm_dbg_atomic(&T->drm, ...) ) ...+> } Checkpatch warnings were addressed manually. Signed-off-by: Wambui Karuga --- drivers/

[PATCH 07/12] drm/i915/sprite: automatic conversion to drm_device based logging macros

2020-01-31 Thread Wambui Karuga
n(&T->drm, ...) | -DRM_DEBUG( +drm_dbg(&T->drm, ...) | -DRM_DEBUG_DRIVER( +drm_dbg(&T->drm, ...) | -DRM_DEBUG_KMS( +drm_dbg_kms(&T->drm, ...) | -DRM_DEBUG_ATOMIC( +drm_dbg_atomic(&T->drm, ...) ) ...+> } Checkpatch warnings were fixed manually. Signed-off-by:

[PATCH 09/12] drm/i915/quirks: automatic conversion to drm_device based logging macros.

2020-01-31 Thread Wambui Karuga
...) | -DRM_DEBUG( +drm_dbg(&T->drm, ...) | -DRM_DEBUG_DRIVER( +drm_dbg(&T->drm, ...) | -DRM_DEBUG_KMS( +drm_dbg_kms(&T->drm, ...) | -DRM_DEBUG_ATOMIC( +drm_dbg_atomic(&T->drm, ...) ) ...+> } Checkpatch warnings were fixed manually. Signed-off-by: Wambui Karuga --- drivers/gpu/

[PATCH 11/12] drm/i915/pipe_crc: automatic conversion to drm_device based logging macros.

2020-01-31 Thread Wambui Karuga
drm, ...) | -DRM_DEBUG( +drm_dbg(&T->drm, ...) | -DRM_DEBUG_DRIVER( +drm_dbg(&T->drm, ...) | -DRM_DEBUG_KMS( +drm_dbg_kms(&T->drm, ...) | -DRM_DEBUG_ATOMIC( +drm_dbg_atomic(&T->drm, ...) ) ...+> } Checkpatch warnings were addressed manually. Signed-off-by: Wambui Karuga

[PATCH 06/12] drm/i915/tc: automatic conversion to drm_device based logging macros.

2020-01-31 Thread Wambui Karuga
_dbg(&T->drm, ...) | -DRM_DEBUG_DRIVER( +drm_dbg(&T->drm, ...) | -DRM_DEBUG_KMS( +drm_dbg_kms(&T->drm, ...) | -DRM_DEBUG_ATOMIC( +drm_dbg_atomic(&T->drm, ...) ) ...+> } Checkpatch warnings were addressed manually. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/i

[PATCH 03/12] drm/i915/vga: conversion to drm_device based logging macros.

2020-01-31 Thread Wambui Karuga
_dbg(&T->drm, ...) | -DRM_DEBUG_DRIVER( +drm_dbg(&T->drm, ...) | -DRM_DEBUG_KMS( +drm_dbg_kms(&T->drm, ...) | -DRM_DEBUG_ATOMIC( +drm_dbg_atomic(&T->drm, ...) ) ...+> } Checkpatch warnings were addressed manually. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/i915/displ

[PATCH v2 2/6] drm/i915/ddi: convert to struct drm_device log macros.

2020-01-22 Thread Wambui Karuga
(&T->drm, ...) | -DRM_DEBUG_KMS( +drm_dbg_kms(&T->drm, ...) | -DRM_DEBUG_DRIVER( +drm_dbg(&T->drm, ...) | -DRM_DEBUG_ATOMIC( +drm_dbg_atomic(&T->drm, ...) ) ...+> } Checkpatch warnings were addressed manually. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/i915/di

[PATCH v2 4/6] drm/i915/dp: conversion to struct drm_device logging macros.

2020-01-22 Thread Wambui Karuga
_dbg_kms(&T->drm, ...) | -DRM_DEBUG_DRIVER( +drm_dbg(&T->drm, ...) | -DRM_DEBUG_ATOMIC( +drm_dbg_atomic(&T->drm, ...) ) ...+> } New checkpatch warnings were fixed manually. v2: fix merge conflict with new changes in file. Signed-off-by: Wambui Karuga --- drivers/gp

[PATCH v2 0/6] conversion to struct drm_device logging macros.

2020-01-22 Thread Wambui Karuga
This series continues the ongoing conversion to the new struct drm_device based logging macros for debug in i915. v2: address merge conflict in i915/display/intel_dp.c due to newer changes in file. Wambui Karuga (6): drm/i915/dsi: conversion to struct drm_device log macros drm/i915/ddi

[PATCH 1/2] drm/i915/gem: initial conversion to new logging macros using coccinelle

2020-01-22 Thread Wambui Karuga
warn(&T->drm, ...) | -DRM_DEBUG( +drm_dbg(&T->drm, ...) | -DRM_DEBUG_KMS( +drm_dbg_kms(&T->drm, ...) | -DRM_DEBUG_DRIVER( +drm_dbg(&T->drm, ...) | -DRM_DEBUG_ATOMIC( +drm_dbg_atomic(&T->drm, ...) ) ...+> } Checkpatch warnings were addressed manually. Signed-

[PATCH 2/2] drm/i915/gem: manual conversion to struct drm_device logging macros.

2020-01-22 Thread Wambui Karuga
Convert most of the remaining uses of the printk based logging macros to the new struct drm_device based logging macros in drm/i915/gem. This also involves extracting the struct drm_i915_private device from various types, and using it in the various macros. Signed-off-by: Wambui Karuga

[PATCH v2 3/6] drm/i915/power: convert to struct drm_device macros in display/intel_display_power.c

2020-01-22 Thread Wambui Karuga
..) | -DRM_DEBUG_KMS( +drm_dbg_kms(&T->drm, ...) | -DRM_DEBUG_DRIVER( +drm_dbg(&T->drm, ...) | -DRM_DEBUG_ATOMIC( +drm_dbg_atomic(&T->drm, ...) ) ...+> } Checkpatch warnings were fixed manually. Signed-off-by: Wambui Karuga --- .../drm/i915/display/intel_display_power.c| 177 ++

[PATCH v2 1/6] drm/i915/dsi: conversion to struct drm_device log macros.

2020-01-22 Thread Wambui Karuga
warn(&T->drm, ...) | -DRM_DEBUG( +drm_dbg(&T->drm, ...) | -DRM_DEBUG_KMS( +drm_dbg_kms(&T->drm, ...) | -DRM_DEBUG_DRIVER( +drm_dbg(&T->drm, ...) | -DRM_DEBUG_ATOMIC( +drm_dbg_atomic(&T->drm, ...) ) ...+> } New checkpatch warnings were fixed manually. Signed-off-by:

[PATCH v2 5/6] drm/i915/opregion: conversion to struct drm_device logging macros.

2020-01-22 Thread Wambui Karuga
..) | -DRM_DEBUG_KMS( +drm_dbg_kms(&T->drm, ...) | -DRM_DEBUG_DRIVER( +drm_dbg(&T->drm, ...) | -DRM_DEBUG_ATOMIC( +drm_dbg_atomic(&T->drm, ...) ) ...+> } Checkpatch warnings were addressed manually. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/i915/display/intel_opregion.c | 134 ++

[PATCH v2 6/6] drm/i915/hdcp: conversion to struct drm_device based logging macros.

2020-01-22 Thread Wambui Karuga
..) | -DRM_DEBUG( +drm_dbg(&T->drm, ...) | -DRM_DEBUG_KMS( +drm_dbg_kms(&T->drm, ...) | -DRM_DEBUG_DRIVER( +drm_dbg(&T->drm, ...) | -DRM_DEBUG_ATOMIC( +drm_dbg_atomic(&T->drm, ...) ) ...+> } New checkpatch warnings were addressed manually. Signed-off-by: Wambui Karuga ---

  1   2   >