Re: [PATCH 4/4] drm/panel: otm8009a: use new backlight api

2018-05-14 Thread Vincent ABRIOU
Hi Philippe, Reviewed-by: Vincent Abriou BR Vincent On 04/23/2018 04:10 PM, Philippe Cornu wrote: > Use the new backlight api. > > Signed-off-by: Philippe Cornu > --- > drivers/gpu/drm/panel/panel-orisetech-otm8009a.c | 26 > > 1 file changed

Re: [PATCH 3/4] drm/panel: otm8009a: no message if probe success

2018-05-14 Thread Vincent ABRIOU
Hi Philippe, Reviewed-by: Vincent Abriou BR Vincent On 04/23/2018 04:10 PM, Philippe Cornu wrote: > Remove the message in case of probe success. This comes from > a suggestion followed in the recent integration of the > raydium rm68200 panel. > > Signed-off-by:

Re: [PATCH 2/4] drm/panel: otm8009a: fix glitches by moving backlight enable to otm8009a_enable()

2018-05-14 Thread Vincent ABRIOU
Hi Philippe, Reviewed-by: Vincent Abriou BR Vincent On 04/23/2018 04:10 PM, Philippe Cornu wrote: > The backlight 1st update was in the otm8009a_prepare() function > for a bad reason: backlight was not working in video mode and the > otm8009a_prepare() is in command mode for the init

Re: [PATCH 1/4] drm/panel: otm8009a: fix backlight updates

2018-05-14 Thread Vincent ABRIOU
Hi Philippe, Reviewed-by: Vincent Abriou BR Vincent On 04/23/2018 04:10 PM, Philippe Cornu wrote: > Backlight updates was not working anymore since the good > implementation of the dsi lpm mode in the dsi host driver. > After a longer analysis, the backlight updates in dsi video >

Re: [PATCH] drm/stm: ltdc: add user update info in plane print state

2018-04-16 Thread Vincent ABRIOU
Hi Philippe, Reviewed-by: Vincent Abriou On 04/07/2018 11:35 PM, Philippe Cornu wrote: > This patch adds the user update information in > frames-per-second into the drm debugfs plane state. > > Signed-off-by: Philippe Cornu > --- > drivers/gpu/d

Re: [PATCH] drm/stm: move enable/disable_vblank to crtc

2018-04-16 Thread Vincent ABRIOU
Hi Philippe, Patch looks good to me. Reviewed-by: Vincent Abriou On 04/07/2018 11:29 PM, Philippe Cornu wrote: > enable/disable_vblank() functions at drm_driver level > are deprecated. Move them to the ltdc drm_crtc_funcs > structure. > > Signed-off-by: Philippe Cornu > -

Re: [PATCH] gpu: drm: sti: Adopt SPDX identifiers

2017-12-06 Thread Vincent ABRIOU
Benjamin, The patch is fine for me: Acked-by: Vincent Abriou Vincent On 12/06/2017 12:29 PM, Benjamin Gaignard wrote: > Add SPDX identifiers to files under sti directory > > Signed-off-by: Benjamin Gaignard > --- > drivers/gpu/drm/sti/sti_awg_utils.c| 2 +- > d

Re: [PATCH] gpu: drm: stm: Adopt SPDX identifiers

2017-12-06 Thread Vincent ABRIOU
Benjamin, The patch is fine for me: Acked-by: Vincent Abriou Vincent On 12/06/2017 12:29 PM, Benjamin Gaignard wrote: > Add SPDX identifiers to files under stm directory > > Signed-off-by: Benjamin Gaignard > --- > drivers/gpu/drm/stm/drv.c | 3 +-- > d

Re: [PATCH v3 16/22] drm/sti: Use drm_gem_fb_create()

2017-08-21 Thread Vincent ABRIOU
Hi Noralf, On 08/13/2017 03:31 PM, Noralf Trønnes wrote: > drm_fb_cma_create() is just a wrapper around drm_gem_fb_create() now, > so use the function directly. > > Cc: Benjamin Gaignard > Cc: Vincent Abriou > Signed-off-by: Noralf Trønnes Acked-by: Vincent Abriou > --

Re: [PATCH 7/8] drm: Nuke drm_atomic_helper_connector_dpms

2017-08-08 Thread Vincent ABRIOU
mi.c | 1 - Acked-by: Vincent Abriou BR Vincent ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 5/8] drm: Nuke drm_atomic_helper_plane_set_property

2017-08-08 Thread Vincent ABRIOU
> drivers/gpu/drm/sti/sti_gdp.c | 1 - > drivers/gpu/drm/sti/sti_hqvdp.c | 1 - Acked-by: Vincent Abriou BR Vincent ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 6/8] drm: Nuke drm_atomic_helper_connector_set_property

2017-08-08 Thread Vincent ABRIOU
ff-by: Daniel Vetter [...] > drivers/gpu/drm/sti/sti_hdmi.c | 1 - Acked-by: Vincent Abriou BR Vincent ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 04/19] drm/sti: Use .dumb_map_offset and .dumb_destroy defaults

2017-08-07 Thread Vincent ABRIOU
Hi Noralf, Thanks for the patch. Acked-by: Vincent Abriou On 08/06/2017 05:40 PM, Noralf Trønnes wrote: > This driver can use the drm_driver.dumb_destroy and > drm_driver.dumb_map_offset defaults, so no need to set them. > > Cc: Benjamin Gaignard > Cc: Vincent Abriou > Sig

Re: [PATCH 7/8] drm: Add old state pointer to CRTC .enable() helper function

2017-06-29 Thread Vincent ABRIOU
ers/gpu/drm/qxl/qxl_display.c | 5 ++-- > drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 5 ++-- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 5 ++-- > drivers/gpu/drm/sti/sti_crtc.c | 5 ++-- For sti: Acked-by: Vincent Abriou __

Re: [PATCH 8/8] drm: Convert atomic drivers from CRTC .disable() to .atomic_disable()

2017-06-29 Thread Vincent ABRIOU
++-- > drivers/gpu/drm/qxl/qxl_display.c | 5 +++-- > drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 5 +++-- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 5 +++-- > drivers/gpu/drm/sti/sti_crtc.c | 5 +++-- For sti: Acked-by: Vincent Abriou

Re: [PATCH 30/37] drm/sti: Drop drm_vblank_cleanup

2017-06-01 Thread Vincent ABRIOU
On 05/24/2017 04:52 PM, Daniel Vetter wrote: > Seems entirely cargo-culted. > > Cc: Benjamin Gaignard > Cc: Vincent Abriou > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/sti/sti_drv.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/g

[PATCH] MAINTAINERS: update drm/stm maintainers list

2017-05-23 Thread Vincent Abriou
Add Benjamin Gaignard and Vincent Abriou as STM maintainers: Benjamin Gaignard Vincent Abriou Signed-off-by: Vincent Abriou --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 81cdd03..757d487 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

Re: [PATCH] drm: Document code of conduct

2017-04-11 Thread Vincent ABRIOU
gt; +interacting with community members on mailing lists, IRC, or bug > +trackers. The community represents the project as a whole, and abusive > +or bullying behaviour is not tolerated by the project. > Acked-by: Vincent Abriou ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] MAINTAINERS: add drm/sti driver into drm-misc

2017-04-10 Thread Vincent Abriou
drm/sti driver is now part of drm-misc as a small driver. Signed-off-by: Vincent Abriou --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 4ea82b2..66b424a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4417,7 +4417,7 @@ DRM

[PATCH] drm/sti: fix GDP size to support up to UHD resolution

2017-03-23 Thread Vincent Abriou
On stih407-410 chip family the GDP layers are able to support up to UHD resolution (3840 x 2160). Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_gdp.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_gdp.c b/drivers/gpu/drm/sti

[PATCH 1/1] drm/sti: fix build warnings in sti_drv.c and sti_vtg.c files

2017-02-20 Thread Vincent Abriou
Fix compilation warning introduced by: commit 0c7ff84f7f9d ("drm/sti: remove deprecated legacy vtg slave") commit 5e60f595d6ca ("drm/sti: use atomic_helper for commit") Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_drv.c | 9 - drivers/gpu/drm/sti/sti_

[PULL] sti-drm-next-2017-02-10

2017-02-10 Thread Vincent Abriou
aling if mode is not set Vincent Abriou (8): drm/sti: remove deprecated sink_term config drm/sti: remove deprecated legacy vtg slave drm/sti: enable gdp pixel clock in atomic_update drm/sti: do not set gdp pixel clock rate if mode is not set drm/sti: do not post GDP

[PATCH] drm/sti: debug fps reset

2017-02-03 Thread Vincent Abriou
From: Fabien Dessenne Reset the fps debug information when 'fps_show' is updated. Signed-off-by: Fabien Dessenne --- drivers/gpu/drm/sti/sti_drv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/sti/sti_drv.c b/drivers/gpu/drm/sti/sti_drv.c index 60a41cc..2b8cf59 100644 -

[PATCH] drm/sti: hdmi: automatically check DVI/HDMI mode

2017-02-03 Thread Vincent Abriou
Remove the hdmi_mode_property and use drm_detect_hdmi_monitor function to check whether the connected monitor is HDMI capable or DVI only. Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_hdmi.c | 31 ++- drivers/gpu/drm/sti/sti_hdmi.h | 17

[PATCH] drm/sti: unbind all components while driver cleanup

2017-02-03 Thread Vincent Abriou
Unbind all the components when the STI driver is unregistered. Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/sti/sti_drv.c b/drivers/gpu/drm/sti/sti_drv.c index e433853..60a41cc 100644 --- a/drivers/gpu/drm

[PATCH 3/3] drm/sti: do not post GDP command if no update

2017-02-03 Thread Vincent Abriou
Do not process update requests with unmodified parameters. This typically happens when the driver is called with legacy (non-atomic) IOCTL : in that case atomic_update() is called multiple times with the same parameters. Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_gdp.c | 15

[PATCH 1/3] drm/sti: enable gdp pixel clock in atomic_update

2017-02-03 Thread Vincent Abriou
Set gdp pix clock rate and parent in atomic_check function and enable it in the atomic_update only the first time. Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_gdp.c | 70 --- 1 file changed, 32 insertions(+), 38 deletions(-) diff --git a

[PATCH 2/3] drm/sti: do not set gdp pixel clock rate if mode is not set

2017-02-03 Thread Vincent Abriou
Fix a division by 0 case : in some cases, when the GDP plane is being disabled atomic_check() is called with "mode->clock = 0". In that case, do not set parent and pixel clock rate. Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_gdp.c | 2 +- 1 file changed, 1 in

[PATCH 0/3] drm/sti: gdp pixel clock and plane update fixes

2017-02-03 Thread Vincent Abriou
This patch series fix issues met around gpd plane: - fix gdp clock selection and enabling - fix div by zero when GDP plane is being disabled - do not process gdp update requests with unmodified parameters Vincent Abriou (3): drm/sti: enable gdp pixel clock in atomic_update drm/sti: do not

[PATCH 1/2] drm/sti: remove deprecated sink_term config

2017-02-03 Thread Vincent Abriou
stih416 chip family is no more supported in Linux v4.9. Then sink_term config becomes useless. The field of the register it was referring to is tag as reserved for stih410 chip family. Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_hdmi.c | 7 --- 1 file changed, 7 deletions

[PATCH 0/2] drm/sti cleanup: remove deprecated register and functionnalities

2017-02-03 Thread Vincent Abriou
Remove stih416 chip deprecated register and functionnalities since stih416 chip is no more supported from Linux v4.9. Vincent Abriou (2): drm/sti: remove deprecated sink_term config drm/sti: remove deprecated legacy vtg slave drivers/gpu/drm/sti/sti_hdmi.c | 7 - drivers/gpu/drm/sti

[PATCH 2/2] drm/sti: remove deprecated legacy vtg slave

2017-02-03 Thread Vincent Abriou
stih416 chip family is no more supported in Linux v4.9. It is then useless to keep vtg slave field since it not used at all for the stih407/10 chip family supported by sti driver. Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_vtg.c | 58 +++ 1

Re: [PATCH 3/3] drm/sti: do not check hw scaling if mode is not set

2017-02-01 Thread Vincent ABRIOU
Acked-by: Vincent Abriou On 01/12/2017 05:27 PM, Fabien Dessenne wrote: > Fix a division by 0 case : in some cases, when the HQVDP plane is being > disabled atomic_check() is called with "mode->clock = 0". > In that case, do not check for scaling capabilities. > > Si

Re: [PATCH 2/3] drm/sti: Fix up crtc_state->event handling

2017-02-01 Thread Vincent ABRIOU
Acked-by: Vincent Abriou On 01/12/2017 05:27 PM, Fabien Dessenne wrote: > Use drm-core to handle event. > This is required to be able to use the nonblocking helpers. > > Signed-off-by: Fabien Dessenne > --- > drivers/gpu/drm/st

Re: [PATCH 1/3] drm/sti: use atomic_helper for commit

2017-02-01 Thread Vincent ABRIOU
Acked-by: Vincent Abriou On 01/12/2017 05:27 PM, Fabien Dessenne wrote: > Since nonblocking atomic commits are now supported, the driver can > now use drm_atomic_helper_commit(). > > Signed-off-by: Fabien Dessenne > --- > drivers/gpu/drm/

Re: [PATCH 13/19] drm/sti: Remove drm_debugfs_remove_files() calls

2017-01-27 Thread Vincent ABRIOU
Thank for this patch. It is working fine with sti driver. Acked-by: Vincent Abriou Tested-by: Vincent Abriou Vincent On 01/26/2017 11:56 PM, Noralf Trønnes wrote: > drm_debugfs_cleanup() now removes all minor->debugfs_list entries > automatically, so it's not nec

Re: [PATCH] drm/sti: Fix compilation failure for drm_framebuffer.pixel_format

2017-01-25 Thread Vincent ABRIOU
Hi Chris, Thank for the patch. Acked-by: Vincent Abriou Vincent On 01/25/2017 11:10 AM, Chris Wilson wrote: > drivers/gpu/drm/sti/sti_plane.c:76:33: error: ‘struct drm_framebuffer’ > has no member named ‘pixel_format’; did you mean ‘format’? > > I didn't look to hard at the

[PATCH v2] drm: get fbdev size from cmdline mode if it exists

2017-01-11 Thread Vincent ABRIOU
On 01/11/2017 08:48 AM, Daniel Vetter wrote: > On Tue, Jan 10, 2017 at 10:06:44PM +0200, Laurent Pinchart wrote: >> Hi Vincent, >> >> On Tuesday 10 Jan 2017 13:33:29 Vincent ABRIOU wrote: >>> On 01/10/2017 12:39 PM, Daniel Vetter wrote: >>>> On Tue,

Re: [PATCH v2] drm: get fbdev size from cmdline mode if it exists

2017-01-11 Thread Vincent ABRIOU
On 01/11/2017 12:11 PM, Laurent Pinchart wrote: > Hi Vincent, > > On Wednesday 11 Jan 2017 09:03:07 Vincent ABRIOU wrote: >> On 01/11/2017 08:48 AM, Daniel Vetter wrote: >>> On Tue, Jan 10, 2017 at 10:06:44PM +0200, Laurent Pinchart wrote: >>>> On Tuesday

[PATCH v2] drm: get fbdev size from cmdline mode if it exists

2017-01-10 Thread Vincent ABRIOU
On 01/10/2017 12:39 PM, Daniel Vetter wrote: > On Tue, Jan 10, 2017 at 12:21:09PM +0100, Vincent Abriou wrote: >> In case no connector is found while creating the fbdev, gives the >> possibility to specify the default fbdev size by firstly checking if the >> command line is

[PATCH v2] drm: get fbdev size from cmdline mode if it exists

2017-01-10 Thread Vincent Abriou
: Vincent Abriou --- Patch v2: add a break in the connector for loop when a first cmdline mode is found drivers/gpu/drm/drm_fb_helper.c | 34 +- 1 file changed, 29 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm

[PULL v2] sti-drm-next-2017-01-06

2017-01-10 Thread Vincent Abriou
(1): drm/sti: allow audio playback on HDMI even if disabled. Arvind Yadav (1): drm/sti: sti_vtg: Handle return NULL error from devm_ioremap_nocache Fabien DESSENNE (2): drm/sti: load XP70 firmware only once drm/sti: do not post HQVDP command if no update Vincent Abriou (3)

[PATCH 2/2] drm: get fbdev size from cmdline if no connector found

2017-01-06 Thread Vincent Abriou
: Vincent Abriou --- drivers/gpu/drm/drm_fb_helper.c | 32 +++- 1 file changed, 27 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index 77d9ac6..115c265 100644 --- a/drivers/gpu/drm/drm_fb_helper.c +++ b/drivers/gpu

[PATCH 1/2] drm: remove useless parameters from drm_pick_cmdline_mode function

2017-01-06 Thread Vincent Abriou
drm_pick_cmdline_mode width and height parameters are useless. Just remove them. Cc: Daniel Vetter Cc: Jani Nikula Signed-off-by: Vincent Abriou --- drivers/gpu/drm/drm_fb_helper.c| 7 +++ drivers/gpu/drm/i915/intel_fbdev.c | 2 +- include/drm/drm_fb_helper.h| 3 +-- 3 files

[PATCH 0/2] get fbdev size from cmdline if no connector found

2017-01-06 Thread Vincent Abriou
your connector cable but you want your fbdev to have the size you have defined in the command line. Then when you plug your connector cable, the fbdev will match your display size. In case no command line is specified, the 1024x768 fbdev resolution is keept as default fbdev resolution. Vincent

[PULL] sti-drm-next-2017-01-06

2017-01-06 Thread Vincent Abriou
mware only once drm/sti: do not post HQVDP command if no update Vincent Abriou (3): drm/sti: update fps debugfs entries drm/sti: create fbdev at binding drm/sti: remove deprecated sti_vtac.c file drivers/gpu/drm/sti/Makefile| 1 - drivers/gpu/drm/sti/sti_drv

[PATCH] drm: sti: allow audio playback on HDMI even if disabled.

2017-01-04 Thread Vincent ABRIOU
Acked-by: Vincent Abriou On 09/30/2016 05:17 PM, Arnaud Pouliquen wrote: > This fix allows to play audio while HDMI is disconnected. > When HDMI is disable, audio configuration is stored and samples > are dropped (by HDMI IP). > When HDMI is enabled, audio HDMI configuration is

[PATCH] drm/sti: create fbdev at binding

2017-01-04 Thread Vincent Abriou
Do not wait for a hot plug event to create fbdev. Cc: Tomi Valkeinen Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_drv.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_drv.c b/drivers/gpu/drm/sti/sti_drv.c

[PATCH v2] drm/sti: remove deprecated sti_vtac.c file

2017-01-04 Thread Vincent Abriou
stih416 chip family is no more supported in Linux v4.9. It is then useless to keep sti_vtac.c file since it not used at all for the stih407/10 chip family supported by sti driver. Signed-off-by: Vincent Abriou --- v2: Take into account Daniel's comment => add a more explicit commit

[PATCH] drm/sti: remove deprecated sti_vtac.c file

2017-01-04 Thread Vincent Abriou
sti_vtac.c file is deprecated since stih416 chip family is not supported anymore. Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/Makefile | 1 - drivers/gpu/drm/sti/sti_drv.c | 1 - drivers/gpu/drm/sti/sti_drv.h | 1 - drivers/gpu/drm/sti/sti_vtac.c | 223

[PATCH 2/2] drm/sti: create fbdev at binding

2017-01-04 Thread Vincent Abriou
Do not wait for a hot plug event to create fbdev. Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_drv.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_drv.c b/drivers/gpu/drm/sti/sti_drv.c index ff71e25

[PATCH 1/2] drm/sti: set initial connectors status at binding

2017-01-04 Thread Vincent Abriou
This avoid to have an "unknown" connector status after the sti driver is registered. Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_dvo.c | 3 +++ drivers/gpu/drm/sti/sti_hdmi.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/drivers/gpu/drm/sti/sti_dvo.c b/drive

[PATCH 0/2] drm/sti: set connector status and create fbdev at binding

2017-01-04 Thread Vincent Abriou
While binding the sti drm driver the initial connectors status are set and the fbdev is created. Vincent Abriou (2): drm/sti: set initial connectors status at binding drm/sti: create fbdev at binding drivers/gpu/drm/sti/sti_drv.c | 27 ++- drivers/gpu/drm/sti

[PATCH 1/2] drm/sti: set initial connectors status at binding

2017-01-04 Thread Vincent ABRIOU
On 01/04/2017 10:39 AM, Daniel Vetter wrote: > On Wed, Jan 04, 2017 at 10:15:45AM +0100, Vincent Abriou wrote: >> This avoid to have an "unknown" connector status after the sti driver is >> registered. >> >> Signed-off-by: Vincent Abriou > > Why i

[PATCH] drm/sti: update fps debugfs entries

2017-01-04 Thread Vincent Abriou
This update allows to have a clearer fps log trace by adding information about plane size and plane pixel format. Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_plane.c | 17 + drivers/gpu/drm/sti/sti_plane.h | 2 +- 2 files changed, 14 insertions(+), 5 deletions

[PATCH] drm/sti: remove deprecated sti_vtac.c file

2017-01-04 Thread Vincent ABRIOU
On 01/04/2017 10:40 AM, Daniel Vetter wrote: > On Wed, Jan 04, 2017 at 10:26:46AM +0100, Vincent Abriou wrote: >> sti_vtac.c file is deprecated since stih416 chip family is not >> supported anymore. >> >> Signed-off-by: Vincent Abriou > > Ehrm, removing existing

[v1] gpu: drm: sti: sti_vtac:- Handle return NULL error from devm_ioremap_nocache

2017-01-04 Thread Vincent ABRIOU
Hi Arvind, Thank for this patch. Since sti_vtac.c file is deprecated, I rather suppress the sti_vtac.c file. I just push a new patch to suppress it. Thank for pointing this out. Br Vincent On 12/21/2016 06:22 AM, Arvind Yadav wrote: > Here, If devm_ioremap_nocache will fail. It will return NULL.

[v1] gpu: drm: sti: sti_vtg:- Handle return NULL error from devm_ioremap_nocache

2017-01-04 Thread Vincent ABRIOU
Thanks for the patch. Acked-by: Vincent Abriou I will take it for pull request that should be issued by the end of the week. Vincent On 12/21/2016 06:30 AM, Arvind Yadav wrote: > Here, If devm_ioremap_nocache will fail. It will return NULL. > Kernel can run into a NULL-pointer deref

[PATCH] drm: Remove the struct drm_device platformdev field

2017-01-03 Thread Vincent ABRIOU
Hi Laurent, Ok for the sti driver. Acked-by: Vincent Abriou On 12/17/2016 11:39 PM, Laurent Pinchart wrote: > The field contains a pointer to the parent platform device of the DRM > device. As struct drm_device also contains a dev pointer to the struct > device embedded in the platfo

[PATCH v3 03/13] drm: bridge: Link encoder and bridge in core code

2016-11-30 Thread Vincent ABRIOU
vers/gpu/drm/sti/sti_hdmi.c | 3 +- Hi Laurent, For sti dvo, hda and hdmi: Acked-by: Vincent Abriou Vincent > drivers/gpu/drm/sun4i/sun4i_rgb.c | 13 +++--- > include/drm/drm_bridge.h | 3 +- > 23 files changed, 83 ins

[PATCH v3 11/13] drm: Set on-chip bridges' encoder type

2016-11-30 Thread Vincent ABRIOU
72,8 @@ static int sti_dvo_bind(struct device *dev, struct device > *master, void *data) > bridge->driver_private = dvo; > bridge->funcs = &sti_dvo_bridge_funcs; > bridge->of_node = dvo->dev.of_node; > + bridge->encoder_type = DRM_MODE_ENCODER_LVDS; > + > err = drm_bridge_add(bridge); > if (err) { > DRM_ERROR("Failed to add bridge\n"); For the sti dvo part: Acked-by: Vincent Abriou Vincent >

[PATCH] drm: Make the connector .detect() callback optional

2016-11-30 Thread Vincent ABRIOU
Hi Laurent, For the sti driver: Acked-by: Vincent Abriou Vincent On 11/29/2016 09:56 PM, Laurent Pinchart wrote: > Many drivers (21 to be exact) create connectors that are always > connected (for instance to an LVDS or DSI panel). Instead of forcing > them to implement a dumm

[PATCH] drm/sti: mark symbols static where possible

2016-09-28 Thread Vincent ABRIOU
Yes true, patch from Ville https://lists.freedesktop.org/archives/dri-devel/2016-September/118631.html"; already fix patches sent by Baoyou. Vincent On 09/27/2016 09:07 PM, Benjamin Gaignard wrote: > I think that create conflicts with what is already in Vincent pull > request where we have fix th

[PULL] sti-drm-next-2016-09-20

2016-09-20 Thread Vincent ABRIOU
crtc_atomic_flush, enable only planes of this crtc drm/sti: use valid video mode Ville Syrjälä (1): drm/sti: Fix sparse warnings Vincent Abriou (3): drm/sti: dpms function missing for HDMI connector drm/sti: fix compositor debugfs creation drm/sti: remove

[PATCH v2] drm/sti: remove stih415-416 platform support

2016-09-20 Thread Vincent Abriou
stih415 and stih416 platform are obsolete and no more supported. Only stih407 and stih410 platform are maintained. Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/Kconfig| 6 +- drivers/gpu/drm/sti/Makefile | 1 - drivers/gpu/drm/sti/sti_compositor.c

[PATCH] drm/sti: remove stih415-416 platform support

2016-09-20 Thread Vincent Abriou
stih415 and stih416 platform are obsolete and no more supported. Only stih407 and stih410 platform are maintained. Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/Kconfig| 6 +- drivers/gpu/drm/sti/sti_compositor.c | 19 -- drivers/gpu/drm/sti/sti_hda.c

[PATCH 12/14] drm/sti: Fix sparse warnings

2016-09-19 Thread Vincent ABRIOU
Acked-by: Vincent Abriou On 09/19/2016 03:33 PM, ville.syrjala at linux.intel.com wrote: > From: Ville Syrjälä > > drm/sti/sti_mixer.c:361:6: warning: symbol 'sti_mixer_set_matrix' was not > declared. Should it be static? > drm/sti/sti_gdp.c:476:5: warning: symbol &

[PATCH] drm/sti: forbid plane on several mixer

2016-09-16 Thread Vincent ABRIOU
On 09/15/2016 05:57 PM, Ville Syrjälä wrote: > On Thu, Sep 15, 2016 at 04:59:55PM +0200, Vincent ABRIOU wrote: >> >> >> On 09/15/2016 04:27 PM, Ville Syrjälä wrote: >>> On Wed, Sep 14, 2016 at 01:40:02PM +0200, Vincent Abriou wrote: >>>> When a plane

[PATCH 8/8] drm/sti: use valid video mode

2016-09-15 Thread Vincent ABRIOU
Acked-by: Vincent Abriou On 09/15/2016 03:41 PM, Fabien Dessenne wrote: > In atomic mode the crtc_xxx (eg crtc_hdisplay) members of the mode > structure may be unset before calling atomic_check/commit for planes. > Instead of, use xxx members which are actually set. > > Signed

[PATCH 7/8] drm/sti: in crtc_atomic_flush, enable only planes of this crtc

2016-09-15 Thread Vincent ABRIOU
Acked-by: Vincent Abriou On 09/15/2016 03:41 PM, Fabien Dessenne wrote: > crtc_atomic_flush performs some additional processing, like plane > enable at mixer level. > Enable only the planes attached to the CRTC. > > Signed-off-by: Fabien Dessenne > --- > drivers/gpu/d

[PATCH 6/8] drm/sti: use vtg array instead of vtg_main/aux

2016-09-15 Thread Vincent ABRIOU
Acked-by: Vincent Abriou On 09/15/2016 03:41 PM, Fabien Dessenne wrote: > This is more generic and more consistent with the other members of the > sti_compositor struct. > > Signed-off-by: Fabien Dessenne > --- > drivers/gpu/drm/sti/sti_compositor.c | 4 ++-- >

[PATCH 5/8] drm/sti: use different notifier_block for each pipe

2016-09-15 Thread Vincent ABRIOU
Acked-by: Vincent Abriou On 09/15/2016 03:41 PM, Fabien Dessenne wrote: > Each pipe shall have its own notifier block to manage the vblank event. > This fixes issues where a client registered on given pipe is later > abusively notified of events on the other pipe. > > Signed

[PATCH 4/8] drm/sti: fix atomic_disable check

2016-09-15 Thread Vincent ABRIOU
Acked-by: Vincent Abriou On 09/15/2016 03:41 PM, Fabien Dessenne wrote: > When a drm_plane is being disabled, its ->crtc member is set to NULL > before the .atomic_disable() func is called. > To get the crtc of the plane, read old_state->crtc instead of > drm_plane->c

[PATCH 3/8] drm/sti: run gdp init sequence only once

2016-09-15 Thread Vincent ABRIOU
Acked-by: Vincent Abriou On 09/15/2016 03:41 PM, Fabien Dessenne wrote: > Do not rely on plane->status to define whether this is the first update > but rather check for gdp->vtg. > This avoids multiple and unwanted calls to sti_vtg_register_client() > which breaks th

[PATCH 2/8] drm/sti: run hqvdp init sequence only once

2016-09-15 Thread Vincent ABRIOU
Acked-by: Vincent Abriou On 09/15/2016 03:41 PM, Fabien Dessenne wrote: > Do not rely on plane->status to define whether this is the first update > but rather check for hqvdp->xp70_initialized bit status. > This avoids multiple and unwanted calls to sti_vtg_register_client() >

[PATCH 1/8] drm/sti: fix debug logs

2016-09-15 Thread Vincent ABRIOU
Acked-by: Vincent Abriou On 09/15/2016 03:41 PM, Fabien Dessenne wrote: > Add some missing \n in logs. > > Signed-off-by: Fabien Dessenne > --- > drivers/gpu/drm/sti/sti_gdp.c | 2 +- > drivers/gpu/drm/sti/sti_hda.c | 4 ++-- > drivers/gpu/drm/sti/sti_hdmi.c | 2 +-

[PATCH] drm/sti: mark symbols static where possible

2016-09-15 Thread Vincent ABRIOU
Acked-by: Vincent Abriou On 09/15/2016 01:39 PM, Baoyou Xie wrote: > We get 4 warnings when building kernel with W=1: > drivers/gpu/drm/sti/sti_gdp.c:476:5: warning: no previous prototype for > 'sti_gdp_field_cb' [-Wmissing-prototypes] > drivers/gpu/drm/sti/sti_hqvd

[PATCH v2] drm/sti: fix compositor debugfs creation

2016-09-15 Thread Vincent Abriou
Fix typo and issue while creating the vid and mixer debugfs entries. Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_compositor.c | 22 +- drivers/gpu/drm/sti/sti_compositor.h | 4 ++-- drivers/gpu/drm/sti/sti_crtc.c | 2 +- 3 files changed, 12 insertions

[PATCH] drm/sti: forbid plane on several mixer

2016-09-15 Thread Vincent ABRIOU
On 09/15/2016 04:27 PM, Ville Syrjälä wrote: > On Wed, Sep 14, 2016 at 01:40:02PM +0200, Vincent Abriou wrote: >> When a plane is going to be enabled we re-evaluate the possible crtcs >> for the associated drm plane. Only the crtc on which the plane should be >> di

[PATCH] drm/sti: fix compositor debugfs creation

2016-09-15 Thread Vincent Abriou
Fix typo and issue while creating the vid and mixer debugfs entries. Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_compositor.c | 8 ++-- drivers/gpu/drm/sti/sti_compositor.h | 4 ++-- drivers/gpu/drm/sti/sti_crtc.c | 2 +- 3 files changed, 9 insertions(+), 5 deletions

[PATCH] drm/sti: forbid plane on several mixer

2016-09-14 Thread Vincent Abriou
nment when the plane is in use (gdp is running). Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_gdp.c | 15 +++ drivers/gpu/drm/sti/sti_plane.h | 2 ++ 2 files changed, 17 insertions(+) diff --git a/drivers/gpu/drm/sti/sti_gdp.c b/drivers/gpu/drm/sti/sti_gdp.c index 3f

[PATCH] drm/sti: dpms function missing for HDMI connector

2016-09-14 Thread Vincent Abriou
Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_hdmi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c index c6aa291..d850dda 100644 --- a/drivers/gpu/drm/sti/sti_hdmi.c +++ b/drivers/gpu/drm/sti/sti_hdmi.c @@ -1054,6

[PATCH v4 05/14] drm: sti: Replace drm_fb_get_bpp_depth() with drm_format_plane_cpp()

2016-09-09 Thread Vincent ABRIOU
igned-off-by: Laurent Pinchart > Acked-by: Vincent Abriou > --- > drivers/gpu/drm/sti/sti_gdp.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > Cc: Benjamin Gaignard > Cc: Vincent Abriou > > diff --git a/drivers/gpu/drm/sti/sti_gdp.c b/drivers/gpu

[PATCH v2] drm: drop DRIVER_HAVE_IRQ flag for some drivers

2016-08-18 Thread Vincent ABRIOU
Acked-by: Vincent Abriou On 08/16/2016 09:06 AM, Shawn Guo wrote: > Since commit 4984979b9b90 ("drm/irq: simplify irq checks in > drm_wait_vblank"), the drm driver feature flag DRIVER_HAVE_IRQ is only > required for drivers that have an IRQ handler managed by the DRM core. >

[PATCH v3 07/15] drm: sti: Replace drm_fb_get_bpp_depth() with drm_format_plane_cpp()

2016-06-09 Thread Vincent ABRIOU
Hi Laurent, On 06/09/2016 11:17 AM, Laurent Pinchart wrote: > Hi Vincent, > > On Thursday 09 Jun 2016 09:52:05 Vincent ABRIOU wrote: >> On 06/09/2016 01:32 AM, Laurent Pinchart wrote: >>> The driver needs the number of bytes per pixel, not the bpp and depth >>> i

[PATCH v3 07/15] drm: sti: Replace drm_fb_get_bpp_depth() with drm_format_plane_cpp()

2016-06-09 Thread Vincent ABRIOU
changed, 3 insertions(+), 3 deletions(-) > > Cc: Benjamin Gaignard > Cc: Vincent Abriou > > diff --git a/drivers/gpu/drm/sti/sti_gdp.c b/drivers/gpu/drm/sti/sti_gdp.c > index ff33c38da197..be7e80535083 100644 > --- a/drivers/gpu/drm/sti/sti_gdp.c > +++ b/drivers/gpu/drm/st

[PATCH v2 11/20] drm: sti: Rely on the default ->best_encoder() behavior

2016-06-08 Thread Vincent ABRIOU
Hi Boris, Thanks for the patch. Acked-by: Vincent Abriou Vincent On 06/07/2016 01:48 PM, Boris Brezillon wrote: > All outputs have a 1:1 relationship between connectors and encoders > and the driver is relying on the atomic helpers: we can drop the custom > ->best_encoder() imp

[PATCH v2 2/3] drm: convert DT component matching to component_match_add_release()

2016-06-07 Thread Vincent ABRIOU
compare_of, child_np); > - of_node_put(child_np); > + component_match_add_of(dev, &match, child_np); > child_np = of_get_next_available_child(node, child_np); > } > Hi Russel, Ok for the sti driver. Acked-by: Vincent Abriou

[PATCH 08/12] drm/sti: Rename async to nonblock.

2016-04-27 Thread Vincent ABRIOU
Hi Maarten, Thanks for the patch. Acked-by: Vincent Abriou On 04/26/2016 04:11 PM, Maarten Lankhorst wrote: > The async name is deprecated and should be changed to nonblocking. > > Cc: Benjamin Gaignard > Cc: Vincent Abriou > Signed-off-by: Maarten Lankhorst > --- >

[Y2038] [PATCH] drm/sti: Use 64-bit timestamps

2016-04-18 Thread Vincent ABRIOU
On 04/17/2016 01:39 AM, Arnd Bergmann wrote: > On Wednesday 13 April 2016 02:28:02 Tina Ruchandani wrote: >> 'struct timespec' uses a 32-bit field for seconds, which >> will overflow in year 2038 and beyond. This patch is part >> of a larger attempt to remove instances of timeval, timespec >> and t

[PATCH] drm/sti: restore mode_fixup callback

2016-03-17 Thread Vincent ABRIOU
Thank you Arnd for highlighting this. Acked-by: Vincent ABRIOU On 03/17/2016 10:02 AM, Arnd Bergmann wrote: > Commit 8a2fa38fddd3 removed the mode_fixup because it was empty, > but 652353e6e561 modified it to call drm_mode_set_crtcinfo() > instead. > > Both commits are correct, b

[git pull] drm/sti: drm-next 2016-02-26

2016-03-03 Thread Vincent ABRIOU
CLUT fetch Vincent Abriou (22): drm/sti: update VTG timing programming drm/sti: GDP cropping fails when we remove 2 pixels horizontally drm/sti: implement atomic_check for the planes drm/sti: do not clip RGB/YUV component value at connector side drm/sti: fix panel

[PATCH 1/2] drm: Add DRM_MODE_FB_BFF flag definition

2016-02-29 Thread Vincent ABRIOU
On 02/29/2016 04:32 PM, Daniel Vetter wrote: > On Fri, Feb 26, 2016 at 11:33:08AM +0100, Vincent ABRIOU wrote: >> Hi, >> >> Have you any comment for this proposal? > > I guess since we don't really have userspace that uses interlaced modes, > much less actuall

[PATCH 1/2] drm: Add DRM_MODE_FB_BFF flag definition

2016-02-26 Thread Vincent ABRIOU
Hi, Have you any comment for this proposal? BR Vincent On 02/12/2016 10:26 AM, Vincent Abriou wrote: > From: Fabien Dessenne > > If a buffer is interlaced, this "Bottom Field First" flag specifies > which of the top or the bottom field shall be displayed first. > W

[PATCH, RESEND] drm/sti: use u32 to store DMA addresses

2016-02-26 Thread Vincent ABRIOU
Hi Arnd, Your patch will be part of the next pull request for the STI driver that will be done by the end of next week. Reviewed-by: Vincent Abriou On 02/25/2016 10:11 PM, Arnd Bergmann wrote: > The STi drm driver correctly warns about invalid format strings > when built with

[PATCH v2 16/17] drm/sti: removed optional dummy encoder mode_fixup function.

2016-02-15 Thread Vincent ABRIOU
implementations. > > (made on top of Daniel topic/drm-misc branch) > > Signed-off-by: Carlos Palminha > --- > drivers/gpu/drm/sti/sti_tvout.c | 10 -- > 1 file changed, 10 deletions(-) > Acked-by: Vincent Abriou BR Vincent

[PATCH 2/2] drm/sti: support interlaced top / bottom field first

2016-02-12 Thread Vincent Abriou
From: Fabien Dessenne Support top field first and bottom field first interlaced buffers Signed-off-by: Fabien Dessenne --- drivers/gpu/drm/sti/sti_hqvdp.c | 72 + 1 file changed, 44 insertions(+), 28 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_hqv

[PATCH 1/2] drm: Add DRM_MODE_FB_BFF flag definition

2016-02-12 Thread Vincent Abriou
From: Fabien Dessenne If a buffer is interlaced, this "Bottom Field First" flag specifies which of the top or the bottom field shall be displayed first. When set, the bottom field shall be displayed first. When unset the top field shall be displayed first. Signed-off-by: Fabien Dessenne --- dr

[PATCH 0/2] drm/sti: support of interlaced content with Bottom Field

2016-02-12 Thread Vincent Abriou
Interlaced video can have different scan order: Top Field First or Bottom Field First In case of video with interlaced content, this information should be propagated from the userland to the DRM kernel driver that will process the deinterlacing starting with the top or the bottom field first. That

[PATCH 10/10] drm/sti: add debugfs fps_show/fps_get mechanism for planes

2016-02-12 Thread Vincent Abriou
Display fps on demand for each used plane: cat /sys/kernel/debug/dri/0/fps_get Display fps in live in the console for each used plane: echo 255 > /sys/kernel/debug/dri/0/fps_show Signed-off-by: Vincent Abriou --- drivers/gpu/drm/sti/sti_cursor.c | 2 + drivers/gpu/drm/sti/sti_drv.c|

  1   2   >